From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBCD1459DC; Fri, 20 Sep 2024 05:49:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F6FA40669; Fri, 20 Sep 2024 05:49:02 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 6CD2B400EF for ; Fri, 20 Sep 2024 05:49:00 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 48JImGm8022897; Thu, 19 Sep 2024 20:48:59 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2048.outbound.protection.outlook.com [104.47.70.48]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 41rh5mme5e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Sep 2024 20:48:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=y3/+FnJNmNyUDiwn5s7wjVhmWMm/Jv6k5UrHFC7TfBlL3UKCJvAWJ+1A6esdPQb9q1fwTnmHlZw+MOiHOc29YysSYZJKSUTF185o2i1Gs1Y2diVm1i8h5ziptiIVJgmqRAMyqZCpT5qYjeK5VoItTiOEa3+arLJJzv1FzyA0ZXHuZ9xYL4VLsrK5k4WNiEJ757d1tUjOl+v2IG4Yg6UZ0IOcvp3KYPbHLsMyqRQ6L14GKXBLClirOipqhJApeOYzENaGDJvL/RPQe5csEnXbzM8uLZ/HMAhVsfO4WBvhAe8Ah3DCbAPC3vW+HCSVowzJ7EOeQDpDFIK+O5C8oNP1Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m+xvtOmEzAM6Ud99fH0mBDTF65nvgtB1up/WymYYCRc=; b=dQAZqBQEyRzRVcFuwf0g5rzgWSu2MYeMkms+U1nASFfW2/a2K2ak75Kn2ucHqusKChCbnG7rBOiCf8PwbAgo0f0ECcOgm5UmvOlVVD/LEQd6aLU9q8diA0LyWUcKZpQFikBztP4ndk/a2ZNpFBb0KGKgMlJrU+G47tDNXCLjXzc3B+xFKAr5V7I+yYMjY6I4gkQciQHEif4hBC5yagqwfIt3Uv0lz/1SQUD5eVRtJk9IThjUB6aBxkK0vxxS2aEhvSuLttcY/MG73FtPx/x653Rlwvvoalg2eQaFL4Dcd6AyMoTNAl+fr7pj+MJEIHYb7wZz/Ifcui/3Ht0I5HKInQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m+xvtOmEzAM6Ud99fH0mBDTF65nvgtB1up/WymYYCRc=; b=ZYiZdB4P9OO1tgZrgMksDjmrSh50dL4OKy/0l2K0ETwBwTGMqs3kkFsaMuIO7IENIemuLOyMcTIWPtJCfal5f9NGo/7en/eAa8O7/WM7bzj4Ls3QO4YLony9wyvLzTojV4bq7YkRcB1aDWyDkGCayGQL+X2b2Kzh4b1q9bek5WQ= Received: from MW4PR18MB5244.namprd18.prod.outlook.com (2603:10b6:303:1e0::16) by LV8PR18MB5558.namprd18.prod.outlook.com (2603:10b6:408:184::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.17; Fri, 20 Sep 2024 03:48:43 +0000 Received: from MW4PR18MB5244.namprd18.prod.outlook.com ([fe80::52f3:9792:ee42:90b]) by MW4PR18MB5244.namprd18.prod.outlook.com ([fe80::52f3:9792:ee42:90b%5]) with mapi id 15.20.7982.016; Fri, 20 Sep 2024 03:48:43 +0000 From: Vamsi Krishna Attunuru To: Jerin Jacob CC: "dev@dpdk.org" , Jerin Jacob Subject: RE: [EXTERNAL] Re: [PATCH] net/octeon_ep: add device removal event callback Thread-Topic: [EXTERNAL] Re: [PATCH] net/octeon_ep: add device removal event callback Thread-Index: AQHa+EKad7KAHgNCRU+O5tq4Ug1gTbJfkDmAgACfDsA= Date: Fri, 20 Sep 2024 03:48:42 +0000 Message-ID: References: <20240827053259.12033-1-vattunuru@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR18MB5244:EE_|LV8PR18MB5558:EE_ x-ms-office365-filtering-correlation-id: f1f518c6-d056-4944-9bb5-08dcd9271f2f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|376014|38070700018; x-microsoft-antispam-message-info: =?utf-8?B?SGFTS1NSbVNyMVREbmQ1SmdXR3dmeG9tUm96djdDbzY5d09Od1Bmb2lVbURV?= =?utf-8?B?T2JXem9MKzE0cEN5WCtrRWRNdUdIaFErOGZURDZQK29iV2FaSStCcll0c1Fq?= =?utf-8?B?bDdBVlVLQnJIdVBWcWRKNGhHVkIrNmFRdXVkLzZ0MHVaMkZrVUFRbGRMT0x2?= =?utf-8?B?blpVbEpEQi9Xcmp5VWZ4QWNyd0N1b2Nnbm45b3ovZVJ6Ykh5ZHRpUU9rU284?= =?utf-8?B?QlhNNkpwc0RrYW4rSUNVVTl4b0RrT25ocnhjMHA5MGxkYittLzFiQVRBbFVL?= =?utf-8?B?UVdEVytiRUVnWnNDUW9hUHRRWmVpSno1RHlXMnZIZGxXVkNQYjJ6d1JZSVFh?= =?utf-8?B?Zm0rKzl0cGVWK3NRQ041aVZ0OGxUbzl1MFBOY3lXbDJOZzdBR3NzN1Q3Tzkw?= =?utf-8?B?c0g3eXUzQndmL3l2bFF4dCtaY2k4M3lWWVRYeExUUTFuVTloRHBHVngvNHVw?= =?utf-8?B?MWF2R2k2WEVZVDRlaTk0Vno3eUJwTUdNV3F1M3JOdU1BMnl3WExpNjZtOWk0?= =?utf-8?B?cFRSQTUxd2E4UDJPay9RQ21MZU54VmJQUkNNaG9kK1Z1UllQU3I0WkdvVk11?= =?utf-8?B?amsrallVYlo0cHhaWUJWcG9PUzRub3VRUEpEMGpTSzFLQW9uVGVkaVF4ajdO?= =?utf-8?B?Mi84VGdVSklHQ1ljTUVyOGNacmU5RkFySi9EZnJxZ2R3SmJxcDJwYUhLWnpG?= =?utf-8?B?SUxxeGdGZTVNTk1ZL2NadXRQSUlXU2k3MjVTNVU5YmZQUWp4ajl5cG1NUVRL?= =?utf-8?B?UHhnZFBreWg3Z0FVekhjVHIxTXFWbUpUYkgwaHhmejRvMHlQbjMreThySSsv?= =?utf-8?B?SFNQOE41MGtwZEhJWXJhVkFEN3BxeE5IbUJxY3FkUTVPcGxIYWREUlZYaUxU?= =?utf-8?B?NUMrbWFweGZzeDNObWJFSG4rVWlZNXI1VjdTeU1BL1VEZmtxeHBlTUhieERt?= =?utf-8?B?ZlNMeFFSd095YXFzRURKbmMrYk5GMU9DOGRCbmtyRG9JMEhtUkxZV3pvYm05?= =?utf-8?B?TXh4ZDRXYkFSd08vRWE4aXQvci9qQzFoMHRhY2dpam5ka3IzWnY0aW13dFEy?= =?utf-8?B?REgyTDlTdUtDZGdXREh6Z3RaMjJMVG5oUkI1R3RuOURoRVE5dlRCUjUyODJu?= =?utf-8?B?Q1FQRDlmVTlZdWlXUVRBNStTWTZyY2IydHdJNHN0aHhlQmprZU9ETW1lZmhy?= =?utf-8?B?blJpbGFIMkdOWU1TWXZPd0NydGRad2liN0VEejBWYVliaFdLaThvSU1ZeUc2?= =?utf-8?B?YnJqY1RJcnpLazFiMWRSUFExNittMDBsR29QdFoxU01oUjVCVjdobkp4K2kr?= =?utf-8?B?OEFSSk9UOGNsWU9ib0htUi9XQTE2cHVDbE1sMGQvcEpHckpURXJaczc3aTB5?= =?utf-8?B?THRUcklGcDd2bzV3aURaSHZ0T1JtcjZQM241VHJWV1A2ZDl0R1l1RU9vcXYw?= =?utf-8?B?NzRJTVZSZlpjZTRrVE9VOWU5ZDhuR2NUWmRZb0xQUzlHcmwzZGxiSlphdDI2?= =?utf-8?B?THJKSUFnTEMrMitmb2RsV2Y3cTJydndaTzdrMmZuTjlPcjRSRDBiY0NQWkVX?= =?utf-8?B?SzhwRkJuTTlwdE9SK1daaGpQQ3k5dFNpWnI1NXpSNHd6elV5SS9qeHZhRGg2?= =?utf-8?B?WXJ5SEMxY3Q0K2dYWllGR01iUTczODZ4SjhyUE9QdXJYeU04T3p6MURnak5u?= =?utf-8?B?YkJwZDZXSVVaNW81dE5ObDU2ZVIwWDdXYjZVU252SUFuR21Wa25TcFZnQkdp?= =?utf-8?B?UmozRU5CVC9PRVhJT1I0aUloT0s1UUhIK1VHeFZPZUVQTDRJZ2szaXN0NG1I?= =?utf-8?Q?Fww2BnbQlpobPQSrTrz17fNbsTMKZOisNgdx0=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR18MB5244.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VVpNVW5DY1g2Z3Fna2R6UmsrRytwMFlQamxWT25UWFNKRUtrcTBlNzNRWjJH?= =?utf-8?B?bTBRWGNna2pWUUlvRzJoL1V4VnZIejhmVFZIbXdLbWJKSkM3RmpxYmc5T0N0?= =?utf-8?B?SUdaRWJzSURKUGRYT2JxTitGVUNCd1ZkcVdYTEdHbFUrTjVUSHdoeE10czgz?= =?utf-8?B?SU5QZDQ2d0xMN3hJRU5nelMrbi9ZSDdQUWorOFNGeVJaSlJKZi9qeUVUakR0?= =?utf-8?B?T1Y2OVRZaDRMUTVWUmpDUXg1YmxiSkxHQWN4WDZ1TjRZT3czUW9pVE9ORVBU?= =?utf-8?B?S1RwSTZTNzc3SjFrVEs3a090N2x0MkNTcWtDaG40QWUvMDFlYnZTcVZHb3ZE?= =?utf-8?B?aFVvREhndjNzNlYxV21FWU1SeUVTYXlHdEZHZU5aVFk5WVNlY0lOKzY1Mk5m?= =?utf-8?B?Wm1CRjNHNjNLUjNjV0d0c2JxalQ4bTExUG9pRG5hZTl2YXlXd1pMMWVjRVlP?= =?utf-8?B?c1JER2RlMVB0M2NqREtIYmNPVGdkMkZ0REowT3UxVUJOL3JFUjZWb0NiYXJJ?= =?utf-8?B?blp1bERBeGs2ZTAyeUs2Ykt2WFdZV0hXTkZBa2FZZW9MSHBwUVNhTTNkZk5L?= =?utf-8?B?WjhxUUR6eC9kU1hESTRkYWlwdXhIVWorRCtSZXBOelhCMzhzUmZzZnY1Uk92?= =?utf-8?B?VzV5TGZLVmUweUh5cXcwaWpHTUg0UkFkb1AySnBsNGZFbFRoL1BmTVl6anBz?= =?utf-8?B?MldsOEppYStLcEZONmhqcWRkSmZBM0ZUOExDN0thT0NNTmxaZFp5c0ZiZG9t?= =?utf-8?B?TWlJODNDYU9ubENTbVYvdk42eG9TZDlnV0s0amd6NlZwWXRmSEdobWhJTGZS?= =?utf-8?B?U0hQWGZJdytkRVlqcGRRK2ZSRzV1blFXclpUNzY3MzlpSWdDWTlkOHVkNTNv?= =?utf-8?B?Z1duTVYxMFBDclU4WkJXQlUvNTQyYXBab0V5Yk9IbkwzcGFnWkwxMVhXMHBn?= =?utf-8?B?dW94Y3RjTzY4aGxqY0RRcktxU2ZmbzJoVUQ4MHNZb3c4N0w1eldBMWRObmV0?= =?utf-8?B?WldDYWQ5QlJaNVBpMGVxN3B5bHdTcmZocVhzdWhYZUN4MGNFcXhnLzhNem1Z?= =?utf-8?B?cG8yK2VKa0I4a1BOTnF1YUdPYllYNHhzZkVqM3Nqb0JBb24zRzlveEV4b0lk?= =?utf-8?B?UXFZNy80RHo1NUxIMkd1eHBDZ3FjRkN5RDVmMFhCQkVqeG12UERSNGx1Q1ox?= =?utf-8?B?SGRBQStzUTVwQW83ZXhGZjlLSmpXWXR1ZWRuR2FxR0pBRHdyekw3R0R5YWhN?= =?utf-8?B?MHlCcTJPY28ydVNVNHk3c202VmJJL1hYaSs5cWptNkRkY3Q2MlRHRGt4cWVE?= =?utf-8?B?NWw4UFFpK3FpaW5EOUNTR0xmYlVVUUE3N0gvOGxNeWNlaVcvRTFtakFnb05B?= =?utf-8?B?THBJaldhZ09YdVhuTDNJNGxCblNNSGJPODY1b3dVVzJFRGMxazJoL0o0cGM4?= =?utf-8?B?Lzl0OXRzUHg5L296SlFnMnRLcy9ETGs1SWVLMjFGNVJheEZnRlRpNXQ3Zks1?= =?utf-8?B?L3JHTVRZSGc5dE44cGorV1ZLRmxPSnJ3WkhYYjM4U2VpeEpFaURtV21OVkEw?= =?utf-8?B?SGErR3J3RHM4dFBGcU5ySG9VeHQrT1lLWk9DR0Rwck1QRTBWQ0NWaVhCUzBK?= =?utf-8?B?MjZPVEJ4VzV2bk1ha3piUUs1cWlvbUtXMXArSEtNMExYYnpnZEJpelVFTWI0?= =?utf-8?B?NDFtUUUzcXRkeWh1ZkZPYmU5ZFJzMUZVd080cWNGYnB1bWNnVkFMUitCMUs3?= =?utf-8?B?NExuK2VvOWV2VXlRQ2Y4SUZ0NVVSY2tzNXdUZTU5bW4wajdBQ3BMMWpYNUt3?= =?utf-8?B?UWNEOWt3U0dPZkhoaktYVHNsUWpsMWxuczdyNGdIUWpiR1NlczNuWE4xUGk3?= =?utf-8?B?clZ4d3ZJMjFucVFIbTVPS1dYQndkYUhOUmJlbE9YV21iM0FuNmRhRGxPZGJt?= =?utf-8?B?M2JFby9ySm0vM0xKbFk0WjRKNDMvV0tWV2p5M3czQXZWSzM1SDRGbWxqM0x5?= =?utf-8?B?M1JkT0lhb0F6UTBsem9Hd1dRSE5oMmJtZkZRV0NQd0VoZXJZRmdONDhXYXlw?= =?utf-8?B?V0o3a1ZRQWUrOGFTVTd2Z2tVeTFBRTcvOURiZ1E3Qk53NG9zeUpDVXF5ZFhT?= =?utf-8?Q?GKaZ9VFwE11X9mXcbvXViF+B7?= MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR18MB5244.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1f518c6-d056-4944-9bb5-08dcd9271f2f X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2024 03:48:42.9345 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qjvl98KF7sPr/Xdc7wAskZ8uYyAeZfvjAeuKrXuFOtA7D5IA5pEjMQDs8tvNV5zwACPgygfio7Ss7Yr3DOD1pw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR18MB5558 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: X88E8PVdR9ahjGnUYl2qtI1tCK-RvGwl X-Proofpoint-GUID: X88E8PVdR9ahjGnUYl2qtI1tCK-RvGwl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >-----Original Message----- >From: Jerin Jacob >Sent: Thursday, September 19, 2024 11:49 PM >To: Vamsi Krishna Attunuru >Cc: dev@dpdk.org; Jerin Jacob >Subject: [EXTERNAL] Re: [PATCH] net/octeon_ep: add device removal event >callback > >On Tue, Aug 27, 2024 at 11:=E2=80=8A03 AM Vamsi Krishna >wrote: > > From: Vamsi Attunuru = > > Patch adds >an event callback to catch any device removal Please remove patch. > event > >On Tue, Aug 27, 2024 at 11:03=E2=80=AFAM Vamsi Krishna >wrote: >> >> From: Vamsi Attunuru >> >> Patch adds an event callback to catch any device removal > >Please remove patch. Ack. > > >> event occurred during driver probe. This callback helps in terminating >> the execution if there is any device removal event during the driver >> probe. >> >> Patch also moves global register configuration into dev_configure() > >Please remove patch. > >> routine and also validates register reads for any invalid return >> values from hardware during driver probe. >> >> Signed-off-by: Vamsi Attunuru >> --- >> Depends-on: patch-142958 ("net/octeon_ep: extend mailbox >> functionality") >> >> drivers/net/octeon_ep/cnxk_ep_vf.c | 2 + >> drivers/net/octeon_ep/otx2_ep_vf.c | 2 + >> drivers/net/octeon_ep/otx_ep_ethdev.c | 58 +++++++++++++++++++----- >--- >> drivers/net/octeon_ep/otx_ep_mbox.c | 11 +++++ >> drivers/net/octeon_ep/otx_ep_vf.c | 2 + > > >Update the release notes for this new feature. Sure. > > >> 5 files changed, 59 insertions(+), 16 deletions(-) >> >> diff --git a/drivers/net/octeon_ep/cnxk_ep_vf.c >> b/drivers/net/octeon_ep/cnxk_ep_vf.c >> index 39b28de2d0..68b89fce4f 100644 >> --- a/drivers/net/octeon_ep/cnxk_ep_vf.c >> +++ b/drivers/net/octeon_ep/cnxk_ep_vf.c >> @@ -408,6 +408,8 @@ cnxk_ep_vf_setup_device(struct otx_ep_device >> *otx_ep) >> >> /* Get IOQs (RPVF] count */ >> reg_val =3D oct_ep_read64(otx_ep->hw_addr + >> CNXK_EP_R_IN_CONTROL(0)); >> + if (reg_val =3D=3D (uint64_t)-1) > > >Use UINT64_MAX from across the patch. Ack, thanks.