From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCDFA45B0C; Fri, 11 Oct 2024 05:37:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C05C64067A; Fri, 11 Oct 2024 05:37:59 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id DD8CA40273 for ; Fri, 11 Oct 2024 05:37:57 +0200 (CEST) Received: from pps.filterd (m0431383.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49B1MK1A006530; Thu, 10 Oct 2024 20:37:57 -0700 Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2044.outbound.protection.outlook.com [104.47.73.44]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 426t9h07k8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Oct 2024 20:37:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oLEAiAxhHAGjLNcFKd4jW4DKMk4woEjO68opQML/EVRC7HwKdx6tc/0MBQFA3FNM4C1R3cIM5Vki9h7RoKgqvWHyfA26/G7Ut0JRxpbEAMVKEt51YnT1nVbMr/ebZohvZxajjIT7hHjry1K6/udO4gEmk7zQWUKTAODZ9obmIMCfw2iPGGqX9DDQHyXUYZwLA4v1rA6D0AVEd/g+HzzjraqFX2l7dbPpjjsyaAZ7mYlZM7ma74PfYwU6/DsDhBpNVSRaaVaeIEVv6bIj7/c8Z+PDfqbN6Zn2McAe3y6QUJehSR3mAVV7L49SFlaQZxBKrRRD5b/rnVRdPW269YHBCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rvym4HUyN0xLbhE/yqANe53BNMq4XSBOKT6JKjDcumc=; b=SjdRPKzWnbgB6hYXbmO4pjnKP6UR8AEZkfrY6Kt4wShHykCFJ+epigIcc01kB9UOHYTC4sJVWSp5e/me80vrlXwftJ38RWgKvAPK2HiHHlQcujhs778x5E30g+E104MlcWh169dJzyKAVdIw5nYTr7l3S0RnFfdIhAiIUAsH23wgQoK2bQ2ekaS93QkQGpiVrh7O5D3zhZ/WCKJ2ieENlOSCIOvJhtf7c7n8TXfjPKHJu8inH6ilwkLuLAt1ppV58pZNbugrOYDx7Pm3sTfsJT+VChiTCKdbCAPmYnQddHwgZrr8sMhfQ6c/c7JSz7rPPBFVAlYSn9YC6P12P08T6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rvym4HUyN0xLbhE/yqANe53BNMq4XSBOKT6JKjDcumc=; b=BTSvXaCDYIj4xyrt4hcd91nRaRBWtuWiAFcZOetrbbMdjt1GvDtbRXZhdMcBuPDp7RqtxkYUel28XPGEsCOQO4H3HUbGAbVHd/DLEMRiet5OLXn1Cfi1nZMrUc+lMsEs+snDO1U2Ocdvgl93G5TEGabthc5QsmrdAu5ujxwDX2U= Received: from MW4PR18MB5244.namprd18.prod.outlook.com (2603:10b6:303:1e0::16) by BY3PR18MB4804.namprd18.prod.outlook.com (2603:10b6:a03:3cf::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.18; Fri, 11 Oct 2024 03:37:53 +0000 Received: from MW4PR18MB5244.namprd18.prod.outlook.com ([fe80::52f3:9792:ee42:90b]) by MW4PR18MB5244.namprd18.prod.outlook.com ([fe80::52f3:9792:ee42:90b%5]) with mapi id 15.20.8048.017; Fri, 11 Oct 2024 03:37:53 +0000 From: Vamsi Krishna Attunuru To: fengchengwen , "thomas@monjalon.net" , "bruce.richardson@intel.com" , "mb@smartsharesystems.com" CC: "dev@dpdk.org" , "kevin.laatz@intel.com" , Jerin Jacob , "conor.walsh@intel.com" , Gowrishankar Muthukrishnan , Vidya Sagar Velumuri , "g.singh@nxp.com" , "sachin.saxena@oss.nxp.com" , "hemant.agrawal@nxp.com" , Amit Prakash Shukla Subject: RE: [EXTERNAL] Re: [PATCH v4 1/1] dmadev: support priority configuration Thread-Topic: [EXTERNAL] Re: [PATCH v4 1/1] dmadev: support priority configuration Thread-Index: AQHbFYrvgWkDEJEtjkGkzagmVoFHC7J8KrEAgATHHPA= Date: Fri, 11 Oct 2024 03:37:52 +0000 Message-ID: References: <20241003114133.1356496-1-vattunuru@marvell.com> <20241003115347.1365370-1-vattunuru@marvell.com> <5d66d7e0-7d94-459c-96ee-4274183f5735@huawei.com> In-Reply-To: <5d66d7e0-7d94-459c-96ee-4274183f5735@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR18MB5244:EE_|BY3PR18MB4804:EE_ x-ms-office365-filtering-correlation-id: cf6a5262-8ba0-46a1-3e3f-08dce9a61672 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|7416014|1800799024|376014|38070700018; x-microsoft-antispam-message-info: =?utf-8?B?UThHNmxoelB6ZGpPQTIwS3NYUFA0MTNRMEtNV2gzLytlL1ZzblMyMGpDWFJs?= =?utf-8?B?MWxJcVVoblJvWGN6Tk11KzJEUjNGc2E0ZGs3dERxMk1WeUhlSlQ0MnhEMzNo?= =?utf-8?B?TmZwMDlDdUVYSTZ6cW9QMGt0N2crVS9IVFBGUXZ3Z21jTHNNSHdiQWxEVmJr?= =?utf-8?B?WHIyemZuRFFIUjBvSDUvR2c4V3ZLbTZpYWY1Ly9JNG5DZDZ3amNab2o3ZHg4?= =?utf-8?B?L3c4ZVk2Z1I5VEswTlRCbnF4clV6TTBnU1ZkVFdFRFNEZ3VzTnQzbE9OYWZ3?= =?utf-8?B?V21kN1Z3WXJQQm5KekM1c1NTTWxHdVRISXdDTVJ0NmlwZWkrT0Q0MzUvTGw5?= =?utf-8?B?RkxmTUwzaVh5UDJXeHJjUzU3QllLd0RLRCtLdWJ4aU1UU1NFMk8yNlNrK1Vk?= =?utf-8?B?TXJwcTZkR2Y0SHg5QjNzcDRTdUVVem5sbGNKQ3VleUs3WDBPUERiWWg3VHNL?= =?utf-8?B?cjRpMnErR2RIay9nN0JZZ0t6VnlDdzBGMjMxTjBQaEtVdGR6OGprdndyZy9V?= =?utf-8?B?blJXN3I4VjJ5YVVjc2Rhc21zVlg3dDJRT1ArbnVhb1R2d3JObkFFU0RJcWxj?= =?utf-8?B?VTNFZWtQSVNqNStVN05rOE43ODJVZ25pRWtjWUVKeUdOQ2VCbjdVWlNCRDho?= =?utf-8?B?QlZpSmtiMURHVzRwZFUrd2tGODd6UG4wM0Z2cHUvT3lYNFBlMjJxZTBYbmJH?= =?utf-8?B?TWEwYVRKWktkajBlUDhqNzd0SG1KUEJETGN3eGQ5UzFTd3FtZWF6YkZXUXcx?= =?utf-8?B?ODJIdW9YQ3dRcXg0Q0p6Y1NheEt5enVkbXFFS2pLaVJBZms2VzFxaXJoN3FD?= =?utf-8?B?d1B1a0d4Y3RqcnJTMTB5cS9mRWRQQ1hQZWtZU2czRFFIeFUvblFTRzBCMkY5?= =?utf-8?B?MkhkaHdYcTE5RGJZdXNXV0tiWURSNGtrSzEyVVg3QmdRa2lpUXpLYUlyck4w?= =?utf-8?B?ejhKOHNwdDJXVVlFNFJhczFEOHFETkwvWERjL0JlRkxZRERwRXdpUkRZZzlI?= =?utf-8?B?WFQrOCtVaHpzN2dndVBOYlJGUFFmSFlSczByREVQUlByUmJQamVzd3NUWGl3?= =?utf-8?B?a0szVkZWMjRzd2xiK3IzK2RDRFZCUnVhNFArSi9DZDBWVHlXRDFkVnFFQlor?= =?utf-8?B?Z2tKQ0pUVGxQZWhKQ0p1eGM0Q2g2K1NxeGUvNmNxWUVqRDR0VlQ2bnlpeTFQ?= =?utf-8?B?MUc2WFFtSkxZR3Q3aWdKdkV0ZmJIQVZTbTdOZ3Y1TUJ0Tms5RUZ5bitLeUR2?= =?utf-8?B?dWU4b05vSnlPRVMzOUk0TXdwUzQzcDIvQlNiQUZydDZsMHRlaWFldHlaaGlH?= =?utf-8?B?d01jcHpZaEIwWWo4RzdsMURIQy9qcmw0ZWRMWW5wTmZFNUlBMmtYeG5reVRy?= =?utf-8?B?QXRhR3l5TkVPRE1nWlhDTVcvRktoS2djclE5QW5qaitQTWtjOEdYQktFWlBQ?= =?utf-8?B?STNMOTh4MjlEMXlFa1Jlb2gxSTl4aGJpRDhZbDVKaEhERVJIY01NTTVFVXVC?= =?utf-8?B?SVFuQXFOMjcxaTNXVkJZaDVCZ0pKMEswekVqVUh6Sld1UVFKd1M2b0czdkY0?= =?utf-8?B?Ykszb1BJS3lxWjNvcTljNkNVUzJyVHdDa0NVYjJEM1hYRGR5R3NGYW9TUDZj?= =?utf-8?B?a0s0Ykt4dFd1TnVuYnRvZVpvR1ZnOGdwMXBxV1hYdXFJdGtRcnQ0em1zazMw?= =?utf-8?B?aTZERlQzN01PWXg2MTJxK3ZHR2RYNUZab2laRjVLK2JGQ3dHR09qMWlnPT0=?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR18MB5244.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(7416014)(1800799024)(376014)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MVJpN0UvSVVjQXJWNlE1cXZ5NjJFcmx4TmRWaGhlRmpvTkhRTEVsS3ZkMnVS?= =?utf-8?B?ZmlxbmsvVjF6RFU5TkljSkszTytJKys3OG8xWW5tRGpaZE8rbk1CeEtOZUtj?= =?utf-8?B?S3BwT25QV1RTVUVha1Fqa3BzekkzdUYxdTg0NTVvUkJJVVFuUHFnWkwxVHMx?= =?utf-8?B?eHlMVGxxcm9Mam1QMFhNSkhudEI1Q2doQTlTNGRyZXR5RTdCL3ZkOWhVNUFq?= =?utf-8?B?cFdFQWsxNXJnZWM3UWI3eTlCcUU5UlJBNVdXRXNzSUE3N2FoeTMwZCt0N2RG?= =?utf-8?B?LzNkeHBVdklNak9NWGFMM2VNWUM1bDhQbHErck14dzMrcjRKL2piMXo3dndz?= =?utf-8?B?TmRjbFV3a016MnB6cUVNSnRCVXJ4M1IrTFFmb2IzazdhcE04OGx6QTQ3UjZv?= =?utf-8?B?OEVwaWZ5STFBUFZJY3JTcStTS0lEWmVyMEhrYW1DTVFhSUQxTmNtNExIRUJr?= =?utf-8?B?SHM0TkRKMnNoRWhTcldFbk42ZloyVDlCcW84RmNXZjVDOVhldVltWHRQa1Yx?= =?utf-8?B?Yk1KTUZPY3pCeFZTbHpxZ3g2dzYyVnJxdHp5UDh0WjR3MEJKYWYzeHdLQmJO?= =?utf-8?B?M1VQZ1NKZzNudWF4a2NaaUN4N21uOTBqeXpIM3ZWMmQ0Y0hLdFlXdGtZcjZo?= =?utf-8?B?MnhQUkVxUXJtRk9hREp5QkhlellYVmFVRk1SOTdDZHhJbGpPK1gvWWppRjRD?= =?utf-8?B?bWo2N2d3MWp1M2JSM0RTcXN5ZUxWT09PMlBpcXBXa2JhejlKTFRLRVN3VU1H?= =?utf-8?B?NXNLay80V3JIYU84VTAwU2UzL0l5clpEZUNDWGJFdnpjaEZpd2ptZ2c4RHJV?= =?utf-8?B?Z3d4T0hRbFliSmZBVHAxVzE4RitKSm9SbnIyY2hkc3lrYzRJb3ZvUHhlMTc2?= =?utf-8?B?STBYUTJWbjQyeG1hR1gwcDczZHkrK0JUdENpbk1LNGRTL2t6TS9LRFpSZldC?= =?utf-8?B?dGpXSHpzazBQZlNJQjcraDZSUVhDTGR5dWFlSEJvU1ZoUHBGZ2tTVTcxYldv?= =?utf-8?B?bkxVdXVlMWdoeTJRWm5RcE5BUWM5SmpIM2dHbnlBeWk1WU1ldXdPdXZLMVZh?= =?utf-8?B?UmFGeXpaL1l2OWVlTEtBeDRsWUNCaURxZThHSE04VFZUR3dINjROWS8rRzI2?= =?utf-8?B?R25QdHVMRVFyQy9KOEUwdGpiR0NkU3BKVWhva2JOdEhBTkRMaUdSaGNYMnlP?= =?utf-8?B?NHNMNDh0VWFCbmxOaTAyMitBd2Rxbjd1QkVjaTdIdlVwZXJ0bVhSNFQ2clJM?= =?utf-8?B?a3FhVjRXb1NlVER6NjZsWk45c3hJcG5iS1hxc2U5cHJ0RXRPc014bFRNaXZt?= =?utf-8?B?S3QzczA0YnFwRUdoQTFvN1BFMHZXNjlIemRNVkU1S1h6Z3d1RHNJbll0UEpV?= =?utf-8?B?Tkg4WEJrd1Q1QWN0ZERKYlYvZjBGU2U1c2xCQjlyRmtndkVtWnZTVkZ3NGZz?= =?utf-8?B?YUZSTHIrYkxabXBVUGR4ekpOVGRlb21HdWdiZ1lrMmVnQy92bHdORDVkODY5?= =?utf-8?B?dEtscUtOdlJ3MkVONkdhUWRVd0dwOG50S0Z6dWpnNEZ4a2U0TVcrN0dSbXZI?= =?utf-8?B?M1pyZjk4bHpGYnJsREFTZzdWM1E4b0hneWIxZEFZVGs5Z0ZtQTlOWjJ4VURr?= =?utf-8?B?VUtSV1kwWjg1eUFjZDFnN1pOYm1KMEV2RlZJME8zV1dkY0FKQzJVbHpyVXgw?= =?utf-8?B?QkQyekdhZzlGYjlibFAzd1ZqRHBsL0pQWnRLREZRQUFvS29rWmlIbHc4RitG?= =?utf-8?B?VG9oN0RqeTkrb2ZCem5MMFZJeVNlOXFORWR4cGE3cVp0M3U4Wkk0cmdkcG1P?= =?utf-8?B?LzBsSFAvNlBTR0FPdHVXTSt2V1RMWm1FOUZSKzVBdzdQN21rQnliemQwekxh?= =?utf-8?B?OHloQ3JIWnRQa0xaK2U4Mkw4bXlvbUQrdjNSckhmSG1OSUIwbm1sM1k5bk9s?= =?utf-8?B?RmVzeGFCSExQdnB6bm9lYnphNU5sT0w1RGczZVJLVVZ1a3NPVWlWU1UrbkxU?= =?utf-8?B?Nzd2MWQwMENxdU9lOUNBRldkaktUR3B6SFFPM0t0d1Zja0Q4YkE2cS81a3g0?= =?utf-8?B?RzcvTmhDSjJ1TXIyNVM1VktEbThhc1FaWUdDM3lKYXFacy9GVUx1aTJtbVZS?= =?utf-8?Q?gKFyykGzuAGucuq29EbVAbSDK?= MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR18MB5244.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf6a5262-8ba0-46a1-3e3f-08dce9a61672 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2024 03:37:52.9889 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /n8yRSiNTWeC3ViyVQM5Ww9dv+ZeUFJiX9YWrbVfbGZ+YvRvqckTH10mmAVxrvSTQDdm15H3eVMp8Sorinck1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR18MB4804 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: 2BAadRUifmr_yk_JNdQT5kgaMdM1kEw_ X-Proofpoint-ORIG-GUID: 2BAadRUifmr_yk_JNdQT5kgaMdM1kEw_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.687,Hydra:6.0.235,FMLib:17.0.607.475 definitions=2020-10-13_15,2020-10-13_02,2020-04-07_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Thank you, Feng, for reviewing the patch. I agree with the comments that ar= e suggested, will rework, and send next version. Regards Vamsi >-----Original Message----- >From: fengchengwen >Sent: Tuesday, October 8, 2024 8:07 AM >To: Vamsi Krishna Attunuru ; >thomas@monjalon.net; bruce.richardson@intel.com; >mb@smartsharesystems.com >Cc: dev@dpdk.org; kevin.laatz@intel.com; Jerin Jacob ; >conor.walsh@intel.com; Gowrishankar Muthukrishnan >; Vidya Sagar Velumuri >; g.singh@nxp.com; sachin.saxena@oss.nxp.com; >hemant.agrawal@nxp.com; Amit Prakash Shukla > >Subject: [EXTERNAL] Re: [PATCH v4 1/1] dmadev: support priority >configuration > >Hi, Sorry to reply now, because I just got back from our National Day vaca= tion. >>From the commit it seem confused about the dmadev and HW channel, >Current one dmadev is corresponding a HW channel if its a hardware device. >So I suggest try not=20 >Hi, > >Sorry to reply now, because I just got back from our National Day vacation. > >>From the commit it seem confused about the dmadev and HW channel, >Current one dmadev is corresponding a HW channel if its a hardware device. >So I suggest try not to mention HW channel, but the dmadev or DMA device. > >Suggest the tile of the commit: dmadev: support strict priority configurat= ion > >On 2024/10/3 19:53, Vamsi Krishna wrote: >> From: Vamsi Attunuru >> >> Some DMA controllers offer the ability to configure priority level for >> the hardware command queues, allowing for the prioritization of > >Let align the queues to channels >for the hardware DMA channels, > >> DMA command execution based on queue importance. > >based on channel importance. > >> >> This patch introduces the necessary fields in the dmadev structures to >> retrieve information about the hardware-supported priority levels and >> to enable priority configuration from the application. > >This patch supports such strict priority configuration. If the dmadev supp= orts, >it should declared the capability flag RTE_DMA_CAPA_PRI_POLICY_SP, then >application could enable strict priority configuration. > >> >> Signed-off-by: Vamsi Attunuru >> Signed-off-by: Amit Prakash Shukla >> --- >> V4 changes: >> * Rebased onto the latest >> >> V3 changes: >> * Corrected patch title >> >> V2 changes: >> * Reverted removed text from release_24_11.rst >> >> V1 changes: >> * Added trace support >> * Added new capability flag >> >> Deprecation notice: >> https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__patches.dpdk.org_ >> project_dpdk_patch_20240730144612.2132848-2D1-2Damitprakashs- >40marvell >> >.com_&d=3DDwICaQ&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DWllrYaumVkxaWjgKto6E >_rtDQshh >> Ihik2jkvzFyRhW8&m=3DBs48xsaE5RgtPTZ5CoHM0E7Jn1c5no1ae- >iuOVu8sJXD2414W2oU >> >rkmSASXpK1bA&s=3DRCRKJ2naUgpLqMM_qB_pD6hc6bFN7Tbl4XCEByoG9Cw& >e=3D >> >> * Assuming we do not anticipate any advanced scheduling schemes for >dmadev queues, >> this patch is intended to support a strict priority scheme. >> >> doc/guides/rel_notes/release_24_11.rst | 8 ++++++++ >> lib/dmadev/rte_dmadev.c | 15 +++++++++++++++ >> lib/dmadev/rte_dmadev.h | 21 +++++++++++++++++++++ >> lib/dmadev/rte_dmadev_trace.h | 2 ++ >> 4 files changed, 46 insertions(+) >> >> diff --git a/doc/guides/rel_notes/release_24_11.rst >> b/doc/guides/rel_notes/release_24_11.rst >> index e0a9aa55a1..9672d8c679 100644 >> --- a/doc/guides/rel_notes/release_24_11.rst >> +++ b/doc/guides/rel_notes/release_24_11.rst >> @@ -67,6 +67,11 @@ New Features >> >> The new statistics are useful for debugging and profiling. >> >> +* **Added strict priority capability flag in dmadev.** >> + >> + Added new capability flag ``RTE_DMA_CAPA_PRI_POLICY_SP`` to check >> + if the DMA device supports assigning fixed priority to its >> + channels, allowing for better control over resource allocation and >scheduling. > >Please refine: > >Add strict priority capability for dmadev. > >Added new capability flag ``RTE_DMA_CAPA_PRI_POLICY_SP`` to check if the >DMA device supports assigned fixed priority, allowing for better control o= ver >resource allocation and scheduling. > >> >> Removed Items >> ------------- >> @@ -112,6 +117,9 @@ ABI Changes >> Also, make sure to start the actual text at the margin. >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D >> >> +* dmadev: Added ``nb_priorities`` field to ``rte_dma_info`` structure >> +and >> + ``priority`` field to ``rte_dma_conf`` structure to get device >> +supported >> + priority levels and configure required priority from the application. >> >> Known Issues >> ------------ >> diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c index >> 845727210f..3d9063dee3 100644 >> --- a/lib/dmadev/rte_dmadev.c >> +++ b/lib/dmadev/rte_dmadev.c >> @@ -497,6 +497,21 @@ rte_dma_configure(int16_t dev_id, const struct >rte_dma_conf *dev_conf) >> return -EINVAL; >> } >> >> + if (dev_conf->priority && !(dev_info.dev_capa & >RTE_DMA_CAPA_PRI_POLICY_SP)) { >> + RTE_DMA_LOG(ERR, "Device %d don't support prioritization", >dev_id); >> + return -EINVAL; >> + } >> + >> + if (dev_info.nb_priorities =3D=3D 1) { >> + RTE_DMA_LOG(ERR, "Device %d must support more than 1 >priority, or else 0", dev_id); >> + return -EINVAL; >> + } > >Please consider other driver which don't set nb_priorities, then it will f= ailed in >the above branch. > >Suggest add this verify in rte_dma_info_get(), make sure that this field s= hould >be > 1 if it supported PRI_POLICY_SP. > >> + >> + if (dev_info.nb_priorities && (dev_conf->priority >=3D >dev_info.nb_priorities)) { >> + RTE_DMA_LOG(ERR, "Device %d configure invalid priority", >dev_id); >> + return -EINVAL; >> + } >> + >> if (*dev->dev_ops->dev_configure =3D=3D NULL) >> return -ENOTSUP; >> ret =3D (*dev->dev_ops->dev_configure)(dev, dev_conf, diff --git >> a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h index >> 5474a5281d..e5f730c327 100644 >> --- a/lib/dmadev/rte_dmadev.h >> +++ b/lib/dmadev/rte_dmadev.h >> @@ -268,6 +268,16 @@ int16_t rte_dma_next_dev(int16_t start_dev_id); >> #define RTE_DMA_CAPA_OPS_COPY_SG RTE_BIT64(33) >> /** Support fill operation. */ >> #define RTE_DMA_CAPA_OPS_FILL RTE_BIT64(34) >> +/** Support strict prioritization at DMA HW channel level >> + * >> + * If device supports HW channel prioritization then application >> +could >> + * assign fixed priority to the DMA HW channel using 'priority' field >> +in >> + * struct rte_dma_conf. Number of supported priority levels will be >> +known >> + * from 'nb_priorities' field in struct rte_dma_info. >> + * >> + * DMA devices which support prioritization can advertise this capabili= ty. > >How about: >Support strict priority scheduling. > >Application could assign fixed priority to the DMA device using 'priority'= field in >struct rte_dma_conf. Number of supported priority levels will be known from >'nb_priorities' >field in struct rte_dma_info. > >> + */ >> +#define RTE_DMA_CAPA_PRI_POLICY_SP RTE_BIT64(35) > >This capa is a control plane flag, so please add after >RTE_DMA_CAPA_M2D_AUTO_FREE. > >> /**@}*/ >> >> /** >> @@ -297,6 +307,10 @@ struct rte_dma_info { >> int16_t numa_node; >> /** Number of virtual DMA channel configured. */ >> uint16_t nb_vchans; >> + /** Number of priority levels (must be > 1), if supported by DMA HW >channel. >> + * 0 otherwise. > >How about "Number of priority levels (must be > 1) if supported priority >scheduling." > >A DMA HW channel was just one dmadev, suggest don't introduce it. > >> + */ >> + uint16_t nb_priorities; >> }; >> >> /** >> @@ -332,6 +346,13 @@ struct rte_dma_conf { >> * @see RTE_DMA_CAPA_SILENT >> */ >> bool enable_silent; >> + /* The priority of the DMA HW channel. >> + * This value cannot be greater than or equal to the field 'nb_priorit= ies' >> + * of struct rte_dma_info which get from rte_dma_info_get(). >> + * Among the values between '0' and 'nb_priorities - 1', lowest value >> + * indicates higher priority and vice-versa. > >How about (you could retouch it. I'm not a native English speaker.): >The priority of the DMA device. >If the the DMA device don't support priority scheduling, this value should= be >zero. >Otherwise, the value should lower than the field 'nb_priorities' of struct >rte_dma_info which get from rte_dma_info_get(). And also lowest value >indicates higher priority and vice-versa. > >> + */ >> + uint16_t priority; >> }; >> >> /** >> diff --git a/lib/dmadev/rte_dmadev_trace.h >> b/lib/dmadev/rte_dmadev_trace.h index e55c4c6091..be089c065c 100644 >> --- a/lib/dmadev/rte_dmadev_trace.h >> +++ b/lib/dmadev/rte_dmadev_trace.h >> @@ -35,6 +35,7 @@ RTE_TRACE_POINT( >> rte_trace_point_emit_u16(dev_info->max_sges); >> rte_trace_point_emit_i16(dev_info->numa_node); >> rte_trace_point_emit_u16(dev_info->nb_vchans); >> + rte_trace_point_emit_u16(dev_info->nb_priorities); >> ) >> >> RTE_TRACE_POINT( >> @@ -48,6 +49,7 @@ RTE_TRACE_POINT( >> int enable_silent =3D (int)dev_conf->enable_silent; >> rte_trace_point_emit_i16(dev_id); >> rte_trace_point_emit_u16(dev_conf->nb_vchans); >> + rte_trace_point_emit_u16(dev_conf->priority); >> rte_trace_point_emit_int(enable_silent); >> rte_trace_point_emit_int(ret); >> ) > >Please also modify dma_capability_name and dmadev_handle_dev_info,