From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5778A0564; Thu, 4 Mar 2021 07:49:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8DCE840684; Thu, 4 Mar 2021 07:49:46 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2138.outbound.protection.outlook.com [40.107.94.138]) by mails.dpdk.org (Postfix) with ESMTP id D05A040147 for ; Thu, 4 Mar 2021 07:49:45 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=be7CuaV3vs2IvUCqucYEqhluIC2r5m9sLzpf9ZpWd/d5vSAP55yUHlssE0GMWphykFHZWWvjLLsQKjw0QhbEw02PobeojbnfO6uo6OFhXeOShqiUOdRMgIB0rkQ+4o+E5GKM3J+vMw3J0pu6BiwYJeI90o/kEVmx4EcJDqBIsJrIJ2mO/bpLyEH8bamxRZoOE7+Vf1xaRNP3RgpSoHxOCEhP+d3t5usp74v0zdqvPYhb1bweVOXIcRbnff07/BkCue/Q7prCAiR2Ka9eMab/QdFPyk0dzOPwgDsLtYViJJcWxckU52KU7mXrnXrD78CAz/2BtQTbLfVuu2AiAutvXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u6cbt14PCfWvImMBB7tr6I4dXcXIrMz4UKsLk3hucFk=; b=IsB10rWSx68uuKapCM6WeOW2HLZ8NPco/DCGMjhahO7Q/nZJQmpNaUe6JU1kPbsovicUq94ha+M+9ysS91AXR5F8acSiwngaFxNiGqR2wo/IjaA5fzPjP9/23bUWvy836xhICm+salPdXwBt9S4U+TDnwjwdM59WWUdGua++2yWJBU4P2Dr6nXsadU2Nmon5jXy+vWD3MwVscCgk7GNi2V5fj+fVAlOYL3Oy0kFg/6r2H6Em8tsPIHtw5DHcStmPAXxPJ/ECLd5qMJAcxK4ckm2zDThRdOsFdNggnbkAV9BMEK6Z9R41UnLkjB0+EqZm5z620n51558eA9X8DKTjRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u6cbt14PCfWvImMBB7tr6I4dXcXIrMz4UKsLk3hucFk=; b=WgQgfDBpJ2nRbcfOJ0F0v4b0ZqEFVrXxleOGWpbDOi6yjrLBWhp5ZVpn2Opa7BCCI5On3FWpmbKR+4ob7SsiGxewnqOyQjyFnLttGW1oIot8gH/yTaZTxoX+2xtZnUS2cYhdgaTLfgDLctN5R6X4t4zxIJJlutdCWVGFoc8vkl8= Received: from MW4PR21MB1954.namprd21.prod.outlook.com (2603:10b6:303:7d::5) by MW2PR2101MB1098.namprd21.prod.outlook.com (2603:10b6:302:a::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.11; Thu, 4 Mar 2021 06:49:32 +0000 Received: from MW4PR21MB1954.namprd21.prod.outlook.com ([fe80::f9ae:13da:b497:f4af]) by MW4PR21MB1954.namprd21.prod.outlook.com ([fe80::f9ae:13da:b497:f4af%8]) with mapi id 15.20.3933.007; Thu, 4 Mar 2021 06:49:32 +0000 From: Khoa To To: Dmitry Kozlyuk , "dev@dpdk.org" CC: Tal Shnaiderman , Dmitry Kozlyuk , Bruce Richardson , Narcisa Ana Maria Vasile , Dmitry Malloy , "Kadam, Pallavi" Thread-Topic: [EXTERNAL] [dpdk-dev] [PATCH v3 7/7] eal/windows: do not expose POSIX symbols Thread-Index: AQHXCF32kLmPKt8mD0K6tvX6T/U9S6pzdDyw Date: Thu, 4 Mar 2021 06:49:32 +0000 Message-ID: References: <20210221012831.14643-1-dmitry.kozliuk@gmail.com> <20210221142819.6769-1-dmitry.kozliuk@gmail.com> <20210221142819.6769-8-dmitry.kozliuk@gmail.com> In-Reply-To: <20210221142819.6769-8-dmitry.kozliuk@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=6815494b-65aa-4052-bb74-fbb8127cfbca; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-03-04T06:49:12Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [67.170.72.207] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 8a783984-05fd-4717-d2d3-08d8ded9aa8e x-ms-traffictypediagnostic: MW2PR2101MB1098: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: k/n3N/O7sLZRcs2S3CGOzQNjfGtBYxcxm83lXUOA5pqqHNgKmftIYJ+AEqLWO+qLy0ayPhOAhu7xb0MbeBUho4RX4HoY+WChrEHlFXIh+LFnnzz93JwkezwShvw7Ms90dRih4d9FgqHExXS8VgylvVQhU6qlBRe4+d0VN1CrOhx/psnJl5PP4ZiUvZyovYUc97DJlxD1jX6A4rMkTXr79dBblTpW1sdrvH7d9RQyegKIwtqqFiiIXmxm+hYDjlRKBrLffzBxgR8ihtZflgQEXryPjTZrglR4nMdLYz0pvSJTK7PiSAzJJQb373HA4FvZ5IpnpBbRvbYRncdMPNUCJx23HDB4dQhsu6VSffgSnyXHHdP6srdfqs6jxFK3Bj8XHMiINfysly/fwVWTUnW0LPVj0bNtKGU2sRjGy/Acoo8YW+TzdqDovQRpNsD0fJn/AkYnFCDWxwDuQHNKH0uF72DqijtEKLlB7V1sCUE4Y5boW3/56+LX2rJ1Xi4hlDd9F2YAnUnkivuggT/7L1ddTUD82H1dagJyBJx0ONz6rxUn+GGk68YbIkk1RrwUsTKH x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR21MB1954.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(396003)(39860400002)(136003)(376002)(7696005)(55016002)(6506007)(82950400001)(66446008)(82960400001)(9686003)(316002)(54906003)(10290500003)(110136005)(52536014)(478600001)(4326008)(86362001)(76116006)(8936002)(66946007)(83380400001)(26005)(33656002)(71200400001)(5660300002)(8990500004)(4744005)(8676002)(2906002)(66556008)(64756008)(66476007)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?qIg3gs81Ay7x8SnqqaRrtybUUqfMp53heUSsS4Sxn0DHv+oDZC5wL7jlBKBL?= =?us-ascii?Q?wFV+R5nAOneqe5TjH5VH4MGWe+Dl5ItGDtOujFY71UOsN97Y1GHxrzjZ92/X?= =?us-ascii?Q?/Xh4GoiG7vehTXVPKTt5sYSX/xyUYy78ydgVj72GO+6eysY4N0yDcrFcpWJx?= =?us-ascii?Q?AJ+UxGv6QkkWpTFvnipF+tkvJ/ushuHQVtQ8Q2a8SZZrnr/FXKb6RXsB8C6c?= =?us-ascii?Q?iG4YFnl3INKlKyMew8caANrCkb4uBGSBKUUCqfpgDQ4CXGEtiAgizIaQDvAb?= =?us-ascii?Q?otW4fgVqLEuyTTdDdL2GfHwIMYBFCf1xD0ob6xMzhVEt//ik6eLZp5aew15i?= =?us-ascii?Q?8GlJMMM8ojtPngb7MkVIxQhw1F4NnfCW2D45Ll6YlP4um3mrVSuQv5D0SoHP?= =?us-ascii?Q?LTOtEcP4k/qgPHPqhl4QRQ5TUbIGGPo9VVxjtKwAbiZ2+e3HVNh7QJwb1RNJ?= =?us-ascii?Q?yMe2cRLptynll154rJcQ3cfyLFG4CMAxihkAoKBxpkOLoCyBnFkErBoszERi?= =?us-ascii?Q?DbTGTWMUy9DE+0HNeROpOI0l7bRxS21CY5jERhZbNngXlLiHOCrNvEvImNJ4?= =?us-ascii?Q?IOQWiaFKoI+/w5n9EDdzZyoajXV1oFcQLhSUo/mldELY/xN/BQCs9iTLuo45?= =?us-ascii?Q?wa98qxQYs3h0pdH8eLe6MQN4ZyTtgWuk+7bATE48nMBF/t0zvW0NycMZlUYI?= =?us-ascii?Q?+VAmb/0auPN8Qrl1H0+zRL+7uncsv0G1WkcjnMdY39SFyjf2cswCwoppxI7W?= =?us-ascii?Q?lZsiikIy4NrccbLR8qt+Hx/WM7GNKPQJVf904Mq3YZBLVd79RNQB68/x/LWA?= =?us-ascii?Q?lHLA51sS/YuN3+/G45mW9NDK9xVEZf2PvRe58VPRABZdA2JetVY99o4LT1oT?= =?us-ascii?Q?FX125WUlI8fObOCutOLoJwFuFHGuC9SVqs+d+ybUcFT2G0QY0PO3PNPqZO8V?= =?us-ascii?Q?U826b/niuywqVkn9Tq6tZ/XTTcT7TZ9ZNjL4PCjEp0ZBAZBJOAUaPsfy1lcn?= =?us-ascii?Q?8yjZ1quHqH4Ezh5B71sqpvwFyTPdLrJe8JuP00NmZMXTdGRUrnquhD+lCes1?= =?us-ascii?Q?/eQZMtmTef0fhvNpAiUuGGsLVMKXemtzVZScYGplqHsbO+KvqbTuyzoENOpy?= =?us-ascii?Q?tcmUEO4b+ivyPhkwujCPG3O0KK+I7fgXpwEwA9exLo6L2zkjjYRurV8SH4IK?= =?us-ascii?Q?YOmfQG7SXEFysxYlRPhRlWp1IecA5b2J9/TxLFsuwTBIOiwYG3YN7dckZi0E?= =?us-ascii?Q?1F+zGWo6AKS4ayTDRc/cnUs9ASjMF2wwQYh7z3izlR/578hSfJCtJLjqD3g8?= =?us-ascii?Q?JFBLa7b0EmRhjJgq6Rmkl8ZW?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR21MB1954.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a783984-05fd-4717-d2d3-08d8ded9aa8e X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Mar 2021 06:49:32.1889 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Gpmbg8BRkf2QP3hT1yPSeKsYZi+kel9NTrX57FHP5Dbo21Y70XXtFGaxaq9lMXWOnPD6reVXuqqebmkLZiE8QTwcuZ3Z0SNsO9i7uzvKzxE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1098 Subject: Re: [dpdk-dev] [EXTERNAL] [PATCH v3 7/7] eal/windows: do not expose POSIX symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Exposing POSIX symbols could break consumer POSIX compatibility code. >=20 > * Make renaming of close() and unlink() private to EAL. >=20 > * Remove renaming of strncasecmp(), strtok_r(), and sleep() > in favor of using EAL wrappers. Similarly remove PATH_MAX macro. >=20 > * Replace index(3p), which is not available on Windows, with strchr(3), > as recommended by POSIX.1-2008. strerror_r() is only used inside EAL, > rename it only where it's needed. Same for asprintf(), it has an > internal EAL wrapper and is removed from public API. >=20 > Signed-off-by: Dmitry Kozlyuk > --- Acked-by: Khoa To