From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5C11A0093; Wed, 9 Mar 2022 15:35:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9C6540687; Wed, 9 Mar 2022 15:35:04 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 606D840395; Wed, 9 Mar 2022 15:35:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646836504; x=1678372504; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=fDEK3gZwp15CppcgXP9QZIwYWY5Z74kE4YXBXxA4nVM=; b=EWHPsm6LYQbs9w794OF4+VL72bdOc3yqUV6PbCZsC/XNZEcPZunkHlc7 7f9SkeegvGubemp7ZNEUxjE8bqLULmTvbDU06rnCRPmK2Z0dtT5sBPJTA oQqQt5sgS3NdbFLeQGzctRKOI/5TJhPUyW3fKQpRxNdeBa5VPO8nbxbnx fD0VchdBiEYj/NOv0rJsa5TzZ6oyYpEoOFkZxV2V5gGJR0hiwSDTXh+gC +S++Npy2j4Wbfh5/aKiYfTHbLZ9HPyqpZJIVGCWmDcpql+twqkzEaCfEM e1wWog3RRxP4BmDpJPRpp+L/Ii4bDRg8uUXfPmJGwD4VMOUJFm1Yh5BOo Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10280"; a="255175054" X-IronPort-AV: E=Sophos;i="5.90,167,1643702400"; d="scan'208";a="255175054" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2022 06:34:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,167,1643702400"; d="scan'208";a="554133741" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga008.jf.intel.com with ESMTP; 09 Mar 2022 06:34:47 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 9 Mar 2022 06:34:46 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Wed, 9 Mar 2022 06:34:46 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Wed, 9 Mar 2022 06:34:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RQ48ph/ZM2Jy5FsBQ1hNM4j3C5ozuuU9z2PgGaba0aPMYBsP1a2ATyEt0ghlHHXJdNnhZUILLLufz5n8v3YVSBvGLQuA7puxUt9a8D3nd0nXI64LXgrntWs31JmVHtnsI0G9eHVqjH2dXWf6WY2relB3BCaz361u8OB1ptEUsxjvAIIYNAZE2LY0ltyRw7fb5QGN6/XJO1PMk6pDyKtAMHPRjtsIsVytnAk+4ADaV6UpIlkQKimqeXNRZ/7e4CjpBaEb4Z5M6ci8sGrBzp8jZQF6ANiOJHA/50vyLWDfO1DCuZqLRXxkAo/WE44vPlg36NsBCaiwYF32mrA9qqkx9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fDEK3gZwp15CppcgXP9QZIwYWY5Z74kE4YXBXxA4nVM=; b=YNZqsf92W4o1OxDND8r10WOcdASXl6pL6R1xwMYzJfRc9MM3qiid5tdlb+v/Q0l+oQSFvDr+l8sHmX2BPoAU9VQ7aDF54PtTt8nE2XCk3DKzUGIyPL9UKRf0W5qZ3ddzFFyhXnQQEz+rgtZaUSw0KvWNv2nW0Z8zJASjjJvHWKWSmj+6U0qt4wTKGpemid2AKqqSQE6DVBdHTU5tphgnBNp+a2PPWs4cOIhcmlYYtKla3nrvlxV6pB9nB07EYsLyAhONo7F2EcXqOvW3y1UkFnKJrlIAm9TVfdA3U5lZfvwPq//Em4OPvEeez28Fkz40P49ywJtVGDiclV91zYRdCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5809.namprd11.prod.outlook.com (2603:10b6:303:197::6) by BN0PR11MB5696.namprd11.prod.outlook.com (2603:10b6:408:14b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Wed, 9 Mar 2022 14:34:44 +0000 Received: from MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::6d1f:57eb:d623:5e0c]) by MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::6d1f:57eb:d623:5e0c%3]) with mapi id 15.20.5038.027; Wed, 9 Mar 2022 14:34:44 +0000 From: "Zhang, Roy Fan" To: "Zhang, Roy Fan" , "Bronowski, PiotrX" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "gakhil@marvell.com" , "Yigit, Ferruh" , "Doherty, Declan" , "stable@dpdk.org" , "Power, Ciara" Subject: RE: [PATCH v2] crypto/ipsec_mb: fix usage of untrusted value Thread-Topic: [PATCH v2] crypto/ipsec_mb: fix usage of untrusted value Thread-Index: AQHYMjjFj3Y1xzA3cEi4qZvtqU0tqay0G8jwgAME66A= Date: Wed, 9 Mar 2022 14:34:44 +0000 Message-ID: References: <20220307124802.1371808-1-piotrx.bronowski@intel.com> <20220307153233.1407564-1-piotrx.bronowski@intel.com> In-Reply-To: Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 454f2810-e325-40c6-274e-08da01d9f456 x-ms-traffictypediagnostic: BN0PR11MB5696:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: f8h5DQz/Oslt/HeN4RO6TQvSEoAJEUzcnuCEJKZBC5+3wCC5wrX1cNaDn+E50SOYEd2PF/U5X0fAMLRfq5oTlGqAK7LR/wOgurBYc4AHB5tdAxzgoZ2LvIRsJlKMGf/LJ0P0HFSEFM1cH1QWyKMpVlVGrVSy01SGZeNEuVCSDhDHlKt7uFtHaXW1uHx3rbvShyWYrkDzkiTzOx0/TqXIvVxzLnq5W+RrcWquK//pQClh4L2SbaXQWwk+aUqhuq7+Ir0didKCt/eZ/LW9xB4yR1ZI8m7284mnQiubH5hvSJAo10FPnqovfiJxFZRFOfDdzGWahTR7O+a2y9usx+wuKZfCfPh/JSMNtcLhPl0HNe6/dzX7E2wPg+UVcO79FjcLoBrBsKHxbQiVVOYTOfFJ3Uz/5UHZyJnRxwzRDNwBAKIPFGcfMhx6pn2Qc8o+jdOUOePU56+DQQ0nDWGSwNspxdqo3OSQAAVhM+TGH9LYLJgbrC0lQfJFQlnMrocZYAk0rC9cNRJqjPNGvBUJ+6HNTdJl3UJJD1ro4hUnGIfQ5/iv/Ii1T6Ma3d9ebfGd9xW3Q/Fap1CTYlOVJd6BsS0Vpfu2z6+bwUaxDGiKYf359LNeqoT3HaS9pMKUHfACWrsJIv7/tLhLiGl6CpiumJlxmb3I8EMP/TOplVNZMEWln4tOAAV34gzN97PCSW4GGEvpnt2uZXFuFL9kT90OuxuAwg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW5PR11MB5809.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(186003)(122000001)(38100700002)(38070700005)(71200400001)(26005)(5660300002)(8936002)(110136005)(52536014)(107886003)(54906003)(55016003)(316002)(66446008)(86362001)(76116006)(4326008)(8676002)(66556008)(66946007)(66476007)(82960400001)(64756008)(9686003)(83380400001)(33656002)(7696005)(6506007)(508600001)(53546011)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?lCJnPxmVNtEhzBxBxya+n1GrDs1Fkbl6PH+Gd0cuMcL+NtBsqc6GSvFh?= =?Windows-1252?Q?4E+lARf3SHMK2l+RBwq6VkxlN07rAlRHcMnxP1yy1Y4s6qanRRWTNCB4?= =?Windows-1252?Q?uH2apIeXrntDGQVfmRbkqpcAmK/3fISPE4HIfTovk2DttUJi3BmhF1ke?= =?Windows-1252?Q?bC7sMoiOz7lSheRkUVT6kQDExqxNE/+87abnC5Dw3YzvRna66grmF4lq?= =?Windows-1252?Q?THrOgRiE+nyQMaRCIfoBLeEvtipNWFMar2xpidhURFzw3CMtmPFKCrxs?= =?Windows-1252?Q?geo+827XPBUKnGSDvi0nbDywvB/OJsEScv+snr818XYLSm3mxWphoiLS?= =?Windows-1252?Q?Oz7fgTa76O6/htb16t7uFhYaHsLDaq9z4t/Syl9Kt2Q0UMlrwzT8Q7Ap?= =?Windows-1252?Q?6TKuJ2qUiNn7txqpvQJ8g+MMEQvPlpTEybq23e+Nw2t/uWK7Hd1WXH3c?= =?Windows-1252?Q?0Xm+OTRB1LZYNXLlZYLPvgwOfEmqX526pYFl6s7jcGjzrAxJKE/72c92?= =?Windows-1252?Q?opmefzGBWEbk5Q2lU8weGl3s9fnwd3w9+tErCatlnjk9LWFOKJYFNT5C?= =?Windows-1252?Q?oF9N7AdHEm7xNOounLArsW6HPhcLp5qvtQy29CvAxQRTz2VBGfjAeiGq?= =?Windows-1252?Q?ToH/7GRiNh+I7ebd9JWwe33xB21eb4PplGsT/phGhgejV5OK7iFPeBJu?= =?Windows-1252?Q?Yriaig4mhmPTPIwJbWNnHGz4m27tfOQQw/WeTffDJ3hwO8gd1SKmPQq+?= =?Windows-1252?Q?kAikcAbJivJSAWyt6NmUAY+zPGuzL4Yu+trM+LCd5k6oLKBNUv1DNnXW?= =?Windows-1252?Q?s1Y0u/1gMxj1aW1EhPJZE0SYUAGcamFsvsZZBaLncEXPCye9t7dF3yZc?= =?Windows-1252?Q?p2UJMTszMuVgUFjAkYF3kaM5z9Ot1gim3E8MkIWZrlC3uc/cmZ2vmp4g?= =?Windows-1252?Q?OnKTJdIFQkr8OhzcT6gPL9G4EJ8HLCqGjZH4kTVYS/xmhRkFBxoA+Hk+?= =?Windows-1252?Q?cZbM5INDBCGuT+OidJMYAOmaSYJbWeZYqHK+UqnkOGPnKGF+75GI93TR?= =?Windows-1252?Q?L2PcxeXy5iuD71a+MvJoS5WHzJrY/1nyn6NRMTFO3OC9pDv7XrKAaaiT?= =?Windows-1252?Q?bvH+budyXUlH4NeKKNegFdFuFa//xbWRU7uGhGt7LrnuHzPa/LrCcDu1?= =?Windows-1252?Q?E2IIIsnPGW58bnEgUuR7i6qAsClr1N8lKOgZ9pbWd1lSvpVT6B5vC1f4?= =?Windows-1252?Q?0Wp2gIHzxS+2YAb1ND6ticEkh0eGtkwoyWXBGPu0cgj0XGA5Wtkdfsx+?= =?Windows-1252?Q?wXJJbt0+ebr2A5wDzshJfD9I3W3XYyc0cT0UZVXlOOwGpYF3mG5cEMKK?= =?Windows-1252?Q?DK7C0hG9ti6OUEJJNnpfcGl8MtI800sAIkQsT4QEvrj7HWbcI9gNXxro?= =?Windows-1252?Q?PlrQf/91HQlsviJVIKdBBro/OLBiIvfmcwD415gzq2trXP3kjhFvW2bm?= =?Windows-1252?Q?szyHNvUdhUtQZyEJXhMd1HpxXkBDPYIqXPVrMY7clNkkHQjI95bPPOVL?= =?Windows-1252?Q?06tvuMP0QiWroQyGpWVGS54HdGldTiJlJzXJ+lJuE+Exk15bsWWjrJ2+?= =?Windows-1252?Q?HSbQ8MH9DUHxJ35DKAB9T9fW/Y+56y7Xy8nKxiZdVf/Q1POm0q7Oua9v?= =?Windows-1252?Q?0BToKdV23BiUdZWbirT2rmk9ikGa+mo1U1YLW4xy3YTGDs8ZK1UKPHkE?= =?Windows-1252?Q?IrON9Af/knl8N6y9m4c=3D?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5809.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 454f2810-e325-40c6-274e-08da01d9f456 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2022 14:34:44.4070 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Q851DA+RORcya2i05lBS+DGgL2yAq7uWtSQHNmG980wbWA1q4tFCxLb8hRN2wwtHPqxnP1futLjrt+aI7whmww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR11MB5696 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Piotr, > -----Original Message----- > From: Zhang, Roy Fan > Sent: Monday, March 7, 2022 4:27 PM > To: Bronowski, PiotrX ; dev@dpdk.org > Cc: thomas@monjalon.net; gakhil@marvell.com; Yigit, Ferruh > ; Doherty, Declan ; > stable@dpdk.org > Subject: RE: [PATCH v2] crypto/ipsec_mb: fix usage of untrusted value >=20 > > -----Original Message----- > > From: Bronowski, PiotrX > > Sent: Monday, March 7, 2022 3:33 PM > > To: dev@dpdk.org > > Cc: Zhang, Roy Fan ; thomas@monjalon.net; > > gakhil@marvell.com; Yigit, Ferruh ; Doherty, > Declan > > ; Bronowski, PiotrX > > ; stable@dpdk.org > > Subject: [PATCH v2] crypto/ipsec_mb: fix usage of untrusted value > > > > This patch removes coverity defect CID 375828: > > Untrusted value as argument (TAINTED_SCALAR) > > > > Coverity issue: CID 375828 > > Fixes: 918fd2f1466b ("crypto/ipsec_mb: move aesni_mb PMD") > > > > Signed-off-by: Piotr Bronowski > > > > Cc: stable@dpdk.org > > > > --- > > v2: use a different logic to check digest length > > --- > Acked-by: Fan Zhang Sorry I missed a point in your change and thanks for Ciara pointing this ou= t. You are changing the gen_digest_size to 64 which is wrong. Please send v3. Also instead of ack - Nack this patch.