From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4ED2EA034F; Mon, 11 Oct 2021 17:07:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 402874111B; Mon, 11 Oct 2021 17:07:19 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 61D0C410DF for ; Mon, 11 Oct 2021 17:07:17 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10134"; a="227181821" X-IronPort-AV: E=Sophos;i="5.85,364,1624345200"; d="scan'208";a="227181821" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2021 08:05:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,364,1624345200"; d="scan'208";a="523864517" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga001.jf.intel.com with ESMTP; 11 Oct 2021 08:05:47 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 11 Oct 2021 08:05:47 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 11 Oct 2021 08:05:47 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 11 Oct 2021 08:05:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VrfuUz2ZneS8y3Icxb7fq5zPJ/b3Lhdb+Ihjt2E82azWY5mIoEKYGXv4BPmJtw74QnxhYLMY/R6/s/WxpGHTG0SqVCDcql1M1gP/yuJ5scBw97HN4lcosBY46Vc4wUepMf4J4QUjpalFVpJPR0UOFUqyoEPMigPim10fyFsFsQq2n0kWKb4tF9VLqXGWbORr1PmxjBm3pRA9BCHpG33VTzmxpUKIVeEbusW+Qd+cBy8gybneTz20spRi15koFq46Hz4cMcS5gkDyu6/ZHclOi40n0y6NjwHAtiBNFaVXQZFYEBD/Aa1vXwm2YqfHl29rsozzECZWTJPywIhvEpUi0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KT72v6zJeEj4jnhD7oPAJqdJdz787fuKWEr5v+bUoSI=; b=HfBNrksXr5u+XeAzZMjnoWlnoitTF2DRRmbI6f25glEZTfZGpZeP3UMPvBGEvx2RdfRvrzfip/6CECKsw8pVRUGdVHbqrtJzddiY/Z5XkUtPzeQwkGox4MWIWuT+O2pbT3366d1Q3nPlfTIiQv6KKr+ea6jful6gB6oP4aTPT7InImrKj2M95824WJxwGlFziIg42go/GL0tcA6yinTALn0OyKXuwBdV7lEbe74Pe8hk+HDYyjYQ3NM2H4+mHVq4BAOHZcN/UOH0wZKVlSXuhmZZeRQ48JrtqfLON6aLKPajzbzWS4AbK40eeirlg/Kpo2grJ11YjvFByn/DqNY4NA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KT72v6zJeEj4jnhD7oPAJqdJdz787fuKWEr5v+bUoSI=; b=mYDt0PZq6du1A6dAMaUI/+kNOnMMGVJ9LJ2Xh7jWTp3eNTCfiyshklOYfG/J8h2WqnvzeVHOJRRZdOqVSR1ZqxK+IrDpTezmwfvFW/WyTj1qYCvzadp6m+6Bu35u998iCYGt6J4DLVTSkMyyo6r2FnHq0qILR4AP5FDt/FqOIqE= Received: from MW5PR11MB5809.namprd11.prod.outlook.com (2603:10b6:303:197::6) by MWHPR1101MB2285.namprd11.prod.outlook.com (2603:10b6:301:57::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Mon, 11 Oct 2021 15:05:46 +0000 Received: from MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::2c31:1470:3036:959b]) by MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::2c31:1470:3036:959b%6]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021 15:05:45 +0000 From: "Zhang, Roy Fan" To: Akhil Goyal , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , "anoobj@marvell.com" , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "g.singh@nxp.com" , "jianjay.zhou@huawei.com" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "Ananyev, Konstantin" , "Nicolau, Radu" , "ajit.khaparde@broadcom.com" , "rnagadheeraj@marvell.com" , "adwivedi@marvell.com" , "Power, Ciara" Thread-Topic: [PATCH v2 5/5] cryptodev: move device specific structures Thread-Index: AQHXvp252+8rbfdI4kG4p6Vt4BMNH6vN4rOg Date: Mon, 11 Oct 2021 15:05:45 +0000 Message-ID: References: <20210829125139.2173235-1-gakhil@marvell.com> <20211011124309.4066491-1-gakhil@marvell.com> <20211011124309.4066491-6-gakhil@marvell.com> In-Reply-To: <20211011124309.4066491-6-gakhil@marvell.com> Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b8458a9c-8ab9-4fe4-4648-08d98cc89a49 x-ms-traffictypediagnostic: MWHPR1101MB2285: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b6Wm7PqdDAuw+4Tu62EfLEhELahu3ROJnhsOwrKN+VlzcyDjwYTqz6iI8JnAR3NHbaJWc75j73lWkFlcT0aqQhhkL8udUvna7cRgTKmzoDQareb+sQzk/a/Z94avuiQxsCLPqmpF/k4Dz3yDyLXKuDmvRudlYIaE349rVrkBYQMMce3KAI3TYHFqx1Dj8OgDpVIXgI1M/O/INScBzS2e/FhvExgzMOpxCje9eaId8kKTp4SHLKfvtXWQu2oyTgCIT+u50Cm1HsfNj5ueL+Yo9CRRqIwKo/SH4G1UrjgfDeH5HvEJZ3Pcrg0NpDtzNB2sm9ppayLgOMwd3Fp7xreZs6EWSkCbefUguvC8H1aG29zYA9tyZ8XRY9ZvuYKZzqrApWb9x2nvjMLROxR+GxMVPTIS5U3Ur7BlPAfRJ1cPIWZ2yRyZ0UR3m/6cnoyxGqb58dIOJieego8yfYEAACcpSjuKKnuxqeYISHg097BTPBp9yVeBvr5mKnhojcrDfvnK3J93Klxqa65416Re1ewqcIYfzLkgaCCYTR+Te2zFrRUAdddWXpAmoHkmRlpXbAFdb+S0W8w2rQYpoHPToqdDJZTbVnXni4blbb/lvzM7jqjz1YyC8kP+ndENC8tXsq/XtGw/ygK2iPEci4DBz8nom4NOuqrr9yHsYbQWkgFBq+alQr3IqppWzpBV36ZrlG+8CbDNX6dgkTAtpM4VdWM/Og== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW5PR11MB5809.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(508600001)(122000001)(83380400001)(8676002)(52536014)(55016002)(5660300002)(86362001)(38100700002)(33656002)(8936002)(64756008)(4326008)(71200400001)(2906002)(186003)(110136005)(54906003)(53546011)(26005)(66556008)(66446008)(316002)(38070700005)(7696005)(107886003)(6506007)(7416002)(76116006)(9686003)(66476007)(66946007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?lovirhdGyd8QtqL44qd3CJNkenoQNGYRHhrQFg4Ygx3erwM2MEM0GbM6?= =?Windows-1252?Q?Ju8EcYHvuFpZcqtcWrCaa3lTdeh1vWel/KsIZ7PF0jzg94OpE9ZM832C?= =?Windows-1252?Q?smN0d5n8GheXPqC5qSYqXxH7taRqXMUQIg/JXrGYjAvKjKzJdUp6rD7F?= =?Windows-1252?Q?wlfj9a3vfTAQL6wD2zPsbwcnaceb082RTIzTFnxuOu3ktggsRtulQp0+?= =?Windows-1252?Q?Zx3w9nZ5bScXMqq2UKoLpSl+AKcuo0cwqrFynXtAHqu9nNiWney5XfPz?= =?Windows-1252?Q?9dOPku3diZwIhy4MHdTtypCv1haepVH3ycepQFek+RlM8cEs8nWLvsLg?= =?Windows-1252?Q?bXmPHQYPPIejrpwFU+MP9qmbpxjmQQgPkRbwIJZUufJnQ8kgxOZsI3qt?= =?Windows-1252?Q?VzgVYqNuTzJsWMehDeyOg7Gb1ZwgUBCL7BhZL6amBanoC0tIFWHJzONz?= =?Windows-1252?Q?lDu8gsQs+d23lA1FVKStkHqFZ4lFdSSF4lmu1E89ATiD6W+uDeKFwwsm?= =?Windows-1252?Q?hnALxZI77YryGfAsdyOosFE/qVSgM22FZwrJ8qzGAfjM1fB+aLWSbYAE?= =?Windows-1252?Q?j/FgPKhDYTXDNOk+4jFRfvRXc+cu84tU/dqIAjE8qlezYh0PGjwTzcdE?= =?Windows-1252?Q?FNkZdQf4QhYaUvMWgYEXDuNv4ND/pCuzVvK5/n/7yti5mTWS01bURfme?= =?Windows-1252?Q?Yo8K+14hfHaalrVBOtpZPrf480WFTQerWYVLyFixFHXdEgmUBztqIJtb?= =?Windows-1252?Q?VUEL6n1d/Xf9VcJL5ncerCTpoQtu19dYDvn8pAiFaMHswp4vxUpIZgjc?= =?Windows-1252?Q?uFJIaKsRwSVAK6NF6mhKohFdcCff+yXZDz/Nfw+eChNukWZR7ptnbjwa?= =?Windows-1252?Q?P5hEN6aQHOGEViNE+db8cl0i0zi7jPY30q5FUP6+wgVkpKj2JN0ATetN?= =?Windows-1252?Q?4EpdK9lco33+WoA32Zdhboq9WwG2J8bDHVrz6ayzgdFtulAqGUxOZXR4?= =?Windows-1252?Q?Iuj6Slj8ZSz6JVCTVs/1/JhL946qKPeZw1sieXF350HdJT/EyUmEMtkc?= =?Windows-1252?Q?AkSrt2afOmekP+Rb0r9+PbaL1SNf/F5FyfkgpxsnG0XzkgQDqBGHdf8N?= =?Windows-1252?Q?MQK0wn54N3H1KceQmyy0bq1sHks+S97nYucRuCKYLzypjDX1AL3ui9vE?= =?Windows-1252?Q?vhxMUd0dJzURgbJnU7427wo96fWHgCkkAqXPcEeo7yoZbVXgSuag7Sf4?= =?Windows-1252?Q?BB1bks96tUK0RuauIhP9PeoskA+rPMK8TGfiwxIqIamCD88hffOox5NC?= =?Windows-1252?Q?G2vuGocHxW8AzUoPiVO08jPDTdDpUeS/z2MABzDGd6xFWxxZ+VTxl6qb?= =?Windows-1252?Q?oo/pefLDRQcRufUdDVpS3LZXLbNtSlkO0iI2u+LRAFT2m7AW5H3Wd98c?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5809.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8458a9c-8ab9-4fe4-4648-08d98cc89a49 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2021 15:05:45.6699 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Tla19Sg6rONoXouuj9UoheokJtvKyYMwO95QnGCiqBb1ZjvvKysBvjpk9MHRh38IqZvlA0XkWMsj4q04J0Ftng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2285 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 5/5] cryptodev: move device specific structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, > -----Original Message----- > From: Akhil Goyal > Sent: Monday, October 11, 2021 1:43 PM > To: dev@dpdk.org > Cc: thomas@monjalon.net; david.marchand@redhat.com; > hemant.agrawal@nxp.com; anoobj@marvell.com; De Lara Guarch, Pablo > ; Trahe, Fiona ; > Doherty, Declan ; matan@nvidia.com; > g.singh@nxp.com; Zhang, Roy Fan ; > jianjay.zhou@huawei.com; asomalap@amd.com; ruifeng.wang@arm.com; > Ananyev, Konstantin ; Nicolau, Radu > ; ajit.khaparde@broadcom.com; > rnagadheeraj@marvell.com; adwivedi@marvell.com; Power, Ciara > ; Akhil Goyal > Subject: [PATCH v2 5/5] cryptodev: move device specific structures >=20 > The device specific structures - rte_cryptodev > and rte_cryptodev_data are moved to cryptodev_pmd.h > to hide it from the applications. >=20 > Signed-off-by: Akhil Goyal > --- ... > diff --git a/lib/cryptodev/cryptodev_pmd.h > b/lib/cryptodev/cryptodev_pmd.h > index a71edbb991..0d1bef0e67 100644 > --- a/lib/cryptodev/cryptodev_pmd.h > +++ b/lib/cryptodev/cryptodev_pmd.h > @@ -52,6 +52,71 @@ struct rte_cryptodev_pmd_init_params { > unsigned int max_nb_queue_pairs; > }; >=20 > +/** > + * @internal > + * The data part, with no function pointers, associated with each device= . > + * > + * This structure is safe to place in shared memory to be common among > + * different processes in a multi-process configuration. > + */ > +struct rte_cryptodev_data { > + /** Device ID for this instance */ > + uint8_t dev_id; > + /** Socket ID where memory is allocated */ > + uint8_t socket_id; > + /** Unique identifier name */ > + char name[RTE_CRYPTODEV_NAME_MAX_LEN]; > + > + __extension__ > + /** Device state: STARTED(1)/STOPPED(0) */ > + uint8_t dev_started : 1; > + > + /** Session memory pool */ > + struct rte_mempool *session_pool; Looks like we never used this pool ever - shall we take this chance to remo= ve it? > + /** Array of pointers to queue pairs. */ > + void **queue_pairs; > + /** Number of device queue pairs. */ > + uint16_t nb_queue_pairs; queue_pairs are likely the only item we use rte_cryptodev_data in the fast-= path. Also take this chance to move it to the beginning of the structure? > + > + /** PMD-specific private data */ > + void *dev_private; > +} __rte_cache_aligned; > + Not really comments but some suggestions - could be done in the future as t= he structure is moved to internal in this patchset. Acked-by: Fan Zhang