From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5624A0C45; Fri, 15 Oct 2021 17:33:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9EAEC411D8; Fri, 15 Oct 2021 17:33:49 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id A1574411CB for ; Fri, 15 Oct 2021 17:33:47 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10138"; a="314129409" X-IronPort-AV: E=Sophos;i="5.85,376,1624345200"; d="scan'208";a="314129409" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2021 08:33:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,376,1624345200"; d="scan'208";a="660545880" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 15 Oct 2021 08:33:46 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 15 Oct 2021 08:33:45 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 15 Oct 2021 08:33:45 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 15 Oct 2021 08:33:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mYxpcS5XunamP9eb9yk4utpeghKlC5Yc+PwzC8uxWFsX1xkWAANm+pJptY8XYca9uK6d3lJf/ldwTLjxDqWQHbgMGPY8XlyC8bNj8aCTmU6JYeGL+DPEu8XgkNB7t4yaG5SK8aq8SyyZrKMdbGBznOk79scEtS0Ix0+x7qUIzzLsOoHPjDWpuhVxH7csZKPnMsinC3+dCyx9SAcc2BqpsiRW9PUqt2vFon5P5TdRmwS03HMav3uQ1fUPfUiXGeMfs/6C+LicOAX0Z2+S+y3Tzux2/qSf2qCZBYqNI6BavoPySzO7kLuhlmlmF55FhGKpbgG+hMd/W+o+NNrN89qgog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=56uvKkO+/B5yqbhiaznGhKdFp+fEl6X2iajbuKAYVDg=; b=P5dtpl0Zl2vf8Bd2YRIWPWnqencYh0vsihOxFShjE2q9iWNyhNPtsMy6V56kQROa6FJv38Wjthl5K2n27o45i6RSk5f0Wr3XnekIuiQJbdnJJnyfTl8jdivXe4ls3QduQu3gLFdyU+Bao8KInbZdn+XHDmjduWKk+3Rz+fnZB0YOEyZILiS9WmwdTRFdp6ton3+gn4dZyvxNNQT5VYzMegPQnzdQ/+P345kuoB/ZwZPU+NTcmIwqy75VQfcU1EP4Xqbijo/wPRHAGS6cExISc9lGKskYVqxvP0wBqzI9f329xh+UB59nQY/9NzTJFcCa8G2hWWNeco/ySmQPqQzHwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=56uvKkO+/B5yqbhiaznGhKdFp+fEl6X2iajbuKAYVDg=; b=n2/rYBiB4ys0WiXkL2kxT4iGpl1OqWSgozkyT/n++EpAhhMpEF2YFU8rLF/OIbSmsLuDQ51+DEpDSU6bkC8qSGIL/oFVN5UaaxMdd3UGFTXWooGO5HoEgVes0TjUFyl4vbh7CB4eIvW8eyKvE5KdaR/oTWbfgX8kUDfWdihMlII= Received: from MW5PR11MB5809.namprd11.prod.outlook.com (2603:10b6:303:197::6) by MWHPR1101MB2093.namprd11.prod.outlook.com (2603:10b6:301:50::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct 2021 15:33:43 +0000 Received: from MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::2c31:1470:3036:959b]) by MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::2c31:1470:3036:959b%8]) with mapi id 15.20.4608.016; Fri, 15 Oct 2021 15:33:43 +0000 From: "Zhang, Roy Fan" To: Akhil Goyal , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , Anoob Joseph , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "g.singh@nxp.com" , "jianjay.zhou@huawei.com" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "Ananyev, Konstantin" , "Nicolau, Radu" , "ajit.khaparde@broadcom.com" , Nagadheeraj Rottela , Ankur Dwivedi , "Power, Ciara" , "Wang, Haiyue" , "jiawenwu@trustnetic.com" , "jianwang@trustnetic.com" Thread-Topic: [PATCH v2 0/7] crypto/security session framework rework Thread-Index: AQHXwGe76fTitYpJN0GlLW4tZSnTFKvSYb2AgABY9OCAABXEAIAACUiAgAFYU6A= Date: Fri, 15 Oct 2021 15:33:43 +0000 Message-ID: References: <20210930145014.2476799-1-gakhil@marvell.com> <20211013192222.1582631-1-gakhil@marvell.com> In-Reply-To: Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cda5a838-5b10-4c05-3af7-08d98ff12ba6 x-ms-traffictypediagnostic: MWHPR1101MB2093: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fUnHwOUIswVz1N0ClG6AOljkVAhOgGcUIGVK2psGwYEkFTuJVr/I8K1NpZfIWWEWK3k0leSDOIPGPQJ6mN0qSC7snaylPxB0dc26mxkla5Mp3R4ZyjbyaRE2FkxFPh7bm9PCV9Dm5KAuZXxFfkz5n1dhPJT2AxqD+Ie1LzOBfRqumMST4pyiZNm2dnL2TFYC8WWDqtcafLYnqrmXi7uItw9F6uSO6Xy7TtdumUPYUzdxTt5mKCd/bgsqDFmPMFRARVhIwUosUqwtLAjkEqaf6jIwqulTGE9Vhd8tCJIB0EQMnfQOqBXW0/hEyrQKLFSmlV4m3M5b+raxz2IbWL21p5hHddHZyLxp5cd91JgzMnGTPPv4bRysOjTJ2Rkj3ETOQq5Q3BwpDWNAU4XAc12wUq5DFUAaPAIdT/fY+QNv8m+F9u+MaMJh7YgEI5NWXb0Gz8dbP7waJcQhRXMRBe4DlBEIXD9bo1ap72wOuV2ytnNFN04bXDbYyuEKtxwjT9mXLdP7JQw3NBqn15chlzDFfitbUWZtN4ICKEO0X0Sp5DwousoYPPBC0J/QFxmxntXiqT6NqSBqwLOtDpIcPDKZwptP9Ru5NwpHJVdnbX9CukT4tFxa+DfdwM4ntp2d0OUXgqZytE6gzNODX8dmivNSBRBOys7FZQMUp48vwm/EXeuHZX32IhhI6GPIcqbecXVk9JFZvQ8r7HAR1qjsNXJLzA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW5PR11MB5809.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(76116006)(5660300002)(64756008)(66946007)(66556008)(66446008)(66476007)(4326008)(2906002)(508600001)(54906003)(110136005)(33656002)(8936002)(7416002)(316002)(6506007)(38070700005)(53546011)(15650500001)(7696005)(8676002)(55016002)(82960400001)(38100700002)(52536014)(71200400001)(83380400001)(26005)(86362001)(122000001)(186003)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?/IqchInzxrNIqaVReHdMdtanVwrmStUBFThfMtGLviynOTIakFyG/fvR?= =?Windows-1252?Q?716rCblAJyYhaZUG4p3dgmuay9yjXoGOeb5XeuRCNStEXNMufLQ3TtAB?= =?Windows-1252?Q?xPOtxK6/5hUoLE6K7k9MEzTco08uMhvKwukeWVNgW29sEKr6jxkE0pdL?= =?Windows-1252?Q?FHXFH25eROTks3oP3Xid2iyl5Tscnk2Sio+ujerUJa1iLUtiQ/JK/yC6?= =?Windows-1252?Q?LNWxYwfTP6PG/4tJ86fZO/8HlyDY0jpjlfexq1h3Foh8HvzxbO0jjC3e?= =?Windows-1252?Q?YeGc0P+t4HRefrQN0wGzD3exToiuTwQlTLXXgoQxtP2pp0Y2o54riuQx?= =?Windows-1252?Q?FRP1V5UAXDCaayW7jnt3SAj9MEZunhEvigCbl7IbhPhv+asfT13VMBwx?= =?Windows-1252?Q?flpVku9UMAFA1+2e5jZgQbnbTwNWLVsouuDt38CMJ3vX/HRLhvdKnFMj?= =?Windows-1252?Q?bqG7z+LfQ/IlEy4edJ9UHmKuKuruiEyKG7pY4KjWreKC+LA1d8JcdWN6?= =?Windows-1252?Q?+imoUt+NBr4mea4dMgodk2beTWUGLbshjtB9/vhDHQrRRWQR1xYzdxel?= =?Windows-1252?Q?tKePoSt7A8rHsd4STmgyORNUo1coDkFZko0isfcVCjgyEVh3mtaXrf8I?= =?Windows-1252?Q?wXiIBGua497PwCf7N66t18SwioRMt8V4sAEBC2NhVnQsK1ZOa3Jkfj1Q?= =?Windows-1252?Q?TTzEbI2vrQMa0+5b1ykNf583OFt8O3mIi53fVf5T1TdKtODLFfhuVAXx?= =?Windows-1252?Q?fwf40IPPg5QfsqBMKs/Y5llfb/S+sq8lpWm8iU6qIIyfD9aWlm/07TVH?= =?Windows-1252?Q?NiOe6C4Q4RRsUltJYicgt3Ib3d+tqL+xpIzsLBQUjXcLli8YwUibzScU?= =?Windows-1252?Q?izUCTeTFGkoqs/nJn11LTuymn7pxI4D7wnZqbk0o8AJo02sBhQvix208?= =?Windows-1252?Q?UNHA3juL1+VGCHeiEtVSfpCp46Ji01uikKXq+48B7Po6nzX90Z0QrtR6?= =?Windows-1252?Q?p9wlbFx0xzXAy2X4VAZv6aP3PFuy+H9SIY/V4bl1qdSQPX10mIaLn3pV?= =?Windows-1252?Q?WIqFqsSVsXwexCXy+I/CsOq1b04DDmrT92wJsz1kFfTRH+GnUH0R/brO?= =?Windows-1252?Q?5m6QzhLl9aHdD0gUfnxNNKbvqHzSqBY6fs7mCDdg4xijA035L33J5IOS?= =?Windows-1252?Q?hysi3WQ1XEWNyImr4Zs1eJEbrv45zbRPIWtAq0y4DjXlfy9zrp0sblPx?= =?Windows-1252?Q?Rk1SyGWJCxvw9Zgd1He35TjY8j0kdkwKo0pb9Z0o1ocDHBzN61v1E+N6?= =?Windows-1252?Q?0zOW021JZ4S5IPmF7XOEKGiV3MefIO/lZcowfHrCozgirt/pwXYVZuAq?= =?Windows-1252?Q?Kxpz5SqgWCb0Nd078xCHkVB4tQdk89k55mhy68OahyQwyKYd7JklSVSf?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5809.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cda5a838-5b10-4c05-3af7-08d98ff12ba6 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2021 15:33:43.0446 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: o6i7iRPcFZ3vGy8PCgnO1K2ecNjuXIxFo+DgsDSiOv/2Dgy57CQEkrKzT9U98Gm5TL6hnAC3ppbdS1eGbJ61vA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2093 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 0/7] crypto/security session framework rework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, I tried to fix the problems of seg faults. The seg-faults are gone now but all asym tests are failing too. The reason is the rte_cryptodev_queue_pair_setup() checks the session mempo= ol same for sym and asym. Since we don't have a rte_cryptodev_asym_session_pool_create() the session = mempool created by=20 test_cryptodev_asym.c with rte_mempool_create() will fail the mempool chec= k when setting up the queue pair. If you think my fix may be useful (although not resolving asym issue) I can= send it. Regards, Fan > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, October 14, 2021 7:57 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Cc: thomas@monjalon.net; david.marchand@redhat.com; > hemant.agrawal@nxp.com; Anoob Joseph ; De Lara > Guarch, Pablo ; Trahe, Fiona > ; Doherty, Declan ; > matan@nvidia.com; g.singh@nxp.com; jianjay.zhou@huawei.com; > asomalap@amd.com; ruifeng.wang@arm.com; Ananyev, Konstantin > ; Nicolau, Radu ; > ajit.khaparde@broadcom.com; Nagadheeraj Rottela > ; Ankur Dwivedi ; > Power, Ciara ; Wang, Haiyue > ; jiawenwu@trustnetic.com; > jianwang@trustnetic.com > Subject: RE: [PATCH v2 0/7] crypto/security session framework rework >=20 > Hi Fan, > Check for below QAT fix also > > > > > > Unfortunately the patches still cause seg-fault at QAT and SW PMDs. > > > > > > - for qat it fails at rte_security_ops->session_size_get not implemen= ted. > And for this one > diff --git a/drivers/crypto/qat/qat_sym_pmd.c > b/drivers/crypto/qat/qat_sym_pmd.c > index efda921c05..96cd9d2eee 100644 > --- a/drivers/crypto/qat/qat_sym_pmd.c > +++ b/drivers/crypto/qat/qat_sym_pmd.c > @@ -306,6 +306,7 @@ static struct rte_security_ops security_qat_ops =3D { >=20 > .session_create =3D qat_security_session_create, > .session_update =3D NULL, > + .session_get_size =3D qat_security_session_get_size, > .session_stats_get =3D NULL, > .session_destroy =3D qat_security_session_destroy, > .set_pkt_metadata =3D NULL, > diff --git a/drivers/crypto/qat/qat_sym_session.c > b/drivers/crypto/qat/qat_sym_session.c > index ef92f22c1a..41b5542343 100644 > --- a/drivers/crypto/qat/qat_sym_session.c > +++ b/drivers/crypto/qat/qat_sym_session.c > @@ -2297,4 +2297,10 @@ qat_security_session_destroy(void *dev > __rte_unused, void *sess_priv) > } > return 0; > } > + > +static unsigned int > +qat_security_session_get_size(void *device __rte_unused) > +{ > + return sizeof(struct qat_sym_session); > +} > #endif >=20 > > > - for sw pmds the queue pair's session private mempools are not set. > > > > > Can you check if below change works for Kasumi. I will replicate for ot= hers. > > > > diff --git a/drivers/crypto/kasumi/kasumi_pmd_private.h > > b/drivers/crypto/kasumi/kasumi_pmd_private.h > > index abedcd616d..fe0e78e516 100644 > > --- a/drivers/crypto/kasumi/kasumi_pmd_private.h > > +++ b/drivers/crypto/kasumi/kasumi_pmd_private.h > > @@ -38,8 +38,6 @@ struct kasumi_qp { > > /**< Ring for placing processed ops */ > > struct rte_mempool *sess_mp; > > /**< Session Mempool */ > > - struct rte_mempool *sess_mp_priv; > > - /**< Session Private Data Mempool */ > > struct rte_cryptodev_stats qp_stats; > > /**< Queue pair statistics */ > > uint8_t temp_digest[KASUMI_DIGEST_LENGTH]; > > diff --git a/drivers/crypto/kasumi/rte_kasumi_pmd.c > > b/drivers/crypto/kasumi/rte_kasumi_pmd.c > > index d6f927417a..1fc59c8b8a 100644 > > --- a/drivers/crypto/kasumi/rte_kasumi_pmd.c > > +++ b/drivers/crypto/kasumi/rte_kasumi_pmd.c > > @@ -139,27 +139,24 @@ kasumi_get_session(struct kasumi_qp *qp, struct > > rte_crypto_op *op) > > op->sym->session, > > cryptodev_driver_id); > > } else { > > - void *_sess =3D NULL; > > - void *_sess_private_data =3D NULL; > > + struct rte_cryptodev_sym_session *_sess =3D NULL; > > > > - if (rte_mempool_get(qp->sess_mp, (void **)&_sess)) > > + /* Create temporary session */ > > + _sess =3D rte_cryptodev_sym_session_create(qp->sess_mp)= ; > > + if (_sess =3D=3D NULL) > > return NULL; > > > > - if (rte_mempool_get(qp->sess_mp_priv, > > - (void **)&_sess_private_data)) > > - return NULL; > > - > > - sess =3D (struct kasumi_session *)_sess_private_data; > > - > > + _sess->sess_data[cryptodev_driver_id].data =3D > > + (void *)((uint8_t *)_sess + > > + rte_cryptodev_sym_get_header_session_si= ze() + > > + (cryptodev_driver_id * _sess->priv_sz))= ; > > + sess =3D _sess->sess_data[cryptodev_driver_id].data; > > if (unlikely(kasumi_set_session_parameters(qp->mgr, ses= s, > > op->sym->xform) !=3D 0)) { > > rte_mempool_put(qp->sess_mp, _sess); > > - rte_mempool_put(qp->sess_mp_priv, _sess_private= _data); > > sess =3D NULL; > > } > > op->sym->session =3D (struct rte_cryptodev_sym_session = *)_sess; > > - set_sym_session_private_data(op->sym->session, > > - cryptodev_driver_id, _sess_private_data= ); > > } > > > > if (unlikely(sess =3D=3D NULL)) > > @@ -327,7 +324,6 @@ process_ops(struct rte_crypto_op **ops, struct > > kasumi_session *session, > > memset(ops[i]->sym->session, 0, > > rte_cryptodev_sym_get_existing_header_session_s= ize( > > ops[i]->sym->session)); > > - rte_mempool_put(qp->sess_mp_priv, session); > > rte_mempool_put(qp->sess_mp, ops[i]->sym->sessi= on); > > ops[i]->sym->session =3D NULL; > > }