From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C63DA034F; Mon, 11 Oct 2021 18:08:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6012410E5; Mon, 11 Oct 2021 18:08:01 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 0E187410E2 for ; Mon, 11 Oct 2021 18:07:59 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10134"; a="225680618" X-IronPort-AV: E=Sophos;i="5.85,364,1624345200"; d="scan'208";a="225680618" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2021 09:03:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,364,1624345200"; d="scan'208";a="523888450" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 11 Oct 2021 09:03:39 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 11 Oct 2021 09:03:39 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 11 Oct 2021 09:03:38 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 11 Oct 2021 09:03:36 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.43) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 11 Oct 2021 09:03:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NPSHqRQHCtToD8sIUUmSnmNf5xt5lJUceN7PH+JOKG87/rSUQfDMsiJEi0rI0Dt8050u3tyMQVf+VVL1jx+SZpg/iV/X2c63V8Z15xl6Er2iflaRu5XSpxvs8f4V9CJOoP4smvg+KDrlKEowHgk6sZgcfRC+QOPv7WB99P+746OGLVQwhBNWFtd5pvx/byGZsGoFhJFNcaNLmQovvJEyTt5jEs8zBGH5NpNLiG+Nf/Fn+hdd965YAuQWTZb6I0poH2r8pi4VJdBbmFvY3W36oeXLwgpzQEiDll4tJqr8eR3+r41NXb6KhQxTjtFOs9OFyUOwIEmAjfqYbj8ViKcRFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qgHngf6MH2CABY5G8cASGhLMCmXp6N9UQb9c84UU7LQ=; b=RV2gfNQfw0suVwUJ/u/hRP4GMffh0LF9DhbyIhU22p6rgxtzdpxMAAN0qN/uuwkETk3Qd5n5OZIj011UyrHhOxWLtwx+DaAELWg5/PEyGyGDM0CGRWCxoNb3P/HVrJAQdLSWztSX8vxRMIKpzLdeiKsqmRD0/x+p1Kr60/eLqANJDvDv3GdkmA7OzXgFmD+mC6UCIYS3u9cavcCfL+tbnTQr8McKM+mJlUmZEkIImy8Ce60cWCKNTpXHZ4OYy4vWz2vVtF18rPwewYXhGoRYVTjae0pCgoKGpTqfx3Zz1Ngg91IcXuUl1TbHqA8L42b7qMWKARzG0MSBunmDka52Gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qgHngf6MH2CABY5G8cASGhLMCmXp6N9UQb9c84UU7LQ=; b=tnv+raOsn+62wbpD7jTpLVivies1Y8jDNFkT9kP48XdeQTuHB/R+f9vsCFXA7Ly6glicqMOd9cQrg5zLVICuqyTptLkofZ8e3sal8LSWX2zEitROZ6D69uQ4Z3V/SKlGTwrULxkhu7atxqzbcLDHp7dpW/d3w8KnUWj2BQTcOoI= Received: from MW5PR11MB5809.namprd11.prod.outlook.com (2603:10b6:303:197::6) by MWHPR11MB1725.namprd11.prod.outlook.com (2603:10b6:300:2a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Mon, 11 Oct 2021 16:03:27 +0000 Received: from MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::2c31:1470:3036:959b]) by MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::2c31:1470:3036:959b%6]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021 16:03:27 +0000 From: "Zhang, Roy Fan" To: Akhil Goyal , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , "anoobj@marvell.com" , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "g.singh@nxp.com" , "jianjay.zhou@huawei.com" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "Ananyev, Konstantin" , "Nicolau, Radu" , "ajit.khaparde@broadcom.com" , "rnagadheeraj@marvell.com" , "adwivedi@marvell.com" , "Power, Ciara" Thread-Topic: [PATCH v2 0/5] cryptodev: hide internal structures Thread-Index: AQHXvp2izGQK7LR18kWSzsvlQ41zrqvN9UtA Date: Mon, 11 Oct 2021 16:03:27 +0000 Message-ID: References: <20210829125139.2173235-1-gakhil@marvell.com> <20211011124309.4066491-1-gakhil@marvell.com> In-Reply-To: <20211011124309.4066491-1-gakhil@marvell.com> Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e1d47f9a-c7c8-4218-224d-08d98cd0a96e x-ms-traffictypediagnostic: MWHPR11MB1725: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2TbR8TOM13WwcA51olnLMkZbAmQved1wf37vjEjBbljm0kES/uj2TPWlyhCReYnJLSP/Td8lksOUJ1nGp0aw6twZWOsdcr5J2LFsaZmliDka5ndnq4WRAdi5ApJ/m+lUPG6rFBdalRIH83TIamCjNnZ1/WOEsbQkkZFmW3ATY9/6C6TPXQFLWAmSKuDy1/qe+/gLpjVb6XUIJukOhPiz8atFDVvl+wD3X5FRDF9TDwURmcXDUvlrNZO/UPBqvdHbjyllYNhzIkWxZ+2tP4+fVMhQMRTh31tducNpMFJmU+xBXW9ZZS1zJrTHv5cm5PcLt8H1EDAJP7bAKqDTRIzg2qvx8pJdmXQdCPLZ3o0sAmgsgtxghf45cfIerGo9EnR8rHH/l/KktzadDR7ss0SriwYNM+xHw8ry/AC4BFb7qpRdZRRMFbXhzcqXiazicCBreJodNTHwoxvwL+CIuYb8KluoE1pxBucOV799uSz/zSbZvgQ4QOJlYMDKA+TDvV2+FFh0huLqwHW2B2JhaMxJqcbwwIBJOveubjw7+Gzz/2gPJcEky2WSa1N/LFcIog8xj0kWsurFKGOvnwgNZfYFHI5oAPg6tjhNTZRn5IFtY3dBPXre1wBnvVuCK3+7jDySfta7zN9ccKeQ7X/JS/luyjkR9emLzSlQ4MADAt4O+fveVRopxWWZTmUFgxjICeCdQK4HaebhK/PQLSHB3IQ0mzFiNsE+4XWMBskTx6AwD0zxYr/IiCdnlj61mAba005guzUnYwLmKsJXHJUMHJZ/0b8fIoBjzM1B1GvElZ5ktpqF6HWbZQDqzlSvEeYXeW98iYPVvYmofmzRwPM0+FzHXg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW5PR11MB5809.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(52536014)(2906002)(53546011)(6506007)(7696005)(186003)(966005)(26005)(64756008)(83380400001)(38100700002)(66556008)(54906003)(66446008)(107886003)(9686003)(122000001)(8676002)(38070700005)(86362001)(316002)(66476007)(5660300002)(4326008)(508600001)(110136005)(33656002)(66946007)(76116006)(71200400001)(7416002)(55016002)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?vDYVFOQeoztaYH+iaJvBLirKFTJke/dGpV9PWJB+yOjYaYO4IVJ5yEAE?= =?Windows-1252?Q?VQpyc9pL61SZYBDK8t5wR3iIOo2KRoN1yn4YI+zfvG4bIthem/SHyRqv?= =?Windows-1252?Q?D6Ykg4y9i524BQa68rkUQT8CPOhy1gIBFK2zpQrdETCiSu7fMRcAnXC0?= =?Windows-1252?Q?u2AxPvQqoVt5zQ+oVZQkMZVimEvJbVrz7nJaZcXjU0SzcVlSm1ZehaH7?= =?Windows-1252?Q?U1Dxq8Vd7bQ1IeMYLSg7YGA7erHssxWCiii4Pxoh2fAyfVP2TKkbxFk+?= =?Windows-1252?Q?OGrylOaOr8nv2JJkL0LgMR+uhJcDZ9Iik27vOXduO4iUW/x4ZUvXDHlc?= =?Windows-1252?Q?4XgPnJ2hCk48ObtyOPlmWxJA51/OpFqEgUTfc0YvYHCr/XifDcVFGVXV?= =?Windows-1252?Q?hoUs9z7CjnHb1L/3yhn34FxNcRRBqUSIzOPMEKrJEqiPXFKtdwHsqIUc?= =?Windows-1252?Q?EzxXgCmbYsC0IwNBtbs5fw8PmuhmTMuWVHxjEfLUv5CIjmsMdI9EqKAR?= =?Windows-1252?Q?KBBACOZqBEtdRHzYAp+lcUbwhEQ+ewoMFWlEqq5AGpceOI8hNtl2dSL1?= =?Windows-1252?Q?40jn1hch4kMZwt8588g2FdHetBxQXsucXeJchVrMQc8JHLSmlq0DmQqi?= =?Windows-1252?Q?tTXfbjHtWI/A37RS4+FJ4ihLQbIMhLtufNQhoPSMvAeSDU85nfUOBdY/?= =?Windows-1252?Q?fxA7GRAfzyaqlX1dhrmFOQpgOaU1Bd+VDkFMajf4XYf6oRHZ+QkSKKsz?= =?Windows-1252?Q?B30O6Lr+V5hQebpX6lsc7o3tgbsabHn19dSJJHZpY/Dbmwg9tY9AKvm3?= =?Windows-1252?Q?XGMPrWW1XvXNPqUfGRMF4X58Wc/eOeCV6SbIf9oaDxzBCANXoL0cXKMM?= =?Windows-1252?Q?kWV/LcHIdSIyTr6uCTmhIgNBpTq5th0Pzo3GvZfEpwtp6R2qW9II7Ups?= =?Windows-1252?Q?rDk7CxIhUXzbJOMfK+K//bf5Zu0kYsPI+LBufiAmeQYPy2yu85HVVZys?= =?Windows-1252?Q?z4+IQBCeH/3+b+poUDxMtMpfeAm/yJzUMgtlNjLXkXXB+TOk5/dexysr?= =?Windows-1252?Q?xdoovciVaBXw9LxBuUMmdtOOHJJMWbOD1W/tdStHSSl8c37py6/zsHxm?= =?Windows-1252?Q?LWD+wB/bgR2+R8Q1Fmt6gcrcQyKl041/s+xa54H89PbO+nVtYPL1yLaI?= =?Windows-1252?Q?m4SpDXBmTRQc2UAQCOBjUJpH/9OJBTI2MR8ru2qSV6FtF+XqTLrod49B?= =?Windows-1252?Q?AhEpusfUzMxPvB3yCMrWUtFrbGeF+1RTcI3yW0zHfHj6UDbnJdSmYs8e?= =?Windows-1252?Q?YVBMhTJQWUtAv6491emiZlZ2qaAjMZygeUlwOa86oK9elYV0VH9IkP6z?= =?Windows-1252?Q?oc16XoOdPsiWEuyRTcq8P86L4EVFxF7JfBzP/pA5fzqkF9WE5swKwnq/?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5809.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1d47f9a-c7c8-4218-224d-08d98cd0a96e X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2021 16:03:27.2288 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: M+uXtqJWoemYYVieCmsYNapH7QoENFHC9EPAPFHGSuG8Z1Di30y6isrP6f9WDEn9CPOhc9ma5q2OBkdvItgOnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1725 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 0/5] cryptodev: hide internal structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, The approach looks great but we may have to check if it works in multi-proc= ess environment - since all enqueue/dequeue handlers are set by primary process the secondary process may not recognize the fp_ops data. We will run a quick test to see if it is true. Regards, Fan > -----Original Message----- > From: Akhil Goyal > Sent: Monday, October 11, 2021 1:43 PM > To: dev@dpdk.org > Cc: thomas@monjalon.net; david.marchand@redhat.com; > hemant.agrawal@nxp.com; anoobj@marvell.com; De Lara Guarch, Pablo > ; Trahe, Fiona ; > Doherty, Declan ; matan@nvidia.com; > g.singh@nxp.com; Zhang, Roy Fan ; > jianjay.zhou@huawei.com; asomalap@amd.com; ruifeng.wang@arm.com; > Ananyev, Konstantin ; Nicolau, Radu > ; ajit.khaparde@broadcom.com; > rnagadheeraj@marvell.com; adwivedi@marvell.com; Power, Ciara > ; Akhil Goyal > Subject: [PATCH v2 0/5] cryptodev: hide internal structures >=20 > Structures rte_cryptodev and rte_cryptodev_data are not > supposed to be directly used by the application. These > are made public as they are used by inline datapath > public APIs. > This patchset, creates a new rte_cryptodev_core.h file > which helps in defining a data structure to hold datapath > APIs in a flat array based on the device identifier which > is filled by the PMD. >=20 > Similar series for ethdev and eventdev are also floated on ML. > https://patchwork.dpdk.org/project/dpdk/list/?series=3D19428 > https://patchwork.dpdk.org/project/dpdk/list/?series=3D19405 >=20 > changes in v2: align with the latest versions of above series. >=20 > Akhil Goyal (5): > cryptodev: separate out internal structures > cryptodev: allocate max space for internal qp array > cryptodev: move inline APIs into separate structure > cryptodev: update fast path APIs to use new flat array > cryptodev: move device specific structures >=20 > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 1 - > drivers/crypto/ccp/ccp_dev.h | 2 +- > drivers/crypto/cnxk/cn10k_ipsec.c | 2 +- > drivers/crypto/cnxk/cn9k_ipsec.c | 2 +- > .../crypto/cnxk/cnxk_cryptodev_capabilities.c | 2 +- > drivers/crypto/cnxk/cnxk_cryptodev_sec.c | 2 +- > drivers/crypto/nitrox/nitrox_sym_reqmgr.c | 2 +- > drivers/crypto/octeontx/otx_cryptodev.c | 1 - > .../crypto/octeontx/otx_cryptodev_hw_access.c | 2 +- > .../crypto/octeontx/otx_cryptodev_hw_access.h | 2 +- > drivers/crypto/octeontx/otx_cryptodev_ops.h | 2 +- > .../crypto/octeontx2/otx2_cryptodev_mbox.c | 2 +- > drivers/crypto/scheduler/scheduler_failover.c | 2 +- > .../crypto/scheduler/scheduler_multicore.c | 2 +- > .../scheduler/scheduler_pkt_size_distr.c | 2 +- > .../crypto/scheduler/scheduler_roundrobin.c | 2 +- > drivers/event/cnxk/cnxk_eventdev.h | 2 +- > drivers/event/dpaa/dpaa_eventdev.c | 2 +- > drivers/event/dpaa2/dpaa2_eventdev.c | 2 +- > drivers/event/octeontx/ssovf_evdev.c | 2 +- > .../event/octeontx2/otx2_evdev_crypto_adptr.c | 2 +- > lib/cryptodev/cryptodev_pmd.c | 51 +++ > lib/cryptodev/cryptodev_pmd.h | 82 +++- > lib/cryptodev/meson.build | 4 +- > lib/cryptodev/rte_cryptodev.c | 50 ++- > lib/cryptodev/rte_cryptodev.h | 367 +++++++----------- > lib/cryptodev/rte_cryptodev_core.h | 62 +++ > lib/cryptodev/version.map | 7 +- > 28 files changed, 398 insertions(+), 265 deletions(-) > create mode 100644 lib/cryptodev/rte_cryptodev_core.h >=20 > -- > 2.25.1