From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0326A0032; Thu, 16 Dec 2021 16:04:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8DDA5410FA; Thu, 16 Dec 2021 16:04:26 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 81D1840DFD; Thu, 16 Dec 2021 16:04:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639667065; x=1671203065; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=yIUoGYKOTD0CAtEdpsIn2+Rs9LyuhRyvT56FlZCO/7k=; b=KRZHq1zgsXToXCD5Fy6Ras8YKcqnDq84SLjxQLQqchkQkInd0h9X50IX YN4Z5mxTfYo3TVnA5jWJ2SwgwVzhj1lxOp63VaEcruoSCm+CXgIspq44/ 6A5Ju55e2v0fxTLNvDtLO6GdIhRQpTq3bQ/DLoDpo+xyCK0CEe+Ho1gcP uqB9tkduzxUSh8G+Djj09dEOFlxFagAeuAsrUovsdovAQT9xUpfnMNtms 4sSe1u2Q8qMmA7wSD83XGu9MEhy4B6/gLK43B2tLdojqY1z181pgOSKeF Vh5dkSb9uG/udbbbIIitTqnzBM8uR01gBNmHq8tHpnqYL+0rfsL1pTUyR w==; X-IronPort-AV: E=McAfee;i="6200,9189,10199"; a="219526812" X-IronPort-AV: E=Sophos;i="5.88,211,1635231600"; d="scan'208";a="219526812" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2021 07:03:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,211,1635231600"; d="scan'208";a="519283624" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP; 16 Dec 2021 07:03:15 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 16 Dec 2021 07:03:15 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 16 Dec 2021 07:03:15 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 16 Dec 2021 07:03:15 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 16 Dec 2021 07:03:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HQrwbagBefDboKvd2ibAYaFnniRqR4q8P3tZlTZXQ0s8sGSkr2iXw6LsUWK6/ZHias3sfgaCAUBau6bpWBG1Eqpqiz0RcEKnxBLYUcy8GERb1piN6gs2WQ1nyy/nXFuVyPDIAUjlyC3D4xDlKg0GjAY/2MKoFrQGGThS5pT0Mxs2RCLsMhy0kDL75BDQVlU+38Ih1unTLrXd/0CD/yD0pruJRzxEY2AO+r91XW9Pg3FforOf+rXtt99kXrerKxFyJkgRd/B/PeaKtn1lgNXklThlT05xAo4pl78V2Pu+0KoIVJM8nyMUfjNm8uxo1zZYO4qgLvsYiVhyaZm9kY6cSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yIUoGYKOTD0CAtEdpsIn2+Rs9LyuhRyvT56FlZCO/7k=; b=WjMHSA9ID9wRyTuhk/ZVB8qn2Y7zZE418iqzN8PzL/cwlfvCm08hmqq73cB+Qk0wBu9gvBbYbsotF3kv8vDdLnZpWpWU6ROGymbHr3+cYvtj2MDsgMY0FOSXeDUU3H4c8V+DI3Ti1bKFhP14NYRb2MfbsF54JaPfAOU98IQ1t+6tQTwGaGoZLZatLN7oM852VYV5QQJMCYzSSSpI06W/C3JLUm+z0MdflZolhztdcjP5q6RDKIpsspoFit+81B8yCIB81h2XIe6PVeY/zQFOtOYRBdwesz2cvvWFX3ntvXUcKqEaomC9NKqFjd/bOnIHOJsvX1//Rpd8bamIAW9+DA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5809.namprd11.prod.outlook.com (2603:10b6:303:197::6) by MWHPR11MB1455.namprd11.prod.outlook.com (2603:10b6:301:9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Thu, 16 Dec 2021 15:03:13 +0000 Received: from MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::6044:ba49:2592:68c5]) by MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::6044:ba49:2592:68c5%2]) with mapi id 15.20.4778.017; Thu, 16 Dec 2021 15:03:13 +0000 From: "Zhang, Roy Fan" To: "Power, Ciara" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Mcnamara, John" , "De Lara Guarch, Pablo" Subject: RE: [PATCH 2/3] crypto/ipsec_mb: fix qp cleanup null pointer dereference Thread-Topic: [PATCH 2/3] crypto/ipsec_mb: fix qp cleanup null pointer dereference Thread-Index: AQHX7c+pwzpmXeg+C06NjpD45kZ4YKw1QGmg Date: Thu, 16 Dec 2021 15:03:13 +0000 Message-ID: References: <20211210140952.2907974-1-ciara.power@intel.com> <20211210140952.2907974-2-ciara.power@intel.com> In-Reply-To: <20211210140952.2907974-2-ciara.power@intel.com> Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5e35a8f9-834a-4a6e-2b38-08d9c0a52eb3 x-ms-traffictypediagnostic: MWHPR11MB1455:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VbsPvBbESi2CIRXQ/35twux26y/KAfaxJU0DGgsHNUOKRsyuQUgcg5W/5wGVIXv4aMIJ0l6VFlr3liy3G4UyjQoxLVIwnTzpAR76VShmjdGt2quf2VcIj6fbB/WGIaLlgkHvumR3KlrBDJhYEDXnp9ZHAqKumu72Yr0UlADkchRMACazEVBSIhAHXCc00cCHI1a/OQO5Ew7jwd2PqHwOFsGjQKyKF9yyvFcLon+key3R/y6KWe/j+ak7sLzLl+Tqdkf1Gs+DrCobv1sWyZ+g2Q1j7AC4fNkhpaDA2hbMtF0wg0D79vc3q1ip/YLPXxVzGe6A4lmJpj7B9bSGvJfArzjZK8RSYu7iri43lZLDkeq4wS0m8cBVlnW0zJGdp0+JiFfOggPP6Pq5FduErImPqyrnpN8UM3GOkLilFSkjwrF9c8YVkDEz4iR4a4zG5FhS/iJx/hgv2hXUBeh1nyatN2vvs5EsqCeYbkBQOeIz0JfbUQu2t/tAk0jB6FNt4IEwd7Dk9pz1QHhQ2C6soh3Fya3CXcDboEBJWROIlc+LztsgeiuyZtbrbV1Gl1qCLeUQ96D0I9B26KJc6C3E1zDix99iaQI472R2fzKl3CU2s3TqTLA0AJo1LszFCfDT29z3jMfI/c2UUvkrjDwrD2JZoI3pPUYwszF3FzM+PI61dGCF8Pz6nVuY+dFYtis9dpH8X6Du1UksThWYg4sZRncAWw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW5PR11MB5809.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2906002)(66946007)(38070700005)(6506007)(66476007)(186003)(107886003)(26005)(66556008)(8676002)(508600001)(7696005)(55016003)(4744005)(450100002)(83380400001)(53546011)(66446008)(5660300002)(71200400001)(33656002)(9686003)(8936002)(76116006)(52536014)(4326008)(122000001)(82960400001)(64756008)(316002)(86362001)(54906003)(110136005)(38100700002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?6zRiBWZdJXbKQ4N0X7bVqZvWb7YiiLcvz0D1lMEQ0Y9YKMOyJ+4A+6Q/?= =?Windows-1252?Q?wFhXVSP4/TJSSMH45XrigCfQfuSSHOneuOeIvUI6GEr4nhIYUb518fgq?= =?Windows-1252?Q?1DFihY0sutwCMJxPo4slqbpXVmhIjfoOeywAMuhMwietywEQBmiNnHgg?= =?Windows-1252?Q?NoFjvDZyQmdu4DkuwgWndfi5/9/YvzSmsgFMqyXSx3zS2opjjFDFnwjp?= =?Windows-1252?Q?tWAS/GfPA6izqBegeTXqPjvmuQ6Z/trH+wvkMuFst0ObkkPi4SwBX7iW?= =?Windows-1252?Q?Rh7hqgClyfwNibVXbBnaQLu8Dj9CVGjWrqFI9KQLUd3x1k348jxmBK3L?= =?Windows-1252?Q?ILLKMWor3glgHQpGLBgfxt6gb4G1/bs7YTeXJQm1Up7GVXopNLVF2GKB?= =?Windows-1252?Q?AZhVyb3I2hLxOK0ktNgdCtB6KLm3IBsJrpx1rKJAXDWZA28tihT0hcth?= =?Windows-1252?Q?TeTKT4qLvI5+5dgt27i1kl7gbK13w4assigJph7/TFLmfkzkjJ4Sl3CC?= =?Windows-1252?Q?89LWzdVQUIsdmVR+GsU1JKoVZUmn/k+vR/f3rTiLorr/9gtipOnVD3dY?= =?Windows-1252?Q?9TyXP+bK8ZpxabuzifBa+vFNlzjkaiOsb4iu/oWDDk++Q6x9GGdBVtE9?= =?Windows-1252?Q?cJWBymbO4biFTlzcSu85FNyfWOiKT0d5juSA2E4BGUN1uQgmTHjYR6gU?= =?Windows-1252?Q?rvX87+ItgpPBoejpYrTT4GRKL98dxXOOTZpP7qiB1qOvCoqFSeBfRMX0?= =?Windows-1252?Q?gHHnBZUZFJLKyeVIp9I53yeVn+4vCwiYFKAGNSPir72UNfRd5JtySRFd?= =?Windows-1252?Q?kM+3sdSIy8ssBp/hN11zOYwsYGRiHVNya9zor0HcDRAdAQRDWWEsRNPW?= =?Windows-1252?Q?stlsvr14koGnFc6LYSCzKQmNWdC2yrgKYGW+HNKoIDY/brBkHDHHybbH?= =?Windows-1252?Q?NPZQqadcWEJR5lOrpfKmKbw8t0IAe/G3Nr6wEx+ZJOUkHwfCXoIxAXNz?= =?Windows-1252?Q?ArATUfscGjmMAHOyMun/xMHNDtGl62K2jtcgJP2XYge7ku8yDgqRpQT9?= =?Windows-1252?Q?NWVb6qjaJFmTSb/NRpFw9d9v6mz9YwPtDzw5WtFvWh1qNoIgD01REG3M?= =?Windows-1252?Q?RKybrQk4BpDxE8kyoYeTqjz6YMk6BzvMgdYe4ik1Eef9vPozPfg36TyZ?= =?Windows-1252?Q?nkeyn0PLXpuPuIzk4/2vH5qCnF40wAu7aqhsyKSdpl+uPSgcngJyL6j4?= =?Windows-1252?Q?5u1hSktQ5pjkVZ0Kj4jDdNZb+7wIWmRpPuGFFUrowGh0nMX1pOAw4aqV?= =?Windows-1252?Q?zRPwSmEU27i+k7fF5QYGMy6ugpqXExWwbtX5VN5t9UQc6Wc1/LWupXxk?= =?Windows-1252?Q?0qmJrUjCufD/KiFq2HYDCUSI5qfExMwE3dmaOsNH7sTRypGwhxp12OHx?= =?Windows-1252?Q?X1D7GlfVJ702NkV0AdBQVvz1qQtMZ4OsSmm/6erJ53wB8JRvpwdnXZJ7?= =?Windows-1252?Q?Je/hhA2lrvCtNtTW9iR72jbPil7orvezfVo4fPkB7wTcfYYtlYjN2hc9?= =?Windows-1252?Q?F9DGhIotn68KUMPVml9J5X3jyxNEwcm85OuZpO4ttq/YUObQyAnDBetj?= =?Windows-1252?Q?ZsINNj/pHdb/StrXu7cwQ/CmAksOpU4PiIS7ZvYpfl7P3PHNiT0f8x7J?= =?Windows-1252?Q?YHotemGAtNJRe9Za4C5rPdy9dnrZBqsNF4V2QNzJYxKeGFdj/zfEU2Zt?= =?Windows-1252?Q?iAzMTUW4soanoZrFxNI=3D?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5809.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e35a8f9-834a-4a6e-2b38-08d9c0a52eb3 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2021 15:03:13.4485 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Om543a+Xg44peKEIIs9Rlu0tFFxGJXd5acklPqdh7oa9HZ2dtlSxQzoCQVg7NmZPTd/ddgUeEvFqR/1B49giVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1455 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Power, Ciara > Sent: Friday, December 10, 2021 2:10 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Mcnamara, John ; Zhang, > Roy Fan ; Power, Ciara ; > De Lara Guarch, Pablo > Subject: [PATCH 2/3] crypto/ipsec_mb: fix qp cleanup null pointer > dereference >=20 > The qp was being used in the cleanup without checking if it was non NULL. > A check is now added to verify qp is non NULL before use. >=20 > Coverity issue: 374375 > Fixes: c75542ae4200 ("crypto/ipsec_mb: introduce IPsec_mb framework") > Cc: roy.fan.zhang@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Ciara Power > --- Acked-by: Fan Zhang