From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE145A0C4B; Thu, 14 Oct 2021 19:37:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 75C1940041; Thu, 14 Oct 2021 19:37:58 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id C98954003C for ; Thu, 14 Oct 2021 19:37:55 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10137"; a="226513279" X-IronPort-AV: E=Sophos;i="5.85,373,1624345200"; d="scan'208";a="226513279" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2021 10:07:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,372,1624345200"; d="scan'208";a="592687382" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga004.jf.intel.com with ESMTP; 14 Oct 2021 10:07:28 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 14 Oct 2021 10:07:27 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 14 Oct 2021 10:07:27 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 14 Oct 2021 10:07:27 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 14 Oct 2021 10:07:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nwFLuteROR8Wb/P8WMD3elJVBVLTYUfPmhZU9UAa60+jkeKGF1hJrSrA9sCRCuJXdssqDCYP/gHUML5aJL9TzuVEp7LBmXSou7eSNNsQGBi+4q8sgmHi+77GGX0Iz5mpVsDf+Q5YGTrbJC9u7PM1zcJTfsqcBw2uHh7XKK70cCOysSLxchi1HWYI5OR7MJlhn76mzSmI2GFZtqqiePKrNVIvivq2sdCxcPM6ougbX4cV3lCHiKEortK6LTjGZaH9Rxsi6BNm1y5PI6lukWRu1Pu5iZ/OhD65nfwgL1wXXrF6nsA48m3qFDxtUb393MhZ2ig+pVUGpkkRHcmh1bWlnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=959iA5EEmfnPvSeHgavI8i/tkLhDn8XTwdSiz8H+IMs=; b=hMdywsgolsInsygpv9+LPD/5JxFm+8J9lgUwa/qE5ARJnWmACED4/wyJZryXkLByRdeme1Vnj+eG5lP3Z47tw/eyq5G27FRjVjKN7tIZZaEAjMGWRoARkLNlc0HkGPG/BGcnPmxBhDcNACvxTh2kXxT1OA+jEl9M1wuYa/rReuGLoQwk14ZsxrZAxXfRlUZYe8X+9Ledti1gzylaj4NIr7y31DBBJDt7+a8eVcloKBzKswPaJMpYJ1KVhFc1H/431H32YS0UXb7shGAJcuteklcpG5uxnifXwPuAvOma8u45nc1ZIfwDKRp4YnRKcBHy9o9SNZJBaO7yoZEd8t9Ljg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=959iA5EEmfnPvSeHgavI8i/tkLhDn8XTwdSiz8H+IMs=; b=B34JzS2EkyhodOhf47aQOrL+p0ZF2z9Z5pUC9jiUnpY3AjqWh/pj38zI5eNWf6yYHEwF5OeR0VItqZruvGhlrI0TsqnGH+hsRP+QLgCVFaNQadNwWby351t+YjYGIbaxkUXci2+cVSquwu9jCrSxjUb17BF9p48PSbZY9JR3CNQ= Received: from MW5PR11MB5809.namprd11.prod.outlook.com (2603:10b6:303:197::6) by MWHPR1101MB2157.namprd11.prod.outlook.com (2603:10b6:301:51::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Thu, 14 Oct 2021 17:07:25 +0000 Received: from MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::2c31:1470:3036:959b]) by MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::2c31:1470:3036:959b%8]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021 17:07:25 +0000 From: "Zhang, Roy Fan" To: Akhil Goyal , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , Anoob Joseph , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "g.singh@nxp.com" , "jianjay.zhou@huawei.com" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "Ananyev, Konstantin" , "Nicolau, Radu" , "ajit.khaparde@broadcom.com" , Nagadheeraj Rottela , Ankur Dwivedi , "Power, Ciara" , "Wang, Haiyue" , "jiawenwu@trustnetic.com" , "jianwang@trustnetic.com" Thread-Topic: [PATCH v2 0/7] crypto/security session framework rework Thread-Index: AQHXwGe76fTitYpJN0GlLW4tZSnTFKvSYb2AgABY9OA= Date: Thu, 14 Oct 2021 17:07:25 +0000 Message-ID: References: <20210930145014.2476799-1-gakhil@marvell.com> <20211013192222.1582631-1-gakhil@marvell.com> In-Reply-To: Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fa4d5234-d488-43a8-ced1-08d98f351870 x-ms-traffictypediagnostic: MWHPR1101MB2157: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Rs01EYAoOj3wGAjby+r5rq3KJdv3STcE5Fj2lkg6AUwAXfl8W9556NzKSSz+mOSR/iRRMfTaJQPUrZ7kRXoo5FgvXYuQ8zYy+zamNaOi7wPjCqAootC83VughxF7KUMZSfN6cfwB7RfVoeFenekTrH4wmoQcePEjarkWHNvG4nU3TxYZIX00aho17DOzfTOX+/1NBwACxTzOTka18jsCPyDNer1Fal5YvWpl8/qfen1sGgNzIHB1WuDO/Un45PxBYhR3t8tgv5xztvlHKHZ8G+zLKIrEGzRSuDg4OSD3B3twRUvudH7/rfKa1BTI6ZEVdWFP2uJ9WEnzyih74Xm9/K+gfHnE5fdNOPFwDHqEQe7S/RbDXv0USrMFPoffAT2xz2r8m9WgvUrXYZv2XI7Fqlp1Ad30P5b1mPYjy0w+GdWknKoZ6SAO7ZvlcKq09LGULedHsEt2juSe5JI2gluPQ7qvUlxjd7yqSArV3DouEJk4zx77W11yr1iBRxcDCUF+p/xzwmTifhT5XBcHw9epIP+8/KoN+pfY7Lop+QAOkOdx1mu+J0H51UqwiGJxF2i36nAzq367hrkCHE6KSN/4T33yzg4SCct9Iao9GwyQzaekJVYaWBRuVdSfU1gglCodkOrkLdoiQ/XOwQ5uP0dTAtX0m+KzdiViYahJtYMeyMOAUZjS5N3OxIYaeVNN4Tdi+paCgo4x0mXQXpsK+APp7av/fxpw/S1oCkkD7160Lc90zJf+6DDupRalbTWFpmVwpN47n4ODrrVH9VG6eoWEYMi3bIHDoBu6TlcuRyaJVM/jktvtfFtaVJbHt1TKVv8bz9DGuuM46hJPMhdqDxVbXg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW5PR11MB5809.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(64756008)(66446008)(66476007)(71200400001)(508600001)(966005)(186003)(8936002)(66946007)(9686003)(33656002)(52536014)(8676002)(66556008)(76116006)(38070700005)(15650500001)(7416002)(122000001)(7696005)(83380400001)(53546011)(38100700002)(6506007)(4326008)(5660300002)(316002)(54906003)(55016002)(26005)(2906002)(110136005)(86362001)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?U9uHBrq35N/R1Q+kO7sakCUrUTcBn7V+KhPoYq+JrNo6QvuQ3Qn6uGeY?= =?Windows-1252?Q?CDzq8s+Q8+OddWBbEuoKBBkJWm79O7r++k4zzWErDWYG6IT3Q6jmXkam?= =?Windows-1252?Q?ekVUbBK0JgoyU2558oK8jwcz1BfvChs83K69rUGn66YT1YchG99GzZZP?= =?Windows-1252?Q?rf5zE7yMBI0OhlQ3GFUrhQe1mqz3a1dF7J5s0kABVSNUDTSZC3SVUdoK?= =?Windows-1252?Q?Ai7T3rz3vmySjCzLwV+UjA+bDiUjeZHKYP+z/C484m2ZEUIlS/YikMAc?= =?Windows-1252?Q?otdUTVm3TQYUEROdVpSakxIRtHhBPxJOwlJXOA6Nh+K0BUUapNln02y2?= =?Windows-1252?Q?Rt7438BfgO1mdQf1+yMfWPbTspx0AWcD11Q4l9E2oBfP4b3i9UQY8Yhz?= =?Windows-1252?Q?+jn4Rdd+X0xbWqk6pvsEy7h7B3kjIRrCLkH2vGpVrJMn61/I2AqytpZ4?= =?Windows-1252?Q?GwC7HHIW0IF68V73ss0TvbkyPiXCnEC78/raD9CE0KfsTXEIsiaCjd6h?= =?Windows-1252?Q?UzwPeRQc7/vsTW5BJKWFlC/g1q4rITLqMDn45p0ACgltEaMuJgn9mzFg?= =?Windows-1252?Q?fWuCr5YDOXTYludWgXEzcDw+WySiHlMZsOec1pdXD+zJ3nX5+/og7d29?= =?Windows-1252?Q?oIP430znvzK3gxMrp+lDGWIRtGonTbVpP0NtjPMMTkrq7107YgbcajZH?= =?Windows-1252?Q?ql2TqsfZ4+Hi3KQCafZKaOEfGVQKeX/UtSLFwXM98NF/CF6UMR+qY+9K?= =?Windows-1252?Q?6cLn0dnpmjhiYAQZf2PPH/vZMESOC7vlvWVsoxsKJ/Hi3cieFnbrL7OV?= =?Windows-1252?Q?ewU9ULsxLZhtbNnD4Qw/ZlBdMfdowZ4Y0OD1I8xDU2fH+8sI2eCMqiNq?= =?Windows-1252?Q?MrZmZt+tkn83SRfu6NnjbMLTX+xX6t3k6vHQn5ynzmYbfZNn9xqXRoYf?= =?Windows-1252?Q?N6Y3auxqaJMAb9gjHjG4JymeeTklh0SEjYY27264tqomZXxDli/Sx0xW?= =?Windows-1252?Q?Al3al6tkFiqq6zxRh9wakiHGRZwkAdMRlgPWXHRocztjCskK6XXmProY?= =?Windows-1252?Q?qESgQd/CdVBaGiCKzB+ugWBVBF8L6O/xfd7KuiCQlS7gfA7cqGji5WGS?= =?Windows-1252?Q?kiNeef8uoNwTDZvNdyzhfY0TrsMf23ovvA7A7w79HJ054dCWf4adXrlE?= =?Windows-1252?Q?jsdcgn5hqG+8iXwtZRn7Jp2VwJA67frbRqkhgJeUeRIhZgoGbYNq8GA+?= =?Windows-1252?Q?gdGG5MFrHKH6HcWRgIBhvQRXiJqKveRfBEe0WMffh4ljU/xg3gQsaM5E?= =?Windows-1252?Q?U1ihPPQDx/V3kIuB6Vzwb4JYfzMk+3nlxmgRoxZKr/91nlxdoPpyUqgp?= =?Windows-1252?Q?Mmm86k1V/2s1FtUvfQn2ht9yl7UoL8mJJCl0NNkuVqQJhyp+jJ0pbbik?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5809.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa4d5234-d488-43a8-ced1-08d98f351870 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2021 17:07:25.3470 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lIPunEGlwvGJlhZJXovZIoaagC9d2JZ8jDOJhLu0jIYAfsK3hY1oUsQ2Q4pn9ZyJx0eBRFgo4SFvU53klJS6Pg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2157 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 0/7] crypto/security session framework rework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Unfortunately the patches still cause seg-fault at QAT and SW PMDs. - for qat it fails at rte_security_ops->session_size_get not implemented. - for sw pmds the queue pair's session private mempools are not set. Regards, Fan > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, October 14, 2021 12:48 PM > To: Akhil Goyal ; dev@dpdk.org > Cc: thomas@monjalon.net; david.marchand@redhat.com; > hemant.agrawal@nxp.com; Anoob Joseph ; De Lara > Guarch, Pablo ; Trahe, Fiona > ; Doherty, Declan ; > matan@nvidia.com; g.singh@nxp.com; Zhang, Roy Fan > ; jianjay.zhou@huawei.com; > asomalap@amd.com; ruifeng.wang@arm.com; Ananyev, Konstantin > ; Nicolau, Radu ; > ajit.khaparde@broadcom.com; Nagadheeraj Rottela > ; Ankur Dwivedi ; > Power, Ciara ; Wang, Haiyue > ; jiawenwu@trustnetic.com; > jianwang@trustnetic.com > Subject: RE: [PATCH v2 0/7] crypto/security session framework rework >=20 > > Subject: [PATCH v2 0/7] crypto/security session framework rework > > > > As discussed in last release deprecation notice, > > crypto and security session framework are reworked > > to reduce the need of two mempool objects and > > remove the requirement to expose the rte_security_session > > and rte_cryptodev_sym_session structures. > > Design methodology is explained in the patch description. > > > > Similar work will need to be done for asymmetric sessions > > as well. Asymmetric session need another rework and is > > postponed to next release. Since it is still in experimental > > stage, we can modify the APIs in next release as well. > > > > The patches are compilable with all affected PMDs > > and tested with dpdk-test and ipsec-secgw app on CN9k platform. > > > > Changes in v2: > > - Added new parameter iova in PMD session configure APIs for > > session priv pointer to be used in QAT/CNXK/etc PMDs. > > - Hide rte_cryptodev_sym_session and rte_security_session structs. > > - Added compilation workaround for net PMDs(ixgbe/txgbe) > > for inline ipsec. > > Patches with actual fix is beynd the scope of this patchset. > > - Added inline APIs to access the opaque data and fast metadata. > > - Remove commented code. > > TODO > > - Release notes/deprecation notice removal. > > - Documentation updates. > > - Asym APIs - postponed for next release. > > > > Akhil Goyal (7): > > security: rework session framework > > security: hide security session struct > > net/cnxk: rework security session framework > > security: pass session iova in PMD sess create > > cryptodev: rework session framework > > cryptodev: hide sym session structure > > cryptodev: pass session iova in configure session > > > The series is rebased over following to avoid merge conflicts > http://patches.dpdk.org/user/todo/dpdk/?series=3D19519 > http://patches.dpdk.org/user/todo/dpdk/?series=3D19467 > http://patches.dpdk.org/user/todo/dpdk/?series=3D19551 >=20 > (HEAD -> next-crypto) cryptodev: pass session iova in configure session > cryptodev: hide sym session structure > cryptodev: rework session framework > security: pass session iova in PMD sess create > net/cnxk: rework security session framework > security: hide security session struct > security: rework session framework > cryptodev: move device specific structures > cryptodev: update fast path APIs to use new flat array > cryptodev: move inline APIs into separate structure > cryptodev: allocate max space for internal qp array > cryptodev: separate out internal structures > security: add reserved bitfields > security: hide internal API > cryptodev: remove LIST_END enumerators > test/crypto-perf: support lookaside IPsec