From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9733FA00C2; Tue, 8 Mar 2022 12:09:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 65AC94068E; Tue, 8 Mar 2022 12:09:08 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 60A6C4068B for ; Tue, 8 Mar 2022 12:09:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646737746; x=1678273746; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=fNfg0U5GtWc8G83zzOIgFM4OyEAEaAkpeARPKVVre9o=; b=Ojz0kOcywHtJVSufsIm9GTX3j59SczHNylW+VLNIFY3qJL1FN/2EGtkp nbuYt6ZN+hM5sKPIPWGStPDfjWvV13eZebmHDxJas7nXTB2PS4VpniduJ zuL3N3Ca5O3PgLFKHcIZ4ODX3GohjJ1dHmawpr9H6cBruDFOZd+yquWF4 uFpK98HgX20HQoG9Y5IOuzh6kglzpJLyJW+V5/KSKSlO+xSGF1mnD5OHi 6QM6vtSUU1qk4iZMVArtEHa+Xo9xacMs9dkAvQUE2PDO759pgJyc93208 vMDBnyTgYfLvK6Hir1pw/DBFYeVp5IalkThkxA9Q7otYsNr9C1lrZWtXK w==; X-IronPort-AV: E=McAfee;i="6200,9189,10279"; a="317887588" X-IronPort-AV: E=Sophos;i="5.90,164,1643702400"; d="scan'208";a="317887588" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2022 03:09:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,164,1643702400"; d="scan'208";a="610972338" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga004.fm.intel.com with ESMTP; 08 Mar 2022 03:09:05 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 8 Mar 2022 03:09:04 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 8 Mar 2022 03:09:04 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Tue, 8 Mar 2022 03:09:04 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Tue, 8 Mar 2022 03:09:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R5YTJpY3Ve0uaxV7GArcW/emnrENx+5BfD6B7Vx9RS0DsMSisQdzwUfAE/2aUjIeBAwbToVcwZQC2o9tvT4oSdCb4jEcfoeIxuXEY+YvN1ADkeRsnGlr0Jg8XfV91hsHafEHH1+zKIkCZVDs8ghm85eB/kdksRJVLNm31UgVRZeOWPwkwEcrEVUU9wuB+S8+T/VKP1heoi2kjUoyGqjZaUQ1D+v5IScbwOoD27d8M0wF7wY7oK/k83pPB7hVYwzKYx3TeXgU+H9LLDb1zOGA9lXUbzJ0M1aMDimQLdhgrpjGzpeHympTdZ9mqpTEkH8BN2qgfHqvcEJfa79fGiCRIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lLLIT+lLipt7GhO9BARSfA6e9odilqd2zoedGaf75ks=; b=VETF2uv2p0uQdziDI1gIok5Y9Ww1/2VBsbAPBW3BXbijZBNUIg6Yc0jEsPM0CC/qRNa6fr1kwsPUUr3tzdwxen4WP8lzNZRJYOVoggIHrp+LCyAL4zB72wkq6ufgbdxpBTbYxNUfOzRhZkoj4MCECAyCBZMhUdNL4H6FvP37A4PQoYLzcF5DWniX5fqUks7JfFxCIh/PxvDRyR45pM31IMtHRwDqy4h5v0jE6KZ/UDRF6DgThrusn+mF4m/M3yi+5vkjuP2lDnmjmYtgoKXbzjh9jnBBEnlYczzo6/vGbNCK3d28fLbJNvyAiFmFd6C3vq2Ad7E0YeEpPHI3EvVbFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5809.namprd11.prod.outlook.com (2603:10b6:303:197::6) by DM5PR11MB1290.namprd11.prod.outlook.com (2603:10b6:3:c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.26; Tue, 8 Mar 2022 11:09:02 +0000 Received: from MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::6d1f:57eb:d623:5e0c]) by MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::6d1f:57eb:d623:5e0c%3]) with mapi id 15.20.5038.027; Tue, 8 Mar 2022 11:09:02 +0000 From: "Zhang, Roy Fan" To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: "gakhil@marvell.com" Subject: RE: [PATCH] crypto/qat: fix structurally dead code Thread-Topic: [PATCH] crypto/qat: fix structurally dead code Thread-Index: AQHYLL0bnxMY0yrG/EyzsoRWwyl4cay1YETA Date: Tue, 8 Mar 2022 11:09:02 +0000 Message-ID: References: <20220228160555.24926-1-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220228160555.24926-1-arkadiuszx.kusztal@intel.com> Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 542c36ea-ca25-48c0-3795-08da00f40d9b x-ms-traffictypediagnostic: DM5PR11MB1290:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZY93TD5Wqr6bjdgRVRsKnk4cdjiR5UoOw7QuB+3Et0qRV0j9/VBBXblCyJIqCxsqYJ0oSYlAQ0NdPCtz0VBOTufdo7HMjrty0q5caT67qXWmZkIjWNXvuhQqaBYpj+iH8nlktLLrvO9f1HXcOgRJyiMk/LrqdG7hWx9bKYPt7e70UOFQYVaIh3V2CK6YAZr4IncQsADPy9S8ouSk1EFiQMB83aaEHdn1uSz3B4YcoQ0JSv+/WbEQngMqaFIdAasiZkYrRI/BvQbYaZvHckljhIsycglMk2FDZSNJBnyvGnFL98UFXMViqF+Pl5fVlA3zNP1yabThV+vE/C0LK8Hb95/BE64Z1+dE2bA3vL0v7R1D0s+n6v1DuHsLboWFFksfIcHpantPyn3qFR6OzQl4cDLYfCD0MZYbjalAXYMA4P6Sam/IeTqWkjKVAELTPc5R5ZV0IXDh0kWHptsnYDEeALkBxTIyg9hDTtLFez3XO9jIu7+8G0pDINZKekw8XgncUDuXu7WSkSLxYJ86g1oZXV52upa9K037sqDmp2k8D7SaN+PbuEY7nBi/pFW+WdAwJgqEs/pOh27CGvy+oKmu0cmrRUbZ25hmLpYn2br4Z4nKSDeqP6ZiqFLcCnvVXSds0u/kAhOxdTIEmcW5+T1InvDzxKHjOk5OBaaOHDE8cP8TULS0xn+XUOwh0Dmq7yW508nA90bLIXY/XuWkCPQLRA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW5PR11MB5809.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(26005)(33656002)(5660300002)(82960400001)(2906002)(55016003)(9686003)(7696005)(6506007)(53546011)(38100700002)(8936002)(122000001)(83380400001)(186003)(66556008)(316002)(66446008)(64756008)(110136005)(38070700005)(71200400001)(508600001)(86362001)(66476007)(4326008)(76116006)(52536014)(66946007)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?UOOwNgi4Vj/ZSUtOVpfuv2D0OWlRYK9GPgKX+hwB7aOkLVCrAZmyg+vZ?= =?Windows-1252?Q?FtdkDH+VRGRgMbO071WSSdQ25APiSuN+UJf1Ihmt3VW8jVYCaYrDS91h?= =?Windows-1252?Q?xsaEkAtlz3L8+OCyA4n5ockXwwJFCDQm3HAZviYLcMrapscrLEJdUYkL?= =?Windows-1252?Q?ccn7uOBkda3afmgodTmNXhyEqwsxbLNkycKLTdPU66vPOsLrPOMWGrYF?= =?Windows-1252?Q?2yYFXGk08zeqr2AwXSHc37PBMkccyyh8JV8en+VUFNXK0NpKVnWfSnSn?= =?Windows-1252?Q?txDNMQ4UJlihq052ohDdB6fUftV1KwniOyXTD/KIfmCO9TFjgZsCuZwF?= =?Windows-1252?Q?0QX+Jd1H7PChd/wPpIyjlnMLvZZnAOdfzuJ0WChx+VrZVURh1UgI00on?= =?Windows-1252?Q?QAd6CPzgndVI3dcbcdS0+jb/ve2NU5N5mZaw5P5myCF77M6/9ExmUw+/?= =?Windows-1252?Q?aHgZeuT26yLRIQHHCB9DvuQhvhQj1JWIqGHnSEy9MoNKFWGMYDVjtev9?= =?Windows-1252?Q?zk8HyD51dMb5tUPQQkLu49TwhIoj2diLZy7x/CGd67pBm2oaXD00EXVP?= =?Windows-1252?Q?LaTjsivSEmlO7PFSp4+r9LEvRkChwqVNjFg2JCICuGBRogRu6uf6lFl3?= =?Windows-1252?Q?KCeY4GT6LSeJ7wEkKKIRP52I3aubZtpzv5IxtlbYXQTy7FlLBn1jjcX5?= =?Windows-1252?Q?rfnv3ljuPYo0mBD8JLyG+TndCYSnrkaeyBJ0ruRtd3mjdLYb2jyoEHE0?= =?Windows-1252?Q?AX3YGsWEErRS6wIJUVSU/8HHrC6c04AALZlJrYWZ+MfJap/tVrGs5Ryc?= =?Windows-1252?Q?3ezFuFNXhTzvS9dvtMiAvb0uHRsoEpzqjR9ooXCKH4Qia8oqr8H1GqfK?= =?Windows-1252?Q?QIvnKcerwj3Oq8XLFb93r2edFeMsMbPiwb2plL7gZyKy78UlNszJtPii?= =?Windows-1252?Q?Qixi68/42Kcq/Ag1RCwq6BMfLkKYM8BaNjHCtf9AnIlRCnmtlxemRBa8?= =?Windows-1252?Q?3pqK3UPyRy958wk9OLmZxN8fyye+lIFG4Xe2Bof0tmmNUMqMhELx4PpT?= =?Windows-1252?Q?lbNE0XNtlEJlWebUfA3IdOe3vdJjOwvIVuu8hqzPgXfoeCHI8DKElLJ7?= =?Windows-1252?Q?8qUDhFp7YhcvprP/hLDSTFF4x9py5xeFUR/bhd838Xi91swXXoCgaX/K?= =?Windows-1252?Q?jQg7Gd9knJV18iqiD+Zohtv+pwE2xg8honzDlaQH730reukg7h6ntuTp?= =?Windows-1252?Q?2pcEontCbGGr8TiEFrxpeUeGo1i7JoRv294s1YXW42ee0+adKK6YwXEd?= =?Windows-1252?Q?2HyAGyOmRPEJpe5UYSdIUeWh/tQcaWO8HPR9xeMr6H5ZALyZDYLXnhXL?= =?Windows-1252?Q?4UMzLkGYBD6Nbdfh5E0FY1M5+LRU9414ss94HozuVGchZ8yYD4mnuiBn?= =?Windows-1252?Q?mc1hul0QotwsSPK+0xSgZ9ZmeEzLIR/3w+3cBqM1fbwMDJJENCIVi5N0?= =?Windows-1252?Q?5WC1XWleh1JFknif7XTWygn0X54AIFLzfM6KlLVa9uHOQJj8ITwZ7NY0?= =?Windows-1252?Q?v5+OP0JWpDh0GaQIqLaI5McYvmxEW6+LQcS1jq+SqvPbJW+VgBpi1O/N?= =?Windows-1252?Q?zEscRFzlcULXrIToo2nvkCpHunpjYxUJsueKbm83ldSxDlI07i3UmXYV?= =?Windows-1252?Q?o4VHx6rhOphYlQkLeUXFCv1N+lzkHmES89zxstXFlIATmfC/D6OLmw?= =?Windows-1252?Q?=3D=3D?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5809.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 542c36ea-ca25-48c0-3795-08da00f40d9b X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2022 11:09:02.6017 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8GR9KSvXEJt0Z/ZDa/eYo/0grGU7aY9taa3rcvoIXEmhHoJxSu2SQ6ibqPknVQivJkvGBciZBzl3mpFfJMIG2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1290 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Monday, February 28, 2022 4:06 PM > To: dev@dpdk.org > Cc: gakhil@marvell.com; Zhang, Roy Fan ; Kusztal= , > ArkadiuszX > Subject: [PATCH] crypto/qat: fix structurally dead code >=20 > This patch fixes structurally dead code in QAT > asym pmd. >=20 > Coverity issue: 376563 > Fixes: ef2f4238a04d ("crypto/qat: refactor asymmetric session") >=20 > Signed-off-by: Arek Kusztal > --- > drivers/crypto/qat/qat_asym.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/crypto/qat/qat_asym.c b/drivers/crypto/qat/qat_asym.= c > index badf018f13..1e4304a3c0 100644 > --- a/drivers/crypto/qat/qat_asym.c > +++ b/drivers/crypto/qat/qat_asym.c > @@ -1183,7 +1183,6 @@ session_clear_modinv(struct > rte_crypto_modinv_xform *modinv) > static void > session_clear_rsa(struct rte_crypto_rsa_xform *rsa) > { > - return; > memset(rsa->n.data, 0, rsa->n.length); > rte_free(rsa->n.data); > memset(rsa->e.data, 0, rsa->e.length); > -- > 2.13.6 Acked-by: Fan Zhang