From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86655A0C4B; Fri, 15 Oct 2021 10:12:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 14F7040692; Fri, 15 Oct 2021 10:12:23 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 4E0F340041 for ; Fri, 15 Oct 2021 10:12:21 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10137"; a="226647389" X-IronPort-AV: E=Sophos;i="5.85,375,1624345200"; d="scan'208";a="226647389" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2021 01:12:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,375,1624345200"; d="scan'208";a="492370542" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga008.jf.intel.com with ESMTP; 15 Oct 2021 01:12:20 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 15 Oct 2021 01:12:19 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 15 Oct 2021 01:12:19 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 15 Oct 2021 01:12:19 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.43) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 15 Oct 2021 01:12:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AMojTsvUc+QzfD/8QnKos6alvh8NA7xxqg2r3dJ0tqIv/scAw7LAVLBX4JWMlov9sJ6ZhrDjvWMJcAn782M+pSGGOuUYt3tuzdXWyis8CTm0CtL+SvYn1qxPRDDP22UQi+vNXPDibVwyVU2aQTLsUMzU94ZD6OPLqsc18NEpdp3jdfMq3tFAyT+0NlIZBjL6vlzbINERvgSRHcIumVmNCN+anUMuBqKxkObJbbvBEMDrLHqx8maTB9FbCK0Xi4viHVliIylqwo4f/daypB5bM5/mTLHXvq+Z5i4557rscgi0F6n6Cmq3RmRIm9LIxJPF3h9TcWlnm2vB7GmwtMU99Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YLELQgzdu/1/vmL5duRaI/FgyCzD+sVuMqyOcLCHn4Y=; b=FRaQvRSpKV7xa/SJ2JoL86q1rF3U3rmvBJ35K+bdl2fs5Ow1BLZA+M4xepLzgRIw0g3vfdUz8+4rbl4vthN2QPXMvxvTWqX91EGa4vUoqudqrNTiGIoNuCMZ7FRitYaSurssj+u0n8t/7VXuNMmxLDxp/Fwoku7MBIZkILl567nT7j7/5Obn/tcz0adYqlEsxePDKIQGefW0Ho5cUXmiHVxOMJnhSzdYBZYBt3bO0utO+gDP0lKkYjP+KhJHVvHH033ljp5TwzA7wrNb8F1xJOG8BQS3p4X9Hm1zOzNLi1T3093HfIOe5ABMY3CTMtrL73RDbYOxhOjappT8xgigaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YLELQgzdu/1/vmL5duRaI/FgyCzD+sVuMqyOcLCHn4Y=; b=N+0hc5+C8QWQ4N4rSCVRhXE7QAAOdwX1979uuU5RgddOAIeNsWsrQhIjgfHY4uh3CszwoIi71a5KkK70oFtrg0v1Yc/ECWq7rXMI/NFIU4wA8g8xx+YgPO6YuYSPiWUJrAdV5i6Gs/1tXbNwEb7XjYwNceFlRp3TY59vFsVx8Ko= Received: from MW5PR11MB5809.namprd11.prod.outlook.com (2603:10b6:303:197::6) by MWHPR11MB1693.namprd11.prod.outlook.com (2603:10b6:300:2b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Fri, 15 Oct 2021 08:12:15 +0000 Received: from MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::2c31:1470:3036:959b]) by MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::2c31:1470:3036:959b%8]) with mapi id 15.20.4608.016; Fri, 15 Oct 2021 08:12:15 +0000 From: "Zhang, Roy Fan" To: Akhil Goyal , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , Anoob Joseph , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "g.singh@nxp.com" , "jianjay.zhou@huawei.com" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "Ananyev, Konstantin" , "Nicolau, Radu" , "ajit.khaparde@broadcom.com" , Nagadheeraj Rottela , Ankur Dwivedi , "Power, Ciara" , "Wang, Haiyue" , "jiawenwu@trustnetic.com" , "jianwang@trustnetic.com" Thread-Topic: [PATCH v2 0/7] crypto/security session framework rework Thread-Index: AQHXwGe76fTitYpJN0GlLW4tZSnTFKvSYb2AgABY9OCAABXEAIAA50FQ Date: Fri, 15 Oct 2021 08:12:15 +0000 Message-ID: References: <20210930145014.2476799-1-gakhil@marvell.com> <20211013192222.1582631-1-gakhil@marvell.com> In-Reply-To: Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: abac8e68-7161-4e16-accd-08d98fb37f8f x-ms-traffictypediagnostic: MWHPR11MB1693: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HWhvtV+DLROUMc2mY5zR/DjnXS7CabXSG3Q6IOgnArzC59TSwdw+mVn7kmTvaZyLGhXPWbrplfkW30NUDuQIBS/ZExAF6O/+Ca66JL31NGYepKxsmOcMIS36lQ1yxk9DyyWA/G/4ZsC6ld1TTeJodDcQSZCGm+RUWn16EviZysrpSzX4vl99pcEkXqA62cqW3Xk9531v3nnnHYRYCel9TkZDDWNXDI3mjlnPYc4BoyymL+gzv9pXHYJr1ta2Fjime7j8oPM0Vr5lVbxhYLh59S/W5VxTozuT1QxTqcjCEOq145YAIoNVsFYkTlR5NjToSrBw2L9o+MY9OnhDyi+YCFWoPAEJlqLJbg49M/m3TjeemSJcV2XgfWFZ4t/XEO8gUGgl4eSGF/QcXPecWQhcU71HJ7K/tcvQTrV/q4Iwdi5tQCVn56R5PIyJalxEtyL+l2TxR5VhMt0ZdIQH4ecnt4StI9vV0Hu5DuyUktzAGmJkiHFW76Yffdv9ZFN6Qi8s1tpk1kXn4YDKvMETV0Jz+tmTqFQYVX0XqoGM9KgPoriOy0comMSnK6gzSjnZ6iosjJtsBmYJMUMsvSj/6A9nVwTKVCsCbM9NnPHueQQxT1tMHNLopApa9CPLizzONAVBbRhi9P67dbE2rP6RM3yRWXMaqmVugIHoLhRQuiIPI27e2jRt8A1q0wGcq7Bug079RaQ/joz3DryUclO/6/74cw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW5PR11MB5809.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6506007)(54906003)(66476007)(66556008)(53546011)(66946007)(64756008)(71200400001)(66446008)(186003)(38100700002)(122000001)(76116006)(33656002)(38070700005)(55016002)(110136005)(5660300002)(9686003)(316002)(4326008)(52536014)(8676002)(86362001)(2906002)(8936002)(7696005)(7416002)(83380400001)(508600001)(15650500001)(26005)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?2Gjsf9CDK0y2gHUm+iDzUxPUqr3pbDJG23Lw2nfIATTL3zv5PXbap0TU?= =?Windows-1252?Q?VQTdH+MlMx44eJ7DSTYGgqbirrBPgqCF+zf70aAZK8IvDxuly5Z5POWK?= =?Windows-1252?Q?oZmvB+jSB+Easypiwp5N0PyGRakxRPmh68AVggLhJJmDmg3ZIaq7q0kv?= =?Windows-1252?Q?hU0BTnyQBW0ETJ+KjjsFIxMUle3ARUkHRLSKlGvwh7cG+0GIV3l/RPUF?= =?Windows-1252?Q?kM6hrxScr3WDv88mYvjZKHOKZByrA6m0FEr4Eak0f8w7b4l+PvIi0YSv?= =?Windows-1252?Q?tOR01NKh81u9YGqU4xjHlQSrRNX+uEMuPVOljZDh2P51I+vG7Pmsed92?= =?Windows-1252?Q?UnOVcT6ROdWgrIib/fS/Vrk4Jq/vV4DqtKGveix+bTtLGVkuch+ScmHS?= =?Windows-1252?Q?ohEwf0FZcrYMqsGjmdHbD9qpmv68xQ/FGTvWffAijgoX6F8M7sO2ho/V?= =?Windows-1252?Q?0QPHb+/fjiXxqYXz49MXD4bj357JsQ+kuf0b1ebX/iiiH+oF4A8zlIDK?= =?Windows-1252?Q?8B6E7eMuYvSs6elhBnPHjJ05nhvllSNXk8t0lpIyyen/Z1qCpuLXohqJ?= =?Windows-1252?Q?cuO1xxU/EPAEMzl4BwB3SQeYctXllqxgdNEC/RG62WrzT5DfPtXypdT/?= =?Windows-1252?Q?jGb+YhJbGjFcpPAOCiv76e+qdW1YjOWxBtiSThB56aPxEt1bZp8J/vn9?= =?Windows-1252?Q?ZuUqRv8g6/VZxHDvqW4WzuxCNh51lMtVJnCMDZ1zH3qlQXdypCsg1hrQ?= =?Windows-1252?Q?+ovkQdbaiBkCDQqoMnu1gPPKcCLIOA/u9oFZ6fl6CAyS+iW281mzxCAC?= =?Windows-1252?Q?lj/UwYXVN1Ke8TvCLtu16sLYzXExutSHAN+PWcDiOCnUClIHKu1xFOc9?= =?Windows-1252?Q?5/df40kbTX5JAcJk9sL5cUdIV1xUYQcCNDwedtp35SLakzM8VtpxbfXd?= =?Windows-1252?Q?XDbOT6/2duXPaqoXshKml8R7e+CGWI9b9p6YojYdicoecuqLulrm+oy2?= =?Windows-1252?Q?gExG5g72fih4c2xUAxAoHEURMA8eNNLT/kS3FmqcqO/D4ZVZvi6I9+HP?= =?Windows-1252?Q?CFfSl4PP941bDHifM90V1SFUzDNOWfWZ9Rk67z5l+WUtvNPzYNMaFYE8?= =?Windows-1252?Q?pBU8Sv5qjUuQw4MHDpHPP3+jExNISHFkCe8/2txyPAE8knYFoeU0duAQ?= =?Windows-1252?Q?PqhZEsly1LiRrNyp/qINDtIVq3JmU/nnm1py3Uvbo1I3aqpW3zBJfWbb?= =?Windows-1252?Q?5Y3iNar+wDBQqJz/fj7uyb/tIm1ijtrKVRC9FAyvt1dCaoX01f/3PVGP?= =?Windows-1252?Q?wCRdHTy4bUkBTecAy3iSxj1AYAylZVyjZxTy4YA1Ro7bfwCQNt4E/ErF?= =?Windows-1252?Q?qIOCqvJ524J93xF9m/o9rLEOdl9XTpYZBMbPnbAsig/FZlobAencKXIx?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5809.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: abac8e68-7161-4e16-accd-08d98fb37f8f X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2021 08:12:15.0381 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aXFCIhSX7vLQPQJSQFlMoW8VwC2UuKvmtKYMBhWMUtY/aYjjqvLHz+VKxz6fu3ffISVXrxGxY/RBx8lcYmmkyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1693 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 0/7] crypto/security session framework rework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, It shall work but Kasumi tests are passing :-) It is snow3g and aesni-mb/gcm that are failing. Thanks Regards, Fan > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, October 14, 2021 7:24 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Cc: thomas@monjalon.net; david.marchand@redhat.com; > hemant.agrawal@nxp.com; Anoob Joseph ; De Lara > Guarch, Pablo ; Trahe, Fiona > ; Doherty, Declan ; > matan@nvidia.com; g.singh@nxp.com; jianjay.zhou@huawei.com; > asomalap@amd.com; ruifeng.wang@arm.com; Ananyev, Konstantin > ; Nicolau, Radu ; > ajit.khaparde@broadcom.com; Nagadheeraj Rottela > ; Ankur Dwivedi ; > Power, Ciara ; Wang, Haiyue > ; jiawenwu@trustnetic.com; > jianwang@trustnetic.com > Subject: RE: [PATCH v2 0/7] crypto/security session framework rework >=20 > Hi Fan, > > > > Unfortunately the patches still cause seg-fault at QAT and SW PMDs. > > > > - for qat it fails at rte_security_ops->session_size_get not implemente= d. > > - for sw pmds the queue pair's session private mempools are not set. > > > Can you check if below change works for Kasumi. I will replicate for othe= rs. >=20 > diff --git a/drivers/crypto/kasumi/kasumi_pmd_private.h > b/drivers/crypto/kasumi/kasumi_pmd_private.h > index abedcd616d..fe0e78e516 100644 > --- a/drivers/crypto/kasumi/kasumi_pmd_private.h > +++ b/drivers/crypto/kasumi/kasumi_pmd_private.h > @@ -38,8 +38,6 @@ struct kasumi_qp { > /**< Ring for placing processed ops */ > struct rte_mempool *sess_mp; > /**< Session Mempool */ > - struct rte_mempool *sess_mp_priv; > - /**< Session Private Data Mempool */ > struct rte_cryptodev_stats qp_stats; > /**< Queue pair statistics */ > uint8_t temp_digest[KASUMI_DIGEST_LENGTH]; > diff --git a/drivers/crypto/kasumi/rte_kasumi_pmd.c > b/drivers/crypto/kasumi/rte_kasumi_pmd.c > index d6f927417a..1fc59c8b8a 100644 > --- a/drivers/crypto/kasumi/rte_kasumi_pmd.c > +++ b/drivers/crypto/kasumi/rte_kasumi_pmd.c > @@ -139,27 +139,24 @@ kasumi_get_session(struct kasumi_qp *qp, struct > rte_crypto_op *op) > op->sym->session, > cryptodev_driver_id); > } else { > - void *_sess =3D NULL; > - void *_sess_private_data =3D NULL; > + struct rte_cryptodev_sym_session *_sess =3D NULL; >=20 > - if (rte_mempool_get(qp->sess_mp, (void **)&_sess)) > + /* Create temporary session */ > + _sess =3D rte_cryptodev_sym_session_create(qp->sess_mp); > + if (_sess =3D=3D NULL) > return NULL; >=20 > - if (rte_mempool_get(qp->sess_mp_priv, > - (void **)&_sess_private_data)) > - return NULL; > - > - sess =3D (struct kasumi_session *)_sess_private_data; > - > + _sess->sess_data[cryptodev_driver_id].data =3D > + (void *)((uint8_t *)_sess + > + rte_cryptodev_sym_get_header_session_size= () + > + (cryptodev_driver_id * _sess->priv_sz)); > + sess =3D _sess->sess_data[cryptodev_driver_id].data; > if (unlikely(kasumi_set_session_parameters(qp->mgr, sess, > op->sym->xform) !=3D 0)) { > rte_mempool_put(qp->sess_mp, _sess); > - rte_mempool_put(qp->sess_mp_priv, _sess_private_d= ata); > sess =3D NULL; > } > op->sym->session =3D (struct rte_cryptodev_sym_session *)= _sess; > - set_sym_session_private_data(op->sym->session, > - cryptodev_driver_id, _sess_private_data); > } >=20 > if (unlikely(sess =3D=3D NULL)) > @@ -327,7 +324,6 @@ process_ops(struct rte_crypto_op **ops, struct > kasumi_session *session, > memset(ops[i]->sym->session, 0, > rte_cryptodev_sym_get_existing_header_session_siz= e( > ops[i]->sym->session)); > - rte_mempool_put(qp->sess_mp_priv, session); > rte_mempool_put(qp->sess_mp, ops[i]->sym->session= ); > ops[i]->sym->session =3D NULL; > }