From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 507E7A00C5; Tue, 19 Jul 2022 11:49:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3AE3A40A8A; Tue, 19 Jul 2022 11:49:14 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 5158C40698 for ; Tue, 19 Jul 2022 11:49:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658224152; x=1689760152; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=BIoZaiG2GH56VlHOTNzRDIkhipukf5Wq3V+YBOeDjvI=; b=dKxkXsWJflAhisaoHqB6yz/4jV17+/PzM9y6Wu0v/KW4vOrZ/srIKxl0 prFgqjMWk2yQ7jlWggAN9Pa3hBB0jyyRTJcRzsKb6lQ4h7kzcefO21MJ7 vW8L78ytCe/IBwiBaAzjZA46EId3AyeouXuKexFK2Ml2paj2izUByctC8 swzEnc8kfcQr4iKoUCxkYvnlfX0RNhjZAgRyJ5rJ8WNScIyETFK42yWJc SQ3KALv6c3KUuw3Dz4LrKI9PL/FQx0mA24V1AZBf3WINCxvvCt6nC2MeO HoHFrdWVUoTg+K5diFetzoSZcWHToNlF3AvZ6mQ+0SIl+pKhCgBulB5hW Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10412"; a="286463330" X-IronPort-AV: E=Sophos;i="5.92,283,1650956400"; d="scan'208";a="286463330" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 02:49:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,283,1650956400"; d="scan'208";a="601533691" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga007.fm.intel.com with ESMTP; 19 Jul 2022 02:49:11 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 19 Jul 2022 02:49:10 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Tue, 19 Jul 2022 02:49:10 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 19 Jul 2022 02:49:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lUH3m2yeo66ACM7JkVw7QEwxCGa7ucufVyAwXl1RJSfHkrJimczyIcoDGd0JSqSsoHKMVFqNTos07qyqL1MyQYLo5zJpMYlqQpNimLja1gOAxltR5OKrX2Qi4d+zsjCEr1uqpvLXCh9b+sMJQyvLQxUsGWFkFX4iqc4Na6yMLAfUn12p6VTq8dWgwSMOtozDr7hAZLjtms5/N4sZykHvrguloE/SMiU8gC+YPGqaNhS7BNnXYqiVPeGpl8AwtpEhIbcEsMbzT4qu4t6NevUB5EHATkUTc9qslKaSSf8ci9RWBLslF6nBC1KoJz655Us0kKh47r/pzALVia78KqvrBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J8c/ZBvGpu1QdyuhQkEMQf1oE7mzF6JgO1Pd8jolXB4=; b=DfMjQhzU1udIXDCuMLmZVHpHKyUBS+Zl6lVeoS23KXr57ntjyvMOEGyhy7JThanEjJaGfqDXQZkgfId94+MMsQJcTM28oKS5UDi2wn5WpoWVvSDZjno86km03uRhOIekJ5Y3qOOgFOuSLSXbfVHwCHsj6A16njTD1o9g5fZtgdjkDX5QyMoffftKWGVsA69Kncf2g1vO5tsy7wSF+HsgCvMDNQ7tlD6cAfnt1QcYmst6gbdrIXPUjGDjmYC2YNqTdgUYlUbgxOGBACpc0aPA/gk6L4BiSD41tocxfQOyTDONDLoCKtLHts8eKGMofE6+sYBffOADbgHtHwWjw6kWUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5809.namprd11.prod.outlook.com (2603:10b6:303:197::6) by BY5PR11MB4087.namprd11.prod.outlook.com (2603:10b6:a03:18f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.21; Tue, 19 Jul 2022 09:49:08 +0000 Received: from MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::f05d:d057:f254:52dc]) by MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::f05d:d057:f254:52dc%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 09:49:08 +0000 From: "Zhang, Roy Fan" To: "Ji, Kai" , "dev@dpdk.org" CC: "gakhil@marvell.com" , "Ji, Kai" Subject: RE: [dpdk-dev v1] crypto/openssl: fix of dstlen passed in HMAC Thread-Topic: [dpdk-dev v1] crypto/openssl: fix of dstlen passed in HMAC Thread-Index: AQHYlUjbWFcRrSc7XESkPg+1akMZQa2Ffvmg Date: Tue, 19 Jul 2022 09:49:08 +0000 Message-ID: References: <20220711170810.60624-1-kai.ji@intel.com> In-Reply-To: <20220711170810.60624-1-kai.ji@intel.com> Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 536b88d9-76b6-40b8-3a2a-08da696becee x-ms-traffictypediagnostic: BY5PR11MB4087:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2r1xB5Xcwokimi32xlfgCSdpiB9H/Ps39FYKDPmNiUKILWXoW2/DtRCR2qyO4mE4fxSu75hEDiASFTvVyfc++3m15jEsj6FEYfJ5Av82uFYK9hLWsfkG15xxXWWviSomk+2hpGMCUkN0uULEfHp5XGWn5FFnHjPJQznBl0RrFBJKFWNg3TAWVqjrOMwKIOxn34oyFyZpdrdAUA1SLDuHjwMJgHQ6k1fG3BjJpdAGN69zGVV1DeMpogNN9/7/gXdEnMWHOOoM0mFFWeceEy5+STntxDNxXBzlbC0EslnxOtVlNC7/x8r849R/WQr94U/4YWgoWBfIUn7sy8jz28yQE8txU3QamDDksMLROSfEanYB89pUKivZaUzL25mmVDzJZiXNbODi0wWF8lWqvVMhGzLpcJMBwJxWJrRLWOljsXSKnDojPpwyB/XO0ZZhrsDAlWUGf9LxABP71n8BxQZn2T8X/6XqL9XNvbcLk6s0eYagLdKBAkgYqEgEVKqtzRqckTBpIPa1m2NjFb+J4My1HmMlGhlaJRhdj/Qn9i3wmXWwX2z7hXAMsr6h6bBMkGLrDK8Ra+wyVfgnTN6dZfB8s+NjeLDsFeEkOflBs+BHgIhKSFazbRv7QbwCltvBJ7NXpoLE0xYXLTSmypYW13iXS1FG/axKAG0pMucDZc98PKPzJAW6djOmHw17Eell6RL97rV3eszHlC5Qbf9e7wtLIinuiQcG9Jk2p6t5sVhlcjOl6C/jJcBPtzO8EejZjF5dkkS8BNN007NlQTIPsLmZxRwZwX4UiQnDpgy8FaudMd1E+zwEIPyd9NqbTztqpovN x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW5PR11MB5809.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(366004)(346002)(396003)(376002)(136003)(76116006)(66946007)(8676002)(66556008)(478600001)(64756008)(66476007)(66446008)(107886003)(186003)(83380400001)(26005)(53546011)(41300700001)(33656002)(52536014)(4326008)(9686003)(8936002)(7696005)(6506007)(55016003)(71200400001)(38070700005)(122000001)(5660300002)(2906002)(82960400001)(86362001)(110136005)(54906003)(38100700002)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?HftfOHVZLb6J2h7w+HohLS0fTGEfynWs60cqARaCyCLZll4AwLwJwZ+w?= =?Windows-1252?Q?uRzQuRG6rH1KwlHPnfSwLBulBDtcGyxxmIBkxK+aBe9GZGUF3Wa4b68M?= =?Windows-1252?Q?Cx4d5BsnyQdBbifN6+OGww3Lna2rXdoMjy4UtdcKSWpAgtK22HBd+dgS?= =?Windows-1252?Q?r7FhZBJRWNhZMw3GJcPLsNcJG5D5Mj9017o6a1AxkGnwTpaKM54HtJrl?= =?Windows-1252?Q?UrdSOV8f/jnOM0X3J99mZy9TGGOaGydJtIc2X/95BQwOv5kJYLfWAN2t?= =?Windows-1252?Q?CUhK9dMahyqeAJXo1/K0Oex+mvYZGENJhIztO4xO1vig75s5dTbGqMmv?= =?Windows-1252?Q?w9XKlCpBeWZrifx6bXBF+R0BlQp4p0aI/LgjBgtQVRhBd2DgHuJE3Aoj?= =?Windows-1252?Q?3URznPVwzTYo2I+j7/YX9GcE+Tr9piavDwKjLvTVYemutBDbm9yKHXhe?= =?Windows-1252?Q?M2I/h8Wwh12r3j52vJybKHkXoSdKeLQipzq1tqWRxXxWi04pxuHBnr5v?= =?Windows-1252?Q?BDKpuDFvPykwE2gigVLjVDE7KWtEI1gtWV+X2uR8BDuEMM0tZcAxPOHg?= =?Windows-1252?Q?JfOBwMqVkmxtYIrY7XUBuk9kfIi6JxEBgmCflRcAcID1IbGGsmDyVbdz?= =?Windows-1252?Q?bYCG8jKbZh9GK8Ys2vfIJh++u9SAp+4uuTwXCpv097GMeTly7nvkqdNB?= =?Windows-1252?Q?N8XYEU47yUykroftcO12VVF0v4GeRjvDOgthS4GbLTLBrWtTkxtMJDoi?= =?Windows-1252?Q?ZT3GyE97yC0/rasm4cpuRX1K9e1VOhf9wOuvnwORRa79uazTMMSUrqPS?= =?Windows-1252?Q?SnRDBGk7Fyn8YDgi3qJ80uxJ+maW8FLfkgBH16NGGLQO2tHzdB4ZvpNm?= =?Windows-1252?Q?wfImOEaMzQE3otqKiyon9xkVAtPSU8gE0TQXGgmMeLrxWAI1V+K/Cxst?= =?Windows-1252?Q?wmF2hIRsv2FKwWvqeDHh2dIm0Z6hz1dvBGsH+dsG9fOpUYfR53W4u8gq?= =?Windows-1252?Q?24VLz3/s5188b1oPRlzFiJvbum9AvU13nLDWzUtO5avXO4sy3ExGyBrN?= =?Windows-1252?Q?KbGQn0GKgT19mF8S4Ycav40DnNPhmMUif1nnKM8bJPhfdvXOY9NSRAOk?= =?Windows-1252?Q?/T4Sla/AUbTwv2icYK0YBb0B4pGUHj0KWqIu4jxzaf65UbET/kOgZf4y?= =?Windows-1252?Q?6XuTpraja6xYSkET8ToOUNBDzItdLPJP9cS1GO8XkbhY2/WwygfwTOCF?= =?Windows-1252?Q?ZACNeJj+Pw6g76XZPMnDmN0J3dQ6jL1xVZOw+u/suZ6lMPWJg8taYRys?= =?Windows-1252?Q?jJM7gbRts0Zx2re0hrY50f4ZVm/0FFcMJS7MY4Vb/6SXTDNP2EQHBIrO?= =?Windows-1252?Q?zx2jchF+ZeGB/WVpi6ojlkafLCYKItsiSQ860YMeCqUQyfH7mPlVJBWT?= =?Windows-1252?Q?WbhCSFr6xlMT3oD2FhhzSNMjp/rt/qIXi7NQ8z5Jz4JR5e66EVbbsiKH?= =?Windows-1252?Q?iC5x2d6SOm1YWCMRY0/Bkx2RcrxaZS6B5+Tze+wsNZgl8lAc62AjRGY6?= =?Windows-1252?Q?N1XMy57KNHEAJRpbFpRzkOl9XWUH7pQe71sP5y88GWfpQH1xXqZ8V+7O?= =?Windows-1252?Q?8Ir06qBJF8x4Y1C5ptaUhuASvBN77oaDu2U1/aNdoTGCuLvsEKGL9NqI?= =?Windows-1252?Q?u4xYGISz7w7dPP02VwACrO3aoE2PiaeK?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5809.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 536b88d9-76b6-40b8-3a2a-08da696becee X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2022 09:49:08.3174 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xXEeCcb8x5xRBTk+/3kCqRhoiYXEG9FBA8GJEEU302h96be+hh3kmrsmKd/hORQxTA9l9k+5Ayki4ATbT8oqQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4087 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Kai Ji > Sent: Monday, July 11, 2022 6:08 PM > To: dev@dpdk.org > Cc: gakhil@marvell.com; Ji, Kai > Subject: [dpdk-dev v1] crypto/openssl: fix of dstlen passed in HMAC >=20 > This fix of dstlen passed in OpenSSL 3.0 lib EVP MAC final routine. >=20 > Fixes: 75adf1eae44f ("crypto/openssl: update HMAC routine with 3.0 EVP > API") >=20 > Signed-off-by: Kai Ji > --- > drivers/crypto/openssl/rte_openssl_pmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c > b/drivers/crypto/openssl/rte_openssl_pmd.c > index e01dacc98d..5658b9db66 100644 > --- a/drivers/crypto/openssl/rte_openssl_pmd.c > +++ b/drivers/crypto/openssl/rte_openssl_pmd.c > @@ -1395,7 +1395,7 @@ process_openssl_auth_hmac(struct rte_mbuf > *mbuf_src, uint8_t *dst, int offset, > } >=20 > process_auth_final: > - if (EVP_MAC_final(ctx, dst, &dstlen, sizeof(dst)) !=3D 1) > + if (EVP_MAC_final(ctx, dst, &dstlen, DIGEST_LENGTH_MAX) !=3D 1) > goto process_auth_err; >=20 > EVP_MAC_CTX_free(ctx); > -- > 2.17.1 Acked-by: Fan Zhang