From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DFB1A0503; Thu, 19 May 2022 14:25:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 08C2A40222; Thu, 19 May 2022 14:25:32 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 523A440156 for ; Thu, 19 May 2022 14:25:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652963130; x=1684499130; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=K4K3941plCmBgN14yv8z3ZHt57J4cRqwFUdZPtWpo8U=; b=jfRqz9sy1rSjWZH5OumITP8RzpV6d8l7pMYiGg+JkT8LdxpGAdRHF4Fi HE5JBA9OVZCDpiSHVxBz3gSWULv7fovD4Zq3zOcV0yUHsB8ktnLFEiF8H 8OlKGRdOGbvdwxpEMwX4szIkfMpZ+QF+d/KkXUaVibdHKSQ8/Ro3AROVQ 7b2udx4v0Irr9E/+FD4DQIFkAAfeKFRiyRYos9SRinCl8JTQak+8RvMR1 kGsGcfc6O3P0lnsOKANJB09I4+DohKAw+N67LmkJSk3i47mH0tyVubeuf yQi5jJpGeCip32KMKDn+QYOY4Wj4X0FbUUBymzPfumdGGME1iIV14yzPm A==; X-IronPort-AV: E=McAfee;i="6400,9594,10351"; a="358584191" X-IronPort-AV: E=Sophos;i="5.91,237,1647327600"; d="scan'208";a="358584191" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 05:25:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,237,1647327600"; d="scan'208";a="570184992" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga007.jf.intel.com with ESMTP; 19 May 2022 05:25:28 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 19 May 2022 05:25:28 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 19 May 2022 05:25:28 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 19 May 2022 05:25:28 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 19 May 2022 05:25:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RC6in7rmZkB3kwPophukBm998lnVevs13ESH8Vq12ripu51omvj/1w3F8oEVFdPFc5rdfEOahS8m6n2PhNWbc/eQSGx0ejc3D3Og9tbVcasQNqoBmHYMV5XZN41kVdDq8eGH8aV7Wrb86R+b5NHjim95o2/WOeX5IyvkDb3w260FwmGjImtnXsPFYi2T8j/BK5V1ZcOGvwq8twPoLCcpW2p5d4g4RaTeJRHn/Q6T/vn9r/0P1YwmLcqkkExOPO7+2jww0U0LFdoOOFYC4Z6evv0SpZgO66ppyzFMLH5z7fZtdgk7EgS3mkgge8GwvNiWuA7Fc4CqX1iHUY1uNA3rZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JF2czgBtyleg2l2HQV3T196hp+2Q1WbdgyS4PCnAJc0=; b=JoRQlWnndp7F//mcG/SphwDS4vpolcDW71KrbFC6fBDj4iDkFY/9PtANwC7UsKA5gBpFznMadRf5hBku4g8bsWa5Vqz2BqIl4V57NzFZ046zeAUDrFWonr8z6D+8IXU0iIOC1hVC9BfeMHOa1YrLeftmD3q886c8MrPb1QRo9cOxmnriCmwNROlqVdz6AgkecL7zBbZ4TTGMVnwM5zofQnSPmj7XOW1wG4Z5a/JrWIWYbSg0/ja1XjrR+hzIObIjRGU0kYLZ1gNPyIyqM/DyhtWzFYb9GV2Vw9GjATM+NqUiRwHrVI5uqta4OTdj8dvL3rVAjAkj5qVNJ/uHjxhfFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5809.namprd11.prod.outlook.com (2603:10b6:303:197::6) by DM4PR11MB5246.namprd11.prod.outlook.com (2603:10b6:5:389::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Thu, 19 May 2022 12:25:25 +0000 Received: from MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::b9ba:9827:9cbd:9f37]) by MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::b9ba:9827:9cbd:9f37%5]) with mapi id 15.20.5273.014; Thu, 19 May 2022 12:25:25 +0000 From: "Zhang, Roy Fan" To: "Richardson, Bruce" CC: Ferruh Yigit , "Ji, Kai" , "dev@dpdk.org" Subject: RE: [dpdk-dev v2 1/2] build: add in option for qat use intel ipsec-mb lib Thread-Topic: [dpdk-dev v2 1/2] build: add in option for qat use intel ipsec-mb lib Thread-Index: AQHYafjrqItVlHeRmEyyIVp3gjwCU60kR/uAgAAniYCAAAHgAIABebeQgAAVxICAACGegA== Date: Thu, 19 May 2022 12:25:25 +0000 Message-ID: References: <20220407152931.8771-1-roy.fan.zhang@intel.com> <20220517141652.53769-1-kai.ji@intel.com> In-Reply-To: Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c7bf4c9b-7510-4dfd-e56a-08da3992a72c x-ms-traffictypediagnostic: DM4PR11MB5246:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 14QH4jrR2IqcB/89Uf+jOJHylmehtgNQbZyN2yWcngSD4ytsstmOk8OWJZJLI5m9Aflcm0r21xCYH2ofs2EKVJ8wTvpcYtnnZN+GqNZxW9vR43tKFU7kL+pgRsm0Hq5jT/DRcLRE8QPJMWihTldulkrXyfnx44c6HL6Q5nQTO7aWg71GXV77Io5vmFLaARA7yw83fTM3ZIiroG9KNTpw2GnHnyuY/VMguPu0yZBAJw6bpA3/JADuOWQBDXrrvvSnQ47wA0uqq6q3jIGN3MSTjgcd+hPqv1FOpStnbVRINo2xUsIcheWzByD4DUTIJsxlXxs0ALoUyLUGQtDUXbn2/1HVssb3uGJ/qBuxpgmXzS8bpfcxacLnSSAgHz0Xc+Z1MEWxPkfBB/HdouHm33XuNHu+0hjykiIpk1cSKY8mu7R5UOsK9NSwp19tV2u7zern9AB2KvxG3+phIKGHhiPM3xA4mJQWVpsYqCLO7zmukD/hd4Srz8kXD+il0WXEPM9zVB7WGgJBI+vVyZb058dS53K8IetMigfSYfFgi0g57qsr8mkNEAA9apzg0x2Y1ueJh9kvu6vHW6VRq1GEyhfG+6czdqwdrFcFAzje2vN6odYlinQPO7iqhoHLwXoGyOYte7w+Bgz0ptWrLybhiQ2dFhf/vQFiyiVM01IWuFo4Y0hGVgKE+J/6XdPpQGB8BngwP9QQFSqvwdwd1kfBzPpusw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW5PR11MB5809.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(5660300002)(6636002)(9686003)(71200400001)(53546011)(316002)(6506007)(26005)(76116006)(66446008)(54906003)(7696005)(82960400001)(38070700005)(122000001)(66476007)(64756008)(66556008)(8676002)(38100700002)(6862004)(4326008)(8936002)(52536014)(66946007)(86362001)(508600001)(83380400001)(55016003)(186003)(2906002)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?JLM6KtB+in5AK06rlkXC48Tb6kFoX+N0kJBKXymqwAghXOufRPf/LyYG?= =?Windows-1252?Q?E98jFoYvF4OG6qB8WihljTaDkJBGHFYvyTI2MjTV+ITjim2AGPqI6duv?= =?Windows-1252?Q?gh/r7Fnl6+22LFGuPS+jLxrtCYEZKP4AJo8QaJpTAOPR05XCyxfFglLx?= =?Windows-1252?Q?HpMHfcUnACw1DQS7ffsa0isyH67E4WQfixajihTDkOlbrCdBb1WoZ8/w?= =?Windows-1252?Q?/rKN4hY3gHApHsLX8U5M2UpBxLIxVWmidVfxzrSlfLEbi/Ogc16rud7D?= =?Windows-1252?Q?D0op9baI5HL5Pu/CwYy/6Sl+ieeVaks885x47TQxub4kLyVvIl5oZGJH?= =?Windows-1252?Q?b3kLCNmAQuOV1yDOdrVVKEgGmSVcb9i9DZTuTmpsqNyV6+dVZzRgHf92?= =?Windows-1252?Q?pnXZBIIh0ZQe099MqVTzL+ZWVyLQArcmJ8aR69shcXBUK0Agn9Vewrf8?= =?Windows-1252?Q?kcrqCtuo1yHIzIp1UZYkK065mp+ju1O5ayRNE/EhvCnd1DFnX6+bW8oz?= =?Windows-1252?Q?5Rp6Hsi72wUZifhFgKwYRmU8QIFi4n2riYLA3bVT7iLfFQGojV0lNZaY?= =?Windows-1252?Q?ab9GuhmRqaRxDc50SmP6HTDJYN5SVuqZwUgED7G8f7fyA//pleti5X9L?= =?Windows-1252?Q?a3w4ctSVT/6ETgZHqRVvmQORiVpame6KXJWfgwrAalv+DGkNMvpDNpOY?= =?Windows-1252?Q?u4495nnbIp2ppeGZMfMW7lU+zBt4DxDtDIa2T3nbc0lAhm8V9136yDbi?= =?Windows-1252?Q?5MpLd6bSioY6WQ9HN5RvbTlhLditT6GTVzF39ixD2eTT5INaz01JrDf5?= =?Windows-1252?Q?ISFZfXu6hnXCTDTlZg8Gb7CLE55LnaFIgdDJ57Loh00fPpjnuZ/Y+yt8?= =?Windows-1252?Q?g0gsj0pWBLhbVfLFeY03KJv1rL0vzZs79RRnYiKsrkJxplXVLkW3Ju1v?= =?Windows-1252?Q?ZpWYghzyfbYYAyTOyYLZKpLZIDiJurmJXPMVQjgygjnqgPNykmm+kYpQ?= =?Windows-1252?Q?HEFfqSX3j866orWYXezUJPoSagDTaEWidlihVMHEmcWebnZgAXpmm+AU?= =?Windows-1252?Q?iVOIU1VKk/KKBhJlapA8UpxvB87pvIM6jaAS7IEIl+/8IN7zOrxwBaav?= =?Windows-1252?Q?WdvmbtuztyDRb3wxQu82L/uKpBibATR+A7SBnCWRRm8DxIVPn85fwAKb?= =?Windows-1252?Q?PAdfAEz9YO24ZSbDcdpiXbUDYBHoltLdafdI2wWhngPn0YDp//YBn7nk?= =?Windows-1252?Q?TMAVHeT7JRbHE7TPl55xClFK3/YsrXBru3JEoKVkjrPeYE1PaYOFK513?= =?Windows-1252?Q?UTHvaFZHobjVCJwuvNPlGWIwSOTiN9WSKnFtdrjjmis4Nr0sXBWldiMu?= =?Windows-1252?Q?SXGSORdwttGs7+lbHpCuQNK7dX9y4brZdTyCB+8991JoPogCbs5TzyFo?= =?Windows-1252?Q?TFejxQRa8H2ew7i9Y72q8DWibulDMYlOacxG/4mGIQJuv2DrHKD+VrV7?= =?Windows-1252?Q?+UijB0Thq5+OmCdf41VciSA6N3MyWibB9Iytu+YJcS7oy2JxZQSd/j8f?= =?Windows-1252?Q?nf1SDtDHvuLDrdruxw7xAPZNZ4fGCnUixuVHhaYMP+K750eFZv4ozvGm?= =?Windows-1252?Q?u6jvNeHW2/IIcXMEeHSZqxLQz16y3qVa5TXwockm+41FF6euOCIr2BZS?= =?Windows-1252?Q?0urDmpnjahEqZ9z4sz/oTyvs/ZTpW53OYMA6s0eeWgz7ovHCrW6B3w4O?= =?Windows-1252?Q?O/EX9sVDJvlL+tooYMeK6EsCsy1IP8i5Fexilwr9T4qr1waAxbYgLIXg?= =?Windows-1252?Q?PXdOCBdOe3dVtynivXNc6akOuUTAS2I3Pm8+MxwmtJDZ4eUCA3fH3dld?= =?Windows-1252?Q?LfH1IOJ397qbLg=3D=3D?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5809.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7bf4c9b-7510-4dfd-e56a-08da3992a72c X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2022 12:25:25.8779 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PEAduLex5HqJhg4+wkOZhEce06ddj44TI+3QI33g5kA3XWk/hcMhoOJNmiggUB7RH4f/T+J8/JwuqrPxFBFREg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5246 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Bruce, > -----Original Message----- > From: Richardson, Bruce > Sent: Thursday, May 19, 2022 11:23 AM > To: Zhang, Roy Fan > Cc: Ferruh Yigit ; Ji, Kai ; > dev@dpdk.org > Subject: Re: [dpdk-dev v2 1/2] build: add in option for qat use intel ips= ec-mb > lib >=20 > On Thu, May 19, 2022 at 10:14:14AM +0100, Zhang, Roy Fan wrote: > > > -----Original Message----- > > > From: Richardson, Bruce > > > Sent: Wednesday, May 18, 2022 11:33 AM > > > To: Ferruh Yigit > > > Cc: Ji, Kai ; dev@dpdk.org; Zhang, Roy Fan > > > > > > Subject: Re: [dpdk-dev v2 1/2] build: add in option for qat use intel= ipsec- > mb > > > lib > > > > > > On Wed, May 18, 2022 at 11:26:27AM +0100, Ferruh Yigit wrote: > > > > On 5/18/2022 9:04 AM, Bruce Richardson wrote: > > > > > On Tue, May 17, 2022 at 10:16:51PM +0800, Kai Ji wrote: > > > > > > Add in build option for QAT pmd use intel ipsec-mb lib > > > > > > instead openssl for precompute partial hash & aes. > > > > > > > > > > > > Signed-off-by: Kai Ji > > > > > > --- > > > > > > drivers/common/qat/meson.build | 12 ++++++++++++ > > > > > > meson_options.txt | 2 ++ > > > > > > 2 files changed, 14 insertions(+) > > > > > > > > > > > > diff --git a/drivers/common/qat/meson.build > > > b/drivers/common/qat/meson.build > > > > > > index b7027f3164..d6eaff3e0e 100644 > > > > > > --- a/drivers/common/qat/meson.build > > > > > > +++ b/drivers/common/qat/meson.build > > > > > > @@ -35,6 +35,18 @@ if qat_crypto and not libcrypto.found() > > > > > > 'missing dependency, libcrypto') > > > > > > endif > > > > > > +if get_option('qat_libipsecmb') > > > > > > + IMB_required_ver =3D '1.0.0' > > > > > > + libipsecmb =3D cc.find_library('IPSec_MB', required: false= ) > > > > > > + if not lib.found() > > > > > > + build =3D false > > > > > > + reason =3D 'missing dependency, "libIPSec_MB"' > > > > > > + else > > > > > > + ext_deps +=3D libipsecmb > > > > > > + dpdk_conf.set('RTE_QAT_LIBIPSECMB', true) > > > > > > + endif > > > > > > +endif > > > > > > + > > > > > > > > > > In general it's not a good idea for individual drivers to add top= -level > > > > > meson.build options. If every driver does this for all its option= s we will > > > > > have an unmanageable set of hundreds of options. Unfortunately, > > > though, I > > > > > don't see a really good way to replace this with something other = than > a > > > > > build option - I assume it's not just good enough to check which = of the > > > > > dependencies is found/not-found? Is there some way that this can = be > a > > > > > generic option, that may be applicable to other drivers? Could th= e > option > > > > > be instead to prioritize FIPs compatibility? > > > > > > > > > > > > > +1 to not have top level meson option for a driver. > > > > > > > > Will it work to give priority to intel-ipsec-mb lib, like when ipse= c-mb > > > > library exists use it, else use openssl? > > > > > > Looking at the patch a bit more, is there a reason why this cannot be > made > > > a run-time option when both libraries are available? > > > > Hi Bruce, > > > > Thanks for the review. > > Are you suggesting adding a EAL option to the QAT PMD? > > > I was thinking you can add a driver option, to allow switching from the > default if both openssl and ipsec-mb were available to be compiled in. We may have to use macros to filter out openssl deprecated API calls otherwise the warning may still be there. Also what kind of driver option are we talking about - any reference you can point to us? Much appreciated! Regards, Fan