From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73308A04FF; Wed, 27 Apr 2022 17:50:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA08A42800; Wed, 27 Apr 2022 17:50:51 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 6108A427F7 for ; Wed, 27 Apr 2022 17:50:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651074650; x=1682610650; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=EJ7mEbJUT5OqvXAIkU6rCt+X1aL1XmS9iePm+ypJm5Y=; b=EyCSFSHQPJeNNijsY5W5GnyYZXrqXexyWar/w0IfrXo1b42PdkpiVyXB UynnAzCqCfyIYIqF307PYFbutV4DbF7ZOXb1vZtQ7VC5gWp13HC6aU4U9 0tibeZkLz/OrGvI3/18/lT6vPdZcCbmceQmxq39903wocWe06SdUlV4n3 HzgFvBGsWtk42JSMm4y9d/k5MLW9e0uVZuq8d/QsYGaC5j9RXVBetrhIY KgpFb8V6M3Qdr1gfkPJ9a/tzK1dLtEuIGjaHE8x7uIUn6K8oe5e/O9LHp T6kZ4YHZMQdL4khLPtYsnX2YdpwQzpMNxPESKEuk/H7Of8VT2vnGZxJS3 Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10330"; a="265499003" X-IronPort-AV: E=Sophos;i="5.90,293,1643702400"; d="scan'208";a="265499003" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2022 08:38:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,293,1643702400"; d="scan'208";a="533272111" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga006.jf.intel.com with ESMTP; 27 Apr 2022 08:38:56 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 27 Apr 2022 08:38:53 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 27 Apr 2022 08:38:34 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 27 Apr 2022 08:38:34 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 27 Apr 2022 08:37:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XZ3FLTbTfDbrudQtG0B/VrCQDX4I2tF63HhxkKIryCngj+LbJA6sGJwk5S22oOHelKMyGYJuJAAO2aZt3ouNQMZcbe4uZxGRPHK7cIT/LCbxQP5Rb/DQwUxkWh/axHVxRppLAYqh2q0zAB3+UBGLRJeZqLn2i5nMzNF8EkoAlXmlCqPOTKicxT5k8R58SX9OzeC+UxsXJfo+F8EmAxB9kQiFhzdgkuVLm0bfG9A9ic4gVX+Vt82j0PMJG2i0wyX6TmSCf3ttJV+c+1XZrXs4bm/lO37naJSjx+/nVj9v/+yGs63a0vTQgFWPSIQfq0gsBuiyb7epu5OQRd+gH3jszA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pk2ja4CDUGQLZrGiYS4R04YTxDTkYCl7XKfN9cMRwro=; b=R76tcGRNROGpHmy3Y/JkhRf+9PqcA8/97hs9pGMaLYr2764uHfz+rlenb0krGUE5YhQiarWrBmt+0Lc54mgzBRUt3c6zx7A4Ad3rCnKjsoXfwtSh01nBW8yvbAo5c72kCEu+QrqH//N3gDgndei2XPezRiYpIMI/fu/jHeFHGbUnqKYFH8gV402BlQqy1eVX3iPCNgCH96Ye+2bTrf5fCk7ATqpDkFL9FdxF1Ud/TWCxd83R6JdhBkvoQUta17MvQXZ1ZZgCOkpC4m38ht5VvJV/66BJ8K8xQULald+Xa9NkeP60bjH4qPECXuB31XM+M2aSJcXj0DjItZnZ8ulEGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5809.namprd11.prod.outlook.com (2603:10b6:303:197::6) by CY4PR11MB1975.namprd11.prod.outlook.com (2603:10b6:903:11f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 27 Apr 2022 15:37:49 +0000 Received: from MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::787b:4b79:206d:9e0a]) by MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::787b:4b79:206d:9e0a%4]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022 15:37:49 +0000 From: "Zhang, Roy Fan" To: Akhil Goyal , "dev@dpdk.org" CC: "anoobj@marvell.com" , "jerinj@marvell.com" , "Gujjar, Abhinandan S" , "Jayatheerthan, Jay" , "Vangati, Narender" , "vfialko@marvell.com" Subject: RE: [PATCH v3 0/7] Add new cryptodev op for event metadata Thread-Topic: [PATCH v3 0/7] Add new cryptodev op for event metadata Thread-Index: AQHYVY1lheKQWpZa2UyE/PAK7p0aHK0D7k2w Date: Wed, 27 Apr 2022 15:37:49 +0000 Message-ID: References: <20220418193325.368313-1-gakhil@marvell.com> <20220421143720.1583062-1-gakhil@marvell.com> In-Reply-To: <20220421143720.1583062-1-gakhil@marvell.com> Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 15c62128-1aa6-415a-dd89-08da2863e2ab x-ms-traffictypediagnostic: CY4PR11MB1975:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: g8sMHNLMhpclZvS/O5tNgifCzwEkLfe8fwBrIMZ58cx+ila9Zp7wIgOp5xO4eUKChXJjW5q9d/sn6Az/vSSCHkXDO4Kseay8mjiWG/c7r5BGU1xsp2CwATCGf4NOgsPqGRDX1/gGgKON9x/GTkXtOG2ri4fwS+qSx9MqEX3+JERThOeCF70akXlCEBcQ7AWjlENdvQPUVRPgzo9LjEnIe3x99ShvTGIRqsGAfX7w4cCxKrpM4Gq8i98Vf4fTWKcD9AS8n9HX1UK/vlShdvsV8aBVVtZ//9+OcOyQ/yuh16wZdTPBW3d7R1X7jDepQNViJgJQQoBalsnhxAGYF8e+xI3c6ZvpANwV5mY9ASGw1FuwHBUMnDGp41CakRtF8C7s40751794YcSu4vwz9jVKzFIK5cM6jNokx41FeEq3azDk723OhnXwgm4CBErakyqYx1az9iu3JMR+tcXr30bdHGoTH9Ok4YoSwz4lCWS/jciwUaizCtpUorJNH/PiRUwUp5+DxsRKt7WoVfBm2G8aersL8R7gIXXV9+JxK+aLfCoU9qsUwCwYJ3fTmIBGw1E5JJT56hWich05l7TtAgu52Jk4ICBWnMyreAq7wJbXgpIBHCdxsuEn3/dfPas6ckatqWni2iPlwbCEni7IdFteoqZv1ldjC8rkxUay6L/Hoq+WjNyUFrhP6V/rD1JuyEKn8R7US/sDiBDd/CkE1k4p1Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW5PR11MB5809.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(55016003)(76116006)(316002)(5660300002)(66476007)(7696005)(186003)(66946007)(66556008)(33656002)(2906002)(52536014)(4326008)(83380400001)(8676002)(66446008)(64756008)(8936002)(110136005)(54906003)(86362001)(71200400001)(508600001)(38100700002)(38070700005)(82960400001)(26005)(9686003)(53546011)(122000001)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?cYDXaYoZcTB3NfK8AFpD2mF3OUmJa/hJvVkzjJif7xrl6hLYDQiO2KEa?= =?Windows-1252?Q?V9alHV99/4vWNuKYB9hORZdEQO1J8f+wPcEpBES0wYoNYFCxicsALslp?= =?Windows-1252?Q?PkU8pgc4TQFY6CYQpI+d9K36p/lGUE0KOn3B9flFZZxVppAhaFddCWrb?= =?Windows-1252?Q?lPmSvtbF+H3bbVaPCPOr02HXkA+tjHubBxD3mC847g+ceJPT7mElGoal?= =?Windows-1252?Q?cYzmTIBzsLDjh6TijEywVKNYrm2CdLC/74jvaeY+UT6/Mj9nLJMY7bLh?= =?Windows-1252?Q?JQNa/SbbUFkVx/MseHM+n2keB/b/mTcB/DrduK1BdZRPOu1kWc+ZFapg?= =?Windows-1252?Q?snFSI1bFIkCWsjH7q4mvB+UCBdZMCCGPpOOw268zO0pOfENdCUmRv6Lt?= =?Windows-1252?Q?jFvL2QxDq7jV1pqFeXxj5gQS464MfYNJhECvNSa/Vhz7IYf3pLiAYwYV?= =?Windows-1252?Q?aqxDlKG9jiw5h0tV0m9dm9E8P/uw2XmlyLwzfyKAu4ooJIUqvfXqZV+7?= =?Windows-1252?Q?A4n4bVkWPs4B5BS3X1RQkwfkFHhYh03KuNZmxChZfO1d+GDjiiwGdiZH?= =?Windows-1252?Q?6iQX6zViEEYvsdlvyskTyYRumcZE2JRVlTqGYSGcceW7gjadyYo6Jrwh?= =?Windows-1252?Q?t8yfGPyIJpe0pb4Ps3EBkIzJpmoP6TvdK52mahsxFh6/FXfJxbBz2hLh?= =?Windows-1252?Q?iZwBlt/ov47/vpO82UrhoaG4d3R332GMLrCZmZ5OWeUoTD4Y8yKIWyIT?= =?Windows-1252?Q?/tHFGkHi7HeEo3gtcjrMATstjEHECZgEKJbyeYwYSoSDRqjAy91goTU7?= =?Windows-1252?Q?JHmYM6iqJx4sTc0Ardend9xC5Rq+MlsG4EVbK42WpqKcJ41A177q+uRP?= =?Windows-1252?Q?kefDCbuejCB/xwsIAlCcpfVmuUQvn5jUFgikPuWleEuZQ9KiECRHE6cw?= =?Windows-1252?Q?XHDjNgS6xwTotSNJsQFefx126IK4PTVGfAn9FEbnwCnBCVoi1ZU9vWkx?= =?Windows-1252?Q?C5CwswUqpevraVgmeoYyZeEEkTXnVHe7gjykR9AihrqGUs+BMHHCICE+?= =?Windows-1252?Q?AIvljNtH5E2bRaEYZ9b2hEf16EaG3oMiiBkKiuSJLaHBOS0b+gre99dL?= =?Windows-1252?Q?csFknqoh77zDkyNeUYBFoOj4Y5SoTE1JJDKwi6P6iq2g5zGyPsuHHaw8?= =?Windows-1252?Q?eczpWFKxrX6N44guvmm+LUOMFznuxDw9UcZeiAXZuNmUtXlW7xNoflhD?= =?Windows-1252?Q?Tn/J2vN/PMuz8fFqaokfURnCHNh8FHpvxc28XgVBAExPg9tt87PERfnZ?= =?Windows-1252?Q?xjAqxCFdmF7AxBbSBVbPcOJHjvnV34gKgkoeEsnf4bNlnB+dZSgoI9WO?= =?Windows-1252?Q?Rd7snZqhtRcIYlxN/gY/6dNLQZejarhAjNflyCP9S/97Ogb3TJ529yUM?= =?Windows-1252?Q?HdaRGU9qI52VRN33oRAmt3vgOgQdSccjkuznGSD1ZzS944wa0Gy1BLnY?= =?Windows-1252?Q?ZZPpddQUhLtTOmSb5VYsDPDQZq7rwwh5d603vM5rDHBVSbLLiwMtcRvd?= =?Windows-1252?Q?dv7jX2Xq6H+EMd6zyo9HoJsX/VoKo2/SHGrKohfx7NyNC7WwEfpV5+9l?= =?Windows-1252?Q?vIGCuDpovYrTgvpfJdAfdmjRimaAMih+tQsWPD9EXutdM3ddYFTuaq+m?= =?Windows-1252?Q?ZDe7PV9lIstnpIMzxTT4q7RDt917/pQpPvbLMM1sjXn9VC5Ve+T6jt9o?= =?Windows-1252?Q?tRpTEX4feBrC1Q9oRhe9Kna41JL4uEZhEsWOPYeVSPbcnXEeVZ2ldGKV?= =?Windows-1252?Q?N9say6WdOxgh1wQytmNzi08ZC9a2myHBVL0Q3Grlaw6Lz/icf0c8I+ai?= =?Windows-1252?Q?YQoTREzPD3uuAw=3D=3D?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5809.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15c62128-1aa6-415a-dd89-08da2863e2ab X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2022 15:37:49.5665 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ERKd8A/+nRx/Ch4/YAZESP/3sfTyE4p2IeEorg61QYmubxgiJwdJceWyNbPJXuO8BYn6wOoQy9tzJEFnzigo4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1975 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, April 21, 2022 3:37 PM > To: dev@dpdk.org > Cc: anoobj@marvell.com; jerinj@marvell.com; Gujjar, Abhinandan S > ; Jayatheerthan, Jay > ; Vangati, Narender > ; vfialko@marvell.com; Akhil Goyal > > Subject: [PATCH v3 0/7] Add new cryptodev op for event metadata >=20 > For using event crypto metadata, event metadata need to be set > in session. For this session user data was used for symmetric > crypto sessions and no support was present for asymmetric and > security sessions. > The use of userdata to store event metadata (which is dereferenced > in PMD) is not correct as it is meant for the application to use it. > Hence, a new API is created to set and get event crypto metadata which > is scalable to all sessions supported by the crypto PMD. > The application can use the set API to set event metadata and the > PMD may store that inside the session private data and PMD need not > use the get API as it would be internal to the PMD. > For the software event crypto adapter implementation, the eventdev > library can use the get API to get the event metadata stored inside > the session structure. > For Asymmetric sessions, a new field is added inside the session > struct which is internal to library. > For symmetric and security sessions, new field cannot be added as > it would be ABI break. Hence, session userdata is being used to > store that as it was used earlier. In next ABI break release this > would be fixed similar to asymmetric crypto case. >=20 > The patchset also add support for asymmetric crypto adapter > in the test applications and the crypto/cnxk implementation of > the new cryptodev op and corresponding changes in the eventdev lib. >=20 > Changes in v3: > - fix SW adapter case of memory allocation/free of mdata. mdata is > allocated in set API and freed in session clear/destroy. > - mark rte_cryptodev_session_event_mdata_get as internal API > as it is only needed for the app or the PMD. >=20 > changes in v2: > - v1 patchset only fixed security sessions and also caused ABI breakage. > This is fixed in v2. > - added new API for setting event metadata. > - added new cryptodev op which can handle all sessions >=20 >=20 > Akhil Goyal (5): > crypto/octeontx: use new API for event metadata > test/event: use new API to set event crypto metadata > eventdev: use new API to get event crypto metadata > test/event: add asymmetric cases for crypto adapter > test-eventdev: support asym ops for crypto adapter >=20 > Volodymyr Fialko (2): > cryptodev: add APIs to get/set event metadata > crypto/cnxk: add event metadata set operation >=20 > app/test-eventdev/evt_common.h | 2 + > app/test-eventdev/evt_options.c | 17 + > app/test-eventdev/evt_options.h | 4 + > app/test-eventdev/test_perf_atq.c | 12 +- > app/test-eventdev/test_perf_common.c | 254 ++++++++-- > app/test-eventdev/test_perf_common.h | 45 +- > app/test-eventdev/test_perf_queue.c | 12 +- > app/test/test_event_crypto_adapter.c | 503 +++++++++++++++++++- > doc/guides/tools/testeventdev.rst | 5 + > drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 144 +++++- > drivers/crypto/cnxk/cn10k_ipsec.h | 2 + > drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 138 +++++- > drivers/crypto/cnxk/cn9k_ipsec.h | 2 + > drivers/crypto/cnxk/cnxk_ae.h | 2 + > drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 18 - > drivers/crypto/cnxk/cnxk_se.h | 2 + > drivers/crypto/octeontx/otx_cryptodev_ops.c | 20 +- > lib/cryptodev/cryptodev_pmd.c | 16 + > lib/cryptodev/cryptodev_pmd.h | 36 ++ > lib/cryptodev/rte_cryptodev.c | 41 ++ > lib/cryptodev/rte_cryptodev.h | 22 + > lib/cryptodev/version.map | 4 + > lib/eventdev/rte_event_crypto_adapter.c | 55 +-- > 23 files changed, 1168 insertions(+), 188 deletions(-) >=20 > -- > 2.25.1 Series-acked-by: Fan Zhang