From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A57E4554D; Tue, 2 Jul 2024 14:24:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8366B40665; Tue, 2 Jul 2024 14:24:11 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by mails.dpdk.org (Postfix) with ESMTP id CA2D7402D2 for ; Tue, 2 Jul 2024 14:24:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719923049; x=1751459049; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Q0MIsODdOOplOzLqrFFUpGd9ZPWgiOR7jClHzI7C308=; b=Wv6vx+Lh9I13WDO+MJevDYMPgEfl40mLcW6LBMifOcRCJWf76JVflmVB s1ynxTjDEy1HBBBbFu0oEqYN4dIIrtZmpvcJ+/txe6UZGz4DrUH1Jm6yM BQNzWbhnuKinW8PCSDs1gGpcoimdADzQcFZhsHvuIAqca5oCUHY/jv9/b WCmKxuCdT5nB/OYGHtRzwD6DG7K76itOn8N29pQqY3Slz9y+SVrnxxrBT nha3SZxdTCw/GI2sQd1Iwfyc0O3Bet5FlJjMtOCvAbvjoKfuAjO7/DsC+ 64RkRzOBvJ5C2vI0//LwBZe+t/YylnyceP0cNlBp/oGVpw1VB3koHyPvB A==; X-CSE-ConnectionGUID: OxjTI+GtQ5m5UP9SMV8INQ== X-CSE-MsgGUID: +4NNYytISxSps5jxl3ijyw== X-IronPort-AV: E=McAfee;i="6700,10204,11120"; a="17226154" X-IronPort-AV: E=Sophos;i="6.09,178,1716274800"; d="scan'208";a="17226154" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2024 05:24:08 -0700 X-CSE-ConnectionGUID: p9Ipzb3nQ4O6zG9UtP3/vw== X-CSE-MsgGUID: jXM717SSTCCzK0r/2fnZ4w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,178,1716274800"; d="scan'208";a="46022542" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 Jul 2024 05:24:07 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 2 Jul 2024 05:24:07 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 2 Jul 2024 05:24:07 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.49) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 2 Jul 2024 05:24:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nTVuYfGLX7xR7eccdwIA9u9EbrWqx0fkFNAuHrC4U5z4aZA7Tar2hlhjwspCCRH+Y66LejD/vuqNx47Y03mUlMcQdVWSgEzrayV1X1haxptnVvdV2yHrpDOmmBppON1VqpCPTjtESdjRoeCDD5Ws0jxYgyzs/4Kn7Q6zP8M6PE/SDTiVEHexKWtY/jquT3U2n2bOjkkgJeEnKso0kdtYMlQeFyFUwU44la8e+Sw5u1/xQCxBJFH884EHsE3PCOgv0tCnXULFDcOzLkr6mLTI+MBmUyJT00njrvnp7zSLDvabeqkEf9Su13ql1A2FCOkFphcw0VJabT6qvyoVeS/lyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s6vEZekGl4rK0NJhxoauidibHzIxBUBst51AlRMp0IM=; b=Z+1NIDAowQUeJQIVJ57yCbp6pDlT5/vh4g8f8w0FUPPn/rV+tjS5qYVm0vkfc5EN4XQbuqe1v2109t1HmjZ4pgOtvangqSypTX7tW1pxcKpPXFZduRErYLacXi3PsJr6QAZj469wAuz/RP9a1ywUnAjeMKjk9ssKhHtdC8R89Dj505xFxa3VAX1gDWoKJapLO4DvFWri+Fcdy3enQ8NGCV3LJPEPxL0RXl+zNoV/caXHCy+YzQrCvtcnz3OdLJax0MrSosfKQpXLfCY71eLdC9pIIpHt+FXytIZDOPyicnVxe8Ao63tP75sNITR8UdquoNtHaSFi+DaE+xELbt4i+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW6PR11MB8309.namprd11.prod.outlook.com (2603:10b6:303:24c::19) by SA3PR11MB7436.namprd11.prod.outlook.com (2603:10b6:806:307::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.26; Tue, 2 Jul 2024 12:24:04 +0000 Received: from MW6PR11MB8309.namprd11.prod.outlook.com ([fe80::ba43:b01f:aee0:10a8]) by MW6PR11MB8309.namprd11.prod.outlook.com ([fe80::ba43:b01f:aee0:10a8%5]) with mapi id 15.20.7719.028; Tue, 2 Jul 2024 12:24:03 +0000 From: "Stokes, Ian" To: "dev@dpdk.org" CC: "Richardson, Bruce" Subject: RE: [PATCH] net/ice: fix use of ice_bitmap_t in promisc functions Thread-Topic: [PATCH] net/ice: fix use of ice_bitmap_t in promisc functions Thread-Index: AQHazHpmsz/ovk761EmaMzL+I0ExOrHjW+5A Date: Tue, 2 Jul 2024 12:24:03 +0000 Message-ID: References: <20240702122127.22401-1-ian.stokes@intel.com> In-Reply-To: <20240702122127.22401-1-ian.stokes@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW6PR11MB8309:EE_|SA3PR11MB7436:EE_ x-ms-office365-filtering-correlation-id: 899205d3-1a37-40ab-b883-08dc9a91dc75 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?sJJknEXZiIUrsVWbHK7p9SeuWTHD7VS2u0VxCS0MuNpQ5KoNvWQdLWwYreNA?= =?us-ascii?Q?KFfscvPjZO54xjv+QI/ayVYtAqVlqeWmWIjz+F0zpWA6VN/fiY1pre+onMxu?= =?us-ascii?Q?TRNDe5d/7s9fAfDRN2/IXxV5cYpa5Mk5XL0DfeUD6kgATSPZT+4hWIzm5exJ?= =?us-ascii?Q?AAI/j4XcrKjy+N5+bQdPVY0TUFYcJ0Ixd9CrZdBBRBd4A/E7/Wy6Yj0NMAeW?= =?us-ascii?Q?A5y73i9H3MbZv8afreBzrYvKNyq0Ocdjv6za7BrKCmsH/HNEPNkGAoQX16fZ?= =?us-ascii?Q?DgX2i5/3bD+e+ZVyChLqLNyPATs5+DP78yfoqgcXIabpGdAk3X7erlCntrui?= =?us-ascii?Q?aRrdIv/pJh04OJt4gc7aEyC2W96SvtuzX/3WAddXGpAtqdVlZXlBt5u7/DFG?= =?us-ascii?Q?rNUzAd1EhHIORYg7h+kHdUYVUizfBHxPiFrrtEAQw2/+Rh6V+gTEWWOgupwj?= =?us-ascii?Q?54KL1QX5m0ZLSk5FZXFftfpxtjb3RmfaBkTDYdjDt1TYjVQInI2GqAjyJKhe?= =?us-ascii?Q?rn+gWOVAiibWB8tr061K34Ti5lfIGWgUtV957wuSblGDputACNrq4xQPTXoJ?= =?us-ascii?Q?87K+BuRQRY81v49Uw/GllFS9wu8D3BTg5y9hTnWyWEer9MBiEsc+IDk+OLOV?= =?us-ascii?Q?0211rzeKxh6eT8gGx63H2tZ7RWGpS5N2DI77f42011s7DAYFwPaUOODYQ/ZH?= =?us-ascii?Q?rsrrsKiWgWANsM1FTSxTCkWI4QAxfqUK53VGOZekN3dBMTsmfp8zI9zS/VY4?= =?us-ascii?Q?lKBDBqX+Ruzon2IbRr3Ei8jwOBJhkHEGK+Xe8HDnceYo8hZQbUJo5fgYV0pC?= =?us-ascii?Q?3gdyn4+SOXubOkyUlfDf3iu03h5L02uFUHYjCH895Qp1slvMAOA1JPECeHlN?= =?us-ascii?Q?dkAnzMwy9QHdPtC8oESV2XhQtr++M+pjxu8g5J/h4lRejBRwJt8KKEeSt9QK?= =?us-ascii?Q?NM+nx3VoT9XyagTFv6e8Vt1OFvql/nx9+kprwm5V/GWAqStLMoS0/HtAGm+2?= =?us-ascii?Q?EfFstrdbjpeQeMZqKp/jue0zy/bm8K2Wt+9CGp9xB09ZNWrkJkUl6oJDhb8v?= =?us-ascii?Q?9+r+2awQI26qocpw1D9M60ERnHbl0cc2te/Z2l7B1SQvuFnXiBBHNXuY888e?= =?us-ascii?Q?qcQslzOpdgzGgnduuNKV1QufPdjx+080cL5znzniPxeRh782rZWWN1dwEM16?= =?us-ascii?Q?rGc1BbNAPgAzQdx9iE0CZ2s83XJCusR7b75ascYKUqf5Mx+0ktdPikjktFFx?= =?us-ascii?Q?FpX1LGGtJJxvI6pJaoYAgU0ciFaIGhEtrHNCfMiEl5dH9UOp351C7JUvo9Lp?= =?us-ascii?Q?Uo0nrHhcFV4/y2lWr3GFjWDbLx8bc4y8yxtds5gl3ouFQszCZVzB/bvPawPk?= =?us-ascii?Q?ZzNax/dVXgGMmdy2l0jQcKbLatVmQRFku5tqesxoBYR2avR+qQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW6PR11MB8309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?idrKXme1ENJBpZYrhEHH16StgWzNuN6reTqOCSy25ii1MR9pWq//bAq39Lof?= =?us-ascii?Q?AsyquadNSgOW8Hc3Zhu2SyD0s4O09PzLAUmntl9DymylqOdmpGi4I41dFxV7?= =?us-ascii?Q?dpPMUomyNp73qe4g7mS8qHZAdoL4Gg48QCsIkC4/J8iX03c1x/b9doyglQgN?= =?us-ascii?Q?AcYAXYol6tgYUTLVWpsRYKOSMxFbjH50y4J4SNirE/fN1032yASMuNsiFjEd?= =?us-ascii?Q?kpwHZBiIciMIAMeYukwIZb57YTsimzm+CSoGFG1U9rIrJIV7+ScZWmo41MrJ?= =?us-ascii?Q?eIPEFkEJ5/GupjX5gWnZgzJpZX23Wtnp/DgG8KkzwYO9cqE+Dps1AdQ+TifP?= =?us-ascii?Q?QT24Pm4pUbmVE+grPPSNyo9V0om+tYneMbAVf5C75k40j5B1LKIIcKcJ0e1Q?= =?us-ascii?Q?LIlhg3O56/k8pef7fJS7lT+4UK7UetvILktsGidozloN5By50Jw/oDi0ZV+C?= =?us-ascii?Q?+NT5jYCHTe50mSxukQQ/kC5jn7edxRQdVfHX73uHgixwDWWeZPzJ2+18ewGe?= =?us-ascii?Q?PgOEzRcenEH0yXmOGVJ8/zSm19OgLl0bN1erNRJgiTEAHOHU0iwz7ZRxA4ZY?= =?us-ascii?Q?amlI2r7QDepn1HTvfq2gUM7llMLWtt+Yz5VFdyI0by+6Qf2Mn+klwl/qMAKB?= =?us-ascii?Q?dp3AMveBCdTbf1Ac0tWE5tFCMkRck2Cv41E2EraHU/z8AcwR9MoDZ87st3vN?= =?us-ascii?Q?6Z1VONSrag3zEbVbRk5nraKB7rxldAGNrgHdYBHfrycdHxaZuT1R6qiUrg2g?= =?us-ascii?Q?10m49o/4+9epBKqmC0OJXDy7v41kOHTblJwcm45NrEdO3wx6n0JZ4gV1ujUE?= =?us-ascii?Q?bPjNE61BQ3hUE0mVJsHxjy0Ec1RSnBeWDe7mx8KvbySS7VBLIbsSmDl1v5B3?= =?us-ascii?Q?UmtygdFnJ5HLvCqROvlVz4tx1IhEc32x0mm3olqRNz+JFlzYgh3lLd/hQiJS?= =?us-ascii?Q?URhLG7lC3EsAwrS4h6MhfU/FMtMGxRHqZDZf6/sCjPD5W043jsOXqJBwnYld?= =?us-ascii?Q?jUrNA/zuIetnm50p6DC5DtWWzz4hYKEOeRb/236gOtYJfyi9TcHlIv14y+v3?= =?us-ascii?Q?npvAtiNtEy/rHDbWHLdeTAZ8qPltLLDk47aEnkimbJqieN+C7keeGyr46iuB?= =?us-ascii?Q?9VGaA0cpTWfGqqHv6MEweEUBm1l3v7Q4rXbY98peh28359xwGJqjVapuyg1W?= =?us-ascii?Q?N3Zd3Y02UsMZpHKo+As1LnZGPhNDFkrzazOyC2l1XHwYejHeMCkJGXc3Y/k5?= =?us-ascii?Q?f8vqZNpTYpW2MJV6ATPQW0bdmEIji6dwImzRWOM19MTl/K7bbmJPQKErtwr4?= =?us-ascii?Q?fxP93lDvApJUVwFJVoIDJAtte0YtBR8hk0vUCtYYE5ZEECaZ6MTDxUY6lfyV?= =?us-ascii?Q?bZ0M1MvkL8J/wvayY2D1nwsEiV/ciRqW2Th/IUJg1TpuDVrYnvBOo9SFUbFi?= =?us-ascii?Q?jEZV/2pQTw1z2Ln1J2RWKB8rQAilrDfQkDBoQdbumL13JGkxCplkJXRO+Ozk?= =?us-ascii?Q?GAxyTxiOeQkwMYPeAsXjszH1BD186X7rZQcgoDQFhCpolUaVIG51TxafSbJn?= =?us-ascii?Q?OjyuTE8Ea5Ap0ITZ6Ln1Zb3XFlRa5La2wcnoY2Xl?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW6PR11MB8309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 899205d3-1a37-40ab-b883-08dc9a91dc75 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2024 12:24:03.9199 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Cr84hVedViLosUXBZsEzJveXj5knvjZmzFwGZ7i7jVEY6V1nUhc4bX14Bv6+Gsf8/ln3b5eURG+9k8Z6ZzXasw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7436 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Promisc functions were modified to use ice_bitmap_t. > However use of ice_bitmap_t requires specific helper > functions to ensure correctness. >=20 > Fix this by adding correct calls to declare, zero and set > ice_bitmap_t within the promisc functions. >=20 > Signed-off-by: Ian Stokes Just to clarify, this patch is intended to be applied with the ice shared c= ode update which I believe is in net-next. It can either be added as an extra patch to= that series or merged with the original patch, whatever is preferred. Thanks Ian > --- > drivers/net/ice/ice_ethdev.c | 59 +++++++++++++++++++++++------------- > 1 file changed, 38 insertions(+), 21 deletions(-) >=20 > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c > index f7189b2dfe..23f14d7c42 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -3807,7 +3807,8 @@ ice_dev_start(struct rte_eth_dev *dev) > uint8_t timer =3D hw->func_caps.ts_func_info.tmr_index_owned; > uint32_t pin_idx =3D ad->devargs.pin_idx; > struct rte_tm_error tm_err; > - ice_bitmap_t pmask; > + ice_declare_bitmap(pmask, ICE_PROMISC_MAX); > + ice_zero_bitmap(pmask, ICE_PROMISC_MAX); >=20 > /* program Tx queues' context in hardware */ > for (nb_txq =3D 0; nb_txq < data->nb_tx_queues; nb_txq++) { > @@ -3864,9 +3865,12 @@ ice_dev_start(struct rte_eth_dev *dev) > return -EIO; >=20 > /* Enable receiving broadcast packets and transmitting packets */ > - pmask =3D ICE_PROMISC_BCAST_RX | ICE_PROMISC_BCAST_TX | > - ICE_PROMISC_UCAST_TX | > ICE_PROMISC_MCAST_TX; > - ret =3D ice_set_vsi_promisc(hw, vsi->idx, &pmask, 0); > + ice_set_bit(ICE_PROMISC_BCAST_RX, pmask); > + ice_set_bit(ICE_PROMISC_BCAST_TX, pmask); > + ice_set_bit(ICE_PROMISC_UCAST_TX, pmask); > + ice_set_bit(ICE_PROMISC_MCAST_TX, pmask); > + > + ret =3D ice_set_vsi_promisc(hw, vsi->idx, pmask, 0); > if (ret !=3D ICE_SUCCESS) > PMD_DRV_LOG(INFO, "fail to set vsi broadcast"); >=20 > @@ -5211,12 +5215,15 @@ ice_promisc_enable(struct rte_eth_dev *dev) > struct ice_hw *hw =3D ICE_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > struct ice_vsi *vsi =3D pf->main_vsi; > int status, ret =3D 0; > - ice_bitmap_t pmask; > + ice_declare_bitmap(pmask, ICE_PROMISC_MAX); > + ice_zero_bitmap(pmask, ICE_PROMISC_MAX); >=20 > - pmask =3D ICE_PROMISC_UCAST_RX | ICE_PROMISC_UCAST_TX | > - ICE_PROMISC_MCAST_RX | ICE_PROMISC_MCAST_TX; > + ice_set_bit(ICE_PROMISC_UCAST_RX, pmask); > + ice_set_bit(ICE_PROMISC_UCAST_TX, pmask); > + ice_set_bit(ICE_PROMISC_MCAST_RX, pmask); > + ice_set_bit(ICE_PROMISC_MCAST_TX, pmask); >=20 > - status =3D ice_set_vsi_promisc(hw, vsi->idx, &pmask, 0); > + status =3D ice_set_vsi_promisc(hw, vsi->idx, pmask, 0); > switch (status) { > case ICE_ERR_ALREADY_EXISTS: > PMD_DRV_LOG(DEBUG, "Promisc mode has already been > enabled"); > @@ -5237,15 +5244,21 @@ ice_promisc_disable(struct rte_eth_dev *dev) > struct ice_hw *hw =3D ICE_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > struct ice_vsi *vsi =3D pf->main_vsi; > int status, ret =3D 0; > - ice_bitmap_t pmask; > + ice_declare_bitmap(pmask, ICE_PROMISC_MAX); > + ice_zero_bitmap(pmask, ICE_PROMISC_MAX); >=20 > - if (dev->data->all_multicast =3D=3D 1) > - pmask =3D ICE_PROMISC_UCAST_RX | > ICE_PROMISC_UCAST_TX; > - else > - pmask =3D ICE_PROMISC_UCAST_RX | > ICE_PROMISC_UCAST_TX | > - ICE_PROMISC_MCAST_RX | > ICE_PROMISC_MCAST_TX; > + if (dev->data->all_multicast =3D=3D 1) { > + ice_set_bit(ICE_PROMISC_UCAST_RX, pmask); > + ice_set_bit(ICE_PROMISC_UCAST_TX, pmask); > + } > + else { > + ice_set_bit(ICE_PROMISC_UCAST_RX, pmask); > + ice_set_bit(ICE_PROMISC_UCAST_TX, pmask); > + ice_set_bit(ICE_PROMISC_MCAST_RX, pmask); > + ice_set_bit(ICE_PROMISC_MCAST_TX, pmask); > + } >=20 > - status =3D ice_clear_vsi_promisc(hw, vsi->idx, &pmask, 0); > + status =3D ice_clear_vsi_promisc(hw, vsi->idx, pmask, 0); > if (status !=3D ICE_SUCCESS) { > PMD_DRV_LOG(ERR, "Failed to clear promisc, err=3D%d", > status); > ret =3D -EAGAIN; > @@ -5261,11 +5274,13 @@ ice_allmulti_enable(struct rte_eth_dev *dev) > struct ice_hw *hw =3D ICE_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > struct ice_vsi *vsi =3D pf->main_vsi; > int status, ret =3D 0; > - ice_bitmap_t pmask; > + ice_declare_bitmap(pmask, ICE_PROMISC_MAX); > + ice_zero_bitmap(pmask, ICE_PROMISC_MAX); >=20 > - pmask =3D ICE_PROMISC_MCAST_RX | ICE_PROMISC_MCAST_TX; > + ice_set_bit(ICE_PROMISC_MCAST_RX, pmask); > + ice_set_bit(ICE_PROMISC_MCAST_TX, pmask); >=20 > - status =3D ice_set_vsi_promisc(hw, vsi->idx, &pmask, 0); > + status =3D ice_set_vsi_promisc(hw, vsi->idx, pmask, 0); >=20 > switch (status) { > case ICE_ERR_ALREADY_EXISTS: > @@ -5287,14 +5302,16 @@ ice_allmulti_disable(struct rte_eth_dev *dev) > struct ice_hw *hw =3D ICE_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > struct ice_vsi *vsi =3D pf->main_vsi; > int status, ret =3D 0; > - ice_bitmap_t pmask; > + ice_declare_bitmap(pmask, ICE_PROMISC_MAX); > + ice_zero_bitmap(pmask, ICE_PROMISC_MAX); >=20 > if (dev->data->promiscuous =3D=3D 1) > return 0; /* must remain in all_multicast mode */ >=20 > - pmask =3D ICE_PROMISC_MCAST_RX | ICE_PROMISC_MCAST_TX; > + ice_set_bit(ICE_PROMISC_MCAST_RX, pmask); > + ice_set_bit(ICE_PROMISC_MCAST_TX, pmask); >=20 > - status =3D ice_clear_vsi_promisc(hw, vsi->idx, &pmask, 0); > + status =3D ice_clear_vsi_promisc(hw, vsi->idx, pmask, 0); > if (status !=3D ICE_SUCCESS) { > PMD_DRV_LOG(ERR, "Failed to clear allmulti, err=3D%d", status); > ret =3D -EAGAIN; > -- > 2.34.1