From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id E9A18A059B;
Fri, 10 Apr 2020 11:43:24 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 60BBA1D517;
Fri, 10 Apr 2020 11:43:24 +0200 (CEST)
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
by dpdk.org (Postfix) with ESMTP id 9D4461D515
for <dev@dpdk.org>; Fri, 10 Apr 2020 11:43:22 +0200 (CEST)
IronPort-SDR: woonUbns+awZeVf9rpYogTquR0KUbtA1eKmOrxcvODlf5KeGQm7R6kEKylMbZwXO7PK6+CnWaC
MlBuWji9UOMA==
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga002.jf.intel.com ([10.7.209.21])
by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
10 Apr 2020 02:43:21 -0700
IronPort-SDR: c9fczIDOd63RTHA9jOWKOIAufjmCZiMHuMvk5ey5biXtOqi1WJDfGXHBvusQV/PoAqC194BC/W
Nfa+MHOopgWQ==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.72,366,1580803200"; d="scan'208";a="270355443"
Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133])
by orsmga002.jf.intel.com with ESMTP; 10 Apr 2020 02:43:21 -0700
Received: from orsmsx126.amr.corp.intel.com (10.22.240.126) by
ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS)
id 14.3.439.0; Fri, 10 Apr 2020 02:43:21 -0700
Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by
ORSMSX126.amr.corp.intel.com (10.22.240.126) with Microsoft SMTP Server (TLS)
id 14.3.439.0; Fri, 10 Apr 2020 02:43:21 -0700
Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.56) by
edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server
(TLS) id 14.3.439.0; Fri, 10 Apr 2020 02:43:21 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=PiZ5xxKE2ot1hJtZ7Y1eNWEes0g40+tVqQmsedBcrSlzZr5jFO4M8phEnNniEgeumnWtYutwjWGCh1zUrUPY6Z+Dg3Q49gPz80CPenV82pVZUSK48D0+DW/RdMyWJgtzwhxKc72WUXpPrYdpUsH5hwWXcDpAlWe1Hxkc4SAd97M7nRh+hq7yEsV5T3+w6thNoBzq+iIPcERUl6ZrI3NTELZH4S1hm3UEU8ZsXPwmYkokim/NZgzZkaBSjZAMQt44eV9IriQyTvuezUX3+gg6+ba+7um+cANiJTgqqw9569OZzAyj31T9Nu/nM4o5ClWxevePr8noXmQZqmu9ixag7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=DhLUbQO5ES97/yK+oSqm25LdMvKbsW2FJ79BR/7+KHM=;
b=CLQNgbH3A4n9VwAeq81zgg56f6KJdXdqYJyif6Ta2CVq4iZgCiwmwtDQ8oh8LE8E3f1K+UTyFu62Qab7doY/98n0icGjF28GIXkGSohGvPk7JkWvAgPFd0mWgUpKfR/XXK87HTPv+6WGneDSGJG6ed45Y+Ib4IR25BpnUZ0Lv0kcarpD7lzRRmnf4Hn7bvIOlUBrs0gvaGkjvpzAtU6sQwwmA5GYe/Ng6rDULQt9WkCS6SxEHqxA25PtZR0tEj1lDPyVK3eGmCgA4oR/1TAlEughybmVP6gY4p8hPmjOEQ1MaCkJ+e731RlkaiuBnQNqtlWgPhKLDZ1D9YwGgioU6A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=DhLUbQO5ES97/yK+oSqm25LdMvKbsW2FJ79BR/7+KHM=;
b=Hi3mD8LxegqBBAX373j67HdZx+PnlHRqLUN28/OJvF7voPoOezqMtnGyrOtJ8FeKVoKrdeThL9TIP84MFs7BBsVDAJ+kBoSDoIMgVZEvlhakH1XPPiEsANF8Bp7jsvbU57j96nWqI+jDSE/z9KIqFUefXEgu114wgg0v7F0bSFc=
Received: from MWHPR1101MB2111.namprd11.prod.outlook.com
(2603:10b6:301:4d::21) by MWHPR1101MB2255.namprd11.prod.outlook.com
(2603:10b6:301:5b::23) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.17; Fri, 10 Apr
2020 09:43:19 +0000
Received: from MWHPR1101MB2111.namprd11.prod.outlook.com
([fe80::2cae:f763:5d8d:fbce]) by MWHPR1101MB2111.namprd11.prod.outlook.com
([fe80::2cae:f763:5d8d:fbce%11]) with mapi id 15.20.2878.025; Fri, 10 Apr
2020 09:43:18 +0000
From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Power, Ciara" <ciara.power@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
"Laatz, Kevin" <kevin.laatz@intel.com>
CC: "jerinjacobk@gmail.com" <jerinjacobk@gmail.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>, "Wiles, Keith"
<keith.wiles@intel.com>, "mb@smartsharesystems.com"
<mb@smartsharesystems.com>, "thomas@monjalon.net" <thomas@monjalon.net>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Thread-Topic: [PATCH v2 09/16] usertools: add new telemetry python script
Thread-Index: AQHWDcht9eThJXsE5kCHjO1zYih1B6hyFROw
Date: Fri, 10 Apr 2020 09:43:18 +0000
Message-ID: <MWHPR1101MB211138B79A3E5127E7CCF939FFDE0@MWHPR1101MB2111.namprd11.prod.outlook.com>
References: <20200319171907.60891-1-ciara.power@intel.com>
<20200408164956.47864-1-ciara.power@intel.com>
<20200408164956.47864-10-ciara.power@intel.com>
In-Reply-To: <20200408164956.47864-10-ciara.power@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.2.0.6
authentication-results: spf=none (sender IP is )
smtp.mailfrom=reshma.pattan@intel.com;
x-originating-ip: [192.198.151.162]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 72edd5b6-2817-4c3a-2b27-08d7dd3399ce
x-ms-traffictypediagnostic: MWHPR1101MB2255:
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <MWHPR1101MB2255BBFE2A81E8358A4F984CFFDE0@MWHPR1101MB2255.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:4125;
x-forefront-prvs: 0369E8196C
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:MWHPR1101MB2111.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFTY:;
SFS:(10019020)(39860400002)(376002)(396003)(366004)(346002)(136003)(110136005)(5660300002)(71200400001)(2906002)(86362001)(107886003)(64756008)(52536014)(54906003)(6636002)(316002)(76116006)(66476007)(81156014)(66556008)(66946007)(9686003)(8676002)(55016002)(8936002)(6506007)(66446008)(478600001)(186003)(33656002)(26005)(7696005)(4326008);
DIR:OUT; SFP:1102;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: RpSb9R0jqgPIFyoAWIU5ymGxUih6ZaFMsX06f6VqQ3WbnYjmUNrtdhiVtVW59oHXpBYJcVSiTUiwA3wCbNfn+TvB6TseeB7yze03NtFdauC1jEsiCOY9eSsCvf8RXaa44LA77E8Rz+CjoA0Bjr4aiK2l19w+OnOzaD/HLffNN9SCeFi7VSBm3tCmWiDZNSy8+GJNJbOiBKSyrkU4xtI1G6/BTAYkNUC33DrDFkyApykSUBQfMzl0v1yU+YDfgkSXJYr1HiCStkvGW5BdYaHodT0D5PXaCUEGvyrVkhNhOVPdayEnMW7iPft5nwJlLRYbagE211MbO/lgxL2Klu771r5Dq1genJ+47amHNInSnpSSC0DTK6eI/43xnul89KKFAYNVEeR8SvXQK0GDWhtjrnT4K7X0M3t6NLJR4pM672Y3PnmiG7Svh3PNJhZAdNnv
x-ms-exchange-antispam-messagedata: sGy1eQ1w/jKa17dSOx0zGqMOHRb5PtYeWJhBZZdBCAqesFwOIhEjDB8FHTp6rBvZi2F8lfpvWoP4WW1WyT/VrEl9Bn3QWnszq+9rwbs1jtnDxL3PK9Oi88Qlh0l2tRfmWCYV/KL+W6IqeJk0DI28jA==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 72edd5b6-2817-4c3a-2b27-08d7dd3399ce
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2020 09:43:18.7091 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GmnTF4WXd28u48ygkolxJt9eQ6UhS//f2ziXoPNfWDxxjyfNo+DtdIMNNEYlyHouKsnxt+80kKM+xLymVAlqQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2255
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH v2 09/16] usertools: add new telemetry python
script
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
> -----Original Message-----
> From: Power, Ciara <ciara.power@intel.com>
Some pylint checks found, good to address valid ones.
#pylint-3.6 ./usertools/dpdk-telemetry.py or # pylint ./usertools/dpdk-tele=
metry.py
************* Module dpdk-telemetry
W: 18, 0: Bad indentation. Found 12 spaces, expected 8 (bad-indentation)
W: 19, 0: Bad indentation. Found 12 spaces, expected 8 (bad-indentation)
C: 30, 0: Unnecessary parens after 'while' keyword (superfluous-parens)
W: 41, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 44, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
C: 1, 0: Invalid module name "dpdk-telemetry" (invalid-name)
C: 1, 0: Missing module docstring (missing-docstring)
C: 10, 0: Invalid constant name "telemetry_version" (invalid-name)
C: 12, 0: Missing function docstring (missing-docstring)
C: 21, 0: Missing function docstring (missing-docstring)
C: 38, 0: Invalid constant name "fd" (invalid-name)
>+def read_socket(buf_len):
>+ return json.loads(reply)
Close the open fd?
>+ except:
>+ print("Error in reply: ", reply)
Close the open fd?
>+ raise
> +def handle_socket(path):
<snip>
> + fd.connect(path)
> + except OSError:
Good to add reason of error message.=20
Do you need to close the fd?
> + return