From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D435BA046B for ; Fri, 26 Jul 2019 23:15:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 371CA1C4C9; Fri, 26 Jul 2019 23:15:11 +0200 (CEST) Received: from rcdn-iport-1.cisco.com (rcdn-iport-1.cisco.com [173.37.86.72]) by dpdk.org (Postfix) with ESMTP id 3128F1C1BC for ; Fri, 26 Jul 2019 23:15:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3839; q=dns/txt; s=iport; t=1564175709; x=1565385309; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=B3lPQaV1eYH3yOOdqJ1tYiaX24sOouplkQvcZnon2s4=; b=WL7Lnr8Wr2jCREyTu+QYlDY1T4RmfGTks7wEdtNNQqexLjU/I9tKl3Zo kfemWRE2WBBUy9Eek1ae2XnooneXpP3UDltoEymFTNj8PGaJ39KADGFRl rsgQ2RhqW7px6Tb0sqndyoGE8tNwk8bZeQtgnIZ5OVFqJY7endrrKg706 s=; IronPort-PHdr: =?us-ascii?q?9a23=3AEXDXkBVoCzjRRR4t8aqzn2ukn4vV8LGuZFwc94?= =?us-ascii?q?YnhrRSc6+q45XlOgnF6O5wiEPSA9yJ8OpK3uzRta2oGXcN55qMqjgjSNRNTF?= =?us-ascii?q?dE7KdehAk8GIiAAEz/IuTtank4G8REWFZh8lmwMFNeH4D1YFiB6nA=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0B7AAD+bDtd/51dJa1mGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBZ4FEUANtVSAECyoKh1sDjH8ygimIHo81glIDVAkBAQE?= =?us-ascii?q?MAQEfDgIBAYRAAkwBBIIRIzgTAQMBAQQBAQIBBm2FHgyCKIMiAQEBAQMSKAY?= =?us-ascii?q?BATcBCwQCAQgRBAEBAR4QMh0IAgQBDQUIGoMBgWoDHQEOoFECgTiIYIIjgno?= =?us-ascii?q?BAQWBMgGDVBiCEwmBNIs5JheBQD+BV4JMPoRGgzuCJowFGooLhGePaAkCghq?= =?us-ascii?q?GWYhwhGKCXT6Uco03BIdKkAsCBAIEBQIOAQEFgWchgVhwFYMnCYI5g3GFFIU?= =?us-ascii?q?/coEpjCwBgSABAQ?= X-IronPort-AV: E=Sophos;i="5.64,312,1559520000"; d="scan'208";a="603124961" Received: from rcdn-core-6.cisco.com ([173.37.93.157]) by rcdn-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 26 Jul 2019 21:15:07 +0000 Received: from XCH-RCD-001.cisco.com (xch-rcd-001.cisco.com [173.37.102.11]) by rcdn-core-6.cisco.com (8.15.2/8.15.2) with ESMTPS id x6QLF7UR019663 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 26 Jul 2019 21:15:07 GMT Received: from xhs-rcd-003.cisco.com (173.37.227.248) by XCH-RCD-001.cisco.com (173.37.102.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 26 Jul 2019 16:15:06 -0500 Received: from xhs-aln-003.cisco.com (173.37.135.120) by xhs-rcd-003.cisco.com (173.37.227.248) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 26 Jul 2019 16:15:06 -0500 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-003.cisco.com (173.37.135.120) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 26 Jul 2019 16:15:06 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mzfMs00b55O0s8MU1zRjW4FujQ4PTJxsYAcnIbB4lwx23YCDzJPT9XbIIe2n62kp3LeHHRNDpGyajqJaB3hmP9pDKGm8fuv3co0SZXCBEcjrO/xf5FXwGdKKKnGaZNZ1oXZ3en4NVZpUmeY3lgTgVuz1y88zziQQqWMmG+DGakwQQHo+KveRpUmlTYH0Qws2Qlyc7xM6OofI4kwomfFXKCcqQIuanpkGXfLIFwVhkEKRKFD5WoJgEEBt0Oc4rEICtmExO5KHvysmVJJCZULCxgXseCjHvq6ZjI4R5BzPn5jquKPM9vIqbZbwEWTYq7LsBVd4FudFElmrrjHiDHfvNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B3lPQaV1eYH3yOOdqJ1tYiaX24sOouplkQvcZnon2s4=; b=FnYY+5MfwAOVnjZlPYVfNiv8YB21RNPP3iIyKwceXOal/y/V2R9BGMvASLxdNmgf1LqU9fTzjldXZ/J8rXiLKaW7cjDik9d/TGkB+EeZR3WLqMgTUrB2XH+fVbaKjJVshmTYp+ahM7zwJAkDEhxmsfCXpDMQWEMKgaH9wsUFXvdJ6HOz0kwcGD80pVdK/4/v+vKdSosJNwzpMkRIXi6trg/AU8EU6SePIo9bTkqgmzo4i5Qm+QEbEqRe3QXSkSAzgEW0u6b9ep/KMnLp2Anw89OBOrgjaIQIriv2TYqrvaKA1EPVLhrd1kOLpM3e9mRML7QR2/dWvAsGxW8wGvStmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=cisco.com;dmarc=pass action=none header.from=cisco.com;dkim=pass header.d=cisco.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B3lPQaV1eYH3yOOdqJ1tYiaX24sOouplkQvcZnon2s4=; b=b+L6MlWFXcYJn4PSHXROQWFS/T85m1hSDx/xS8bTf8kBgOHcUY1wVy0jfpYaWAwrlGRhNmV/EjpMpoHQOuiBG6yBMESpI10UprLhBwYOjE9WMS+feyd/j0DSrJE3r3dHgFkjgcmY2o2dAAwd7FTlfgUbX8f2MFbOCTyJosaqZxA= Received: from MWHPR1101MB2143.namprd11.prod.outlook.com (10.174.255.136) by MWHPR1101MB2365.namprd11.prod.outlook.com (10.173.50.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.10; Fri, 26 Jul 2019 21:15:05 +0000 Received: from MWHPR1101MB2143.namprd11.prod.outlook.com ([fe80::2ce2:d671:1285:4b3b]) by MWHPR1101MB2143.namprd11.prod.outlook.com ([fe80::2ce2:d671:1285:4b3b%3]) with mapi id 15.20.2094.013; Fri, 26 Jul 2019 21:15:05 +0000 From: "John Daley (johndale)" To: Stephen Hemminger , "Hyong Youb Kim (hyonkim)" CC: Ferruh Yigit , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/enic: retain previous message logging Thread-Index: AQHVQpM2VSXicQB1h0iPoP2Hh7aMf6bbHFaAgACoNtCAAIl3gIABFGwAgAAF9sA= Date: Fri, 26 Jul 2019 21:15:05 +0000 Message-ID: References: <20190725024619.26040-1-johndale@cisco.com> <4fe558a6-b2b5-0401-ac0b-6ca45f0389f9@intel.com> <20190726135044.287956ae@hermes.lan> In-Reply-To: <20190726135044.287956ae@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=johndale@cisco.com; x-originating-ip: [98.151.71.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4373e92d-301d-4be2-16cf-08d7120e5487 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MWHPR1101MB2365; x-ms-traffictypediagnostic: MWHPR1101MB2365: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 01106E96F6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(366004)(376002)(39860400002)(136003)(346002)(31014005)(199004)(13464003)(189003)(26005)(316002)(186003)(86362001)(55016002)(11346002)(6506007)(486006)(8936002)(966005)(14454004)(52536014)(6636002)(54906003)(7696005)(9686003)(102836004)(6306002)(53546011)(76176011)(476003)(66066001)(446003)(99286004)(229853002)(6436002)(64756008)(71190400001)(74316002)(15650500001)(7736002)(53936002)(66446008)(68736007)(71200400001)(3846002)(33656002)(2906002)(81156014)(14444005)(256004)(8676002)(81166006)(2420400007)(7110500001)(6116002)(5660300002)(66476007)(66556008)(6246003)(4326008)(305945005)(66946007)(76116006)(110136005)(25786009)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR1101MB2365; H:MWHPR1101MB2143.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ULOEsxiB1szxo/80yDSkyHqDeWeDqo0/C3wpVShbWZ2CbGk9WRnD4NwOvS27j/xQywMPYR4x764thl/4DYkIPoHUVcqJZWp2a8yoqcIFw5h+fuq+rrg0TcDsXHNV7ti9lwU6I5hB4BOa9tD8VNSMb9ouCym1n+gMEV5OlTs4GMSiA7CsH9mIclPMNhpGs/PVIMYT2BiK586MBnuVjNe6rNwZmwHZtVL5ja+puPCp25VMvrFwoIwPZGZN9JPltJSWYgd/C95mtgz+kLFo2ZCD/63PkPs6n9crKoYekXeWO+2iXZjglLmLEd1SyNeLwoVM5nfOGYVvtIMpzQdMbtK5b9mej2zGOAfvGrZuMBaQjoAzgxeoyLt/DlVxQz2d9lLKmSHsc7md3m6My5LtBaK7W8BE/a1y8YyTHI1fUx2YqoI= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 4373e92d-301d-4be2-16cf-08d7120e5487 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2019 21:15:05.1644 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: johndale@cisco.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2365 X-OriginatorOrg: cisco.com X-Outbound-SMTP-Client: 173.37.102.11, xch-rcd-001.cisco.com X-Outbound-Node: rcdn-core-6.cisco.com Subject: Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Stephen Hemminger > Sent: Friday, July 26, 2019 1:51 PM > To: Hyong Youb Kim (hyonkim) > Cc: John Daley (johndale) ; Ferruh Yigit > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging >=20 > On Fri, 26 Jul 2019 04:21:23 +0000 > "Hyong Youb Kim (hyonkim)" wrote: >=20 > > > -----Original Message----- > > > From: John Daley (johndale) > > > Sent: Friday, July 26, 2019 5:26 AM > > > To: Ferruh Yigit > > > Cc: dev@dpdk.org; Hyong Youb Kim (hyonkim) > > > Subject: RE: [PATCH] net/enic: retain previous message logging > > > > > > Ok, lets NAK this patch. See comment inline. > > > Thanks, > > > John > > > > > [...] > > > > On 7/25/2019 3:46 AM, John Daley wrote: > > > > > Prior to fix, RTE_LOGTYPE_INFO messages would display in testpmd > > > > > by default. After the fix, using dynamic logging, only NOTICE > > > > > level and higher were displayed by default and INFO level were > > > > > not. Change the messages to NOTICE level so they continue to disp= lay. > > > > > > > > > > DTS uses testpmd and parses messages and some tests failed > > > > > because messages were no longer displayed. Other apps may also > > > > > depend on the messages. > > > > > > > > If you need messages for the test framework, why not just increase > > > > the log level for enic PMD via application parameter [1], or as > > > > command to testpmd[2]? > > > > Since it is dynamic debug now, you don't need to change the > > > > default, can change the level on demand. > > > > > > I have no problem modifying our test scripts. The bigger concern was > > > about any other scripts out there that might break because the > > > default enic PMD messages changed. I suppose chances are slim and > > > any such scripts can easily be modified to set the log level to info. > > > > > > > Hi John, Ferruh, > > > > Can you guys reconsider? John's commit message makes it sound like he > > is modifying PMD to avoid modifying test scripts. That is not the > > issue at all. The real problem is that his previous commit causes a > > customer visible change, which can lead to a lot of headache for both > > us (doing tech support) and customers (wondering what's changed). > > > > Prior to commit bbd8ecc05434 ("net/enic: remove PMD log type > references"): > > > > enic prints vNIC config related messages (rq/cq/wq info and such) via > > dev_info(). And, dev_info() uses LOGTYPE_PMD and the INFO level. > > LOGTYPE_PMD defaults to the INFO level, so these messages appear by > > default. Customers and tech support use them for debugging and so on. > > > > After the commit: > > > > dev_info() is now enic_pmd_logtype, which defaults to NOTICE. The > > macro is still using the INFO level. So, config messages are > > suppressed by default. This was never the intention. The current patch > > tries to fix that by elevating dev_info to dev_notice, because we do > > want these messages to appear by default. Should have done it as part > > of the previous commit, but we missed it. > > > > Down the line, we will have to guide our customers to exploit dynamic > > log levels, but not this way (i.e. suddenly hiding messages that they > > used to see/rely on). > > > > Thanks a lot. > > -Hyong > > >=20 > Drivers should be silent unless they see a problem. > We don't want every driver outputting messages by default. >=20 > For your current issue, why not just register the default log level as in= fo? Yes, that is better and what Ferruh suggested also. It is what the v2 patch= is: http://patches.dpdk.org/patch/57199/. Thanks, John