From: "John Daley (johndale)" <johndale@cisco.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Hyong Youb Kim (hyonkim)" <hyonkim@cisco.com>
Subject: Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging
Date: Thu, 25 Jul 2019 20:25:45 +0000 [thread overview]
Message-ID: <MWHPR1101MB2143F10836A3C493365FEED8CFC10@MWHPR1101MB2143.namprd11.prod.outlook.com> (raw)
In-Reply-To: <4fe558a6-b2b5-0401-ac0b-6ca45f0389f9@intel.com>
Ok, lets NAK this patch. See comment inline.
Thanks,
John
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Thursday, July 25, 2019 3:07 AM
> To: John Daley (johndale) <johndale@cisco.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH] net/enic: retain previous message logging
>
> On 7/25/2019 3:46 AM, John Daley wrote:
> > Prior to fix, RTE_LOGTYPE_INFO messages would display in testpmd by
> > default. After the fix, using dynamic logging, only NOTICE level and
> > higher were displayed by default and INFO level were not. Change the
> > messages to NOTICE level so they continue to display.
> >
> > DTS uses testpmd and parses messages and some tests failed because
> > messages were no longer displayed. Other apps may also depend on the
> > messages.
>
> If you need messages for the test framework, why not just increase the log
> level for enic PMD via application parameter [1], or as command to
> testpmd[2]?
> Since it is dynamic debug now, you don't need to change the default, can
> change the level on demand.
I have no problem modifying our test scripts. The bigger concern was about any other scripts out there that might break because the default enic PMD messages changed. I suppose chances are slim and any such scripts can easily be modified to set the log level to info.
>
> [1]
> starting testpmd with following option should do it:
> --log-level=pmd.net.enic.*:info
>
> testpmd --log-level=pmd.net.enic.*:info -- -i
>
>
> [2]
> after testpmd started, can change the debug level:
> testpmd> set log pmd.net.enic 7
>
>
> [3] bonus, see current log levels
> testpmd> dump_log_types
Nice! I didn't know about this.
>
>
>
> >
> > Fixes: bbd8ecc05434 ("net/enic: remove PMD log type references")
> >
> > Signed-off-by: John Daley <johndale@cisco.com>
>
> <...>
next prev parent reply other threads:[~2019-07-25 20:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 2:46 John Daley
2019-07-25 10:07 ` Ferruh Yigit
2019-07-25 20:25 ` John Daley (johndale) [this message]
2019-07-26 4:21 ` Hyong Youb Kim (hyonkim)
2019-07-26 9:51 ` Ferruh Yigit
2019-07-26 20:50 ` Stephen Hemminger
2019-07-26 21:15 ` John Daley (johndale)
2019-07-26 8:17 ` John Daley (johndale)
2019-07-26 10:00 ` Ferruh Yigit
2019-07-26 20:06 ` John Daley (johndale)
2019-07-26 20:12 ` [dpdk-dev] [PATCH v2] " John Daley
2019-07-29 11:03 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR1101MB2143F10836A3C493365FEED8CFC10@MWHPR1101MB2143.namprd11.prod.outlook.com \
--to=johndale@cisco.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hyonkim@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).