From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FBB4A0567; Tue, 10 Mar 2020 13:44:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4C2A71BF7F; Tue, 10 Mar 2020 13:44:35 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id B64F42BE6; Tue, 10 Mar 2020 13:44:32 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Mar 2020 05:44:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,537,1574150400"; d="scan'208";a="353617688" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 10 Mar 2020 05:44:29 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 10 Mar 2020 05:44:27 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 10 Mar 2020 05:44:26 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 10 Mar 2020 05:44:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ffnvN/F09W/Q38gy8oe+CS85yDWhfo42807YX0Qe0Uw/d2gUf8dVMTvVOdZm613NQwLh4XHDihJiQO+Jl7xP1LJ5fZsj7ZrTPBJSRBNWD9DvM4a7moPRmhPQyJKUvFCOZHBGZdL8B++df5WZQsUaLGTGt2uMFWUfO+TqCBGaksmntM/jpQcdr++kKilBKmvAKNtOZdoYTUjbz9sx7Ti1pYIg3YuiowqUcco7jm7m1L3dcGEPNsr9C0QWlc0PggGJr33+GfXTjFsO4R6xJX+i7vX2FrO51zq7cHr+csJKUdkMplI6sTq96klvXczggyJUQNv4biFj1FQBLBtVf09N+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1MWcsbOfcQYaPhWx0iOLSJ8+4ZaFB2cLq9/s9i3LDYU=; b=YP9g6mJu3BIBAuYmA92juiB+krnqsN709i8fiIWfvO+2VoL0u89r/FLVTSrNEvo5zZEFVOpE2d7FFdkjSUnwFSv0SZibuR39zwjL2tKRYKOtqHtya7J52MPhGdD5Y16+qRToOnJMcKU0BHLYGf3XhCDpFfnYqjffqtl95vwVjFIckWOrVu9QYD3LRHI9HR2JdxWlwE46PwPwbTVaOTX49qweUV5A7w3mBM864qiqw2ke2cIkGwxFoRsB/cJm+XuBHWD9D6YPiuSINNuATglVegObHXvG7S7rCvncjcixfMOiNt/1owDTrg7+mkfqG651cIZ+i+lFjq/QHx9UBf2mjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1MWcsbOfcQYaPhWx0iOLSJ8+4ZaFB2cLq9/s9i3LDYU=; b=DC92zgLV7D6/QubI+ptIJCKn8Xj8A3NDcQbHkqeYBzNkAnJSc8Eg7e7/Jfrp5iZX3nMNRKyD9oc8BGCuJAErFV3GYxGoMJNu75JiHWt1KSuYnHFMP0rhx+nm2uRvY8/x6uF95WL61h4DC2XdwWkUvV9yQIDm66QjXwmiBCOrFUU= Received: from MWHPR1101MB2157.namprd11.prod.outlook.com (2603:10b6:301:51::10) by MWHPR1101MB2192.namprd11.prod.outlook.com (2603:10b6:301:59::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.17; Tue, 10 Mar 2020 12:44:24 +0000 Received: from MWHPR1101MB2157.namprd11.prod.outlook.com ([fe80::7d16:3f1d:52c9:3116]) by MWHPR1101MB2157.namprd11.prod.outlook.com ([fe80::7d16:3f1d:52c9:3116%5]) with mapi id 15.20.2793.013; Tue, 10 Mar 2020 12:44:24 +0000 From: "Van Haaren, Harry" To: "Ye, Xiaolong" , Itsuro Oda CC: "dev@dpdk.org" , "maxime.coquelin@redhat.com" , "Wang, Zhihong" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] vhost: make iotlb cache name unique among multi processes Thread-Index: AQHV9tABdIqvncUtrUSJztdFcK5F7KhBxPjw Date: Tue, 10 Mar 2020 12:44:24 +0000 Message-ID: References: <20200310050003.16728-1-oda@valinux.co.jp> <20200310113206.GA14733@intel.com> In-Reply-To: <20200310113206.GA14733@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=harry.van.haaren@intel.com; x-originating-ip: [192.198.151.169] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 709c7438-b923-47e6-7d42-08d7c4f0c35d x-ms-traffictypediagnostic: MWHPR1101MB2192: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3044; x-forefront-prvs: 033857D0BD x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(396003)(346002)(376002)(39860400002)(136003)(189003)(199004)(316002)(4326008)(8936002)(53546011)(6506007)(186003)(33656002)(7696005)(110136005)(26005)(54906003)(52536014)(5660300002)(2906002)(76116006)(478600001)(71200400001)(9686003)(66446008)(66556008)(66476007)(64756008)(66946007)(81156014)(86362001)(55016002)(81166006); DIR:OUT; SFP:1102; SCL:1; SRVR:MWHPR1101MB2192; H:MWHPR1101MB2157.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3lVK0dfwBLSKLxrYZGXQglTBxccIjj8Ghx/IjXBMMuU7GciNCIc+FuVDgVXZlRw6kWJz0xav5RuqTbN6/sl3ZBUaFabEX4BDWSgfaewa4VivNxyzbtApNGLGMJ1Tipr/ZVhfETLB8DxF4IZ1UllruzHs4btvC2FhCpfiWsNIpFXrgoHpVRP9KFTyW69i0+rgml+C3EWyiAGRE0tVIVCWRPWJgOQkjVUZv37MlYQIZZY4gsaf2043aWOa1UJoRZgPbGIOdRcOCfi35Cslm5dS0ZWz8QlzUYDSaCFv7e2hirmGIk+9Q3E8/xTJSIZCKD69VuO4m/8w2FeBEuODYj+RdYl2GFAHyW5ZarwMhgUmPWDDi1IwHGDBPelKQw7iGtimBmmpjcIW2/MIR48zDab9CvOI6y38zMYAusfC+wx3aVL2gru3UYT4c5GehQTnDxvR x-ms-exchange-antispam-messagedata: cdLkvK7GMFW4bcCU3/ZlTgZLk1jYsW/8AFQ8KMPbTfu8DfnKbBCMj7Xd9vVTtTmhlqfAq0LUJHyO2+pbOPD+rxE2ZulEr6HtN1iNKVG3arQUicyAdv3tYqYStnlUxud+WSD4cNQOvXuGpHvqSzw8rQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 709c7438-b923-47e6-7d42-08d7c4f0c35d X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Mar 2020 12:44:24.2324 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yYTzxqgxcGX88tESLv8xkVCjgc6wCAkGjbfvi19ztPXVBnmpIjPSiqkJr6VhOCFtvWc4VdhgEvnHylKWpMG/dBrEMhpR8b6QAmn+WNvqRno= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2192 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] vhost: make iotlb cache name unique among multi processes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Ye Xiaolong > Sent: Tuesday, March 10, 2020 11:32 AM > To: Itsuro Oda > Cc: dev@dpdk.org; maxime.coquelin@redhat.com; Wang, Zhihong > ; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] vhost: make iotlb cache name unique among > multi processes >=20 > On 03/10, Itsuro Oda wrote: > >Currently, iotlb cache name is comprised of vid and virtqueue > >index. For example, "iotlb_cache_0_0". Because vid is assigned > >per process, iotlb cache name is not unique among multi processes. > >For example a secondary process uses a vhost > >(ex. eth_vhost0,iface=3D/tmp/sock0) and another secondary process > >uses a vhost (ex. eth_vhost1,iface=3D/tmp/sock1), iotlb cache > >name of both vhost ("iotlb_cache_0_0") are same and as a result > >iotlb cache is broken. > > > >This patch makes iotlb cache name unique among milti processes > >by using the interface name not vid to comprise iotlb cache name. > >Since the length of interface name is variable, this patch uses > >hash value calculated by the interface name. > > > >Fixes: d012d1f293f4 (vhost: add IOTLB helper functions) > >Cc: stable@dpdk.org > > > >Signed-off-by: Itsuro Oda > >--- > > lib/librte_vhost/iotlb.c | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > >diff --git a/lib/librte_vhost/iotlb.c b/lib/librte_vhost/iotlb.c > >index bc1758528..0992c145b 100644 > >--- a/lib/librte_vhost/iotlb.c > >+++ b/lib/librte_vhost/iotlb.c > >@@ -6,6 +6,7 @@ > > #include > > #endif > > > >+#include > > #include > > > > #include "iotlb.h" > >@@ -288,6 +289,7 @@ vhost_user_iotlb_init(struct virtio_net *dev, int > vq_index) > > char pool_name[RTE_MEMPOOL_NAMESIZE]; > > struct vhost_virtqueue *vq =3D dev->virtqueue[vq_index]; > > int socket =3D 0; > >+ uint32_t val; > > > > if (vq->iotlb_pool) { > > /* > >@@ -308,8 +310,10 @@ vhost_user_iotlb_init(struct virtio_net *dev, int > vq_index) > > TAILQ_INIT(&vq->iotlb_list); > > TAILQ_INIT(&vq->iotlb_pending_list); > > > >- snprintf(pool_name, sizeof(pool_name), "iotlb_cache_%d_%d", > >- dev->vid, vq_index); > >+ val =3D rte_jhash(dev->ifname, strlen(dev->ifname), 0); > >+ snprintf(pool_name, sizeof(pool_name), "iotlb_cache_%08x_%d", > >+ val, vq_index); > >+ VHOST_LOG_CONFIG(DEBUG, "IOTLB cache name: %s\n", pool_name); Although very unlikely, what would happen if there is a hash-collision? For example imagine two different names hash to the same "val", from my understanding they will now use the same IOTLB but should not share one.