From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Ye, Xiaolong" <xiaolong.ye@intel.com>,
"Kovacevic, Marko" <marko.kovacevic@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH v4] doc: introduce openwrt how-to guide
Date: Fri, 17 Jan 2020 13:46:26 +0000 [thread overview]
Message-ID: <MWHPR1101MB2158BEADC075D5051D783D61FC310@MWHPR1101MB2158.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20191216030109.99125-1-xiaolong.ye@intel.com>
Hi,
Overall looks good. Some notes below:
> +
> +.. note::
> +
> + For compiling the NUMA lib, run libtool --version to ensure the
> +libtool version >= 2.2, otherwise the compilation will fail with errors.
This continuation line isn't indented and raised a build error:
$ make doc-guides-html
sphinx processing guides-html...
/work/dpdk_docs/doc/guides/howto/openwrt.rst:80: WARNING:
Explicit markup ends without a blank line; unexpected unindent.
Also you should used spaces not tabs for indentation in the docs.
> +If you are using Windows PC, you can use some free and opensource raw
> +disk image writer program such as
> +``Win32 Disk Imager`` and ``Etcher`` to write OpenWrt image
> +(openwrt-x86-64-combined-ext4.img) to a USB flash driver or USB SDcard
> with SDcard or a Sata hard drivre or SSD from your PC.
Typo: drive
I'll send you a few other suggested minor corrections.
John
next prev parent reply other threads:[~2020-01-17 13:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 8:19 [dpdk-dev] [PATCH] " Xiaolong Ye
2019-11-29 10:09 ` Bruce Richardson
2019-11-29 15:03 ` Ye Xiaolong
2019-11-29 16:59 ` Stephen Hemminger
2019-12-01 11:30 ` Ye Xiaolong
2019-12-02 6:34 ` [dpdk-dev] [PATCH v2] " Xiaolong Ye
2019-12-02 7:31 ` Jerin Jacob
2019-12-02 8:09 ` Ye Xiaolong
2019-12-12 2:25 ` [dpdk-dev] [PATCH v3] " Xiaolong Ye
2019-12-16 3:01 ` [dpdk-dev] [PATCH v4] " Xiaolong Ye
2019-12-19 6:05 ` Zhang, Xiao
2020-01-17 13:46 ` Mcnamara, John [this message]
2020-01-18 1:52 ` Ye Xiaolong
2020-01-18 5:48 ` [dpdk-dev] [PATCH v5] " Xiaolong Ye
2020-01-22 12:34 ` Mcnamara, John
2020-02-16 11:04 ` Thomas Monjalon
2020-02-16 17:29 ` Ye Xiaolong
2020-02-16 18:02 ` Thomas Monjalon
2020-02-17 1:18 ` Ye Xiaolong
2020-02-17 3:12 ` Dmitry Kozlyuk
2020-02-17 6:21 ` Ye Xiaolong
2020-02-17 2:47 ` [dpdk-dev] [PATCH v6] " Xiaolong Ye
2020-02-17 15:08 ` Ray Kinsella
2020-02-17 15:44 ` Ye Xiaolong
2020-02-17 15:49 ` Ray Kinsella
2020-02-18 8:26 ` Mcnamara, John
2020-02-18 9:12 ` Ray Kinsella
2020-02-18 9:32 ` Thomas Monjalon
2020-02-18 9:49 ` Ye Xiaolong
2020-02-18 10:08 ` Ray Kinsella
2020-02-21 21:08 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR1101MB2158BEADC075D5051D783D61FC310@MWHPR1101MB2158.namprd11.prod.outlook.com \
--to=john.mcnamara@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=marko.kovacevic@intel.com \
--cc=stephen@networkplumber.org \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).