From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 624B8A051A; Fri, 17 Jan 2020 14:46:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6120F2904; Fri, 17 Jan 2020 14:46:56 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 031381AFF for ; Fri, 17 Jan 2020 14:46:54 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2020 05:46:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,330,1574150400"; d="scan'208";a="220046271" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by fmsmga007.fm.intel.com with ESMTP; 17 Jan 2020 05:46:31 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Jan 2020 05:46:30 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 17 Jan 2020 05:46:30 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 17 Jan 2020 05:46:30 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Jan 2020 05:46:30 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kWnLFrwuAHu5SI8MOARn9bQlALe4RZgn1xHGiYSjLL+8D4SBBWna7FINRt+XjdsPOmXRLxwxRE9ILljulG2x7KIDBrKJFwKhiLQYfeo0T+Fp/B7LXm9mwUv0wEHYTW/3rqPleRZPNuFNIuScznellbC9lf2WY7W9hT2zm8XrgiO0KhLMamUuxAi66jCHcv3OIjrljFZKIUPNQEiU5ISWg5yOS/oxK6i6mCQV11xwg+584bAmcdNUc5EyUo+V3OFlPC9umXAVQBx3fBddHOtOfSSn0YCvorXLZkLTlTf4WW76zmbKvyB6w7DXnRC3yneYveMlVhrys+mPZnNJur39BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DBtaDHN92Jc1bXCFQfUUsu94t27aMa3zSuabLiI5BoM=; b=Yxtf0CEUca+LJUsfTOGJaT8WaNTSXggTeqVSsT4iIe17TT+kRwLbDWCo5elbmblSJ5zflz6iYoZTw/980M3XvV7Iag//a/2uHKrOc4mpxjdTY2dN6PP3be5LzD1+bIUaXOBPzcdMhxfznsyHFga1ihMeBEsqNvKjgSh/nehKr9hzi3NzSEiPlCZK911mCXuBdskDqFh647LmLEigxDlismzeA5jmh1AjJLsNijegHON8yqWVkvx+d6roLCxx7I7kU38cLe5vqddhdo/uMnx5JvgonycfPTOTyAzpxdX2QAQUQHjk7dxz8UtzP9OSWmjmfVSMsSj3nxKQzft5Nczxvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DBtaDHN92Jc1bXCFQfUUsu94t27aMa3zSuabLiI5BoM=; b=tkZZiAgSgsUWx2iBM//VSgw1hjm7FdemqpOvrM2W7lA6WgN1AMZjuE6dwXdrnMn0EhNvDmnFZIZtpDxZ+ITvY+HSfOjUv2iNmsh4rnoJ9Pvk93RYZgX4i60eByYvEr7jfrRSi4zS4/aUqboUSmZc8AIkJIs+Sh/9Y7viAqiucNU= Received: from MWHPR1101MB2158.namprd11.prod.outlook.com (10.174.100.145) by MWHPR1101MB2303.namprd11.prod.outlook.com (10.174.101.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.20; Fri, 17 Jan 2020 13:46:26 +0000 Received: from MWHPR1101MB2158.namprd11.prod.outlook.com ([fe80::1084:b8f3:ed73:4d59]) by MWHPR1101MB2158.namprd11.prod.outlook.com ([fe80::1084:b8f3:ed73:4d59%8]) with mapi id 15.20.2623.018; Fri, 17 Jan 2020 13:46:26 +0000 From: "Mcnamara, John" To: "Ye, Xiaolong" , "Kovacevic, Marko" CC: "dev@dpdk.org" , "Richardson, Bruce" , Stephen Hemminger Thread-Topic: [PATCH v4] doc: introduce openwrt how-to guide Thread-Index: AQHVs73GVkOuI/tppkmOmoR70grlAafvEJeA Date: Fri, 17 Jan 2020 13:46:26 +0000 Message-ID: References: <20191129081911.92988-1-xiaolong.ye@intel.com> <20191216030109.99125-1-xiaolong.ye@intel.com> In-Reply-To: <20191216030109.99125-1-xiaolong.ye@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2MxZDI1Y2YtNDlmYy00M2IwLTkwMGMtYTgwNjk2Mzc3ZjI0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWWV1Sk5uc3Q1YWdmUVUxeE5veWw2Vzg1enhcL2U2bDZKWXNSMkRLZlRibG1QajVjWUI1K0hCT3U1bHFVSkFRTzgifQ== dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=john.mcnamara@intel.com; x-originating-ip: [134.134.136.220] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 776472f3-d9ce-4cb1-97a7-08d79b53a600 x-ms-traffictypediagnostic: MWHPR1101MB2303: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-forefront-prvs: 0285201563 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(199004)(189003)(66946007)(5660300002)(76116006)(64756008)(66446008)(66476007)(4744005)(8936002)(66556008)(7696005)(81156014)(81166006)(86362001)(8676002)(6506007)(55016002)(9686003)(2906002)(498600001)(6636002)(71200400001)(26005)(52536014)(54906003)(4326008)(33656002)(110136005)(186003); DIR:OUT; SFP:1102; SCL:1; SRVR:MWHPR1101MB2303; H:MWHPR1101MB2158.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IC2hpEDHbkNcQFn5ksYbzbadP+/pTFx/8289pfNLotiPn75/8camKiauGLgpMmYqzF3h0ajIhoRCh1czr0Zy3M687Ca45xMnoaOhVp053KuK+0IrxC8B6iPPulkkHG0K6S+30U7O5r/3EhVV9NLXEllht9ElZJ6MBNXCnrZpYJyD+80tdoXiBm2gM5ZJwbIFYtjZah0/nnCUDMuVJqZU90+DrUXlEPvZ6M9xKsnUXRNhkWscXTjf9HrFA7vfjyFYddMf4S4IiqphasmTIxm6zfVICc0Hi0tO2zHi64syN2g+fqys5GENEkWVXVxW5CEOcZ3cjNBkMdi/5/2w/lg8NdCdthCZBSv/NGXG1TFUsfUBkVN8DBWI3o9jX/pdH1HE0uThY+/XIblWIzS1SlCDVrjxhq+QqRZL9WHGyM03yoFNQMGBb7R5OlKLoeMHb8YG Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 776472f3-d9ce-4cb1-97a7-08d79b53a600 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2020 13:46:26.4242 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Qdr+hDZt+TmRCAJBRvxTARVmTgu2CBcvrgWH7VQZpzCyCU03QT1Hmb56sLb6q0IrNiKJvSLJpRYrBu7ZBMMJzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2303 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4] doc: introduce openwrt how-to guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Overall looks good. Some notes below: > + > +.. note:: > + > + For compiling the NUMA lib, run libtool --version to ensure the > +libtool version >=3D 2.2, otherwise the compilation will fail with error= s. This continuation line isn't indented and raised a build error: $ make doc-guides-html =20 sphinx processing guides-html... /work/dpdk_docs/doc/guides/howto/openwrt.rst:80: WARNING:=20 Explicit markup ends without a blank line; unexpected unindent. Also you should used spaces not tabs for indentation in the docs. > +If you are using Windows PC, you can use some free and opensource raw > +disk image writer program such as > +``Win32 Disk Imager`` and ``Etcher`` to write OpenWrt image > +(openwrt-x86-64-combined-ext4.img) to a USB flash driver or USB SDcard > with SDcard or a Sata hard drivre or SSD from your PC. Typo: drive I'll send you a few other suggested minor corrections. John