From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E47E8A0524; Tue, 13 Apr 2021 08:30:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A75EC160B7F; Tue, 13 Apr 2021 08:30:16 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 5BC4C160B77 for ; Tue, 13 Apr 2021 08:30:14 +0200 (CEST) IronPort-SDR: EXh4uU99mm5cDYzdPBW9rPT1kE9yom9B927SW8HDCCJiiUHgm38PalOukqxQhqT4qJIwoYMUMA ECOB7ZmlinaQ== X-IronPort-AV: E=McAfee;i="6200,9189,9952"; a="255676232" X-IronPort-AV: E=Sophos;i="5.82,218,1613462400"; d="scan'208";a="255676232" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2021 23:30:11 -0700 IronPort-SDR: jZ3WX8SHv3aRddM2nC0pqemyVjncM0FADZnHgV2PGjrDnujb9sE/R55iCPDgxJAA8Vh6tBTPYJ NgLiZSO1r1pA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,218,1613462400"; d="scan'208";a="451820963" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 12 Apr 2021 23:30:11 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 12 Apr 2021 23:30:11 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 12 Apr 2021 23:30:10 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 12 Apr 2021 23:30:10 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 12 Apr 2021 23:30:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TRwlRsxRSsBI76iLmYIcXy5tHddDA4DLnZgZb1G+NwkdC/SmrHlf9zHDAbePSnPx3Unfmyldy9s5q9OXL+Ze5zup7rAU6BXRkRAqvELlVDdYjpWr2WoTRZCA8ciW4nkntSTJ6L+IaW/4BeyyN+pPAiG7xRtZwRTwRRkdAY/FXKyrbl06XP5yG8FJb3FuNuF90Fv5MsjikWjE6HAbQKVPowUIZsQxp8FyuIlefkv2nplUQdOIN3jCbWFtIbL/RRYbWwhU6OWJHE+o6zrqE0q31GOHcbkKFYce/Q6Lzj2zSyNEbcI8nUzkhB1hNHk1lnpLyPvKkwXtDyIibjEDL7CY+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zXXXCKnNehkyD1wOfFVsx1vSo1pAxPiZOzBEs14V9go=; b=E/krv6bppyXdn3bOJnr69SxIJlBIzm93+1auE7Ct6aa7mk0ivMsF1FFr+k4aS2NQOv1yJlr9clANWgt+oCynCqGGg3E0xKR9KWBtp1G81CfwP7Dx5swHLndqPRXv4/Q8/4SV7FSlwV2kJ9q+RRIL1VH7BvBgUF3FpRc6sZnaGrgr0K6HajZVQ9rnxjYlCYW7Kor+smoRixAwvFL0jLsaMd6kxEBYf4thG6N5Nz+XkHQLiQy3UoycuxaPObYs2lGmcY7kGNNKSOMp3E1vL6iwmXiZstWTNk8cQF0bJ/hn2n/YWJQz3/eXvPlc8QHzBche+uaPhWePh31DTAMreH5Drg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zXXXCKnNehkyD1wOfFVsx1vSo1pAxPiZOzBEs14V9go=; b=YWdM4TlQRFXtfO9S2WwPf3NP1jut6hdlM20SZBNu03ZrW4K0PoskPKpb1yWn58rfvKfMnH8O/xvoOY5besMuFKMZ5utF6XJG3d2otDs+kklQetM4AZg8Iw1FlfVcNxX6NsDjHWTMMNCvLvPPa0YgCFPeho2cP8uGPVFMztEzIcg= Received: from MWHPR11MB1264.namprd11.prod.outlook.com (2603:10b6:300:27::13) by MWHPR11MB1584.namprd11.prod.outlook.com (2603:10b6:301:e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.22; Tue, 13 Apr 2021 06:30:05 +0000 Received: from MWHPR11MB1264.namprd11.prod.outlook.com ([fe80::2de0:bee7:e720:7736]) by MWHPR11MB1264.namprd11.prod.outlook.com ([fe80::2de0:bee7:e720:7736%12]) with mapi id 15.20.4020.022; Tue, 13 Apr 2021 06:30:05 +0000 From: "Peng, ZhihongX" To: "Ma, WenwuX" , "Yang, Qiming" , "Zhang, Qi Z" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/ice: fix illegal pointer access when removing mac filter Thread-Index: AQHXJ2PRU6N360vaU0qSsFgEVMOxuaqyDahA Date: Tue, 13 Apr 2021 06:30:05 +0000 Message-ID: References: <20210402135247.20094-1-wenwux.ma@intel.com> In-Reply-To: <20210402135247.20094-1-wenwux.ma@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.54] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9dd5ab75-c60f-4889-02f1-08d8fe459372 x-ms-traffictypediagnostic: MWHPR11MB1584: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jH3yv+Lkjbs1cs9fIae6ALdsROza+I1ms9dzCVY0lxV9HqpvyKaEd0VUTFP6+1MnZRZuK+7imIsxIL47nRcTrw/JyY5O4hh/JcpRENtAEyEmEfBXXGVLMU/lqO3CO0TeR5plS/w+jfcC0Dh2ANA2CKiSi0xMPJAHOL51OcyMD2OMtdYb/xaiMJA2t16Rs4BxY7gELICrWi7ft8hAfB3ok6820gWAmr0BXVMoqMgWFG3ynlFMTiBvHRzsxaTaj71PWvmbnk0phCgpwqWzacZFXjpFUnl/SeevXUrFUC4kzowpRntJw7WESZykw0oW1I/ltPLRBfWlGIXGS3zEzAz17jTbthAdtzXVINobPQKMoStszwwxdRarurBYJ6oSp8OFZ8URAw278GQcBgEnizrZ4spI3CIaZu4SwHrZxNiTpct+6U4DwrcsbeOfz3c4bEQuSdFrW4soxI8qXEZoOwdDm/yF0a+EFTdVpu0CLmCeo4D28QK5D/U/yLbpLGzCJggrMk1zkWUsgeIUffzjr1lxZyP5H1zX1fpPlyLcV6jcg0acg0dDJNqUuVjgg8LeM9HUmDoSVlS/4myfbklgYOyuYG9ZRD0NwoTcvAeMvAphCL0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1264.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(346002)(366004)(396003)(39860400002)(376002)(66556008)(66476007)(66446008)(76116006)(8936002)(66946007)(6636002)(33656002)(2906002)(316002)(26005)(110136005)(64756008)(9686003)(55016002)(186003)(8676002)(4326008)(83380400001)(6506007)(478600001)(53546011)(38100700002)(7696005)(5660300002)(86362001)(71200400001)(52536014)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?2liE59Bmq3TFH8You24FHc1YC7S/f3zWk0KGNRuNAA9zvPQexTAkcs72WSQP?= =?us-ascii?Q?Ez3T4DqFyXDyDBC/P3Ga+FHTkQOkgUopQeYUJs8mIAiqXoJE6oL8DIpb4yGK?= =?us-ascii?Q?694mpZgPQtp740mDzuvmyS+pfJ5GWc9bWIms9aYscG279hh1Ahp0nO2BeOF+?= =?us-ascii?Q?bbt4wfpA8VJEoR6QRhBe33ZyuJ5c/hcHqTX3uZMEukowwXXXftNZfQyw8ezn?= =?us-ascii?Q?EuWRz1s+p4l1/6o+TkdE79WaLvzXUDl9EfYqfKKIvASr0gKLh3MFbIgc/Cur?= =?us-ascii?Q?6glHzK+Q4gOAU5ycbtO2smbRvgWwrsJU2/ltq+4yycsYMzOlIiOYAiKGwJhy?= =?us-ascii?Q?ZCR4oMyvO/cQhXFydoh1S8R8qjnomZ2Qr2NbHG3PEBA3rQm468chD3xlCU8v?= =?us-ascii?Q?HqXR6GFoa9OfK9Gap8S165lMmHYW+Sf5FVCVTGGQllW9w/Rfi6JrnIwRNF6y?= =?us-ascii?Q?r+fv84JbxMjEMie4coJtJ8qcQ8eZFCDI3KWNmhOQJw44ttoMSdQJq15qcXdP?= =?us-ascii?Q?p6n2H0Q45jDwYagrAk7YuD9LBb08qEy/v3n4sk8DCLB/+4hrdjyJqdOAphER?= =?us-ascii?Q?mQAMPbjCu2NIJynVJdP4kMi8zShVrXRLkyvG1kDBF3n5cYVZqUNRXq1Uqfnh?= =?us-ascii?Q?jFPn0L7LOg9HGm4fF10c8kVZW/Maft823h0GVauaG25WH77uBH4zPrau+h0N?= =?us-ascii?Q?vV0yfcCuma+CxK0y185OToG7iZaKP43xUr0uEDBnjwuQoZAtRMQC2imSXN+I?= =?us-ascii?Q?uCY7CD4vd/hirR2wqIfreVOTnPK8VzMLB1lqdWzdu69E5ynM4m+vGxzcyBLo?= =?us-ascii?Q?8VjR4jsGJnH+/Lg4xy3j4nsvFKkAEhVbx+/mNRdBYtPz8z8uJmuXGNzhFe0E?= =?us-ascii?Q?/mrA5SsjeFeV83mlomt2fSzqcRycj8+e0YhF/81ay0+TRgARI8i8jo52SYob?= =?us-ascii?Q?0AQbMepBpCAtp/W0OIsrbpky29ghBMdvXgTwwXkrAQhfIZKKiNkuQ1t4ocom?= =?us-ascii?Q?2E2/APIiDhmAT7KaEg8eY6ctc6T90/HJ6MftoKSGMOOQhuAYl+TDm1csMTLi?= =?us-ascii?Q?qjuXvzQ/EwIYfYna+MU3M+O6ak9SKwpgLXZjgQO+3houvpXS9MgwjGhhWLcr?= =?us-ascii?Q?XA868NcPAE/5cLIzg6k5hW3Oazp9thj6z7QD7T6yt3mN95eYnnjP8yycrM91?= =?us-ascii?Q?JUysYh1IJMpDVt6MkRWZTgUvdUftGzu82psBxMg8uz6756ZCTBEadVYXhVSE?= =?us-ascii?Q?iX4u8ns5zipP1u6JyTScEqMP0UdyPYUvGYEArXzY9KHI0NpqaO+apCzSyJbb?= =?us-ascii?Q?zs0=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1264.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9dd5ab75-c60f-4889-02f1-08d8fe459372 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2021 06:30:05.1277 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iaiMls8yvGzMcOvTLByII4doMFcRRh1Y4hjvnakBzYz+5Quvr3qmpHhBBNy9bLIJgku4sgYcPEiImAPSpZWEog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1584 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/ice: fix illegal pointer access when removing mac filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- From: dev On Behalf Of Wenwu Ma Sent: Friday, April 2, 2021 9:53 PM To: Yang, Qiming ; Zhang, Qi Z Cc: dev@dpdk.org Subject: [dpdk-dev] [PATCH] net/ice: fix illegal pointer access when removi= ng mac filter When removing the mac filter in ice_remove_all_mac_vlan_filters(), TAILQ_FOREACH_SAFE should be used instead of TAILQ_FOREACH, Otherwise, it w= ill result in a illegal pointer access. Fixes: e0dcf94a0d7f ("net/ice: support VLAN ops") Cc: stable@dpdk.org Signed-off-by: Wenwu Ma --- drivers/net/ice/ice_ethdev.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c in= dex 9c9b84a93..785750d9b 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -10,6 +10,8 @@ #include #include =20 +#include + #include "base/ice_sched.h" #include "base/ice_flow.h" #include "base/ice_dcb.h" @@ -1094,12 +1096,13 @@ ice_remove_all_mac_vlan_filters(struct ice_vsi *vsi= ) { struct ice_mac_filter *m_f; struct ice_vlan_filter *v_f; + void *temp; int ret =3D 0; =20 if (!vsi || !vsi->mac_num) return -EINVAL; =20 - TAILQ_FOREACH(m_f, &vsi->mac_list, next) { + TAILQ_FOREACH_SAFE(m_f, &vsi->mac_list, next, temp) { ret =3D ice_remove_mac_filter(vsi, &m_f->mac_info.mac_addr); if (ret !=3D ICE_SUCCESS) { ret =3D -EINVAL; @@ -1110,7 +1113,7 @@ ice_remove_all_mac_vlan_filters(struct ice_vsi *vsi) if (vsi->vlan_num =3D=3D 0) return 0; =20 - TAILQ_FOREACH(v_f, &vsi->vlan_list, next) { + TAILQ_FOREACH_SAFE(v_f, &vsi->vlan_list, next, temp) { ret =3D ice_remove_vlan_filter(vsi, &v_f->vlan_info.vlan); if (ret !=3D ICE_SUCCESS) { ret =3D -EINVAL; -- 2.25.1 Tested-by: Peng Zhihong