From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0069.outbound.protection.outlook.com [104.47.32.69]) by dpdk.org (Postfix) with ESMTP id E09E52BB4 for ; Tue, 21 Feb 2017 12:37:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=harmonicinc.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=6hi+OK6f3qcnSA5d4GyN001xMu+A0Sj2jFMsPJEBEHs=; b=XdcVL4X2UTVRLNVu/Vx2bXWuu6nqUO/0wiHNw+iCIHDhk+VbhKRTxumZT91gMU2/Ol/t4obPO8YfeRnCgRPtDkr6RiseC/CvCL2ZZZbz9S+6uyH2zRRfL0zFthnudiJWhCXKVRyJdZ6dAFa7Ymj2EifwNVIRdo0JGZ2+RFPaRck= Received: from MWHPR11MB1360.namprd11.prod.outlook.com (10.169.235.22) by MWHPR11MB1358.namprd11.prod.outlook.com (10.169.232.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.919.13; Tue, 21 Feb 2017 11:37:09 +0000 Received: from MWHPR11MB1360.namprd11.prod.outlook.com ([10.169.235.22]) by MWHPR11MB1360.namprd11.prod.outlook.com ([10.169.235.22]) with mapi id 15.01.0919.018; Tue, 21 Feb 2017 11:37:09 +0000 From: Vladyslav Buslov To: Bruce Richardson CC: "dev@dpdk.org" Thread-Topic: [PATCH] lpm: extend IPv6 next hop field Thread-Index: AQHSjDTxGWMaIAazVkq/EPq2Ouc9ZqFzUZFA Date: Tue, 21 Feb 2017 11:37:09 +0000 Message-ID: References: <1487524499-9570-1-git-send-email-vladyslav.buslov@harmonicinc.com> <20170221112330.GA194104@bricha3-MOBL3.ger.corp.intel.com> In-Reply-To: <20170221112330.GA194104@bricha3-MOBL3.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Vladyslav.Buslov@harmonicinc.com; x-originating-ip: [95.67.66.62] x-ms-office365-filtering-correlation-id: 0aa16f1d-2204-4ab6-1bf5-08d45a4df8a6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:MWHPR11MB1358; x-microsoft-exchange-diagnostics: 1; MWHPR11MB1358; 7:4cPQR8YRaQU9bMJuhpLbn3F2/sPR3s325Zenr/5e2zDDx3dQeUq/Q28T1O2OO/96vBylVbVUFpRXTKpp0Db45K3WJqweOg08dn+bGVxiMP7QuLDXJ2l+8dpGScvwtf/3Tr1cMVlqDZknVpbDpdpkYpadSszJTneZODy/6nwRyOvXRcYajr4IlpefOttSlOMcHFcQRwipKMJ7Y8oD79ooSjCrnSemqMt1KggWjN0CfkcLLZt5ZA4gTKBJgnHi7S7oAPF/E49f+4kvsww0vUsUJQZlxND65xuUTS0hVkz21oxuTT3taevG2Aqq0GI40UQ4xDep8N/4Ytr62QFy8wNj4Q==; 20:UKPoTWLLPK9tyo+B5p1rge3I6Ycv6DHhfQgQjAfFfZO6+64CPQG+h2LE62hyFN0to1p9XfPmiyNmj4vVIkfBCzhpD67i3tS+MWg/1LYSoqJxoIjPMVDMq8ainkiT0WKvEH5dyQAR1ix0H5RugIvE7W1BHH1avHkmUMRdegMXgfg= x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(278428928389397)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123560025)(20161123562025)(20161123555025)(20161123564025)(20161123558025)(6072148); SRVR:MWHPR11MB1358; BCL:0; PCL:0; RULEID:; SRVR:MWHPR11MB1358; x-forefront-prvs: 0225B0D5BC x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39450400003)(39850400002)(39410400002)(39840400002)(24454002)(377454003)(13464003)(199003)(189002)(66066001)(38730400002)(6116002)(81166006)(3846002)(102836003)(189998001)(92566002)(53936002)(6246003)(97736004)(74316002)(305945005)(2950100002)(8936002)(81156014)(76176999)(54356999)(110136004)(7696004)(229853002)(77096006)(6506006)(25786008)(6916009)(99286003)(55016002)(6436002)(5660300001)(9686003)(8676002)(53546006)(2900100001)(50986999)(122556002)(106356001)(33656002)(106116001)(68736007)(105586002)(2906002)(7736002)(3280700002)(101416001)(4326007)(3660700001)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR11MB1358; H:MWHPR11MB1360.namprd11.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: harmonicinc.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: harmonicinc.com X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2017 11:37:09.5048 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 19294cf8-3352-4dde-be9e-7f47b9b6b73d X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1358 Subject: Re: [dpdk-dev] [PATCH] lpm: extend IPv6 next hop field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Feb 2017 11:37:12 -0000 Hello Bruce, Thanks for reviewing my code. I noticed errors generated by checkpatch. However all of them are due to original formatting of files. (e.g. code cop= y-pasted by me as-is from same file or modifications to original lines unre= lated to formatting) I decided to preserve original formatting of files instead of introducing i= nconsistencies. I'll create V2 according to code guidelines if it is your preferred approac= h. Regards, Vlad > -----Original Message----- > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > Sent: Tuesday, February 21, 2017 1:24 PM > To: Vladyslav Buslov > Cc: dev@dpdk.org > Subject: Re: [PATCH] lpm: extend IPv6 next hop field >=20 > On Sun, Feb 19, 2017 at 07:14:59PM +0200, Vladyslav Buslov wrote: > > This patch extend next_hop field from 8-bits to 21-bits in LPM library > > for IPv6. > > > > Added versioning symbols to functions and updated library and > > applications that have a dependency on LPM library. > > > > Signed-off-by: Vladyslav Buslov > > --- > Looks good to me. There are a number of checkpatch errors flagged. Can yo= u > perhaps do a V2 with those fixed. (You can use the checkpatches.sh wrappe= r > script in the devtools directory to help). >=20 > Once checkpatch errors are cleared: >=20 > Acked-by: Bruce Richardson >=20 > Regards, > /Bruce