From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0044.outbound.protection.outlook.com [104.47.36.44]) by dpdk.org (Postfix) with ESMTP id 04FA91BBE for ; Sun, 28 Aug 2016 13:20:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=harmonic.onmicrosoft.com; s=selector1-harmonicinc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=btx+vzu5ukiMKi7clOZo4BJjkMHkIVgC9vWJMWyIJik=; b=LOuqZCybaBoPmO78lhGk3IGx2e9KjDs9ImYeg7UcXLyeiSfyalR8jNgtzloGlcq6poE10xK0C4Aaviq78mRVdsekxeWW+CoSJRKLwWec+NemcYkcBbAoGZ3+3wF3N/j5HznkXWU1FCSLoF73H2hMZxq2MtPZOyQipblrQrs/PQw= Received: from MWHPR11MB1360.namprd11.prod.outlook.com (10.169.235.22) by MWHPR11MB1360.namprd11.prod.outlook.com (10.169.235.22) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.557.21; Sun, 28 Aug 2016 11:20:28 +0000 Received: from MWHPR11MB1360.namprd11.prod.outlook.com ([10.169.235.22]) by MWHPR11MB1360.namprd11.prod.outlook.com ([10.169.235.22]) with mapi id 15.01.0557.022; Sun, 28 Aug 2016 11:20:28 +0000 From: Vladyslav Buslov To: Ferruh Yigit CC: "dev@dpdk.org" Thread-Topic: [PATCH] kni: add module parameter 'bind_to_core' Thread-Index: AQHR/t+FYvq44lRqyUKy93Wu/qBBQKBePS/Q Date: Sun, 28 Aug 2016 11:20:27 +0000 Message-ID: References: <20160816182455.4809-1-vladyslav.buslov@harmonicinc.com> <57BF04D6.9040108@intel.com> In-Reply-To: <57BF04D6.9040108@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Vladyslav.Buslov@harmonicinc.com; x-originating-ip: [62.205.135.152] x-ms-office365-filtering-correlation-id: 98676c4f-2eef-4125-a730-08d3cf355093 x-microsoft-exchange-diagnostics: 1; MWHPR11MB1360; 20:BhNJn8o3FyJqM1cWBLTVLKJ3N9u+BadDQ13Dbf0iS4xB6dhUrzQ94QRkafIgWPJ9v4/Feb9hnn0ekn5Q/n8TYVv5Iwvl9ghpwHXCNSXaxCwr4uJw6n0TsZ6qAe3xppWYVhmPGCg+ChDX2kpGVLDm8TUhwb/3/kQTAn6erbONxvs= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:MWHPR11MB1360; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026); SRVR:MWHPR11MB1360; BCL:0; PCL:0; RULEID:; SRVR:MWHPR11MB1360; x-forefront-prvs: 0048BCF4DA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(24454002)(189002)(199003)(76104003)(13464003)(377454003)(7696003)(81166006)(33656002)(97736004)(54356999)(19580405001)(2950100001)(81156014)(2906002)(102836003)(6116002)(11100500001)(77096005)(10400500002)(50986999)(76576001)(87936001)(101416001)(3660700001)(3280700002)(122556002)(4326007)(5002640100001)(586003)(105586002)(99286002)(92566002)(106116001)(66066001)(106356001)(110136002)(74316002)(2900100001)(189998001)(3846002)(86362001)(8936002)(5660300001)(19580395003)(76176999)(7846002)(68736007)(8676002)(9686002)(305945005)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR11MB1360; H:MWHPR11MB1360.namprd11.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: harmonicinc.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: harmonicinc.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Aug 2016 11:20:27.9600 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 19294cf8-3352-4dde-be9e-7f47b9b6b73d X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1360 Subject: Re: [dpdk-dev] [PATCH] kni: add module parameter 'bind_to_core' X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Aug 2016 11:20:31 -0000 Hi Ferruh, I agree that your solution is more flexible. I'll work on moving single thread creation to kni_ioctl_create next week an= d get back to you with results. Regards, Vladyslav -----Original Message----- From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]=20 Sent: Thursday, August 25, 2016 5:47 PM To: Vladyslav Buslov Cc: dev@dpdk.org Subject: Re: [PATCH] kni: add module parameter 'bind_to_core' Hi Vladyslav, On 8/16/2016 7:24 PM, Vladyslav Buslov wrote: > Allow binding KNI thread to specific core in single threaded mode. I think this is good idea. But I am not sure about making this a module parameter, setting core can be= more dynamic. There is already a kni->core_id field, which is only used for multiple_kthr= ead mode. What do you think moving single thread creation into kni_ioctl_create() and= use first kni->core_id to bind the thread? If there is no kni->core_id set, it will behave as it is now. >=20 > Signed-off-by: Vladyslav Buslov > --- <...>