From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 712D2A0350; Sun, 28 Jun 2020 08:03:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 010911C196; Sun, 28 Jun 2020 08:03:06 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 383911BFFA; Sun, 28 Jun 2020 08:03:04 +0200 (CEST) IronPort-SDR: upj4EZuLwt1NYjG9x6NBcBMHqFpkE6SJ4x1a+YWn/XhnbEPXnwXwEx6lHRYE4EbVL+vZOs9Aqt bqKNhtdnsmxg== X-IronPort-AV: E=McAfee;i="6000,8403,9665"; a="133216091" X-IronPort-AV: E=Sophos;i="5.75,290,1589266800"; d="scan'208";a="133216091" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2020 23:03:03 -0700 IronPort-SDR: 47MADLygzqLSOyfMrJkOgZSxyI7eTpKQd2iIitmLDSXkMq4sBv0jnO6MuYKFRvFN4bzPAF9Iuf PS+OnIZpgxBQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,290,1589266800"; d="scan'208";a="480241816" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 27 Jun 2020 23:03:02 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 27 Jun 2020 23:01:36 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sat, 27 Jun 2020 23:01:35 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sat, 27 Jun 2020 23:01:35 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.52) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 27 Jun 2020 23:01:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VOxERKISYRQWZaZhzP3J8f7luCCXxB7vwz/+ydWrIl+KvhvylphR5yHTmjn7IXgQC6XQT1kFuTxfAgBT1wsJCknFXLzeaIvRYeHYEsOdvJG0/pl+36l8Uct/YTxStaYrb2EDzrTKDJ1vTFO5vZzFd5/Bg6W3l80CZ0Fmm6dpIIFGA6OlHecucAbQkz4rqhqI/0u5wCZy1R6LTrJvox/oDkWUDMRAdpoioM13GWFbic3rR0QGMHNY4fquY63V1GVWmeuvmB7hETtZLvCb0XiWrYJ108tPJlf8ruydCbZvlBIDFcinoFAkwAYfb5bX/qM8CXBpNoeRPeuKHJOS+g+N/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/Bcdae6WpiNArTvMmUL+6Z9xC9y7q6g7f3Wa52+rExw=; b=giDU4ZGIDxLhzRWFC9qnyrOyBWtReDlzW2oO174KIFvDb5oVzXKqQMqr6vCBDTfr9XpMP9HZnEmanvdE0b+Z54Zo8klkS2Fja1YZFOYvxkDzVooVhx875EpHysiUxCOIxGg1ttY3SY1Qd14CNzJXGUMnzsk+sWM0Sbv5Ew793dNfgCoMEJ9i5ykDRYFSWzGXK8JZoqmaqrXf045yGrSyiK8UxOD3tXqTWDtASLRwAKHX5XKXif+WIPDB9iEQbEVOagU644CS0vthcTKcKBvwOlWrwWjIdtdl2ZTP69fWJsQKNTvWTK6Dqu69gQ9jR602dLpcqSWTd0wJp5dbS811ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/Bcdae6WpiNArTvMmUL+6Z9xC9y7q6g7f3Wa52+rExw=; b=yFeoCEAUAhNQSsPOB/jsZ1YYNv0pmWn3VMi4QmAM/+OL6chfBnjxcT5Cova8dugDGgxo5v+Saak7dhZdoH41pYEGigGUydB3yXx73xY1AemjwDI4m8UxJ1oIoEqWxmbygM2S/P4J9JIB7A6BogleA5Cm7UJmrI9f0B/vBvDFTho= Received: from MWHPR11MB1391.namprd11.prod.outlook.com (2603:10b6:300:23::15) by MW3PR11MB4603.namprd11.prod.outlook.com (2603:10b6:303:5e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.21; Sun, 28 Jun 2020 06:01:33 +0000 Received: from MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::f8f5:b48c:be92:ac17]) by MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::f8f5:b48c:be92:ac17%3]) with mapi id 15.20.3131.026; Sun, 28 Jun 2020 06:01:33 +0000 From: "Zhao1, Wei" To: "Wang, ShougangX" , "dev@dpdk.org" CC: "Xing, Beilei" , "Guo, Jia" , "Wang, ShougangX" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] net/i40e: fix queue region issue in RSS flow Thread-Index: AQHWKNk11N8f+87F4kKay5de0t2iA6jt0I0w Date: Sun, 28 Jun 2020 06:01:33 +0000 Message-ID: References: <20200424085225.27655-1-shougangx.wang@intel.com> <20200513033320.15771-1-shougangx.wang@intel.com> In-Reply-To: <20200513033320.15771-1-shougangx.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTZlYWVmYTMtNmZkZi00ZTllLTllMDUtNjNjNmMxYzMzZjRlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTEZwaU91UkVMQ3k3bGNwTFJRQnU2NW42b3hnMlY1QmhpWFdKVndxdW8wY2xtSDBhY1lLWWpldWZuZ1VKMWRidyJ9 dlp-version: 11.0.600.7 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.199] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a2126208-606d-47fa-e57f-08d81b28b5a6 x-ms-traffictypediagnostic: MW3PR11MB4603: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3513; x-forefront-prvs: 0448A97BF2 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mkNYFQ/OSTl7nO+3u81VL073l/kAV4xTStE4YOSOQlhoDq3PwTrcQrGAaz1o7ZLubk9DHjUcH333Zq/LwSbOuM1jMXs06iyIhQKhUhfu5Z87oeYK/q2pZ0a8DOhlNx0F6WRdGhgnXEX50wwa2PUCGycWA6Nl5pmZ4ZP8bANER3Jn5yAtW+ryVnUrcziiRoBe8rbtyJkUrFW/XKtJi5p8u/X3fEq2fhl/8hj1S+airA03ZKVPhGtBNaioGjfw7pN/cJK5t10P6A+cUjBJiKjItwRczUb86e79b+pE0F+LmSKzJLoS/1mZY1awTdZX/4kNIGTwDtgpTpgYgFUW659mpQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1391.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(366004)(346002)(136003)(376002)(39860400002)(26005)(55016002)(2906002)(7696005)(66946007)(66476007)(66556008)(66446008)(76116006)(64756008)(52536014)(316002)(110136005)(450100002)(71200400001)(53546011)(6506007)(5660300002)(83380400001)(9686003)(4326008)(8936002)(186003)(8676002)(478600001)(86362001)(33656002)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: S6hFnxEmJ6fEIP0DPU6g//2Ds3PStp/ChoVPZb8tGwpUAXB03yiATn1e/jLtaV9lEXhnFqIHBrqJQ/TW6HPmLBUk/Izgn6E2JoRUlwTSN1ysWyZiR/PaT11cPbbFi2le+5V32c1SRqbx+QmfTHjdTOvOH2a9r6IXt34k8H2le1Gb+aDwbtbsCWeK8bjMZERVlZn/X+ci7WH4uq8U/gAEnsO7XxGkAkmTPPMiaYWhEidASX+d192ODOZNtLBAONEfFAQX5N0mJeGN2LZN+1ykA2RfMnLGRsngJHAqK9MJTV3au0s2wvN99xEyyq9eS9qPqG1V364X/vCrr+DO0Y/ktogfxlxhvx5AKVM4iCGCCvqB4eU9ymp6S6X2Ho3OXFZg+Rpnv1+52ncZicRO8/jRyPDd+/kqz9KsXkibSCtYWHa13ICozXNwCBk5ug7Pm6kfvBeSgCQmyYeu8uMuD8oNzQiA2unLohhFQg2ubiOROVUrZ5KI3a+eCnYToKsO3DDE Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1391.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2126208-606d-47fa-e57f-08d81b28b5a6 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2020 06:01:33.1011 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6LSBHWZiGhWc3qOuof/Z3l5eRQBCkZqeSR6IbujHtU8fQnaPDGbgy1U2xNeCD3+eIh4jDihBkSX3Mx74V4N+3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4603 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix queue region issue in RSS flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, shougang > -----Original Message----- > From: dev On Behalf Of Shougang Wang > Sent: Wednesday, May 13, 2020 11:33 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; W= ang, > ShougangX ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v3] net/i40e: fix queue region issue in RSS fl= ow >=20 > This patch fixes the issue that the queue region does not take effect due= to > incorrectly setting the flow type. >=20 > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Shougang Wang > Reviewed-by: Jeff Guo > --- > drivers/net/i40e/i40e_flow.c | 35 ++++++++++++++++++++++++++++++++--- > 1 file changed, 32 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c = index > 7e64ae53a..2f937567b 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -4625,6 +4625,34 @@ i40e_flow_parse_rss_action(struct rte_eth_dev > *dev, > uint32_t index =3D 0; > uint64_t hf_bit =3D 1; >=20 > + static const struct { > + uint64_t rss_type; > + enum i40e_filter_pctype pctype; > + } pctype_match_table[] =3D { > + {ETH_RSS_FRAG_IPV4, > + I40E_FILTER_PCTYPE_FRAG_IPV4}, > + {ETH_RSS_NONFRAG_IPV4_TCP, > + I40E_FILTER_PCTYPE_NONF_IPV4_TCP}, > + {ETH_RSS_NONFRAG_IPV4_UDP, > + I40E_FILTER_PCTYPE_NONF_IPV4_UDP}, > + {ETH_RSS_NONFRAG_IPV4_SCTP, > + I40E_FILTER_PCTYPE_NONF_IPV4_SCTP}, > + {ETH_RSS_NONFRAG_IPV4_OTHER, > + I40E_FILTER_PCTYPE_NONF_IPV4_OTHER}, > + {ETH_RSS_FRAG_IPV6, > + I40E_FILTER_PCTYPE_FRAG_IPV6}, > + {ETH_RSS_NONFRAG_IPV6_TCP, > + I40E_FILTER_PCTYPE_NONF_IPV6_TCP}, > + {ETH_RSS_NONFRAG_IPV6_UDP, > + I40E_FILTER_PCTYPE_NONF_IPV6_UDP}, > + {ETH_RSS_NONFRAG_IPV6_SCTP, > + I40E_FILTER_PCTYPE_NONF_IPV6_SCTP}, > + {ETH_RSS_NONFRAG_IPV6_OTHER, > + I40E_FILTER_PCTYPE_NONF_IPV6_OTHER}, > + {ETH_RSS_L2_PAYLOAD, > + I40E_FILTER_PCTYPE_L2_PAYLOAD}, > + }; > + For x772, the pctype for UDP is different, this table should be different a= lso. if (hw->mac.type =3D=3D I40E_MAC_X722) ..............................