From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7A04A0093; Wed, 20 May 2020 11:32:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9280D1C43E; Wed, 20 May 2020 11:32:52 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 8DD111C436; Wed, 20 May 2020 11:32:50 +0200 (CEST) IronPort-SDR: CESwEACaoOrUEXfSo5rG9rj1/DlV6CXvJUgogAhbBebel5fQpczOJncOjQMUMvARoQ8crt2NXV V11K/5k+4s4w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2020 02:32:49 -0700 IronPort-SDR: hnGUXx9xeLsN0r40i+FCPiXiIrS15LvHx0H8oLy40co7n6eD9tOhkIxmlnX1HzRfYjf8QTg4NZ GPn+HIP9p+8g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,413,1583222400"; d="scan'208";a="289289470" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by fmsmga004.fm.intel.com with ESMTP; 20 May 2020 02:32:46 -0700 Received: from orsmsx160.amr.corp.intel.com (10.22.226.43) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 May 2020 02:32:14 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX160.amr.corp.intel.com (10.22.226.43) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 May 2020 02:32:14 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 May 2020 02:32:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q36Ipw+IXTfXEhX3b+cp9v2wUy/fycrCG91ulMPXf1JTd1gK4xQFp7zKIVlTcW5hiKo1ulGFTeCde0zfzqxdpnR00ci0sc9o/K4IA4rOnUDtDmmy8mUfG90hR0XQ82x7MLjyhCmH3eKs0mfiXkaxTapSvHaaVoQU+qxW7+3K2qdImtTBofQKmlQ/4OyROAeMhPcMogcPKjXY8yy6xd7YqKBzn+XJA9eFbxdiP8O66sK+sVUSFFPMkx+y/HRxDDBFa5Ar2WZav80DWNCRD9odATrvlAKIuPcNSQEUJcJYLfg26MjPFhqv0xmShq6R1lJkJ2T5fay4W40ybRtf+tCPYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/VSJq9VAej6hr7EZDSUBgBB7WHE59OY7yJTC7SucBSY=; b=L1UH2Fj/JIGwW0THvuArOt6pBl4drMayovJSCqxKin/c+g5086Fka1Tc3UCkpyWLt1LGaXs5lR/LAJX1y/qqR7572wdXsQzQ1cUkF3rUGUWcadCLDvwAjjEmF8mPCjpIN10YfinQgDqn+443XG9W5SeGfiikLci5C7afmoLK4IFY+QKzPmdihqJeiquJhcE6eUwfJ7bIxB9tG1N+UTkQuAjT2hwhhRQfY1k4nRGf6uWuDr5M8SYg6SDkWNs6OaX1G75bTqsiPPDxeq/ihNu0jpQa2mmZVGLhWHGVs1cyDKhUhZbMinZKHEe3mythMoBWG9loT6nXbLz8DXOX/PZq+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/VSJq9VAej6hr7EZDSUBgBB7WHE59OY7yJTC7SucBSY=; b=WGq5rG+14XYcDjGDDH82jJ5dAc84T8/vapPxX3Enu1l+hhYRICSPkN7D2vz/jU/c9njr0j2FEzzUtbtvbJQ+FHDzdI2Ou/bPi54BYVONcJjfvJ2x/O0cD+yp1DUliUj2HchwxUy8BO3I7nIndU01K3Lti30orHTdCtCyv/ba9hI= Received: from MWHPR11MB1391.namprd11.prod.outlook.com (2603:10b6:300:23::15) by MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23; Wed, 20 May 2020 09:32:13 +0000 Received: from MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211]) by MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211%7]) with mapi id 15.20.3000.034; Wed, 20 May 2020 09:32:13 +0000 From: "Zhao1, Wei" To: "Jiang, JunyuX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Jiang, JunyuX" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] net/ice: fix core dumped issue in switch filter Thread-Index: AQHWI1QUOO+ZNaIRbUijF0dYt+M1/aiwy7gAgAAAj0A= Date: Wed, 20 May 2020 09:32:12 +0000 Message-ID: References: <20200429072516.65403-1-junyux.jiang@intel.com> <20200506030525.3907-1-junyux.jiang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTYyN2E0ZTUtY2E5Yy00M2U4LTg2OTgtYjVlNzYwN2Y4NTNkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWDBtVWJ0YTVtYXUzV1NyXC9YbU5VbmVOeVl6cUp5azQyUHRPOTMyR3FyQkg4UVdYQTFcLzdcL05wdXo4TUNqWHZLZiJ9 dlp-version: 11.0.600.7 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e6bc8c53-c933-41a5-bb21-08d7fca0ad72 x-ms-traffictypediagnostic: MWHPR11MB0062: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:336; x-forefront-prvs: 04097B7F7F x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lzP7QxbmevMXb3yQhLQXYIhgxDeeDdSZgETquonN7CYy0tZYytd1UDMjCHk8Kmr5i6atGypT6FUha6EyhTnxMnlUJghJMdRUtFzIW6/g/5u37OfGySiCR/YJKDesJERr1yCzwd3Ujjaff7e39l5TVphzDMlYn2vldIayeGAZwg/o5WUoImI+1wVNCGxjq3wkw05F631lpaq3dbRiXjsUNp5U9+dQirk9UNnwm419ywqS2gcoLS90h0BfzKHBGAbUp1Z0Zv8qwD0pKrC1TXa7KP1xHY5/jFwBgPS7QbkrA7s+X3umrFFzNSVUDJc3g61s x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1391.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(376002)(136003)(366004)(346002)(39860400002)(396003)(8936002)(33656002)(5660300002)(66476007)(66946007)(9686003)(66556008)(86362001)(54906003)(64756008)(66446008)(110136005)(76116006)(55016002)(316002)(186003)(26005)(53546011)(2940100002)(478600001)(7696005)(52536014)(450100002)(71200400001)(2906002)(6506007)(4326008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: wQBX7Ao/S6yDkY49drD8z9rKehINgoHzNTn95vbi0FTGPuiEiZ5nRTfe4zzhVsiH6ReZrYiZkF8HsVFSltWONk4gYCkFt4a9pcrc3MKUacWVZDQWaOHXhJ1t+iyDvBtRElDx9JdficM/kQxf5r/QytxyXFSEb6QaB6Dv0gT099UNkxsQr8C5sg8QF4DWLC/4Lv22hoZQ9mTF5M8xRyfY9exZjS0g74Qgr3HdAYxsOArmq2EcKJfWFkTBTQb12QqaYTFVc3scqFEY91W7P5oOewdzW4kigqW8FO0gGdVocrbb0xZxz+2qF/qxywgcvBlXuNU71a2cQltk694wduVaIMz/u7yIDr7GdU38s1q9FyG2jcKQgTTJDxulLOpNFFP9vZAgo4SYvNoQIinIFmDNwnsRJGz5OhIv9YgtWUIa7Cd+Y1z+q4r/ww1ZJmlCGKsUWCLjUkptdwRRpilgZRh29XuTBaTSDdpAvWe6LyZpmEY= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: e6bc8c53-c933-41a5-bb21-08d7fca0ad72 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2020 09:32:12.9469 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cJknhVDNmu8DKc2UMviJnwzBReIzObm01qrpR9AUuKF/YlYooUt6StVeJ83ntB6qfzWxpLRnPJkHgfo2e5D9ZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0062 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix core dumped issue in switch filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Get, this is for queue group, thanks. > -----Original Message----- > From: Zhao1, Wei > Sent: Wednesday, May 20, 2020 5:31 PM > To: Junyu Jiang ; dev@dpdk.org > Cc: Yang, Qiming ; Jiang, JunyuX > ; stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] net/ice: fix core dumped issue in swit= ch > filter >=20 > Hi, Junyu >=20 > > -----Original Message----- > > From: dev On Behalf Of Junyu Jiang > > Sent: Wednesday, May 6, 2020 11:05 AM > > To: dev@dpdk.org > > Cc: Yang, Qiming ; guinanx.sun@intel.com X > > ; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH v2] net/ice: fix core dumped issue in > > switch filter > > > > The number of queues in queue group should be checked before using it. > > This patch fixed the issue. > > > > Fixes: 47d460d63233 ("net/ice: rework switch filter") > > Cc: stable@dpdk.org > > > > Signed-off-by: Junyu Jiang > > Tested-by: Qimai Xiao > > --- > > drivers/net/ice/ice_switch_filter.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/ice/ice_switch_filter.c > > b/drivers/net/ice/ice_switch_filter.c > > index 179430136..c2762e331 100644 > > --- a/drivers/net/ice/ice_switch_filter.c > > +++ b/drivers/net/ice/ice_switch_filter.c > > @@ -1296,6 +1296,8 @@ ice_switch_parse_action(struct ice_pf *pf, > > switch (action_type) { > > case RTE_FLOW_ACTION_TYPE_RSS: > > act_qgrop =3D action->conf; > > + if (act_qgrop->queue_num <=3D 1) > > + goto error; >=20 > Why do you ban the case of queue num =3D1? >=20 > > rule_info->sw_act.fltr_act =3D > > ICE_FWD_TO_QGRP; > > rule_info->sw_act.fwd_id.q_id =3D > > -- > > 2.17.1