From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4AE45A046B; Sat, 9 May 2020 09:35:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CB1A51D92E; Sat, 9 May 2020 09:35:03 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id A19591D716; Sat, 9 May 2020 09:35:02 +0200 (CEST) IronPort-SDR: b7BbmomACtSVegqs6PCuIWSVCFA6rSMdkWSbdH3vHlV7azGI/eUg0Pravd8cFBkMMCIHD1Megi Fv0eODDKQJhw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2020 00:35:01 -0700 IronPort-SDR: RWtT5AwqBvtdCgCp+THvHd+jD2q2ihmdY2bHg59w0u0yg0919W/p0EotjeDWXOPlsy1RRD4ifO ArSLCaOhkckA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,370,1583222400"; d="scan'208";a="408358330" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 09 May 2020 00:35:01 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 9 May 2020 00:35:01 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 9 May 2020 00:35:00 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 9 May 2020 00:35:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ajlXwZVOyYACk3bXhQGQUWZkIZWTuenLr/ve+iXnn8/K0j4zYb+gDY978QDqB3i9aN49SixAkNy8eWMh4YMnTSE9sSmG8D3yoPN4KSKQGrL+bX98Jt/G1Lkmb2ukisQckf9XAuxsWU9BgNh2X8P+Q3fIPmq+X8vsKTuFkgIz85MviyU6vQ45E47bRFjjUTaxH4tr1WwkjWeUn0fH8RIG904FtDT9oQYiC7wDtd+210iwe/2b+seGO2sJA5P3lFYXBd/2q2FPWNzaCP7xI4fV387QA2xG7iqKCv9vD+RvhZlSl12TQYvVd1XHmDrQv8otsARjrACW86bUYWPaqJOTkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qk7sMj0A1eq9ASQ/tUZBY88kMmW/eTXXX/YQumAbfyE=; b=j/RvJ8WUGa1fzODpDgxvzCJyfBmL5QeAUIz00wPQ75oZgdqVUDHYDWxLPSQdzQleAYrk60ZqZK7ZHm75XMBqG/w7K3ARV/gTKd4pRJsrrb0oM2fDTdvXlpRoJIm+BaFSgqmg3FHnPekyTjUVm0oxmlt38frH2VGqFz8h50wkmFnyHSJMSXtHiRcTplv59zaoejwmVp/C0eU0mi+n399/b30XfA8Yn5ksD0t3/w31ikZlc7/ns8EjyUR0QqhqINoXEBSef8aL1pA+GrCPtZuJaMyeY9oCYyr1G1twpWdbp41gq6+Lq+t3X+VsQNJz9V5zG6cZpa2lRtKaDmRun8VexA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qk7sMj0A1eq9ASQ/tUZBY88kMmW/eTXXX/YQumAbfyE=; b=oTc89WiPFC66q3flPc4hoUxr6VnniHoeKXeuSbxWkps6mWUqxGXrABJz9PgEvTp9Yu5bTA3FjyrU6rxnR4FIbPUjKC04KZ/O8s2hd04QA2qktczDv/Hm/lcFfnPRlxXcp0ijH23qtwdGPW3CXkkXWk636A+riywPaqYn9PBBTRw= Received: from MWHPR11MB1391.namprd11.prod.outlook.com (10.169.233.143) by MWHPR11MB1661.namprd11.prod.outlook.com (10.172.53.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.29; Sat, 9 May 2020 07:34:55 +0000 Received: from MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211]) by MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211%7]) with mapi id 15.20.2979.033; Sat, 9 May 2020 07:34:55 +0000 From: "Zhao1, Wei" To: "Sun, GuinanX" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Yang, Qiming" , "Zhang, Qi Z" , "Sun, GuinanX" , "stable@dpdk.org" , "Guo, Jia" Thread-Topic: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting Thread-Index: AQHV5g4SQCYyNSj5GkWMk/UwaDOS2Kif2TsQ Date: Sat, 9 May 2020 07:34:55 +0000 Message-ID: References: <20191219044356.30762-1-guinanx.sun@intel.com> <20200218033931.81821-1-guinanx.sun@intel.com> In-Reply-To: <20200218033931.81821-1-guinanx.sun@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTcyMjcyYTgtODRhNS00MmI2LWFlODEtMGIzMmZlZjJkZDdhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaEN2cXRVUHdHQVlwd2thQ2RHU3puOVZGaUZ1c2pvQ05laVdMbmZ4bm16TitBcXN6MlB5S29OQ2ZubTdVQ2ZBMiJ9 dlp-version: 11.0.600.7 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.203] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 36b072a6-405c-4c15-95ea-08d7f3eb781d x-ms-traffictypediagnostic: MWHPR11MB1661: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-forefront-prvs: 03982FDC1D x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rm8yjq1xGR/pNpoSFal4yt5QbWK2daVKiEbFV8WW7wp1Ab9g9/v2z+xYXJ6gE/+lNFjLSIOHMYl3maMWUstwLv9wQvvAo20YswIK0slnMBVfgxIUpuoBZYp4LQrf6mE0b+DLQElSFKH3Iw8MFBl/oklmvQdgH+LPtbkNBwiGpM/IXNLG1Ov4jX4nosOPv1umaP6jbptsfDf7aya3gEhPXC/nKXbYycIVKie30TKjpwmoy3LHHVL+WJNMsfNxpoUDLCd3+/XIiuIXfGxeNavaV1HqBp/tK99dLfedwBIbgzRsPRRveO3VRC8wCGmfP7hK4im3OcNZ8AS38xjcJJ93YDPUz/g5xG1w+psF0956jGc/qF/jlXohi3UIgNULQ8OghMG9wzG09zXdFcBRHBoOLv2w7rytqWpLnvMRp3j+uN9demJfYNKXEdDNwrNdtx42nSmSKVuG8Xm8/OxB/K+1YE3LUv7R5vbpnJYUmJjyIof5ssgtZBJh+YDuf/m+4urEmZZFgQ0+tMHBBBQYlAQgGA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1391.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(396003)(136003)(39860400002)(376002)(346002)(33430700001)(7696005)(8936002)(33656002)(66476007)(6506007)(4326008)(316002)(54906003)(110136005)(64756008)(450100002)(66446008)(66556008)(53546011)(71200400001)(5660300002)(26005)(76116006)(8676002)(86362001)(52536014)(186003)(33440700001)(107886003)(2906002)(66946007)(478600001)(55016002)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: PINDtjeHkNxPPjvYF9aLeNgbct8PYQ8mhY+vaz00f1c50qdt6gHM26xT9nDp6pWJimLRfmgLWye/7eWBKMe3KYxm+/6vEi5eha9aeZTZ0FWxBAvW408nsOfX2QLrj1wujTGphHN+iCNMGlXNutVN8XBVg5fbiWiMnI02YkV2GY2ktea4xn0GzEYSGMi5ApzIHvMD+wYKVoP0bQEBUu36R1x0yUO+SJLYo2cpSEPtQv446bq0FXWl+o/7NolNCGw3VHktbkRB6273CyExDC2RgZIoDNu6gfYBVIycAWNhGXNhXzT4YDxiyyeyH+1WRT1czPPLHWs7edwYW+9hJVp2Wz0BG+8uLo0km2LLJKKhjVKPFvwHgkAswndx2PZqW2i2L/lmGKZTVt1IluHOF+SMYuQ0xxIOqIhth1QBvJtgaWTV+RJG8KzOKQ31nIXQZA4FJg/hc8dRtGoFDiFuk33kylKhnt3Tkv7kkkhC/mQM1jk= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 36b072a6-405c-4c15-95ea-08d7f3eb781d X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2020 07:34:55.1864 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aXhYHEk+BXNbu04h9YYV9FlB/lR6NJvYb5aa1liM7PjVMYD6kJ08UffZgCMrrSiVg9bP5TYmaFIqki8RnTxpzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1661 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, guinan In this patch, you have add a new parameter of mac_ctrl_frame_fwd, it shou= ld not be clear in ixgbe_dev_stop(), Or it will be over write when do port reset, and also you should add mac_ct= rl_frame_fwd in ixgbe_flow_ctrl_get() for FC info get. Although this patch has been merged, please commit fix patch for it, thanks= ! > -----Original Message----- > From: dev On Behalf Of Guinan Sun > Sent: Tuesday, February 18, 2020 11:40 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Zhang, Qi Z ; Sun, GuinanX > ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting >=20 > When the port starts, the hw register is reset first, and then the requir= ed > parameters are set again. > If the parameters to be used are not set after resetting the register, a = read > register error will occur. This patch is used to fix the problem. >=20 > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org >=20 > Signed-off-by: Guinan Sun > --- > v4: changes > * rebase to dpdk-next-net-intel >=20 > v3: changes > * wrap duplication code into a function > * Modify checkpatch warnings >=20 > v2: changes > * Modify the initial value of requested_mode and current_mode > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 76 +++++++++++++++++++++----------- > drivers/net/ixgbe/ixgbe_ethdev.h | 1 + > 2 files changed, 51 insertions(+), 26 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index 3aab24e82..08b4cc689 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > + } > + > err =3D ixgbe_dev_rxtx_start(dev); > if (err < 0) { > PMD_INIT_LOG(ERR, "Unable to start rxtx queues"); @@ -2900,6 > +2939,8 @@ ixgbe_dev_stop(struct rte_eth_dev *dev) >=20 > adapter->rss_reta_updated =3D 0; >=20 > + adapter->mac_ctrl_frame_fwd =3D 0; > + Delete it please.