From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34BBDA00BE; Tue, 28 Apr 2020 03:19:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BAD5A1D546; Tue, 28 Apr 2020 03:19:01 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id D36F71D540; Tue, 28 Apr 2020 03:18:59 +0200 (CEST) IronPort-SDR: uGvUlsNdS1bhcRIjV/IorfBsdlTeW1Oy853KUsKp9gKrfsfFSq68zCd5b5cal0CM3W/ufsLIBR u/V+iKtNPuLg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2020 18:18:58 -0700 IronPort-SDR: NrpgBgTtmkLOfF1KWk7Y0B3nBqI4TDfv0cdMyikbfh/HXZ9TFd7vWGocENhAOUbrloU8Tizx+F 9ZlpLCCS8cgQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,325,1583222400"; d="scan'208";a="431994818" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by orsmga005.jf.intel.com with ESMTP; 27 Apr 2020 18:18:58 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 27 Apr 2020 18:18:58 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 27 Apr 2020 18:18:58 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 27 Apr 2020 18:18:58 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 27 Apr 2020 18:18:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fYIBzjHvTyUX7vtXvI7M3srdT+h8+XWMyNHkzT6v2ofAGvcoNNnhf9hLFnGcnhaSoadUVsT6CUx80JuVPZhlmUsK1Qma0tKilIIW2y6d9am0FnTnmv9lYklVNm/yrNBloW30pge4n5pCQhdFLdbkhbHw3styCANl0DBBVflLsP1h7+1RB2BiELt+bh6GHlbSMZ+4ryrdSXxV8OMwtV3rcTOgyV/dNTZgU/MfDcEsJjpnM4q1+DphX3UYJy68n5DB2mzXM97ygJ4tQ9FfTnuz7G0YzmvXkK+wyArKyzdgbiXmFj2DsoQWPFQHLJNC0ID7cB5FoiuxNp6eTfPL37zT0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OXY1vyUT6sRo9Qy1b74AKpA8LQGT6SLGMqAVY+vSA9k=; b=khgS64SBoGLzfJy830D2Sd1UPDsV3bB0ElcCH4JgDhutguEPvj1fBG9+7xyJMcKcVrP0TdGgK/JNxCnWDF0UHeADYDf5qEmZfFwhEA+jm89q8voczBRDAPyjdY+AP5q2JOMCaIu6t5B0TqY3V4t1mjPdpDF/o/E/vlH+TDYV9Gun/BUFC8pAUPVWotf1XByHaZM8PDtriYBbFRHhAXZ8TqQAAev21x0c8ObtBj4l54nQ21Md3mQWZqGe2CjHITqCNEG2j8Ulj+SNDRbuDxoK/5aUa8LlXqr+6XxZv1KOKrsvj2hQJ8PC8Ephr1Pr81Ii2CMqK9X5hXmKWV/hQZWw2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OXY1vyUT6sRo9Qy1b74AKpA8LQGT6SLGMqAVY+vSA9k=; b=RmRDToX6W1oF+orGZycmcrcI8y9oTtFZ5vY3AoFLQTYWBLaIpkZCcsJCv7ex7Wfyd85gXYZkF3XYr5xtuVxvsVdaV+AXun7fQqdiZpCNyxk3PBm8Pl5btYj9Vd/W5vZu18EUka5y3q96m35PKjaX0pmtAIEYfHKFBwkNoypgYn4= Received: from MWHPR11MB1391.namprd11.prod.outlook.com (2603:10b6:300:23::15) by MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Tue, 28 Apr 2020 01:18:49 +0000 Received: from MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211]) by MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211%7]) with mapi id 15.20.2937.023; Tue, 28 Apr 2020 01:18:49 +0000 From: "Zhao1, Wei" To: "Xing, Beilei" , "dev@dpdk.org" CC: "maxime.leroy@6wind.com" , "stable@dpdk.org" Thread-Topic: [PATCH 3/3] net/i40e: remove teardown when flush FDIR filter Thread-Index: AQHWHGbSlhClp35kXUGaY3jU+Us0XaiNu6IAgAABREA= Date: Tue, 28 Apr 2020 01:18:49 +0000 Message-ID: References: <20200427071500.14767-1-wei.zhao1@intel.com> <20200427071500.14767-4-wei.zhao1@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzU4YmRjYTUtNjk3NC00N2EwLWIzMzItMzg3MzAwYTcyMzRjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoid1VrUHQwZjdLTGhwM1UrS3JUZDFFcytOOUJ2XC9QXC91bGZRNzUwT0JGcXZlaHhWenlwS0l6NjVRUk9qRis1V1wvbiJ9 dlp-version: 11.0.600.7 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action authentication-results: spf=none (sender IP is ) smtp.mailfrom=wei.zhao1@intel.com; x-originating-ip: [134.191.221.122] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 77c3baf5-efca-48ae-1b77-08d7eb121b74 x-ms-traffictypediagnostic: MWHPR11MB1631: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:229; x-forefront-prvs: 0387D64A71 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1391.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(396003)(366004)(136003)(39860400002)(346002)(376002)(81156014)(86362001)(5660300002)(478600001)(4326008)(66446008)(64756008)(66556008)(66476007)(66946007)(76116006)(6506007)(186003)(7696005)(52536014)(53546011)(26005)(8676002)(8936002)(316002)(9686003)(33656002)(55016002)(71200400001)(110136005)(2906002)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oojpkjQ/yVy7EpG3jvInHJZX3GBI/0JK5Oy1M8arXulvSMLjc1QOoH7cFjAFOYDntwJ1RTkj1UIY/RIi+GDpvlUdlcghth8s6jeRvc9rhpLq7hYFic32/2JaeLowCLT8zicGyToiW3rLEKa12QBxTfvmaoq09p02xUxuXMf7y0nJqDU255oIZhSHbi3sR3y7CMyf20368J7iFmLC/x5mbLeJd3KCrnSvnlG1adBmLOnRWUjiwrY+OlYsph+AVCBjo+Xy9MZU6cN4yDdJeR24f2olvhGaN9wCY8mpYURrbxyAgIQcsef5jjJpFLTOqsXM8td+whY9Ag351WIp5d+eEzXgINzZQ2dH4oReUcwGiEfizwLgtx9xCz+0SS0GWlGJaWu3deDWqMB0tgriO/ISlyRsKfIYxtAej63vknSvLTJVhk26EdaeRnTldBDHORDj x-ms-exchange-antispam-messagedata: OZxlBp8XUuVilbVW8r/ze8dOC+PQujak8NOXt8fwispc+P9R3zHd5qIVQVAdSBNIuLHcjS83rznwmcp3YUvNNWU5Rd0YlAi4o+odtOgpa8ix+JTmLcb05LepW+VNaB4EX4p3CoRgBqYP2t6o8DHvPL4IuXs2x1iI+UZXBmTDumBOoOn1CrjNVslK9vlV0+d86/McI99Hrk+JbN0nPVFbNjykCycQYrmQzu5ylavV0KjwID5oAm4WDpgJMsdKR9+TwdRgukxeBwYFJijAHhwXBIWCs0BwEMl7y4S9UDdqNNv4uym1bMQfKp6JgfkebztiQdF+lSDwgotTWoQxdno+1Zbgrmu6In5odJ9l6LWvBsp2Nl0SLsbxiYzlc9ordKQO8d24sjv/vfKwKPwccURA0MuvF61O6LS3xMDmf2PdC35ecXCF+BElpHynLgBBFRT82WbBbjL+WdEgy5n7O/Ayq43WT8GRgxlzAcWAZVxwKK8ITNS3374auZ2l8zVxE88GbSlpkQDEepJgv8+sV/ibXk8yWwCDffbqiTHVCNPGnt6qpXqUn7r3EQCK3zFJSHvA9XrqlwpkGvmdwYREElACfeCxGabsmyFLRNDHPLyzduQe371msBMhDeLMhc7TAbhAHyT+hKE9y/54O2vVUTzCqbq5OWQhk75PkpPaVobtBkvg/6nQ0W5Xi2IyUTiAtq9feYwjkc//PdnkHDXTLbdQFpMnD2fIVO6tYxeSA12qxc8jcUp3EuBTmz1yjnis7Z+0+3mCj+MC7VsLbEAxowhRSgNh4mkIewYivf54+ebYh9XzvakR9s3OJewAKHrc3wO8 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 77c3baf5-efca-48ae-1b77-08d7eb121b74 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2020 01:18:49.6868 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bebkVN//ERN0OoHsMt9AdZM42cD7MEl54SPPdS+E1utvK9WLopRZ4ftWmrmz3ST0ZwltqgmGRMOGVSeYwk7pRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1631 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 3/3] net/i40e: remove teardown when flush FDIR filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Xing, Beilei > Sent: Tuesday, April 28, 2020 9:13 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: maxime.leroy@6wind.com; stable@dpdk.org > Subject: RE: [PATCH 3/3] net/i40e: remove teardown when flush FDIR filter >=20 >=20 >=20 > > -----Original Message----- > > From: Zhao1, Wei > > Sent: Monday, April 27, 2020 3:15 PM > > To: dev@dpdk.org > > Cc: Xing, Beilei ; maxime.leroy@6wind.com; > > stable@dpdk.org; Zhao1, Wei > > Subject: [PATCH 3/3] net/i40e: remove teardown when flush FDIR filter > > > > When we flush FDIR filter, we can not call i40e_fdir_teardown() > > function as it will free vsi used for FDIR, then the vsi->base_queue > > will be freed from pf- > > >qp_pool, but vsi->base_queue can only get once when do dev init in > > i40e_pf_setup(). If we free it, it will never be alloc again. >=20 > Then we should teardown fdir in dev_uninit, right? Yes, dev_close has call teardown function. >=20 > > > > Bugzilla ID: 404 > > Fixes: 2e67a7fbf3ff ("net/i40e: config flow director automatically") > > Cc: stable@dpdk.org > > > > Signed-off-by: Wei Zhao > > --- > > drivers/net/i40e/i40e_flow.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_flow.c > > b/drivers/net/i40e/i40e_flow.c index > > 1533d5abb..65f877866 100644 > > --- a/drivers/net/i40e/i40e_flow.c > > +++ b/drivers/net/i40e/i40e_flow.c > > @@ -5145,7 +5145,6 @@ i40e_flow_destroy(struct rte_eth_dev *dev, > > > > /* If the last flow is destroyed, disable fdir. */ > > if (!ret && TAILQ_EMPTY(&pf->fdir.fdir_list)) { > > - i40e_fdir_teardown(pf); > > i40e_fdir_rx_proc_enable(dev, 0); > > } > > break; > > @@ -5343,8 +5342,6 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf) > > pf->fdir.inset_flag[pctype] =3D 0; > > } > > > > - i40e_fdir_teardown(pf); > > - > > return ret; > > } > > > > -- > > 2.19.1