DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Fu, Qi" <qi.fu@intel.com>
Subject: Re: [dpdk-dev] [PATCH 3/3] net/ice: add flow support for AH ESP and L2TP
Date: Mon, 20 Apr 2020 05:18:51 +0000	[thread overview]
Message-ID: <MWHPR11MB1391639780AE62FB6A607698B7D40@MWHPR11MB1391.namprd11.prod.outlook.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E70611547FDAEA@SHSMSX103.ccr.corp.intel.com>

Ok, fix in v2

> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Monday, April 20, 2020 1:17 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Fu, Qi <qi.fu@intel.com>
> Subject: RE: [PATCH 3/3] net/ice: add flow support for AH ESP and L2TP
> 
> 
> 
> > -----Original Message-----
> > From: Zhao1, Wei <wei.zhao1@intel.com>
> > Sent: Friday, April 17, 2020 4:26 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Fu, Qi <qi.fu@intel.com>;
> > Zhao1, Wei <wei.zhao1@intel.com>
> > Subject: [PATCH 3/3] net/ice: add flow support for AH ESP and L2TP
> >
> > Add switch filter support for AH ESP and L2TP protocol, and use spi or
> > session idas input set for switch rule.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> .....
> 
> >  struct sw_meta {
> >  	struct ice_adv_lkup_elem *list;
> > @@ -148,16 +166,24 @@ ice_pattern_match_item
> > ice_switch_pattern_dist_comms[] = {
> >  			ICE_SW_INSET_MAC_PPPOE_PROTO, ICE_INSET_NONE},
> >  	{pattern_eth_vlan_pppoes_proto,
> >  			ICE_SW_INSET_MAC_PPPOE_PROTO, ICE_INSET_NONE},
> > +	{pattern_eth_ipv4_esp,
> > +			ICE_SW_INSET_MAC_IPV4_ESP, ICE_INSET_NONE},
> > +	{pattern_eth_ipv4_udp_esp,
> > +			ICE_SW_INSET_MAC_IPV6_ESP, ICE_INSET_NONE},
> 
> Why IPv6 input be used by IPv4 flow? Just typo?
> 
> >  	{pattern_eth_ipv6_esp,
> > -			ICE_INSET_NONE, ICE_INSET_NONE},
> > +			ICE_SW_INSET_MAC_IPV4_ESP, ICE_INSET_NONE},
> 
> Same issue.
> 
> 


  reply	other threads:[~2020-04-20  5:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-17  8:26 [dpdk-dev] [PATCH 0/3] add support for L2TP AH ESP and NAT-T on switch Wei Zhao
2020-04-17  8:26 ` [dpdk-dev] [PATCH 1/3] net/ice/base: add support for " Wei Zhao
2020-04-17  8:26 ` [dpdk-dev] [PATCH 2/3] net/ice/base: add support for L2TP " Wei Zhao
2020-04-17  8:26 ` [dpdk-dev] [PATCH 3/3] net/ice: add flow support for AH ESP and L2TP Wei Zhao
2020-04-20  5:16   ` Zhang, Qi Z
2020-04-20  5:18     ` Zhao1, Wei [this message]
2020-04-20  5:18 ` [dpdk-dev] [PATCH v2 0/3] add support for L2TP AH ESP and NAT-T on switch Wei Zhao
2020-04-20  5:18   ` [dpdk-dev] [PATCH v2 1/3] net/ice/base: add support for " Wei Zhao
2020-04-20  5:18   ` [dpdk-dev] [PATCH v2 2/3] net/ice/base: add support for L2TP " Wei Zhao
2020-04-20  5:18   ` [dpdk-dev] [PATCH v2 3/3] net/ice: add flow support for AH ESP and L2TP Wei Zhao
2020-04-20  7:26   ` [dpdk-dev] [PATCH v2 0/3] add support for L2TP AH ESP and NAT-T on switch Zhang, Qi Z
2020-04-22  6:38     ` Ye Xiaolong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR11MB1391639780AE62FB6A607698B7D40@MWHPR11MB1391.namprd11.prod.outlook.com \
    --to=wei.zhao1@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.fu@intel.com \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).