From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2951DA0093; Fri, 22 May 2020 11:46:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ADA761D976; Fri, 22 May 2020 11:46:42 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 620A61D961; Fri, 22 May 2020 11:46:40 +0200 (CEST) IronPort-SDR: 0F93aZT61rBGiolUMzQ38ZYkTb36crDz4vJUMtFA0YYhYjPvFi1y47Tk+iEQYo+GY8I82NA3gs sTfZPvII00yg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2020 02:46:38 -0700 IronPort-SDR: zDlRd3skpd9K0iORXmJ9EvFjR5NX9qPVU2PVTFJpG/szJIyH+EZK1lP3ikHYPuHIfUlgiJBRKS DfLROPdTHSJA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,421,1583222400"; d="scan'208";a="254239011" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga007.fm.intel.com with ESMTP; 22 May 2020 02:46:38 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 22 May 2020 02:46:38 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 22 May 2020 02:46:38 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.52) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 22 May 2020 02:46:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OEMUY+N+3qGKm1mm1OJOGVwb7NMVRftE1hrituNay+3wuOWFZBsO7PAHF7MmQyMWiDc6PTl++B+P3MINrd6GMdeCNONgvnHmxjIVC2XaWHrpddY+GSAYLj/EPi6IFjh9/2iykGRq6BpTHop+QMIIFYF5MJJhBByFQZ21/0OWZY4br2aryRzAiQXRcv8ijYGWaIhfrtjXt4MfgjlXO8EDDiosPevdwTdxcrMeLkxkvg8BvFF55VZi35zxrQ6J9xhfZMu8RrfOeGzcTOL9PD1d+SsfoYWmTtkFL2YyySMviQJbc551BFxPLlZ5Ob/AV8UrQDVQVF2tO03T3hKvhQWOTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=60HEfQmpDokGvqMK0aKyYdhLEo85aWiMblFzVzOPZV0=; b=S/gyW3/0qGc9DYsWkZ55NA8MwzmvEpUX0dIL7j+8K3g2Sn4UB4iyay3uIvYT0ARzFBZUxnYBo6SWgWK0MVWA1+eJseB/NcfrQtZnQzh/gTuZNCyVtBuAjdu2BQhWuMIu2nETnVVsEEmAtSYwCB4tubTQ0wSkoFG1+2iVDCVpMQWt5jBhWrGxF2Ch5rkqhyZ6gLyIr/TsIxKvpYGayofzN3b6RfypNjvxh/voj0SAa8xF6yNE23TMkaPQyyxkCagy/gQHqaCwvmckH8Q5QGcA8/kwd6h3ad8IbiPtB0dcWKBvXP807cmi2pWALcFXQqO3+rvclVEKdC3zlKCnhT7N2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=60HEfQmpDokGvqMK0aKyYdhLEo85aWiMblFzVzOPZV0=; b=A9TWUpob3UINkPtnLb7g+xaMcVowchO9pddOjjZS9bSeN3S3V9oJ2zddkcOahQWZEb4MqLkLDbjb/4Xrrf1oWm2iZgpy9ZDXDZJ2+1S9WjNg+rwMySm/XHB6XWWc8JsPwCDRfhDPxxj7mTeHhNuRseaUPCIiRMwfUxPZempPPCg= Received: from MWHPR11MB1391.namprd11.prod.outlook.com (10.169.233.143) by MWHPR11MB0029.namprd11.prod.outlook.com (10.164.204.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.24; Fri, 22 May 2020 09:46:37 +0000 Received: from MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211]) by MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211%7]) with mapi id 15.20.3021.024; Fri, 22 May 2020 09:46:37 +0000 From: "Zhao1, Wei" To: "Sun, GuinanX" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Yang, Qiming" , "Ye, Xiaolong" Thread-Topic: [PATCH] net/ixgbe: delete MAC control frame fwd in struct adapter Thread-Index: AQHWMAKP7LvQ+1xyfU2gqq57qOf1Yaiz22NQ Date: Fri, 22 May 2020 09:46:37 +0000 Message-ID: References: <20200522061208.31694-1-guinanx.sun@intel.com> In-Reply-To: <20200522061208.31694-1-guinanx.sun@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGY2ZTMxZmMtY2JmZi00ZTdkLTgzOWItMjEyOTcxNzliMTlhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTGRGeG5OcjhYQ000UWV5MEdJNk1hVXp1ektPVHFkWStEa3dIYnlHcTZcL0VkdUJ4THE4TFA1aCtkNVJVeUd4RmoifQ== dlp-version: 11.0.600.7 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.213] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a41f445f-91ac-4121-d78c-08d7fe350552 x-ms-traffictypediagnostic: MWHPR11MB0029: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 04111BAC64 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ij+dWqbBhvTQ219M4vZ+pWE1GgeVyMSFC+rmUM9jmhL7WtlarnMRh5GR0C3eEkmzEHKZGq/NKMa66hTS1hEXarHahjfUdIEHtTe26+Rh0a3Jl1wDc2lLTGDUq0gm92pDS1mJbabwnlGsctcizKKy/POCPV4Lt04CP4u2aCqbh5IvRe74CpwH1LFlTJi+yFmE555m7H/pZnmFj7xw5I9WsTUmk0vQDlSYCKIp5NGYXLTr3avtB4U6St4RQ0qVMTXZgvXCKKlrmplcfCHJf+9iws6XrdOccXJxdKbmmaRK5fNv5t40A98GBqnkYY4Vir+KJ6ckFTxvGz4H1j0IoAJj8A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1391.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(39860400002)(396003)(376002)(136003)(366004)(346002)(71200400001)(4326008)(450100002)(478600001)(107886003)(26005)(186003)(53546011)(6506007)(5660300002)(9686003)(7696005)(2906002)(66446008)(8676002)(110136005)(8936002)(66946007)(54906003)(64756008)(52536014)(316002)(66556008)(66476007)(86362001)(55016002)(76116006)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: Ic0TRJD1V0di5O0JMki89TDZ7Ha6jhJt7j4UQeH4Yn32/aMEJMBujoXtrDMVJdcig2bOsOoz6F5c3TJaNbVd9W9x/JfGUmcXo5L9xzgFx0InFIhv6yAdDIdTmA5Kb3JQf19HxsQp02M6oy5nL3TpBGTLMs2uE//VEw3P9oOM+14zU7IWQ+ttzyzq57SijZZU775sc1EUenD7gef7c/eW0fdzOY8zH5mcc2SabPaP4yWvoXkGiprKNc7gLa+qP2mArp6ivRh8ceERwFfz2N+D+CB6CSDiXv9OPTRFgKgLlUv7O6tcpqViv6LiSy045a6+xdRV8lhYIttqPq44MYqxMMAMyev6seB4vwniLZ/QZIkHWitdPxJrJKKcqghlftRAgaoQw1ZGfHO8uaOO3nQoV97/bRp257ydnmiRSwaapzKclAxHfMwTF3JmTsFZQ8VLHl8xK2ZFycPCwulk/VdvE/Ic2xOyIBEdyyZ0m+XuSCY= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: a41f445f-91ac-4121-d78c-08d7fe350552 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2020 09:46:37.1231 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YbNV6czCHZA/crPkX1c/+ifq8JVzIKTDZFZzhPc55NOqMAzbfSbSu7gbk6bE+lOy3BgJxmwkakemqBSb4mlIuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0029 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: delete MAC control frame fwd in struct adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Sun, GuinanX > Sent: Friday, May 22, 2020 2:12 PM > To: dev@dpdk.org > Cc: Zhao1, Wei ; Sun, GuinanX > ; stable@dpdk.org > Subject: [PATCH] net/ixgbe: delete MAC control frame fwd in struct adapte= r >=20 > If some user set mac_ctrl_frame_fwd to 1 from fc ops, then he do a port r= eset > process of >=20 > testpmd> start > testpmd> set flow_ctrl mac_ctrl_frame_fwd on 0 stop port stop 0 port > testpmd> start 0 start >=20 > Then after this process, the mac_ctrl_frame_fwd has been change to "off",= so > we should delete "adapter->mac_ctrl_frame_fwd =3D 0;" from dev-stop. >=20 > In addition, add a value to mac_ctrl_frame_fwd in the ixgbe_flow_ctrl_get= () > function. >=20 > Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting") > Cc: stable@dpdk.org >=20 > Signed-off-by: SunGuinan > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index f8a84c565..dd4023f01 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -2939,8 +2939,6 @@ ixgbe_dev_stop(struct rte_eth_dev *dev) >=20 > adapter->rss_reta_updated =3D 0; >=20 > - adapter->mac_ctrl_frame_fwd =3D 0; > - > hw->adapter_stopped =3D true; > } >=20 > @@ -4754,6 +4752,8 @@ ixgbe_flow_ctrl_get(struct rte_eth_dev *dev, struct > rte_eth_fc_conf *fc_conf) > * MFLCN register. > */ > mflcn_reg =3D IXGBE_READ_REG(hw, IXGBE_MFLCN); > + fc_conf->mac_ctrl_frame_fwd =3D mflcn_reg; > + Error, that is not right!! > if (mflcn_reg & (IXGBE_MFLCN_RPFCE | IXGBE_MFLCN_RFCE)) > rx_pause =3D 1; > else > -- > 2.17.1