From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2B59A034F; Tue, 28 Apr 2020 09:45:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8F0591D509; Tue, 28 Apr 2020 09:45:11 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 6C7391D412; Tue, 28 Apr 2020 09:45:08 +0200 (CEST) IronPort-SDR: ITKJoxiTcnIf7/gxbpIVqsnHd2Px4LFy2+6SHazk+25CB355oZkiryQ/amDStdNCvC8nF0hP6K M2x7AKD9RR/Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2020 00:45:08 -0700 IronPort-SDR: Q3zyorcDfDemSUo3CW/QaFarsO+KwRds2uyJlXnqLMDvr3hIO5EOKa3wp1+XcYbfU3IyJnem37 v+Kkz7rKbE3w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,327,1583222400"; d="scan'208";a="404609239" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 28 Apr 2020 00:45:08 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 28 Apr 2020 00:45:07 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 28 Apr 2020 00:45:07 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.53) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 28 Apr 2020 00:44:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FOcqtBokDEtv72Fa61dMjelo3nzEWh3H2ibz/FCHNN4nZanfIOYquEjzzXNpcuXQhGWbuisYQ/PzolMD46vJNZAkF0vUVc/0+oQAzBCfLIZJcV1nNtWx3Ub1EhP3Hz8O6r3kucw6QdC0sTbMsrDvH94dVNxe4HYjNel6jFcTNYEgKGP7YnpVhlNTkGn4pgjFiPhaGCdYP/3ZnlKDD45xeBHjLNCfP0MCgqAJjapn88wugQl+NYx5AMqugxYVMG7gTzIZ6MK5UQ/lIl4bjXUEpTB3cChoEKAqHjZWhxuGT1nMEyQcXRedGfm6tra6Xkp3WJN9RaTEwxNCjYM0V8ABxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kwd7BXhEgv3ay0Rbsip9oCXQ6ILgBsvoNmS5udm9g9M=; b=kUMsAV5Q7OlTcp6E+fwuUkPsyOUK03dJMtzd9FtxQ8zdYW7shftQPqsnZBfHj5+j52pXjqDpkXy6NxhbHKvHzH5CzdabMJtcOOq3iLHVBIieyH9k+PzXoqERIvp8rS3gJDaPt5CLEIUUa9kfgxZhkC0dbG6UFxBYP0ZrVojdG8j8YBu5f3h7LdXu5FJcGTBtp7rWRWPWVdj+Oa1MB2v6+PuaR0OSO8zqDQQCQiHAMupqnUn6bQdcjiuXOAhxsxNUHsfA9iKZYm4Vl+VM4LOFpPMMCSmSyxqCkIA/ed+sP1SwHXSDQh5+eZh32uFuMywU794QqjpQ3ZjIAUk0lB8eUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kwd7BXhEgv3ay0Rbsip9oCXQ6ILgBsvoNmS5udm9g9M=; b=RqtH7dN28uGwUQhQcDWNvY1bvCL5EljztsaznAaj0XTSL5NoZo0lBSLtCcI4qURNh0WosmqZm7Oe5L37id0SFkNvKu/kqI7V1OJ9G960jCMulSS9rxRB3DxuO9yq0jAPQq1uCrbouce1oYotMjM9RjOGEgWgZ5DXU3TqVO8ux8c= Received: from MWHPR11MB1391.namprd11.prod.outlook.com (2603:10b6:300:23::15) by MWHPR11MB1327.namprd11.prod.outlook.com (2603:10b6:300:2a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Tue, 28 Apr 2020 07:44:47 +0000 Received: from MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211]) by MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211%7]) with mapi id 15.20.2937.023; Tue, 28 Apr 2020 07:44:47 +0000 From: "Zhao1, Wei" To: "Xing, Beilei" , "dev@dpdk.org" CC: "stable@dpdk.org" , "maxime.leroy@6wind.com" Thread-Topic: [PATCH v2 3/3] net/i40e: remove teardown when flush FDIR filter Thread-Index: AQHWHSPn/6c94SExZUOVEUuKWX+K7KiOH5eAgAAHpcA= Date: Tue, 28 Apr 2020 07:44:47 +0000 Message-ID: References: <20200427071500.14767-1-wei.zhao1@intel.com> <20200428054815.3551-1-wei.zhao1@intel.com> <20200428054815.3551-4-wei.zhao1@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmVmMTBjYjctNGU3NS00Y2RiLWJlNjctZmEzZWQ0N2Q1ZGRiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTnpOelM5RjNCOE1MelJQbkUzRVBpOHpCNW10c0JRSlRkN0lON2tzNmozTk16NVdMMHU0SzFkU0VJSnV3OXAxaiJ9 dlp-version: 11.0.600.7 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [134.191.221.116] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f1c67913-93d0-4663-cb48-08d7eb4806a8 x-ms-traffictypediagnostic: MWHPR11MB1327: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:538; x-forefront-prvs: 0387D64A71 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1391.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(346002)(136003)(39860400002)(396003)(376002)(366004)(186003)(55016002)(4326008)(26005)(110136005)(9686003)(64756008)(66476007)(7696005)(8936002)(53546011)(66446008)(76116006)(81156014)(52536014)(54906003)(316002)(66946007)(66556008)(6506007)(71200400001)(2906002)(33656002)(478600001)(8676002)(86362001)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LGAgPNIOVucd90py3MOkVq6RoC9tOg9UUDH6e7ibXGkbACdMWldnUJY+ETnrALvw35GC+2ipWuTBiduNpW4YCOceHKXJ00HWw2mGwDkMDhHyAPYp7pJ4Y+Vtw/nVyLm9D5ZdQ4kAaYws6GvY7blJ1syKFsQwxIZ+CBCp8ojDyIJJ5OtCUHPtlc8AHUVelY3FN16nuX8ul52Ep4GOE4/87C/ZEjAcMh4Pyoe3uQC2Q2RZpWpGnSWB6PGogPnwiK34ZID7Nwg2JX2lD+infV22AWI4WmmefR/I0AZeUeEXMA4F5ikbcPx6Y73rvnmKWoMflFfb+xJeDx4hfmHvQOHD2Ab+srwlg5g1WRSOAbEINGkwoDbYZZAPC5W8lcMiHaO5DSvZkBZNXyBb5MLhnmwmcuGFUTez7MJEpQP2rsGPuh9UR7KOuPtFbdquSaCysEd3 x-ms-exchange-antispam-messagedata: i2KnFPWHH0TLadbHe9HXuEz8ZnwcKHD0eTmTwzZAcH76ZmYrxbrZe7CxkrCOUzkFm9Nk8E9Rg4N9o9XjOJEcxg5ioHGN6LfzTxGpryb8rMmoFpvBRI2YnEM70wOk6qNcsy5216ckBaiG4rRJaLGWxDTkVTGfwyltUNjqTWAVbQm/Xl4wG11L6Y7nm4MlPNhmSHjogd6fOt8KwR/Avg7LzMatp074pcTFS5thGtdYdY42tWkyXE+8rO7H/1cNB0sPiOQ1Rwwcf5FaociClgeZ2ntLmYqVSMr157dkJMtJRsxuoinbF/vEfaJAohAm84FygGCwWCHky+3w0S7PduWt+V5pKeGt/iVJ/YfVgrho5yJYJRGD3rvaleYaNVLnxAWBBIatwzepOLNiuGw8TsD0gUe/N4M7fF8U1U/uSRzIKYjSEVbyq+dbEb7zQ19faYI7HidjZ1uidxiavOH1Fe2Lg7pV6iMqsZLf6W5yIYFzNWtxjxU7P3YbVE3ENTXMhjrCETi3l0V3gMnaEfO5K9qOPuZIJ0HYyIsxJRaQXx+R73jqd84Se1BrVd0nZEL0sSd0Md8tBRUqZ0cNZZo7QHEj+yjeuq55uALxUlJZvGmPkenSXX6Hanr3wXgVNMUIC7odyOKhmu94RBoJQXytsatPaMYja/c7Zl2ETHuLIK7VHR6zr4bqcxZhvX5VTu5pk7lZS2x1BL4U4gZtJvreoCb5BBbJjn5omqgM5qudEALSo72YpiyxHEJyc67qqsURQOFNAfysNFjklbySpCa/KBjAq5zKV2e4EbxGI1/8OmrTKNYnDETV/yzR36VOWCshxMST Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f1c67913-93d0-4663-cb48-08d7eb4806a8 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2020 07:44:47.7362 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DgbYczeGAEqTq50NZNeZ+jtTjGVPglY6JQDcvJkFU/l812k6o38gq6SsXF6n+PeUJlz4d4lMoBYomwWnZBuh+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1327 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 3/3] net/i40e: remove teardown when flush FDIR filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Xing, Beilei > Sent: Tuesday, April 28, 2020 3:16 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: stable@dpdk.org; maxime.leroy@6wind.com > Subject: RE: [PATCH v2 3/3] net/i40e: remove teardown when flush FDIR fil= ter >=20 > Didn't address my comment in v1 patch. Hi,=20 it has exist in unit. >=20 > > -----Original Message----- > > From: Zhao1, Wei > > Sent: Tuesday, April 28, 2020 1:48 PM > > To: dev@dpdk.org > > Cc: stable@dpdk.org; Xing, Beilei ; > > maxime.leroy@6wind.com; Zhao1, Wei > > Subject: [PATCH v2 3/3] net/i40e: remove teardown when flush FDIR > > filter > > > > When we flush FDIR filter, we can not call i40e_fdir_teardown() > > function as it will free vsi used for FDIR, then the vsi->base_queue > > will be freed from pf- > > >qp_pool, but vsi->base_queue can only get once when do dev init in > > i40e_pf_setup(). If we free it, it will never be alloc again. > > > > Bugzilla ID: 404 > > Fixes: 2e67a7fbf3ff ("net/i40e: config flow director automatically") > > Cc: stable@dpdk.org > > > > Signed-off-by: Wei Zhao > > --- > > drivers/net/i40e/i40e_flow.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_flow.c > > b/drivers/net/i40e/i40e_flow.c index > > 1533d5abb..65f877866 100644 > > --- a/drivers/net/i40e/i40e_flow.c > > +++ b/drivers/net/i40e/i40e_flow.c > > @@ -5145,7 +5145,6 @@ i40e_flow_destroy(struct rte_eth_dev *dev, > > > > /* If the last flow is destroyed, disable fdir. */ > > if (!ret && TAILQ_EMPTY(&pf->fdir.fdir_list)) { > > - i40e_fdir_teardown(pf); > > i40e_fdir_rx_proc_enable(dev, 0); > > } > > break; > > @@ -5343,8 +5342,6 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf) > > pf->fdir.inset_flag[pctype] =3D 0; > > } > > > > - i40e_fdir_teardown(pf); > > - > > return ret; > > } > > > > -- > > 2.19.1