From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4141A00C4; Fri, 24 Apr 2020 05:16:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 998A81BFE2; Fri, 24 Apr 2020 05:16:02 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 4F27A1BFD9 for ; Fri, 24 Apr 2020 05:16:01 +0200 (CEST) IronPort-SDR: WPZ78m50JxaQdR3WbxRsTgO7f0McG7EqmDrcMsFcDoU59wwuddIPq5dTLJFMyTe57RzfpiDuEh aM7FeFFiKDTA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2020 20:16:00 -0700 IronPort-SDR: VGwZIYXsM8y7Hel4KJFmEi7f5se8lbvbLUsj23jamcDStcGL83bMC5t+TEtlLjvfIPI9lXNT06 ynqRkNff1HCA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,310,1583222400"; d="scan'208";a="274459136" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 23 Apr 2020 20:15:59 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Apr 2020 20:14:49 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Apr 2020 20:14:49 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.55) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Apr 2020 20:14:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jqlRkRzJzCskfuCrcmKNL5xvhR5J9oQu2DkrpuCrBRwA854NY5WDzGZflU5Ti0CNiU4AY59JSo1yOfkYUeR3IaPR7iMiSuCYmyevhMX73RQnz0z9r0MxwoGC8CE8/CygRGf9GhmqIB0hJWS6jF3jTk7p/155WkHwrsRCvU/NjO6Z9BpO3cQIir2pcdncZl23ZdZIhLXdBrGn6wyC/8Ez02TDT4Q5dT3JGHXnQz9w9loJRUvDbRVCKPxVL6byDLaQhufRXcUYS+GhI+CCtsjchxl2FOxHOlTQ+HAYSuTSCBH+r+A7YhLm28FpUHkin+Lnl56qTNduFYH4DyttfnNNew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dv4t2P8eu66AEcCa5HK144K+3YoSZuVcrDSjgnmUKaQ=; b=MqJcTeZAYj66yc6gvREjevemO5C1uJ1dxmZinHzBkWBzEjlanfiu/fCDbY/eGpVN7veqWUAJnKYOiAWjTWrnX0kmKjk1kodZIKZYHXEQAxFxyHVBjcf4qNq+mBOkhLab46lw7se9kQcDhdPSGLgvFF+qMs2QZzvY0Ct2ZwP/mRyOYVriKlLtXEI5QC0YDqVLqdjezFrlhWakPeh/kBVYPE+NmQJ6J0xYfTgY8r1GpT8Y6vfEzWvADd1t6VjIBw/dENmaYPbvV6+sv3EHfVFzInshO8ezN1KCVz5hvimH7119vOkj3MKq/GxkOlZHMewsyc2q/B+EmNU7etGZE4LUFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dv4t2P8eu66AEcCa5HK144K+3YoSZuVcrDSjgnmUKaQ=; b=W53ZshiB/upFtnnECDKU3WMt8CHIkfkjcndjBnXdAHrIry+hdfUV+m7J2N1J8Z4I4lhayv9PvOg2uOeMaDiVCkJZ2899BofpivpnrtCYC7DX+fpFopPUG3g0MMyo5PFKQy0M3k8WQWuxd9/HSdD0G78EHk+zKllr3f07McpkS8M= Received: from MWHPR11MB1391.namprd11.prod.outlook.com (2603:10b6:300:23::15) by MWHPR11MB1728.namprd11.prod.outlook.com (2603:10b6:300:2b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Fri, 24 Apr 2020 03:14:47 +0000 Received: from MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211]) by MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211%7]) with mapi id 15.20.2937.012; Fri, 24 Apr 2020 03:14:46 +0000 From: "Zhao1, Wei" To: "Zhang, Qi Z" , "Yang, Qiming" CC: "Ye, Xiaolong" , "Xing, Beilei" , "Zhang, Xiao" , "dev@dpdk.org" , "Zhang, Qi Z" Thread-Topic: [dpdk-dev] [PATCH] net/ice/base: workaround for unexpected rule deletion Thread-Index: AQHWGSZWA5H4D8nZa0yzFPXc+bhtCaiHmhgQ Date: Fri, 24 Apr 2020 03:14:46 +0000 Message-ID: References: <20200423042213.17391-1-qi.z.zhang@intel.com> In-Reply-To: <20200423042213.17391-1-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMThlYzg1NzItZmZmZi00ZWY0LWI0YzMtMTM3Yjc3MThiZGViIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYk9EWldDUVdwWXV1TnJwUWxieXhKc1wvMkQzSmgza0hlRDdaSnJZZG54VGVGS0hpODNSc1hsV1ljQjliblRpY2sifQ== dlp-version: 11.0.600.7 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action authentication-results: spf=none (sender IP is ) smtp.mailfrom=wei.zhao1@intel.com; x-originating-ip: [134.134.136.209] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7f68c9c4-1825-42fd-f9c3-08d7e7fda48a x-ms-traffictypediagnostic: MWHPR11MB1728: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 03838E948C x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1391.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(39860400002)(346002)(376002)(136003)(396003)(366004)(316002)(81156014)(5660300002)(4326008)(107886003)(8936002)(6636002)(66946007)(76116006)(66476007)(64756008)(66556008)(66446008)(86362001)(71200400001)(26005)(33656002)(2906002)(52536014)(55016002)(9686003)(7696005)(6506007)(53546011)(186003)(54906003)(110136005)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: H92xLtymgctIzls486kGBSRZttkqsjWXYN2jsQ5D4q6TvIZMa0GzHrL/2l6Df+N80n+6uLkECmUhaIgVXTBMZYBjOtQlfdJXOu+v+7aekhjxFH9LnP5eV2Npu7kMjSGfCyt0wg06F8YB20+BoG5a12pGKjO/PnJ037GNjonYBAbZmPEPvho5OpHfc3+wf1LW6XZWrJKeWkKZOv8fE35iNZjpxh6N3kCNsR+e1HHpAnBhBLN5gdfv6nZ2ZZumC4YNEzmfJTJOkq5WVqIflRMI9Jb41ClHrYB1IsyQL2FhudncfcvKMh3HN8Ef1jcKvpnqU2FJ/64DTxfmAup+jd2Pvd+DfV08kzAjDCm7Y5K2opBVIuIxg4tfrqcbQ6Fuv1Xf6yMgjCjC7pWIe9IdNW1Q1f5iiXLxeq2UAvJgBFIp0RbmxZRF2hydzTYzMUC7F3c4 x-ms-exchange-antispam-messagedata: k+MX2W0HXBhyD3LvF3XhPOXxWu8zdBxu6XLIc2bHhEjdw/MDj7n+OI6Qs5OYn7ruzlr4rM71LpAg5clafLc9N9sG/i5EpyEN6imt1qWjvR+ebmo7qx9VbA/FkiCoclTwKf+/pIBMY33fNDjsjRT+5g== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 7f68c9c4-1825-42fd-f9c3-08d7e7fda48a X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2020 03:14:46.7278 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: J16oPDD5nGaHge1eSDX46qyv+K86UEEjT1Kd/+/wiss4VAFC/FdD9iMYe0TinpYCzZMVVyjQLhvQtVJVMlTlww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1728 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/ice/base: workaround for unexpected rule deletion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" It will be delete after fix in kernel to re-enable vf list feature. Reviewed-by: Wei Zhao > -----Original Message----- > From: dev On Behalf Of Qi Zhang > Sent: Thursday, April 23, 2020 12:22 PM > To: Yang, Qiming > Cc: Ye, Xiaolong ; Xing, Beilei ; > Zhang, Xiao ; dev@dpdk.org; Zhang, Qi Z > > Subject: [dpdk-dev] [PATCH] net/ice/base: workaround for unexpected rule > deletion >=20 > Ideally a rule with "TO VSI LIST" action should not be deleted when one o= f the > VF reset happens. The correct action by kernel PF driver is to remove the= VSI of > a reset VF from the VSI list, but this is not implemented in kernel PF ye= t, so > workaround is the DCF to prevent a rule with "To VSI List" action happens= . >=20 > Signed-off-by: Qi Zhang > --- > drivers/net/ice/base/ice_switch.c | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/drivers/net/ice/base/ice_switch.c > b/drivers/net/ice/base/ice_switch.c > index 08999d336..b9fa516b0 100644 > --- a/drivers/net/ice/base/ice_switch.c > +++ b/drivers/net/ice/base/ice_switch.c > @@ -6438,6 +6438,13 @@ ice_adv_add_update_vsi_list(struct ice_hw *hw, > cur_fltr->sw_act.fltr_act =3D=3D ICE_FWD_TO_VSI_LIST)) > return ICE_ERR_NOT_IMPL; >=20 > + /* Workaround fix for unexpected rule deletion by kernel PF > + * during VF reset. > + */ > + if (new_fltr->sw_act.fltr_act =3D=3D ICE_FWD_TO_VSI && > + cur_fltr->sw_act.fltr_act =3D=3D ICE_FWD_TO_VSI) > + return ICE_ERR_NOT_IMPL; > + > if (m_entry->vsi_count < 2 && !m_entry->vsi_list_info) { > /* Only one entry existed in the mapping and it was not already > * a part of a VSI list. So, create a VSI list with the old and > -- > 2.13.6