From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 675E0A0093; Wed, 20 May 2020 11:31:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B5C871C43E; Wed, 20 May 2020 11:31:13 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 93BA71C436; Wed, 20 May 2020 11:31:11 +0200 (CEST) IronPort-SDR: cnMGMEU2Doh5MAkgwmAvGIlknSw5NiB1RbBHqOZw+nJ/9MzpOFOQi8LkIDwDEcQFQqxp+zdfw5 bo/f7LD28c7A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2020 02:31:10 -0700 IronPort-SDR: iH+RuBEL8hQv/Sa544Jqeb0foE+TlHpLYvcX+UY1MLJeF4Uf7XkaZSx5h8Qwetbz7gKo0lKAP2 LSmldWD2eHHA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,413,1583222400"; d="scan'208";a="308668894" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by FMSMGA003.fm.intel.com with ESMTP; 20 May 2020 02:31:09 -0700 Received: from orsmsx151.amr.corp.intel.com (10.22.226.38) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 May 2020 02:31:09 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX151.amr.corp.intel.com (10.22.226.38) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 May 2020 02:31:09 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 May 2020 02:31:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KvOM4piNguRmDwuhwJqcOVrBmE/xZD03/YqThTDDRWf2PGa9CIJmlb7VdNi8WjGsrwogccVYYpGCfQprKbMSUbUKT2mk5Uqj5mtOni8Gs+diK8x8XfkCsGqNFXyw/gMjUzXLXzxqHmsSa2PlEq5SXaSogcyfYnsu4xc8Cz8S98EF+OPsSKweDBeVo/Ybf/Su5dsv94+WZtJrN85WvRICaJ0LooqxBwOmBzebSezSW1zNoWGyZ9aaFFEiXXWdUo+PXLAfOBuGKu8Bz2CcS2ZDuvvcoOgIRO/5Jumt9zFyY5krFXzkQl8zARmkO+MzGvf18/cNX3dy5i3qBObraShtMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v+O8taxC0gQ6Lt+H40UAgEXMt8VLF/JLMzdnXjWuA40=; b=UkJ51EAuVYC6I8uBmCg5H7W/qfnRv8bC1O0+l94QOkIVucINu5Uz4TIe439vQoZDFBjca3+vkZVNq2f6Yxc2cqurhR39uszrirOjNodRfxl/gL0ecbkYkcnV+yciT037MLrpD9d8YlQjdsdFE4d5pNJwNznjqJQ7ybibKN1j0dtZcTNOECcLalU3fFUvELiwPCZJLpgU/lbAdXofIoLDImmTUMytkbPdzPUhkomNojVo6S1PgdrLDSlQuTXtJC7zV3iOkhzrMXTU+z9GdH2FGpZygUms8fU17tEcZ/VUwQ0iwJeIsHSa4CAsDXGdGjlLAyc+xv9HHX77CAi0tTFEZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v+O8taxC0gQ6Lt+H40UAgEXMt8VLF/JLMzdnXjWuA40=; b=uB2+FnFaur8m/zKzP+Aj3pJVdorm+266jlSJ2pcZyfldKMu/tsIfdvJ1oESOnGl57MyN3JuYQraIGriY4YcycGOWnTkaClfF1l/H/W1cHy4DYpcWaQ1MGqAWrFJwLlcq4Uy1En7PiJzefoYLXO+bhg962ZV/dAVk9VO9p/M5jrk= Received: from MWHPR11MB1391.namprd11.prod.outlook.com (2603:10b6:300:23::15) by MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23; Wed, 20 May 2020 09:31:07 +0000 Received: from MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211]) by MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211%7]) with mapi id 15.20.3000.034; Wed, 20 May 2020 09:31:07 +0000 From: "Zhao1, Wei" To: "Jiang, JunyuX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Jiang, JunyuX" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] net/ice: fix core dumped issue in switch filter Thread-Index: AQHWI1QUOO+ZNaIRbUijF0dYt+M1/aiwy7gA Date: Wed, 20 May 2020 09:31:07 +0000 Message-ID: References: <20200429072516.65403-1-junyux.jiang@intel.com> <20200506030525.3907-1-junyux.jiang@intel.com> In-Reply-To: <20200506030525.3907-1-junyux.jiang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTYyN2E0ZTUtY2E5Yy00M2U4LTg2OTgtYjVlNzYwN2Y4NTNkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWDBtVWJ0YTVtYXUzV1NyXC9YbU5VbmVOeVl6cUp5azQyUHRPOTMyR3FyQkg4UVdYQTFcLzdcL05wdXo4TUNqWHZLZiJ9 dlp-version: 11.0.600.7 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9a835982-60ca-485f-a0a2-08d7fca08680 x-ms-traffictypediagnostic: MWHPR11MB0062: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1169; x-forefront-prvs: 04097B7F7F x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: J8tR8Ac8NgxXPIgeTbz1BPqyeF9Vzh28Y/LE0SXQgUDMYlx+ng7si3K0/BPZ+UtCV7NebO/3GI+TRlhHTn5mBdKtRWxn7wpuTN2E1W9mFJvy886gdyxIfmU2ZlInRxZ5AVMPGOmXv7xKnkaiIAuUGU+obxW+gW8YYvbG5J58HU/yf+TYatVks3Owwy/9u7sv22Hq0bTiVgiVIXCF7oEXuinCCWUKKpxwhpk/Kao7uQcFvcdBZvdURySj7nFneeJ+vPnlEjh0CeufvIQoUWCrTUgmKF+U2mbM82Rn1P1K/XkQwYMxTtyN52VfKUXRDFLf x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1391.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(376002)(136003)(366004)(346002)(39860400002)(396003)(8936002)(33656002)(5660300002)(66476007)(66946007)(9686003)(66556008)(86362001)(54906003)(64756008)(66446008)(110136005)(76116006)(55016002)(316002)(186003)(26005)(53546011)(478600001)(7696005)(52536014)(450100002)(71200400001)(2906002)(6506007)(4326008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: nvBLjgnXPlYJ6nXNrtGdYJLxz8wf/erSuSCXVV1K+Rc52N1rYz5OhmPIDdT1P4mRqyS8hFcMU2BJWR+Ql4j1gv3Nxax9b3f/LFxL2+Y+5OGwjTV+XUdsvc6R3Y1oJtxjGoZ1R7xJ3CuCNo9EAggFAg25nnjjjb3D5hi6XS5CUHtUz7wfbFudzYEIlzMLyiJPfM6x/n9ACUMySrNT6GKZUmmbNrE9sEeoTZG//AltR1oxUO6T1m9fhL3ID551tvBdpvP1nnHWZFlarYBsICjOI77HRn5zUFxnxrEyTujKHHtUYPGIbVU9j22hLLETI7lkKwYY0PXS1OI50FvEvpaoOKf+ihQzwVRAhE6IiUBwIWlxTaC5XujwHK0qMCUvg+Aqiu4ZyM2YS8AC+CaEJH4QKnbdCHchuW2kfOfdt0lnHKE0xnAbAjcctsgKK0ZA6olLz3sHe/l+D681id/j5FNZAEQg8PrdEn1EcmfhH5/q1nk= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 9a835982-60ca-485f-a0a2-08d7fca08680 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2020 09:31:07.6448 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: I9dIZesG5iUu7p4vV2aCHkKmJFfGpZbGB3UURdvAWffiSv91sNmvP+VhIJmglvSU9KjHBcQysBI97fUTmcXLMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0062 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix core dumped issue in switch filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Junyu > -----Original Message----- > From: dev On Behalf Of Junyu Jiang > Sent: Wednesday, May 6, 2020 11:05 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; guinanx.sun@intel.com X > ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/ice: fix core dumped issue in switch f= ilter >=20 > The number of queues in queue group should be checked before using it. Th= is > patch fixed the issue. >=20 > Fixes: 47d460d63233 ("net/ice: rework switch filter") > Cc: stable@dpdk.org >=20 > Signed-off-by: Junyu Jiang > Tested-by: Qimai Xiao > --- > drivers/net/ice/ice_switch_filter.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/ice/ice_switch_filter.c > b/drivers/net/ice/ice_switch_filter.c > index 179430136..c2762e331 100644 > --- a/drivers/net/ice/ice_switch_filter.c > +++ b/drivers/net/ice/ice_switch_filter.c > @@ -1296,6 +1296,8 @@ ice_switch_parse_action(struct ice_pf *pf, > switch (action_type) { > case RTE_FLOW_ACTION_TYPE_RSS: > act_qgrop =3D action->conf; > + if (act_qgrop->queue_num <=3D 1) > + goto error; Why do you ban the case of queue num =3D1? > rule_info->sw_act.fltr_act =3D > ICE_FWD_TO_QGRP; > rule_info->sw_act.fwd_id.q_id =3D > -- > 2.17.1