Re: [dpdk-dev] [PATCH v2] net/ice: support based RSS configure

["Zhao1, Wei" <wei.zhao1@intel.com>]

Hi, all

> -----Original Message-----
> From: Zhao1, Wei
> Sent: Friday, July 3, 2020 4:17 PM
> To: Junyu Jiang <junyux.jiang@intel.com>; dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Su, Simei <Simei.Su@intel.com>; Jiang, JunyuX
> <JunyuX.Jiang@intel.com>; Lu, Nannan <nannan.lu@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v2] net/ice: support based RSS configure
> 
> Hi,  Junyu
> 
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Junyu Jiang
> > Sent: Monday, June 22, 2020 1:33 PM
> > To: dev@dpdk.org
> > Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>; Su, Simei <simei.su@intel.com>; Jiang, JunyuX
> > <junyux.jiang@intel.com>
> > Subject: [dpdk-dev] [PATCH v2] net/ice: support based RSS configure
> >
> > Enable/disable RSS for corresponding flow base on the user's requirement.
> >
> > Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
> >
> > ---
> > v1->v2:
> > remove gtpu and pppoe/pppod configuration from rss init
> 
> Why do we remove the rss for PPPOE or GTP-U?
> The switch cmd can not work now. Maybe we also need a rss CMD to enable it
> before using this CMD?
> 
> flow create 0 priority 0 ingress pattern eth / pppoes / ipv6 dst is
> CDCD:910A:2222:5498:8475:1111:3900:2022 / udp src is 25 dst is 23 / end
> actions rss queues 2 3 end / end
> 


Btw, RSS hash not support IPV6 type hash cmd, how can we enable it?
flow create 0 ingress pattern eth / pppoes / ipv6 / udp / end actions rss types ipv6 end key_len 0 queues end / end
so, the flow create 0 priority 0 ingress pattern eth / pppoes / ipv6 dst is  CDCD:910A:2222:5498:8475:1111:3900:2022 / udp src is 25 dst is 23 / end actions rss queues 2 3 end / end
can not work at all.

> 
> > ---
> >  drivers/net/ice/ice_ethdev.c | 162
> > +++++++++++++++++++++--------------
> >  1 file changed, 96 insertions(+), 66 deletions(-)
> >
> > diff --git a/drivers/net/ice/ice_ethdev.c
> > b/drivers/net/ice/ice_ethdev.c index
> >
> >  	return 0;
> >  }
> >
> > --
> > 2.17.1