* [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode
@ 2020-05-08 8:29 Guinan Sun
2020-05-09 3:13 ` Jiang, YuX
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Guinan Sun @ 2020-05-08 8:29 UTC (permalink / raw)
To: dev; +Cc: Guinan Sun, stable
The register autoneg can't be updated synchronously
with flow control mode setting in the state of port start
, so NIC statistics error occurs. The patch fixes the issue.
Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
Cc: stable@dpdk.org
Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index cf5f1fe70..e6c747aef 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev, struct ixgbe_hw *hw)
int err;
uint32_t mflcn;
+ hw->mac.ops.setup_fc(hw);
+
err = ixgbe_fc_enable(hw);
/* Not negotiated is not an error case */
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode
2020-05-08 8:29 [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode Guinan Sun
@ 2020-05-09 3:13 ` Jiang, YuX
2020-05-11 1:03 ` Zhao1, Wei
2020-05-12 8:13 ` [dpdk-dev] [PATCH v2] " Guinan Sun
2 siblings, 0 replies; 8+ messages in thread
From: Jiang, YuX @ 2020-05-09 3:13 UTC (permalink / raw)
To: Sun, GuinanX, dev; +Cc: Sun, GuinanX, stable
Tested-by: Jiang, YuX <yux.jiang@intel.com>
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Guinan Sun
Sent: Friday, May 8, 2020 4:30 PM
To: dev@dpdk.org
Cc: Sun, GuinanX <guinanx.sun@intel.com>; stable@dpdk.org
Subject: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode
The register autoneg can't be updated synchronously with flow control mode setting in the state of port start , so NIC statistics error occurs. The patch fixes the issue.
Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
Cc: stable@dpdk.org
Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index cf5f1fe70..e6c747aef 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev, struct ixgbe_hw *hw)
int err;
uint32_t mflcn;
+ hw->mac.ops.setup_fc(hw);
+
err = ixgbe_fc_enable(hw);
/* Not negotiated is not an error case */
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode
2020-05-08 8:29 [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode Guinan Sun
2020-05-09 3:13 ` Jiang, YuX
@ 2020-05-11 1:03 ` Zhao1, Wei
2020-05-12 8:28 ` Sun, GuinanX
2020-05-12 8:13 ` [dpdk-dev] [PATCH v2] " Guinan Sun
2 siblings, 1 reply; 8+ messages in thread
From: Zhao1, Wei @ 2020-05-11 1:03 UTC (permalink / raw)
To: Sun, GuinanX, dev; +Cc: Sun, GuinanX, stable, Guo, Jia
Hi, Guinan
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Guinan Sun
> Sent: Friday, May 8, 2020 4:30 PM
> To: dev@dpdk.org
> Cc: Sun, GuinanX <guinanx.sun@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode
>
> The register autoneg can't be updated synchronously with flow control mode
> setting in the state of port start , so NIC statistics error occurs. The patch fixes
> the issue.
>
> Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
> Cc: stable@dpdk.org
>
> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index cf5f1fe70..e6c747aef 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev,
> struct ixgbe_hw *hw)
> int err;
> uint32_t mflcn;
>
> + hw->mac.ops.setup_fc(hw);
1. please use base code API ixgbe_setup_fc(), do not use internal function directly.
2. please more info for this patch, what register error you want to fix, and why it can fix.
> +
> err = ixgbe_fc_enable(hw);
>
> /* Not negotiated is not an error case */
> --
> 2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH v2] net/ixgbe: fix statistics error in flow control mode
2020-05-08 8:29 [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode Guinan Sun
2020-05-09 3:13 ` Jiang, YuX
2020-05-11 1:03 ` Zhao1, Wei
@ 2020-05-12 8:13 ` Guinan Sun
2020-05-12 8:39 ` Zhao1, Wei
2020-05-13 0:59 ` [dpdk-dev] [dpdk-stable] " Ye Xiaolong
2 siblings, 2 replies; 8+ messages in thread
From: Guinan Sun @ 2020-05-12 8:13 UTC (permalink / raw)
To: dev; +Cc: Guinan Sun, stable
The register autoneg can't be updated synchronously
with flow control mode setting in the state of port start
, so NIC statistics error occurs. AUTO_NEG Advt register
should be updated by ixgbe_setup_fc() when enabling flow control.
The patch fixes the issue.
Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
Cc: stable@dpdk.org
Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
---
v2 changes:
* Replaced mac.ops.setup_fc() with ixgbe_setup_fc()
* Modified commit message.
---
drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index a4e5c539d..f8a84c565 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev, struct ixgbe_hw *hw)
int err;
uint32_t mflcn;
+ ixgbe_setup_fc(hw);
+
err = ixgbe_fc_enable(hw);
/* Not negotiated is not an error case */
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode
2020-05-11 1:03 ` Zhao1, Wei
@ 2020-05-12 8:28 ` Sun, GuinanX
0 siblings, 0 replies; 8+ messages in thread
From: Sun, GuinanX @ 2020-05-12 8:28 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: stable, Guo, Jia
Hi zhaowei
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, May 11, 2020 9:03 AM
> To: Sun, GuinanX <guinanx.sun@intel.com>; dev@dpdk.org
> Cc: Sun, GuinanX <guinanx.sun@intel.com>; stable@dpdk.org; Guo, Jia
> <jia.guo@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control
> mode
>
>
> Hi, Guinan
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Guinan Sun
> > Sent: Friday, May 8, 2020 4:30 PM
> > To: dev@dpdk.org
> > Cc: Sun, GuinanX <guinanx.sun@intel.com>; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow
> > control mode
> >
> > The register autoneg can't be updated synchronously with flow control
> > mode setting in the state of port start , so NIC statistics error
> > occurs. The patch fixes the issue.
> >
> > Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> > ---
> > drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index cf5f1fe70..e6c747aef 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev,
> > struct ixgbe_hw *hw) int err; uint32_t mflcn;
> >
> > +hw->mac.ops.setup_fc(hw);
>
> 1. please use base code API ixgbe_setup_fc(), do not use internal function
> directly.
> 2. please more info for this patch, what register error you want to fix, and why it
> can fix.
V2 patch will be send to resolve the problems.
>
>
> > +
> > err = ixgbe_fc_enable(hw);
> >
> > /* Not negotiated is not an error case */
> > --
> > 2.17.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix statistics error in flow control mode
2020-05-12 8:13 ` [dpdk-dev] [PATCH v2] " Guinan Sun
@ 2020-05-12 8:39 ` Zhao1, Wei
2020-05-13 0:59 ` [dpdk-dev] [dpdk-stable] " Ye Xiaolong
1 sibling, 0 replies; 8+ messages in thread
From: Zhao1, Wei @ 2020-05-12 8:39 UTC (permalink / raw)
To: Sun, GuinanX, dev; +Cc: Sun, GuinanX, stable
Reviewed-by: Wei Zhao <wei.zhao1@intel.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Guinan Sun
> Sent: Tuesday, May 12, 2020 4:13 PM
> To: dev@dpdk.org
> Cc: Sun, GuinanX <guinanx.sun@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] net/ixgbe: fix statistics error in flow control
> mode
>
> The register autoneg can't be updated synchronously with flow control mode
> setting in the state of port start , so NIC statistics error occurs. AUTO_NEG
> Advt register should be updated by ixgbe_setup_fc() when enabling flow
> control.
> The patch fixes the issue.
>
> Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
> Cc: stable@dpdk.org
>
> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> ---
> v2 changes:
> * Replaced mac.ops.setup_fc() with ixgbe_setup_fc()
> * Modified commit message.
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index a4e5c539d..f8a84c565 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev,
> struct ixgbe_hw *hw)
> int err;
> uint32_t mflcn;
>
> + ixgbe_setup_fc(hw);
> +
> err = ixgbe_fc_enable(hw);
>
> /* Not negotiated is not an error case */
> --
> 2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/ixgbe: fix statistics error in flow control mode
2020-05-12 8:13 ` [dpdk-dev] [PATCH v2] " Guinan Sun
2020-05-12 8:39 ` Zhao1, Wei
@ 2020-05-13 0:59 ` Ye Xiaolong
2020-05-13 7:03 ` Jiang, YuX
1 sibling, 1 reply; 8+ messages in thread
From: Ye Xiaolong @ 2020-05-13 0:59 UTC (permalink / raw)
To: Guinan Sun; +Cc: dev, stable
On 05/12, Guinan Sun wrote:
>The register autoneg can't be updated synchronously
>with flow control mode setting in the state of port start
>, so NIC statistics error occurs. AUTO_NEG Advt register
>should be updated by ixgbe_setup_fc() when enabling flow control.
>The patch fixes the issue.
>
>Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
>Cc: stable@dpdk.org
>
>Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
>---
>v2 changes:
>* Replaced mac.ops.setup_fc() with ixgbe_setup_fc()
>* Modified commit message.
>---
> drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
>index a4e5c539d..f8a84c565 100644
>--- a/drivers/net/ixgbe/ixgbe_ethdev.c
>+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>@@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev, struct ixgbe_hw *hw)
> int err;
> uint32_t mflcn;
>
>+ ixgbe_setup_fc(hw);
>+
> err = ixgbe_fc_enable(hw);
>
> /* Not negotiated is not an error case */
>--
>2.17.1
>
Applied to dpdk-next-net-intel, Thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/ixgbe: fix statistics error in flow control mode
2020-05-13 0:59 ` [dpdk-dev] [dpdk-stable] " Ye Xiaolong
@ 2020-05-13 7:03 ` Jiang, YuX
0 siblings, 0 replies; 8+ messages in thread
From: Jiang, YuX @ 2020-05-13 7:03 UTC (permalink / raw)
To: Ye, Xiaolong, Sun, GuinanX; +Cc: dev, stable
Tested-by: Jiang, YuX <yux.jiang@intel.com>
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ye Xiaolong
Sent: Wednesday, May 13, 2020 8:59 AM
To: Sun, GuinanX <guinanx.sun@intel.com>
Cc: dev@dpdk.org; stable@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/ixgbe: fix statistics error in flow control mode
On 05/12, Guinan Sun wrote:
>The register autoneg can't be updated synchronously with flow control
>mode setting in the state of port start , so NIC statistics error
>occurs. AUTO_NEG Advt register should be updated by ixgbe_setup_fc()
>when enabling flow control.
>The patch fixes the issue.
>
>Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
>Cc: stable@dpdk.org
>
>Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
>---
>v2 changes:
>* Replaced mac.ops.setup_fc() with ixgbe_setup_fc()
>* Modified commit message.
>---
> drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
>b/drivers/net/ixgbe/ixgbe_ethdev.c
>index a4e5c539d..f8a84c565 100644
>--- a/drivers/net/ixgbe/ixgbe_ethdev.c
>+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>@@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev, struct ixgbe_hw *hw)
> int err;
> uint32_t mflcn;
>
>+ ixgbe_setup_fc(hw);
>+
> err = ixgbe_fc_enable(hw);
>
> /* Not negotiated is not an error case */
>--
>2.17.1
>
Applied to dpdk-next-net-intel, Thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-05-13 7:03 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-08 8:29 [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode Guinan Sun
2020-05-09 3:13 ` Jiang, YuX
2020-05-11 1:03 ` Zhao1, Wei
2020-05-12 8:28 ` Sun, GuinanX
2020-05-12 8:13 ` [dpdk-dev] [PATCH v2] " Guinan Sun
2020-05-12 8:39 ` Zhao1, Wei
2020-05-13 0:59 ` [dpdk-dev] [dpdk-stable] " Ye Xiaolong
2020-05-13 7:03 ` Jiang, YuX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).