From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65247A04E6; Tue, 17 Nov 2020 19:08:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7B76237B1; Tue, 17 Nov 2020 19:08:45 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 63C45F90; Tue, 17 Nov 2020 19:08:42 +0100 (CET) IronPort-SDR: D05YcJxxZT8RcFCkjzbXxsM8HIdG+MoMT5Wep2avw/CZvwBAnFsWq9MuB2fPm67k9PHVN+DAsU V3JqamazWOaw== X-IronPort-AV: E=McAfee;i="6000,8403,9808"; a="150825528" X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="150825528" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2020 10:08:10 -0800 IronPort-SDR: WUcS8+I4V8ELBkci5CIvYag0PwT68Cll6PL/JVTi2VfoXSaKVt9+qAPmL5llz3cVJJuN0lhGuH T3FGRnT1+N5w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="430548515" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga001.fm.intel.com with ESMTP; 17 Nov 2020 10:08:09 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 17 Nov 2020 10:08:08 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 17 Nov 2020 10:08:08 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 17 Nov 2020 10:08:08 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 17 Nov 2020 10:08:02 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hXQrYjJfWQyxZtYEYSuQur7520ewMuGxj8oZtaiahYE1OhDC63EwlEU+VMw4T2hYzFYCx4PeOJosFo+6sznRv/rFYJrZomxqbOJSNg9vwTXzX838a8mcslSe3g2081jSQexawQdAcGPQ2Y1XKhcvv4OvOEALL1iMzExRZahSMpCugK4IwDVs5uZtiyki91EPJoEdIcBkrPeC3+XqdrzC3h0jKluKv2Wevt4WmYYAc2Ysp9n4eCktCXVePkHuS3I9zF6EBwhhaH+dMOvTY9cW+NC3bNQVi96fiyezMb4Um7XcBb8HwV/G+f1wlDD5rUSX65kB8cdxqRCKjPKR9ICsjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S8bdbAXyfU1Tbh4Uh3+O3gU8CMIAbbKbigTHKtXJU+A=; b=J66ZA/HlipB8bThpDrUY7wmpqO/VSki+i4ssmzz3Htg/sZOU37jbk514ZzHNA4EUpz7cpxCLUumThaIouz9XjjdN9inKqebyITye6b5XZz5CxVe5CqX4svz86TJy7SzzTf0DKDVlvWl0cC4OxS87cwH+8za1H9hNwkJyIwP6z2du/ek2ECuIofCpMAtsea+wrjlFxCwVyR6ayJ98OetCKRASJKXtCGJxUuFqpHq3qY8biQ6CcGTmnLW5kTpN/F3vOeBXaa2Ggu+F7Ke4KNWRNoOeLKP44cegDfYYY6U35AdfGE/AyOFG6X80gzXklFI7tjm8RU/lKuhAgMICT4QOfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S8bdbAXyfU1Tbh4Uh3+O3gU8CMIAbbKbigTHKtXJU+A=; b=VfGgPBWDIyUndhXj4tj0IB3VWYcrg9o+goPh4En249C9v+xRVjOO3SUwa5vAE60zN9WTnM8fWCMVK1A6EcG9dLJTcJv3C/QaDotQNTPsMqluvxeDo5NJjH2wWqoMVJ+AG45TloOuxZj0WiZjl4IM2DiIiABTNc/apidmIn2y+Ck= Received: from MWHPR11MB1581.namprd11.prod.outlook.com (2603:10b6:301:d::9) by MW3PR11MB4650.namprd11.prod.outlook.com (2603:10b6:303:54::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.28; Tue, 17 Nov 2020 18:07:54 +0000 Received: from MWHPR11MB1581.namprd11.prod.outlook.com ([fe80::556:15d2:6ce4:d49d]) by MWHPR11MB1581.namprd11.prod.outlook.com ([fe80::556:15d2:6ce4:d49d%2]) with mapi id 15.20.3564.028; Tue, 17 Nov 2020 18:07:54 +0000 From: "Varghese, Vipin" To: "Yigit, Ferruh" , "Tahhan, Maryam" , "Pattan, Reshma" , "Mcnamara, John" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH 3/4] app/procinfo: remove suspicious sizeof Thread-Index: AQHWvQVDUCotWB84HUOsHSnD9NDkDKnMnw2g Date: Tue, 17 Nov 2020 18:07:54 +0000 Message-ID: References: <20201117171435.2303641-1-ferruh.yigit@intel.com> <20201117171435.2303641-4-ferruh.yigit@intel.com> In-Reply-To: <20201117171435.2303641-4-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [103.66.79.221] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 02936837-04ae-4ba4-15be-08d88b23b4f0 x-ms-traffictypediagnostic: MW3PR11MB4650: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6LQTygR65UKiNByqnIkEY2tfmBnBp3C9j/jUVZG7kTzGOk1QeXX/uaCcjJmA3UvhHletQ28Hj2woTHTlu6jwFw1LNsbvOuOOMwF8G9SGkNcfnMDTHei9/ETEBvfsBgTUQIORQHj9taw1BxUVhjnT/3nC1JBub7gjCIMp3hMZq+8HuYrHeek86OD6NCDBsCNnnvNmSVA3//kk4go4boIr5t4lPV6ziWWHtZY/zk7F9WHWI8s/5JqfIdnHA/o4jmI6L/+l1Y3nbPrClN/w3Aum5hAq5M6ricz5ahXxZ67LId9zUh4D+fYtdu6napg6M00E0DnGPxYpRGZeIAqYoZ6U6g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1581.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(346002)(376002)(39860400002)(366004)(5660300002)(2906002)(53546011)(52536014)(186003)(316002)(66476007)(66446008)(64756008)(76116006)(54906003)(26005)(110136005)(6506007)(66946007)(66556008)(83380400001)(55016002)(9686003)(4326008)(450100002)(71200400001)(7696005)(8936002)(6636002)(478600001)(33656002)(8676002)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: VZMVLe1FF3dVSqVXNvl7c3bVmIWi4l8EMSkcBm+OwUHM3ZwT/HvUm82mZZGIWvjMjEUs6uSzmZj8uHkSmRVv068sdv0iyGMHEXENcVfVbfpSV/so7/MzP1wa2zJ4CmIZB9ZiQyQ1+3Z3VkmWVvQ9pv7T5T0Eboa94JaCxPeNMjyVsktD87Xe8fUTlSRctwSNhnOuIyvCc8LEbQKbu3dNyjITA7fDiHxfju3B8f0KrDdBjXPpdSpCzhwvGuY3gJkHEEtTnVkfNRbhasX4ktpeWEV1hS2uCLpqVzqvsB0blpX6dSf3KmOsBWtIvzx9yLxoQSJWjtM3BCzoPozUvwmY1U4b3pjK7JzlX1U/wWZsJtrWCuFyrEdhtu16rJjpS940zPSaLSkB3ApvIX/odfwTxY91Cp0N7V6CEM2XGT1rc7r+5Doay+tjGJPXbQp7Jg3Y19/qLcTAx+WByipaIsJ1J1+174dDbMT3PkbdbDTjxShCZCqL9YcDtzuA/bOz9NpHz0256+/KSN1SbqF0GiNHjyBfTt2tH+fAzrjJM+ofuXL41X1fHs7lGCiwGr1M7jCsiVxLlN7Ni/ITK/51QliBHPB+qj4Hviyr5+0VT7Tmhxm/v8U1OCqbN/GIsxP6ztcFYm6L7OfPMn5v1FoZg7yP/Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1581.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02936837-04ae-4ba4-15be-08d88b23b4f0 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2020 18:07:54.7864 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EEOHWk3bu48uv4VWBra9OI7XUiLGLXgG8caz+7XDpvQutsDTrtBlKjHNmMZm9MKWgCHAEQwdUavelRhwGdBO9UbbXyQPZJ7wWhVXNkiX8nE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4650 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 3/4] app/procinfo: remove suspicious sizeof X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks Ferruh > -----Original Message----- > From: Yigit, Ferruh > Sent: Tuesday, November 17, 2020 10:45 PM > To: Tahhan, Maryam ; Pattan, Reshma > ; Mcnamara, John ; > Varghese, Vipin > Cc: Yigit, Ferruh ; dev@dpdk.org; stable@dpdk.org > Subject: [PATCH 3/4] app/procinfo: remove suspicious sizeof >=20 > The intention with the "sizeof(0)" usage is not clear, but the 'stats' > already 'memset' by 'rte_cryptodev_stats_get()' API, removing 'memset' > in application. >=20 > Fixes: fe773600fe3e ("app/procinfo: add --show-crypto") > Cc: stable@dpdk.org >=20 > Signed-off-by: Ferruh Yigit > --- > Cc: vipin.varghese@intel.com > --- > app/proc-info/main.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/app/proc-info/main.c b/app/proc-info/main.c index > c11fe25af4..dc5cc92209 100644 > --- a/app/proc-info/main.c > +++ b/app/proc-info/main.c > @@ -1207,7 +1207,6 @@ show_crypto(void) >=20 > display_crypto_feature_info(dev_info.feature_flags); >=20 > - memset(&stats, 0, sizeof(0)); > if (rte_cryptodev_stats_get(i, &stats) =3D=3D 0) { > printf("\t -- stats\n"); > printf("\t\t + enqueue count (%"PRIu64")" > -- > 2.26.2