From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D672A0350; Tue, 30 Jun 2020 15:25:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ECE691BF6D; Tue, 30 Jun 2020 15:25:10 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 80EA01BEAC for ; Tue, 30 Jun 2020 15:25:09 +0200 (CEST) IronPort-SDR: ZnfICHf1IYYT8IHEhUCi7K7k7inT97MlSz3+0EtXor28loD4tkYljupJqoF8yDaBq0RfH1oSML KBC1rLyu3sqA== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="211292463" X-IronPort-AV: E=Sophos;i="5.75,297,1589266800"; d="scan'208";a="211292463" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2020 06:25:07 -0700 IronPort-SDR: JU9127KPWY517aGW3gaz2PFgbP7geHP1U53XgKD4oHQuKcbEHf+I44qET0oXA6AwaCu1AKllrw tE1PSwgJcXBg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,297,1589266800"; d="scan'208";a="481189225" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by fmsmga005.fm.intel.com with ESMTP; 30 Jun 2020 06:25:05 -0700 Received: from orsmsx152.amr.corp.intel.com (10.22.226.39) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 30 Jun 2020 06:25:04 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX152.amr.corp.intel.com (10.22.226.39) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 30 Jun 2020 06:25:04 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.54) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 30 Jun 2020 06:25:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JxXvOSxrMZLu4Q9mDVzeX/iMuuKskxXF4szJ7kx3yTxf0SeMbi1wcmQufufppn+kPrUZ3PGelgsrRqR7ojcAT5GN9wD2qTqn6F2H/OM9y82nNBo1HLAPPY9yzKSMEZ+aWKWq+YSMBdZEAiLu2qU9yAjmFgG4tkKHpozQyXgsgFnl34X1/uL6JyDnp9S3J2hBjABSX/pQDnkOurl6XR3I1hL+8X8e1eYk51q1TrUA8oKvVt1deEoMQ0fKijlfyUnSZPqFqzqpAGChLDQfbVPvs0LuBgg96CaMKX0e4xfNiitNSQANNQSqDV0I8wlZnXUkcPOubinN/9RAJF8MkmSddA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hJm5KLTVQ2aoGRb5mgzUhu5D9axDX5bR33D6Mra2hXo=; b=Alyt+0qlppJL1nwXEm2jPPsbYT9Y+9tHo1htpObGwWylVVohHYTe2oR8Ry0BRDaf0Zb7cwefpaswKP1BwCeMuArG89GDm5N/ijsVkSJEmObJ9k8LsebdNEMos+r1wiIvikQMOvMuqr1UYB9XJYFtMiTvReikIihKz3dA05OduAP4ZfTJqT02UdzyMXZtwu52ZktBwvsTiu/2Q9DFYi/Hsgq4JCKD+299iOuoOjCGHvnLXqFn0qCsrr0plX6YrmRROIzRAmJstM4V6S2CzVX5y2QV8FyLmJK/LfOko+9vBINZZMxiHSFuk2hAzkuoa3b1Zvkzbf3BGtPFVCItG4NV/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hJm5KLTVQ2aoGRb5mgzUhu5D9axDX5bR33D6Mra2hXo=; b=WRBHSskhYZ6iTsnvGbFxp2FnC0z4ivVNqyBp2kZsDVDC72016TNcEawAS9wcg2UwRa/drIiWaFQHfSnubntn0LNkpnR2q/F0WiKNIlptzhobKAPZoRONoFHRC6BOse/cRn09OzWxR8kY/OGE4WAT9F9QyMH0aNiDw0MZ5VLwxOo= Received: from MWHPR11MB1805.namprd11.prod.outlook.com (2603:10b6:300:114::14) by MWHPR11MB1296.namprd11.prod.outlook.com (2603:10b6:300:1d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.23; Tue, 30 Jun 2020 13:25:03 +0000 Received: from MWHPR11MB1805.namprd11.prod.outlook.com ([fe80::2f:26e2:8473:d215]) by MWHPR11MB1805.namprd11.prod.outlook.com ([fe80::2f:26e2:8473:d215%10]) with mapi id 15.20.3131.028; Tue, 30 Jun 2020 13:25:03 +0000 From: "Pai G, Sunil" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "bluca@debian.org" , "david.marchand@redhat.com" , "ktraynor@redhat.com" , "Richardson, Bruce" , "Stokes, Ian" , "Pai G, Sunil" Thread-Topic: [dpdk-dev] [PATCH v2 0/7] improve DPDK static builds with meson Thread-Index: AQHWH8DPmhkRzF1SWkGOzw/JQ8M0QKjxg5Ig Date: Tue, 30 Jun 2020 13:25:03 +0000 Message-ID: References: <20200429100831.398-1-bruce.richardson@intel.com> <20200501135401.28124-1-bruce.richardson@intel.com> In-Reply-To: <20200501135401.28124-1-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [106.51.109.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4edd41be-1850-47ed-a6f6-08d81cf8ff36 x-ms-traffictypediagnostic: MWHPR11MB1296: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0450A714CB x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Kdj2m02uhijiFArAqMFvoNnWPf9/WyqoBiexXAF4dQ5DjnGeAkZdl9JccZRiwsXock/K49NJXGldgBX1fBZc9KQt+W8nHsdyEddhAtHiyCu3gdrMJqVPmZoHUu0pH9kH7UpSxoT5FlCv2d1R8c/mC6HZK1N3XQWXkjYH0Yg5JZhGN3iHESFYqrgC4X2iKKvFm8uUwUItX/zf7wN2EYbKorcJ25+t5xoXs14+LCk81zg1GcJWHjF989bSOGKLjnw7BgPGHA8DdcRT4jGZIIBzrnwAExrANiqsxvjfjyr9PdcaDxo9qXJRNxU4VNzGisbUcrjNXMuqkB1kdIdl/0DI9g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1805.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(346002)(396003)(136003)(366004)(39860400002)(4326008)(186003)(33656002)(26005)(8676002)(478600001)(71200400001)(2906002)(83380400001)(55016002)(86362001)(9686003)(7696005)(316002)(107886003)(54906003)(66946007)(66476007)(66556008)(64756008)(76116006)(66446008)(110136005)(52536014)(5660300002)(55236004)(53546011)(6506007)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: JvEOULu8R5CX07kOkJDdo8EEpGf7vtSweILx9HXb1GifinYJuvSpIHo2m2qC7fMIoCIacsqXEqrviloZogAsZwqj195NhwI+YwLIc8Ph9/rYwtqKSr3woAfMKIBPXtZQSaQca4MrVgIgdjY2E47S7O25lBge6jEQNGjZjRAuRryXYG+lgUv3+MlHpKn8WjOd3vU3aUzTPp0rO4b9tDVD7fmRFafCXre8JWTSvqLY0PB9RUEuCl8HhWmkRTTmAWB4kWMxQnG18CcG81WBMA9pYZcJY8TmXD9c2cDL94C7BMXU0QRZLvz+KSBpoZoJFmWKOtGPLwWeLaFGBMCApGbj6bewxi7xyUQh/6yDwLa2kDuq40uSAiBtxJG7ry/BO6zKQC01RnpTzJUuTEjfjiPO/gr6dTFNNEwWJQItXtkFiQynfd6Xh5Lhak6z5DM91tIsybh4IVN47ZsCnDPEIP4JILV7d4JB1pt3Bx4LwoilmF4= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1805.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4edd41be-1850-47ed-a6f6-08d81cf8ff36 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jun 2020 13:25:03.0404 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: w97gvMmEjxEM3uAwdITxDCROpj2evQMRAh2j/NDps1CwS4/pWfQJqiEbVU87Vma7CzYDo7gdBPcVf/Vv6+E3BA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1296 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 0/7] improve DPDK static builds with meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Bruce Richardson > Sent: Friday, May 1, 2020 7:24 PM > To: dev@dpdk.org > Cc: thomas@monjalon.net; bluca@debian.org; > david.marchand@redhat.com; ktraynor@redhat.com; Richardson, Bruce > > Subject: [dpdk-dev] [PATCH v2 0/7] improve DPDK static builds with meson >=20 > This set fixes a number of minor issues with static builds when using mes= on, > both for linking apps/examples as part of a meson build itself or when us= ing > pkg-config subsequently. >=20 > Following this patchset, all DPDK static builds should be linking with --= whole- > archive to ensure all lib and driver constructors are included, and the u= se of > pkg-config for doing static builds is simplified. The downside is that fo= r > correctness we need two .pc files for DPDK rather than just one. >=20 > v2: improved log messages for a number of patches, and clearly marked > internal-only pkg-config file as such >=20 > Bruce Richardson (7): > build: always link-whole DPDK static libraries > build: remove unnecessary variable > devtools/test-meson-builds.sh: add pkg-config static builds > build: move pkg-config creation to separate file > build/pkg-config: output driver libs first for static build > build/pkg-config: improve static linking flags > build/pkg-config: prevent overlinking >=20 > app/meson.build | 2 +- > app/test/meson.build | 2 +- > buildtools/pkg-config/meson.build | 43 +++++++++++++++++++ > .../pkg-config/set-static-linker-flags.py | 38 ++++++++++++++++ > devtools/test-meson-builds.sh | 2 +- > doc/guides/prog_guide/build-sdk-meson.rst | 2 +- > drivers/meson.build | 2 +- > examples/bbdev_app/Makefile | 2 +- > examples/bond/Makefile | 2 +- > examples/cmdline/Makefile | 2 +- > examples/distributor/Makefile | 2 +- > examples/eventdev_pipeline/Makefile | 2 +- > examples/fips_validation/Makefile | 2 +- > examples/flow_classify/Makefile | 2 +- > examples/flow_filtering/Makefile | 2 +- > examples/helloworld/Makefile | 2 +- > examples/ioat/Makefile | 2 +- > examples/ip_fragmentation/Makefile | 2 +- > examples/ip_pipeline/Makefile | 2 +- > examples/ip_reassembly/Makefile | 2 +- > examples/ipsec-secgw/Makefile | 2 +- > examples/ipv4_multicast/Makefile | 2 +- > examples/kni/Makefile | 2 +- > examples/l2fwd-cat/Makefile | 2 +- > examples/l2fwd-crypto/Makefile | 2 +- > examples/l2fwd-event/Makefile | 2 +- > examples/l2fwd-jobstats/Makefile | 2 +- > examples/l2fwd-keepalive/Makefile | 2 +- > examples/l2fwd/Makefile | 2 +- > examples/l3fwd-acl/Makefile | 2 +- > examples/l3fwd-power/Makefile | 2 +- > examples/l3fwd/Makefile | 2 +- > examples/link_status_interrupt/Makefile | 2 +- > examples/meson.build | 6 +-- > examples/ntb/Makefile | 2 +- > examples/packet_ordering/Makefile | 2 +- > examples/ptpclient/Makefile | 2 +- > examples/qos_meter/Makefile | 2 +- > examples/qos_sched/Makefile | 2 +- > examples/rxtx_callbacks/Makefile | 2 +- > examples/service_cores/Makefile | 2 +- > examples/skeleton/Makefile | 2 +- > examples/tep_termination/Makefile | 2 +- > examples/timer/Makefile | 2 +- > examples/vdpa/Makefile | 2 +- > examples/vhost/Makefile | 2 +- > examples/vhost_blk/Makefile | 2 +- > examples/vhost_crypto/Makefile | 2 +- > examples/vmdq/Makefile | 2 +- > examples/vmdq_dcb/Makefile | 2 +- > lib/librte_telemetry/meson.build | 1 - > lib/meson.build | 2 +- > meson.build | 26 +---------- > 53 files changed, 134 insertions(+), 76 deletions(-) create mode 100644 > buildtools/pkg-config/meson.build create mode 100644 buildtools/pkg- > config/set-static-linker-flags.py >=20 > -- > 2.20.1 This series allows OVS to consume the DPDK libraries appropriately (static = and shared) and simplifies the build.=20 When building OVS with DPDK, without this patch, the linker would always pi= ck the shared libraries over static even after specifying the -Bstatic flag= .=20 With this patch, no such behavior is observed. So, it would be very helpful= for the OVS community if this patch is merged in DPDK. I would also ask this series to be back ported to 19.11 as OVS can immediat= ely consume it on the latest master instead of waiting on the next DPDK rel= ease i.e 20.11=20 Series-acked-by: Sunil Pai G