From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C81FA04C0; Fri, 25 Sep 2020 13:15:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D5ECD1E951; Fri, 25 Sep 2020 13:13:22 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 7E6621E8FE; Fri, 25 Sep 2020 13:13:20 +0200 (CEST) IronPort-SDR: PkocrqHlpAPxuvVaEvnLsXFDjvypYlR2d71zhwLEYTNm8HniPWwetE//OYlicEiNzPVOEDxSHr dc6b0CVlU4Aw== X-IronPort-AV: E=McAfee;i="6000,8403,9754"; a="141522773" X-IronPort-AV: E=Sophos;i="5.77,301,1596524400"; d="scan'208";a="141522773" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2020 04:13:19 -0700 IronPort-SDR: xInmk2wTVlUg9HnbEFp5IooqWsXuoGAnxfb7jH+xDMvDD+kiBd63Zana/6X4Ciz6WAOVwdB83r Rx3C1BS1WmiA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,301,1596524400"; d="scan'208";a="349695264" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga007.jf.intel.com with ESMTP; 25 Sep 2020 04:13:19 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 25 Sep 2020 04:13:19 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 25 Sep 2020 04:13:19 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 25 Sep 2020 04:13:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PWpH9NQF3byV6dhtJTWwz2QfBgOBN5QbCuePlj/CI6z1Nt2dHU3hD7/FHAnlIy/EZo6o6MFD193MXsf+e3o1ucQy6F0oMeWjEjrEXeW2lqqFpfYu3VaQKEw0Trv1FLQaVEWwu8Kwrk22O15QEsEH3EaoXPJIgYoRBFC4h6h70Ov+suNx5Psx0C/m50Hv1BAkzdLau1iD30XsyGqffOy7E4iOiDpN2HiW/CJz5HlgHt3pgGbRDlBkJHw7OT/4a9C4cLxFPVaSyxPPDcXdm8Qy9i9awZzKeHOoPclh77V+XadZ9WJZd2Ixqx2mJDKZdiSwWsWZhtMezmng9J2HUkKQGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kje26KLzvs6YgBA94KKCcalJH90swk3g3FjoGaO6Qxk=; b=YYmzk/PArGrpkzYB32FVT//DvUsMWcYB1aZehhkueAJHflcHDG0NrVMb9ZEPveFlLnk8gDnT74AH8J5l7Pi3ZZeHbctSaVNDL9dxBTaH/26gG6fAmEZP7nuoHftdfSkbgzLixHTVa9tqMc2RYlWmwYvnGcglWHDFLQ2LBXfqnN179fod9OwfjJbm6iwzh/dlx3NOeqiESsfUY40vbKE47LW7JvpA3XmSWC1hQC/kx0ZdXQbmkmdI4iU5xqWPQR77zwWpceQUubyxZlsS0XzROREioonyypewzQ/cLuNHakC3YK/NiOfF86sRWURvnmZh4IL5pBu6UhBdbQXlAUQlPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kje26KLzvs6YgBA94KKCcalJH90swk3g3FjoGaO6Qxk=; b=cUXdzpFahjp7ZtfKiWRlgc5MoBUBbtDBZ5+8ELKVW/hytkcD7xehJ8N02E/Pd6UqA2pDC/KAoPo+3VK4JpNC7IUTBZjlcVSNLBFCy7lInCYYPKa+VY99z0H+eLcmNv/WyMaHZaAu0vt3rlQiuJ75MGVSLNJ+n8LPQ9bCCUDhlIo= Received: from MWHPR11MB1805.namprd11.prod.outlook.com (2603:10b6:300:114::14) by MWHPR1101MB2335.namprd11.prod.outlook.com (2603:10b6:300:73::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.20; Fri, 25 Sep 2020 11:12:58 +0000 Received: from MWHPR11MB1805.namprd11.prod.outlook.com ([fe80::e8c4:4960:1481:b0f9]) by MWHPR11MB1805.namprd11.prod.outlook.com ([fe80::e8c4:4960:1481:b0f9%10]) with mapi id 15.20.3391.024; Fri, 25 Sep 2020 11:12:58 +0000 From: "Pai G, Sunil" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Fu, Patrick" , "Laatz, Kevin" , "stable@dpdk.org" Thread-Topic: [PATCH v3 02/25] raw/ioat: fix missing close function Thread-Index: AQHWkyxdxKjTds8cmUSM6AkGOGElual5Ms7g Date: Fri, 25 Sep 2020 11:12:58 +0000 Message-ID: References: <20200721095140.719297-1-bruce.richardson@intel.com> <20200925110910.284098-1-bruce.richardson@intel.com> <20200925110910.284098-3-bruce.richardson@intel.com> In-Reply-To: <20200925110910.284098-3-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [157.45.50.197] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bbe576df-15b3-4001-b837-08d86143f5d0 x-ms-traffictypediagnostic: MWHPR1101MB2335: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2399; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HZL4OpnchgW0LA4D0wMHYBNrxh1x/tlIjoMvIQJOMY1BmL/QmwQPYW/37KwofkteBmYA4pZv7/c6f9hhIEhDh10LxquJD+3oihuP5Llb7cZ1iLvODexlJJd/mSbfDiNLuWIFI5OSoKgg3QeADRazyCt56COvW1uMZ2hNiJy7FY4/B0x2D+uPI7fo0H48QPqNE7I2gqsGzKWYRbOpgiTgpVN3O0byPxKHKMukxO2O9d5CSKR3rE7IjZ5J//iUZay0xkW/jt849KuehkCD2EzX5l/cNlbcY248jaUfnuSdA6T4cjAcDoGZ5Qa31NAJEIdokW2b1NVjgQeZHKu8Gt/37w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1805.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(376002)(346002)(366004)(396003)(26005)(8676002)(450100002)(5660300002)(316002)(54906003)(2906002)(110136005)(71200400001)(66446008)(83380400001)(86362001)(4326008)(55016002)(53546011)(6506007)(66946007)(7696005)(186003)(66476007)(76116006)(478600001)(66556008)(8936002)(9686003)(64756008)(33656002)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: o2BKb3RUNSD2f/xEJ0xUAuO2xFDbr+1D8BowYyIs0N2YYM6ebjonkVoDqGWRsYziZzU7+Ht/IaQD+5HBU0EGGWyPvNZepGtbUTPE0I5dEjyuA1D9DH6G3MDL+cxuyhqOh6fD0PqTHglGiarIa5Ok6lhQGpM3vDyfyXTJUv7/hjBoA9nOU9WIHxjwac7eptleN45jXv/Mc4dHmJPg0RPe/XZ9JhcTmzC7meGPJRZDJmwwqAHRvR3qQJepdBRxx1Lo04kbhpOu6QDUQ6e3fPekvVmR0edSJrLptBZrjjzDGXK5LzSl0YtXZZh0j56Qs2jrSLI7qCH0/gmGb0jJdbc/Ua0iy8HSHd9oeRr8Va+uDKndSjSbuTI/Hswu6ojbNQb0AXE5NJaGKVVaozYc2vH7vDPdr+Md25ZX7hpZ0JMvxTy99XEBwxBFG61i4ziAXEWwIgXUgSd3w0j0CUQcIhHwlnQFytYiI6R+CzrwNc7+BiOVCdhfHIDvHUBGxq8FFKd6uA+JJZMnUd3uFsahxC8xLmSsb7oZFIXg1QyqFWiitLBDi++oVIeS53D0HaRpMcpeuM4kHVTt0YhMek+EzDtyLU6BIfnpYdxdke0rE8fNQsp9CpQ8mFGs74mLMDHniXLg2wisbVP7YVCmP3sNT7h8xQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1805.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbe576df-15b3-4001-b837-08d86143f5d0 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Sep 2020 11:12:58.6595 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aECzh5gYzHe+1PCJCXNqSbbjJm5KDp5YrrAHTJTnwnpZcEYQcfm6SiylcZNZ9H4kM5iX9+VVpvS0Zpny6AMrAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2335 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 02/25] raw/ioat: fix missing close function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Richardson, Bruce > Sent: Friday, September 25, 2020 4:39 PM > To: dev@dpdk.org > Cc: Fu, Patrick ; Laatz, Kevin ; > stable@dpdk.org; Pai G, Sunil > Subject: [PATCH v3 02/25] raw/ioat: fix missing close function >=20 > From: Kevin Laatz >=20 > When rte_rawdev_pmd_release() is called, rte_rawdev_close() looks for a > dev_close function for the device causing a segmentation fault when no > close() function is implemented for a driver. >=20 > This patch resolves the issue by adding a stub function ioat_dev_close(). >=20 > Fixes: f687e842e328 ("raw/ioat: introduce IOAT driver") > Cc: stable@dpdk.org >=20 > Reported-by: Sunil Pai G > Signed-off-by: Kevin Laatz > --- > drivers/raw/ioat/ioat_rawdev.c | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawde= v.c > index 7f1a15436..0732b059f 100644 > --- a/drivers/raw/ioat/ioat_rawdev.c > +++ b/drivers/raw/ioat/ioat_rawdev.c > @@ -203,6 +203,12 @@ ioat_xstats_reset(struct rte_rawdev *dev, const > uint32_t *ids, uint32_t nb_ids) > return 0; > } >=20 > +static int > +ioat_dev_close(struct rte_rawdev *dev __rte_unused) { > + return 0; > +} > + > extern int ioat_rawdev_test(uint16_t dev_id); >=20 > static int > @@ -212,6 +218,7 @@ ioat_rawdev_create(const char *name, struct > rte_pci_device *dev) > .dev_configure =3D ioat_dev_configure, > .dev_start =3D ioat_dev_start, > .dev_stop =3D ioat_dev_stop, > + .dev_close =3D ioat_dev_close, > .dev_info_get =3D ioat_dev_info_get, > .xstats_get =3D ioat_xstats_get, > .xstats_get_names =3D ioat_xstats_get_names, > -- > 2.25.1 Acked-by: Sunil Pai G