From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2E08A04AC; Tue, 1 Sep 2020 15:23:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F0C1E1C0BD; Tue, 1 Sep 2020 15:23:19 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id B76C81C0B2; Tue, 1 Sep 2020 15:23:17 +0200 (CEST) IronPort-SDR: pL8GzPBKjQv1Xlv2UWX2QD2scJccV8dNswcOIaTSVskKKlPIym7QvVJCIZlormLssyx2Rnl2AI a0CXI/7r6SNg== X-IronPort-AV: E=McAfee;i="6000,8403,9730"; a="218713372" X-IronPort-AV: E=Sophos;i="5.76,379,1592895600"; d="scan'208";a="218713372" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2020 06:23:16 -0700 IronPort-SDR: 6FG0MEPLTXsE3YD8L8WCl8a4qnSOJT0BZnTlgDRkP0R5l8fe/DQdvWN0MSD2Tn1tRKNElPiOSB BMv4mglulFlg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,379,1592895600"; d="scan'208";a="281967356" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga007.fm.intel.com with ESMTP; 01 Sep 2020 06:23:15 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 1 Sep 2020 06:22:33 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 1 Sep 2020 06:22:33 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 1 Sep 2020 06:22:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gWvcdF8cZgV41TrzjoCBwXWfXI7pCMfcwxLR5PeCSdC36yT1QpJ6JI+sp+d9JTpnfOrMNMTr1sRWrFS6etX7gwhOOhePTpmmp6X0iCG8QlBHOQQA/1oR9T4uAG6h4EHok+3KYcKYyT2AEaLM7B2bATwqFsW3cATwY9D1gLiwWEOc82KwSHdi4nEKiKlR8/5EZ51ihksmwEQn9TPWkFWXbEWEawViBz2c+fq30R0mzs8fsE6y7OR3EmZwUj713ytQxSXiY81nltnS1WwJE3HWd4w2Vnqur7q0bj4U0FKv8WU+Gjczf/D+SazRkIIKk03zndG5qqJQGNc5jXLE82JlHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=flbcKRLIiC9BpIQTEV2gRqJskEc2wIDDOReLmSxvLII=; b=VxF1/6ycDSD7z9VSRJXdwBiApUSHh00k+LyIPtctH5BmiiNXbQtXzayuAwzj0dRwT0yFZXx6NCu49whF5Ksc6RcguMwpJetfddmOvHR1KY9b3Hp+5qJVdFt008ydyQAGJjc9sR7srbekGT2B7hUWw3i8j3inzaGV1OX1Er526PmCBW2SwJuQg2u1ZOSne/iRswQZarrJZp5wEgEUWP8cSq689ObjC0uUKFvb5QK1HMK2KPnbvWje2Zsytrp+tNBilW3ePPSzXS+IgJd9qb0Lg9n2rFQHP+YAa2JxXWuXzh/nqYxBXrkIGfT1qYLCYiNWpr7EJ1UlAGq+FrsMqcGKjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=flbcKRLIiC9BpIQTEV2gRqJskEc2wIDDOReLmSxvLII=; b=KT4XNYsYuUdxgfnFIfSvCVeoCxaf8F+RkToSq9L3qYTmuz6K1J3uK5JxuGSX3ZouE6HsVTi7icA+E3eGFbvP2h1euki4QfgHsBPK7puSSgaGPiQJGjjgCUA5De6ba5Rindb6WYTxGXzDqRGUu0QTLnjPma1ZHLLZqP+2JdrQ6PE= Received: from MWHPR11MB1805.namprd11.prod.outlook.com (2603:10b6:300:114::14) by MWHPR1101MB2287.namprd11.prod.outlook.com (2603:10b6:301:4e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.19; Tue, 1 Sep 2020 13:22:20 +0000 Received: from MWHPR11MB1805.namprd11.prod.outlook.com ([fe80::d907:f142:1203:82fa]) by MWHPR11MB1805.namprd11.prod.outlook.com ([fe80::d907:f142:1203:82fa%5]) with mapi id 15.20.3326.025; Tue, 1 Sep 2020 13:22:20 +0000 From: "Pai G, Sunil" To: "Richardson, Bruce" , Christian Ehrhardt CC: Luca Boccassi , "stable@dpdk.org" , dev , "Stokes, Ian" Thread-Topic: [dpdk-dev] 19.11.4 patches review and test Thread-Index: AQHWdYs0F5hCfNPWm0KbwUgbP1UGTqlTiVEAgABDfgCAAARKgIAAAsIw Date: Tue, 1 Sep 2020 13:22:20 +0000 Message-ID: References: <20200818181222.8462-1-bluca@debian.org> <20200901124747.GB1047@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20200901124747.GB1047@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [223.186.230.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 57caa0e1-7f90-4819-3c7e-08d84e7a0e5b x-ms-traffictypediagnostic: MWHPR1101MB2287: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: e4k71garGuGyi8B+aBB5wYi3vaOEUX32rOqGjprp3ILZoWKI8zGr7PTLBvGK2UpKKSt6hA8r4YkRO3b9QNxqWox/JQRp7oDs/kR0V9h1hxNNHWDFIgVaYSuMWUNgKTahG7ntoC5qj6xQLUURy3+SDHb6OdTUsnpZhEgoN8dRyTVxI1ZMPL8YaQnR0iM3vZHd6sgeQ4k6fBEsV3S0LxuUdSZsd9GoQlxBtf0OPJ0r8D/tlxcSpL9M0FNUIiG/5umRuvCdgxHc8a5sbZu22srVHzw8YHai7SUV29cm6zXZTv8pPUP0OFTxXA7b6h4RtuxLU0HdvnWLXG+WBfaNR5iN4QKD0SPx3lHs8ydIvoGIs9lJYgb7aKyThtqaE35h7bjlr3aPR/cdDDG7Wz/BUqlMFA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1805.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(39860400002)(136003)(396003)(376002)(66556008)(45080400002)(53546011)(33656002)(26005)(6506007)(966005)(110136005)(107886003)(76116006)(83380400001)(71200400001)(7696005)(54906003)(9686003)(8936002)(5660300002)(52536014)(2906002)(66946007)(86362001)(66476007)(55016002)(316002)(8676002)(66446008)(4326008)(478600001)(64756008)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: bAyvaYja9q/GwtBL5bb/CFVaAPVNWppfvWv0/nwiy8O1nf0bA3yQxOrzCguOPVBwipIMUnf9UJuOOAY8GHm/dIChCGpK+QrEvgkRYzmnvDqbigDDCryFUkPGtZ3pzksWYPoGaaD1Jxd8uZbpT0x5vC8dsiNNucZp5g1olqn7Mc04yhSzaLbPoAtMxm7AML+FWUdgba9NF3C6+FBFMHVf31BlTOaPlmgaUqHkziKBeLyvs+ULiHDH1P9XwXVyMZfumJitxyHyd4fJOe93WEszSdDFIo1m1sH1/cr3t4q0l+u2kFoG7w+b3Kf4ZO+kLyM4tnRB6okxksZ/hBMfgFA/m/XE74dhYzjqRIr6CVTQEs89eoVVEcpHbivuh2KjEkAQKn9YqOW+vI7wbzPlTxwk3/aNpn9WhbIKrmAfD4NeJ22HNGhtWRMI7VkU5zwaMKXgsnrZs55JpR+sTFJZt2qX8Jbz+j4onht1bM5Egw+7BRjPvUTWbp9CINFSxH4LNBjuT7Ytffz55uiIvJBXVjiJEOCjqDuIuNbidNSUz1chO2xxzlIFDFCKZjaqng9Z8fuy4f6WA6S7Eq8D5d48KPwD0KXtDSZ19wObDX9FpEFYB25hJ+UbNfDWTd59c90ypdmTJhXKg4nn4IulDltPddP6AQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1805.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57caa0e1-7f90-4819-3c7e-08d84e7a0e5b X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2020 13:22:20.4783 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IVrKSlqLZGEZFwSyl+ihZoVESXPHvOxNS9Xzci7lCKO/JAtgofpa0GfMHDIUqld7BfIIovd68wEvBv15nA1fWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2287 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] 19.11.4 patches review and test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Yes , OVS was using pkg-config even before these patches were rolled out. But it always used to pick the DPDK shared libs by default for OVS even on = using the -Bstatic/-Bshared flags. These patches from Bruce simplify the process from DPDK side without having= the user to specify them. Moreover, with these patches , the problem of shared DPDK libs always being= picked instead of static was not seen any more with a bit of changes from = the OVS side as well. http://patchwork.ozlabs.org/project/openvswitch/patch/20200707141126.71414-= 1-sunil.pai.g@intel.com/ . The patches for ovs-master are ready as well and will them out soon. Thanks and Regards, Pai G, Sunil Sunil > -----Original Message----- > From: Bruce Richardson > Sent: Tuesday, September 1, 2020 6:18 PM > To: Christian Ehrhardt > Cc: Luca Boccassi ; stable@dpdk.org; dev = ; > Pai G, Sunil ; Stokes, Ian > Subject: Re: [dpdk-dev] 19.11.4 patches review and test >=20 > On Tue, Sep 01, 2020 at 02:32:26PM +0200, Christian Ehrhardt wrote: > > On Tue, Sep 1, 2020 at 10:30 AM Luca Boccassi wrote: > > > > > > On Tue, 2020-08-18 at 19:12 +0100, Luca Boccassi wrote: > > > > Hi all, > > > > > > > > Here is a list of patches targeted for stable release 19.11.4. > > > > > > > > The planned date for the final release is August 31st. > > > > > > > > Please help with testing and validation of your use cases and > > > > report any issues/results with reply-all to this mail. For the > > > > final release the fixes and reported validations will be added to t= he release > notes. > > > > > > > > A release candidate tarball can be found at: > > > > > > > > https://dpdk.org/browse/dpdk-stable/tag/?id=3Dv19.11.4-rc1 > > > > > > > > These patches are located at branch 19.11 of dpdk-stable repo: > > > > https://dpdk.org/browse/dpdk-stable/ > > > > > > > > Thanks. > > > > > > > > Luca Boccassi > > > > > > Microsoft's regression tests are still running, delaying until > > > Thursday the 3rd. Apologies for any inconvenience. > > > > Due to report on OVS failing to build I happened to find that 19.11.4 > > has massively changed linking. > > =3D> https://paste.ubuntu.com/p/znCRR4gpjP/ > > > > This was meant to be helpful for sure and I assume is around: > > 48f7fd27f6 build/pkg-config: prevent overlinking > > 2d1535d592 build/pkg-config: improve static linking flags > > 9fb13a12c1 build/pkg-config: output drivers first for static build > > 59b108d824 build/pkg-config: move pkg-config file creation > > aea915e944 devtools: test static linkage with pkg-config > > > > But overlinking has effectively become underlinking now > > https://launchpadlibrarian.net/495845224/buildlog_ubuntu-groovy-amd64. > > openvswitch_2.13.1-0ubuntu2~ppa1_BUILDING.txt.gz > > > > /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux- > gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o): > > in function `rte_eth_from_rings': > > (.text+0x91c): undefined reference to `rte_vdev_init' > > /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux- > gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o): > > in function `vdrvinitfn_pmd_ring_drv': > > (.text.startup+0x28): undefined reference to `rte_vdev_register' > > collect2: error: ld returned 1 exit status > > > > Also as you can see in the pastebin above, CFlags and Libs massively > > shrunk and likely too much so. > > > > Given that this should be a stable release I'd ask to back out those > > changes so that a test build creates the same .pc file as before - > > would that make sense? > > > > > Adding some OVS folks on CC. >=20 > The request for backporting these actually came from the OVS side, since = they > were deemed necessary to enable OVS to switch to use DPDK pkg-config rath= er > than the older approach using a makefile-based build. However, it appears= you > guys were already building OVS using the pkg-config file, and since this = causes > issues where there were none, backing it out seems a prudent choice. >=20 > Ian, Sunil, any comments here. >=20 > Regards > /Bruce