From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6EF9DA051A; Fri, 17 Jan 2020 15:57:00 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5A4D229C6; Fri, 17 Jan 2020 15:56:59 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 35B6328F3 for ; Fri, 17 Jan 2020 15:56:57 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2020 06:56:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,330,1574150400"; d="scan'208";a="424480856" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by fmsmga005.fm.intel.com with ESMTP; 17 Jan 2020 06:56:56 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Jan 2020 06:56:55 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Jan 2020 06:56:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WIZtwS4uBlfwho1WgkBb+NBopxzg4Vxz6fNk3HdZDs3fxRaHa72GNrM4M4DgoWynPyGKNDugfIOy3FG2g2OsRVdDy22X81HYL2/VgsSzq8pQyxCCD1SjdQlyMfQtzfz4Cvb+KIqCZL5CW7M+KMlxMYJcyp7CA22W6xP/YmULr53BHPYsJbPGlRIayazOYIvTqmXd+1wjmW8JpPjp7EkIKEFYEb/IAgpfJqJN5aazDpWMlT++chyYs3Pw2RmMeTXbWEM6U+eyljSsxy4FimLmyc6CMSl1yi4AsHtcOainLij54a33Mp1LyHZOUdhFVs+Ikre8Zi46Lcl1dzd5jrv1qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LPL+dOPhW+6ousCXMUqJJle9MYObVaFTa3+7usnRGM8=; b=G0iiRv/g/GlXU6K8BFd8h7CH39Dx//fGUyUW78PnNtR5IjrMMWzTlYrGp7sk8ZEDVN2Mpg3PWQr8sD0Rr1KXuszbrEjc7IeQkCyGW/ZecpwsZ1JNVEQ0pHSfa25TYB++VwzZtKpzW5wCwEJB1p5twz6ZddjHHviyqTM98trTyuW+G8s9r01MaDjqzO8z7NJXtz5f2SxmSopqpenIIa0JzpMiEg784v6arDyfLyBygsqsK4IqKFD32OxQqz2HU4VyuQ9cBDrFeulq/aNPl1rZNoAHQ3p51DifwFbugxIAwn0BpOU/vJ2vDEM6gczf3q5kOBNVpE/UEb4PLqMtvnFevQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LPL+dOPhW+6ousCXMUqJJle9MYObVaFTa3+7usnRGM8=; b=BlsH1dbEajOqrB5+1AQFBzC4wrtS4WPhSpZoh+JEqJg7bZhL7Qtbe/5jKw2OwZq0qUPKuMeV6EGYHcmiVeig6lRi5Lot841DwCxErUj+iryo7ZNifRGbGeTaD9rqCWcgQYcNpsB9vrI0uQabqItzP3DJaHrNuJXWFK/VGgmB8LQ= Received: from MWHPR11MB1807.namprd11.prod.outlook.com (10.175.55.20) by MWHPR11MB0047.namprd11.prod.outlook.com (10.164.204.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.22; Fri, 17 Jan 2020 14:56:53 +0000 Received: from MWHPR11MB1807.namprd11.prod.outlook.com ([fe80::6548:ed5a:bf21:61de]) by MWHPR11MB1807.namprd11.prod.outlook.com ([fe80::6548:ed5a:bf21:61de%7]) with mapi id 15.20.2644.023; Fri, 17 Jan 2020 14:56:53 +0000 From: "Trahe, Fiona" To: "Dybkowski, AdamX" , "dev@dpdk.org" , "akhil.goyal@nxp.com" CC: "Trahe, Fiona" Thread-Topic: [PATCH v6 0/3] Refactor crypto unit tests. Thread-Index: AQHVzUUFvW2z1tJpbkGmjGyPLiILhafu8WJg Date: Fri, 17 Jan 2020 14:56:53 +0000 Message-ID: References: <20200116124232.22282-1-adamx.dybkowski@intel.com> <20200117144651.26804-1-adamx.dybkowski@intel.com> In-Reply-To: <20200117144651.26804-1-adamx.dybkowski@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=fiona.trahe@intel.com; x-originating-ip: [192.198.151.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1f6c401c-3c31-4f4d-8f1d-08d79b5d7d61 x-ms-traffictypediagnostic: MWHPR11MB0047: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2449; x-forefront-prvs: 0285201563 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(396003)(136003)(39860400002)(346002)(376002)(199004)(189003)(478600001)(8676002)(86362001)(66556008)(64756008)(66446008)(66946007)(76116006)(8936002)(6506007)(55016002)(81156014)(26005)(2906002)(33656002)(4326008)(53546011)(81166006)(66476007)(9686003)(5660300002)(71200400001)(107886003)(316002)(52536014)(7696005)(186003)(110136005); DIR:OUT; SFP:1102; SCL:1; SRVR:MWHPR11MB0047; H:MWHPR11MB1807.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8okFu80xZE4Ec7xRje8FYZD7S+maorLAv5Xw6k3soIxx2KmM+0enW7u7YWg3gsuU6G7Z4Py4p3LycWo0A1ITYUjwGL8x3iWTeqPpwPcPbzAB/K+ZdwRGB4MeVOKDY2V63yfmFxSCEsKLqSaoYxQSfR0JN70SIySNB5p4uFA4Oh7iW1/kCm0yBZqTFHPKYMi3FgWiICpqXN8crgNneOM7qr9D08JzFOwxY+BB8fICSdJg9BJhUUNy+zZHbtqve5w+fM9XgIEZ98mgCHvOmdh8IHUsWdOnSIsqQJrZa/LA+kD6tjhqt9IhbG+/C9lXYuEogosgIJ22BIWg5DUry3/Lv9WNODaBYQnYvUsxpjJN1xJs5oE6SnVifmNiJUIgZGaQnBV2sD43DxF+Ohk7Tr3zYc6coWlGdTo2+i+5HzJevjIsLg3bbADqhmotev7ULppy Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 1f6c401c-3c31-4f4d-8f1d-08d79b5d7d61 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2020 14:56:53.2854 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LRBYbAFJfupe9kCUmmgHSguSR8N1mpBRl0B8vkp0XVMKcjf10E8LwQfnIBr+/+pCCu9bSuVDtcQ1Jw/9xYNHxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0047 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v6 0/3] Refactor crypto unit tests. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dybkowski, AdamX > Sent: Friday, January 17, 2020 2:47 PM > To: dev@dpdk.org; Trahe, Fiona ; akhil.goyal@nxp.c= om > Cc: Dybkowski, AdamX > Subject: [PATCH v6 0/3] Refactor crypto unit tests. >=20 > This patch set is a first step to refactor the overly complex symmetric > crypto unit tests. It merges many separate arrays of the tests > for these PMDs: null, aesni_mb, aesni_gcm, openssl, qat, sw_snow3g, > sw_kasumi, sw_zuc into one big array that's then used when running > unit tests on these PMDs. >=20 > Individual test functions check the capabilities and execute the rest > of the test or skip (return -ENOTSUP) based on the particular test > requirements - e.g. test if PMD supports ZUC algo or even a particular > key length in few cases. Few edge cases required to check the PMD > itself (e.g. run on QAT only, or skip on AES NI / AES GCM). >=20 > It's the first step of bigger refactoring. Maintainers of other PMDs > are encouraged to add their PMD unit tests also into this big central > array and remove individual test macro arrays. >=20 > This patch doesn't address next refactoring steps to be done in the > future: geting rid of many small (usually 1-2 line) test functions, > created separately for every test case; and simplifying many bigger > functions that currently do similar things but work on different > test vector structures. >=20 > A simple script to check if symmetric crypto unit tests work properly > on multiple PMDs at once, update the PMDs list to your needs: >=20 > for PMD in null aesni_mb aesni_gcm openssl qat scheduler sw_snow3g sw_kas= umi sw_zuc > do > echo +++++ $PMD +++++ > echo cryptodev_${PMD}_autotest | build/app/test -c7 -n1 --log-level= =3D7 | grep ' Tests > [Failed|Passed]' > done >=20 > --- > v2: > * Update the cover letter, regenerate the patch file. > v3: > * Break very large commit into four smaller commits, easier to review. > * Show in the cover letter how to run unit tests on multiple PMDs at once= . > v4: > * Rebase. > v5: > * Fix a test failing on SW ZUC PMD. > v6: > * Rebase again, squash first two commits to allow building individual pat= ches. >=20 > Adam Dybkowski (3): > test/crypto: refactor unit tests > test/crypto: add capability checks > test/crypto: refactor unit tests into one combined array >=20 > app/test/test_cryptodev.c | 15975 +++++++++---------- > app/test/test_cryptodev_blockcipher.c | 2 +- > app/test/test_cryptodev_des_test_vectors.h | 6 +- > 3 files changed, 7335 insertions(+), 8648 deletions(-) >=20 > -- > 2.17.1 Series-acked-by: Fiona Trahe