From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2435A04B7; Wed, 16 Sep 2020 17:17:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 14C7A1C2ED; Wed, 16 Sep 2020 17:17:26 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E264F1C2E8 for ; Wed, 16 Sep 2020 17:17:23 +0200 (CEST) IronPort-SDR: dzgLgQBeTDe2DlqGgXrORj1i0D2ZrEEjoaJcQVw5WH0C/KSgWPOTMDwrmMDmj/8krYlJjqZ64T bDccUWdoRPMg== X-IronPort-AV: E=McAfee;i="6000,8403,9746"; a="223671863" X-IronPort-AV: E=Sophos;i="5.76,433,1592895600"; d="scan'208";a="223671863" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2020 08:17:22 -0700 IronPort-SDR: DsnipOVCeTI5m2C1PP2DFj1fbj47o3a7Lk+fsdBVraFYrQ8mKSqqwnvok7aw45+TjjU5FM+Xbx jd2n3YnLiLoA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,433,1592895600"; d="scan'208";a="380202180" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 16 Sep 2020 08:17:22 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 16 Sep 2020 08:17:21 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 16 Sep 2020 08:17:21 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 16 Sep 2020 08:17:21 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 16 Sep 2020 08:17:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C3bo8F3MI0YFhz7yJ+kirTu7jWcdekiXfyJoaB/QfHZgKaNlQmuYwxNOiVetpc0Ja7aHdK8iOhLNeLYuj4Z3e8VoUNqmB+CQ+ggqEURrLfWgRUrNqOpH4IrnT7jJLOmIsv4UcAUPopjliL3SAG19048VpX12Zjd4a8aZ2PPCjALYfSef1RSuh89JOoTW9cy+YS2nnrnU7PPEc+DNP2F4LPUDMAQticiHK3mb3raWO/VjwlsGxzEofEJo9vcpYi/z1Vpbs2iNps/+rLltVzPIDGJJsLcNTv/3AdVRhdg7QJHGXOedbsFAneLlxqK3FUGwDPffJp3TGamTeTZLrBfqEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gQopwUdLoW7ghKPlXl4TXMr1hUvT52b+m49xhnUGHuQ=; b=dM1Q2fZ8wOrYrbe+Ab8yv1m6JcrSTG8rczHNOX+14hxY2kXcO5Sb/CsosBHOnpTEHCmkbOd4WrsD4bS1O35Rc3qZ+8jnzzNPuPDeT4RfQWeqvPsu8pXd5FzDG78c1nlJY8ufTGbWb3qAdEKo4CuNTXrNuXjNURuBh5jYG5AeGGys/6ba+oIOP2I3tUTW4lqzs8TfmDDa3PWqjE/eupqrGhOqO+NBUknsXEWYf+pwVHhgGlCCZQgB//ogBE8bGHyDzUE33LwrnAV+4/osCVLAU7cFUGCNtW0UU8mRXKeYBTXnNeiSYjgE7H/rV9Ga14VInEeCUQacTz5CPvOHmh6mJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gQopwUdLoW7ghKPlXl4TXMr1hUvT52b+m49xhnUGHuQ=; b=k52yB++KunBUC30+0UuXwgqnjIoztCF/SAt0Z6rrZGxQ9kKpEmexoqwZXB8836KKxDJkeHyhdW/vvpRggxNJI+jHCKrc4xCfQ/o9dsHQKKQv1a1E+P3zx89lbSHCdMN7qtPi4t0uHV+soj16VR/gnjlBWvVHdSlEH4rGd6K5u8Y= Received: from MWHPR11MB1838.namprd11.prod.outlook.com (2603:10b6:300:10c::11) by MWHPR11MB2016.namprd11.prod.outlook.com (2603:10b6:300:26::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Wed, 16 Sep 2020 15:17:16 +0000 Received: from MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::34c5:6550:a098:209f]) by MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::34c5:6550:a098:209f%12]) with mapi id 15.20.3391.011; Wed, 16 Sep 2020 15:17:16 +0000 From: "Gujjar, Abhinandan S" To: "Ananyev, Konstantin" , "dev@dpdk.org" CC: "Doherty, Declan" , "jerinj@marvell.com" , "akhil.goyal@nxp.com" , "Vangati, Narender" Thread-Topic: [dpdk-dev] [v2 1/2] cryptodev: support enqueue callback functions Thread-Index: AQHWhsTNpueHJn2Z1E+jIJevuNB9zqlrUBQAgAARrrA= Date: Wed, 16 Sep 2020 15:17:16 +0000 Message-ID: References: <1599549024-195051-1-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [103.5.135.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d4e1e9de-510a-4fe1-0128-08d85a5398ae x-ms-traffictypediagnostic: MWHPR11MB2016: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5v0AFdmVozc59Mn/3lC4ZV24mA/QRJ9x5opXpIVUOysADzBME1gj8j3UAxChG8ztzqCQUVPJ/7P3QXi5iPCMI8lshjyDwX6BxjwdGGaRQyFVmUj4lYdl49Iy4JH3YgpVpMV3Ow9rmHs5zohv6ur0UPE5TeLjBzhmsCjwafVeSkloioBkam4FSMMA8MlUim+QAjQIpaOWGYx2xyj3rCBrWRuEI9bXopkr8uA0CkqeEVP5TKCjBP5lBjd8MY6UoNI+jhYE0GL9qc4Zu+UVDZrPTHWXjNEpqUb77rfI+3p0y4J0nHPa86yWYKDzqu7Q4CwHG/97rngVLDMJOOUzyluiwU+sSesQc/ytqwOBv82Jvb/fsgfFnyRngNv6kyYP036O8QJzWNHtRyEQurgnKSSsvksJpn+n/eJMmP4PKrV2l7dcGYn7V5uJxibzxL2K2gf0P04j/OBdQc4K1bbNCkFMSg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1838.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(39860400002)(136003)(376002)(346002)(966005)(316002)(8676002)(55236004)(9686003)(186003)(110136005)(66446008)(64756008)(2906002)(30864003)(66556008)(55016002)(66476007)(478600001)(76116006)(83380400001)(26005)(33656002)(66946007)(8936002)(86362001)(5660300002)(52536014)(6506007)(4326008)(7696005)(107886003)(53546011)(71200400001)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 8e3HcAfxqmE1TRbv8jB0Ihq7R1qBhXqgQemZt1L9bQUCA2xciL7O0io9VHa/RhXn6N3K36iMVZtdgQEt6MBLAl5vBAgdPIc6lxPXZAIY0ePGkLMEEDXOwjl7BgA4m0bTkcxeHfmf+kTetPQoyDFQmjujXPzA0HXkGDRNicSPJRfZMixQHYt1d1ztYw+TfOMuTW2A5+EsOkastDvEGzXeq5kgvY5ncROiflCXua4rBSBIKUnLWL+k87Q0SwwUnWTYIDiL6I0Bn0N1dz//ffs8WslilpCMAwQibW3ltKsQTPcyicOsNrxPn/UohCEKM76TW6hLYWcJSdtDrzhTk6+cjHilQpXvRQiRv6TpuKnyZenFesF2jLBUl9ieVP9yKbJ0P9ro231qXgoobY9DdkioExTBIWh/EaffvcfN6Q96xz6qnvvuWsN4dUSRF+J0zpLrWo3uaNRL1ox5qo1tYc4MTr8uktM+4hieykudRfepHEdnJ5aBQbR9ErHJ39a5UudCFrfyMUbimzTmOphI/eUAzMIIhIwhGKwdgUmPmy+QuDx5Y6RqnJPc5cVYcA6nJerR474cnadcfFCcW3nRdrkqjMiWPyZVhQq3qO/jPzz4zh7MjHDjkXPfb7580sHG6ax5PVXSaMk5wgz8RGVdbZxFoQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1838.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4e1e9de-510a-4fe1-0128-08d85a5398ae X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2020 15:17:16.0572 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: t8i/dHanqxFGxjukrVVPn1ykO8s/w6GuWilm6irJ5Es7S1jTdBmGTxjwp/gWe19c7n8RqTiOpQ+cTzrqXbEr3TPneyenFOBgjiSMqKyz9Xk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB2016 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [v2 1/2] cryptodev: support enqueue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Konstantin, Please find some comments inline. > -----Original Message----- > From: Ananyev, Konstantin > Sent: Wednesday, September 16, 2020 7:10 PM > To: Gujjar, Abhinandan S ; dev@dpdk.org > Cc: Doherty, Declan ; jerinj@marvell.com; > akhil.goyal@nxp.com; Vangati, Narender ; > Gujjar, Abhinandan S > Subject: RE: [dpdk-dev] [v2 1/2] cryptodev: support enqueue callback > functions >=20 > Hi Guijjar, >=20 > > > > In an eventdev world, multiple workers (with ordered queue) will be > > working on IPsec ESP processing. The ESP header's sequence number is > > unique and has to be sequentially incremented in an orderly manner. > > This rises a need for incrementing sequence number in crypto stage > > especially in event crypto adapter. By adding a user callback to > > cryptodev at enqueue burst, the user callback will get executed in the > > context of event crypto adapter. This helps the application to > > increment the ESP sequence number atomically and orderly manner. > > > > This patch adds APIs to add/remove callback functions. The callback > > function will be called for each burst of crypto ops received on a > > given crypto device queue pair. > > > > v1->v2: > > Moved callback related members to the end of cryptodev struct Added > > support for RCU > > > > Signed-off-by: Abhinandan Gujjar > > --- > > config/common_base | 1 + > > lib/librte_cryptodev/Makefile | 2 +- > > lib/librte_cryptodev/rte_cryptodev.c | 157 > +++++++++++++++++++++++++ > > lib/librte_cryptodev/rte_cryptodev.h | 154 > +++++++++++++++++++++++- > > lib/librte_cryptodev/rte_cryptodev_version.map | 6 + > > 5 files changed, 318 insertions(+), 2 deletions(-) > > > > diff --git a/config/common_base b/config/common_base index > > fbf0ee7..f5ebde4 100644 > > --- a/config/common_base > > +++ b/config/common_base > > @@ -599,6 +599,7 @@ > CONFIG_RTE_LIBRTE_PMD_BBDEV_FPGA_5GNR_FEC=3Dy > > # > > CONFIG_RTE_LIBRTE_CRYPTODEV=3Dy > > CONFIG_RTE_CRYPTO_MAX_DEVS=3D64 > > +CONFIG_RTE_CRYPTODEV_CALLBACKS=3Dy > > > > # > > # Compile PMD for ARMv8 Crypto device diff --git > > a/lib/librte_cryptodev/Makefile b/lib/librte_cryptodev/Makefile index > > 73e77a2..514d552 100644 > > --- a/lib/librte_cryptodev/Makefile > > +++ b/lib/librte_cryptodev/Makefile > > @@ -10,7 +10,7 @@ LIB =3D librte_cryptodev.a CFLAGS +=3D -O3 CFLAGS += =3D > > $(WERROR_FLAGS) LDLIBS +=3D -lrte_eal -lrte_mempool -lrte_ring > > -lrte_mbuf -LDLIBS +=3D -lrte_kvargs > > +LDLIBS +=3D -lrte_kvargs -lrte_rcu > > > > # library source files > > SRCS-y +=3D rte_cryptodev.c rte_cryptodev_pmd.c > > cryptodev_trace_points.c diff --git > > a/lib/librte_cryptodev/rte_cryptodev.c > > b/lib/librte_cryptodev/rte_cryptodev.c > > index 1dd795b..2fb3e35 100644 > > --- a/lib/librte_cryptodev/rte_cryptodev.c > > +++ b/lib/librte_cryptodev/rte_cryptodev.c > > @@ -38,6 +38,7 @@ > > #include > > #include > > #include > > +#include > > > > #include "rte_crypto.h" > > #include "rte_cryptodev.h" > > @@ -499,6 +500,10 @@ struct > rte_cryptodev_sym_session_pool_private_data { > > return 0; > > } > > > > +#ifdef RTE_CRYPTODEV_CALLBACKS > > +/* spinlock for crypto device enq callbacks */ static rte_spinlock_t > > +rte_cryptodev_enq_cb_lock =3D RTE_SPINLOCK_INITIALIZER; #endif > > > > const char * > > rte_cryptodev_get_feature_name(uint64_t flag) @@ -1449,6 +1454,158 > @@ > > struct rte_cryptodev * > > rte_spinlock_unlock(&rte_cryptodev_cb_lock); > > } > > > > +#ifdef RTE_CRYPTODEV_CALLBACKS > > +int > > +rte_cryptodev_rcu_qsbr_add(uint8_t dev_id, struct rte_rcu_qsbr *qsbr) > > +{ > > + > > + struct rte_cryptodev *dev; > > + > > + if (!rte_cryptodev_pmd_is_valid_dev(dev_id)) { > > + CDEV_LOG_ERR("Invalid dev_id=3D%" PRIu8, dev_id); > > + return -EINVAL; > > + } > > + > > + dev =3D &rte_crypto_devices[dev_id]; > > + dev->qsbr =3D qsbr; > > + return 0; > > +} >=20 > So if I understand your patch correctly you propose a new working model f= or > crypto-devs: > 1. Control-plane has to allocate/setup rcu_qsbr and do > rte_cryptodev_rcu_qsbr_add(). > 2. Data-plane has somehow to obtain pointer to that rcu_qsbr and wrap > cryptodev_enqueue() > with rcu_qsbr_quiescent() or rcu_qsbr_online()/rcu_qsbr_offline(). Yes. I think, it is not a new model. It is same as RCU integration with LPM= . Please refer: https://patches.dpdk.org/cover/73673/ >=20 > That seems quite a big change and I don't think it is acceptable for most > users. > From my perspective adding/installing call-backs to the dev has to be opa= que > to the data-plane code. > Also note that different callbacks can be installed by different entities= (libs) > and might have no idea about each other. > That's why I thought it would be better to make all this RCU stuff intern= al > inside cryptodev: > hide all this rcu_qsbr allocation/setup inside cryptodev init/queue s= etup > invoke rcu_qsbr_online()/rcu_qsbr_offline() inside cryptodev_enqueue(= ). I have already tried exploring above stuffs. There are too many constraints= . The changes don't fit in, as per RCU design. Moreover, having rcu api under enqueue_burst() will affect the performance. The changes are more on control plane side, which is one time. The data plane changes are minimal. >=20 > > + > > +struct rte_cryptodev_enq_callback * > > +rte_cryptodev_add_enq_callback(uint8_t dev_id, > > + uint16_t qp_id, > > + rte_cryptodev_enq_cb_fn cb_fn, > > + void *cb_arg) > > +{ > > + struct rte_cryptodev *dev; > > + struct rte_cryptodev_enq_callback *cb, *tail; > > + > > + if (!cb_fn) > > + return NULL; > > + > > + if (!rte_cryptodev_pmd_is_valid_dev(dev_id)) { > > + CDEV_LOG_ERR("Invalid dev_id=3D%" PRIu8, dev_id); > > + return NULL; > > + } > > + > > + dev =3D &rte_crypto_devices[dev_id]; > > + if (qp_id >=3D dev->data->nb_queue_pairs) { > > + CDEV_LOG_ERR("Invalid queue_pair_id=3D%d", qp_id); > > + return NULL; > > + } > > + > > + cb =3D rte_zmalloc(NULL, sizeof(*cb), 0); > > + if (cb =3D=3D NULL) { > > + CDEV_LOG_ERR("Failed to allocate memory for callback on " > > + "dev=3D%d, queue_pair_id=3D%d", dev_id, qp_id); > > + rte_errno =3D ENOMEM; > > + return NULL; > > + } > > + > > + cb->fn =3D cb_fn; > > + cb->arg =3D cb_arg; > > + > > + rte_spinlock_lock(&rte_cryptodev_enq_cb_lock); > > + if (dev->enq_cbs =3D=3D NULL) { > > + dev->enq_cbs =3D rte_zmalloc(NULL, sizeof(cb) * > > + dev->data->nb_queue_pairs, 0); > > + if (dev->enq_cbs =3D=3D NULL) { > > + CDEV_LOG_ERR("Failed to allocate memory for > callbacks"); > > + rte_errno =3D ENOMEM; > > + rte_free(cb); > > + return NULL; > > + } > > + } > > + > > + /* Add the callbacks in fifo order. */ > > + tail =3D dev->enq_cbs[qp_id]; > > + if (tail) { > > + while (tail->next) > > + tail =3D tail->next; > > + tail->next =3D cb; > > + } else > > + dev->enq_cbs[qp_id] =3D cb; > > + > > + rte_spinlock_unlock(&rte_cryptodev_enq_cb_lock); > > + > > + return cb; > > +} > > + > > +int > > +rte_cryptodev_remove_enq_callback(uint8_t dev_id, > > + uint16_t qp_id, > > + struct rte_cryptodev_enq_callback *cb) { > > + struct rte_cryptodev *dev; > > + struct rte_cryptodev_enq_callback **prev_cb, *curr_cb; > > + uint16_t qp; > > + int free_mem; > > + int ret; > > + > > + free_mem =3D 1; > > + > > + if (!cb) { > > + CDEV_LOG_ERR("cb is NULL"); > > + return -EINVAL; > > + } > > + > > + if (!rte_cryptodev_pmd_is_valid_dev(dev_id)) { > > + CDEV_LOG_ERR("Invalid dev_id=3D%" PRIu8, dev_id); > > + return -EINVAL; > > + } > > + > > + dev =3D &rte_crypto_devices[dev_id]; > > + if (qp_id >=3D dev->data->nb_queue_pairs) { > > + CDEV_LOG_ERR("Invalid queue_pair_id=3D%d", qp_id); > > + return -EINVAL; > > + } > > + > > + if (!dev->qsbr) { > > + CDEV_LOG_ERR("Rcu qsbr is NULL"); > > + return -EINVAL; > > + } > > + > > + rte_spinlock_lock(&rte_cryptodev_enq_cb_lock); > > + if (dev->enq_cbs =3D=3D NULL) { > > + rte_spinlock_unlock(&rte_cryptodev_enq_cb_lock); > > + return -EINVAL; > > + } > > + > > + prev_cb =3D &dev->enq_cbs[qp_id]; > > + for (; *prev_cb !=3D NULL; prev_cb =3D &curr_cb->next) { > > + curr_cb =3D *prev_cb; > > + if (curr_cb =3D=3D cb) { > > + /* Remove the user cb from the callback list. */ > > + *prev_cb =3D curr_cb->next; > > + ret =3D 0; > > + break; > > + } > > + } > > + > > + if (!ret) { > > + /* Call sync with invalid thread id as this is part of > > + * control plane API */ > > + rte_rcu_qsbr_synchronize(dev->qsbr, > > + RTE_QSBR_THRID_INVALID); > > + rte_free(cb); > > + } > > + > > + for (qp =3D 0; qp < dev->data->nb_queue_pairs; qp++) > > + if (dev->enq_cbs[qp] !=3D NULL) { >=20 > Some reference count (number of callbacks) seems like a better approach > here. Ok. >=20 > > + free_mem =3D 0; > > + break; > > + } > > + > > + if (free_mem) { > > + rte_free(dev->enq_cbs); > > + dev->enq_cbs =3D NULL; > > + } > > + > > + rte_spinlock_unlock(&rte_cryptodev_enq_cb_lock); > > + > > + return ret; > > +} > > +#endif > > > > int > > rte_cryptodev_sym_session_init(uint8_t dev_id, diff --git > > a/lib/librte_cryptodev/rte_cryptodev.h > > b/lib/librte_cryptodev/rte_cryptodev.h > > index 7b3ebc2..2c7a47b 100644 > > --- a/lib/librte_cryptodev/rte_cryptodev.h > > +++ b/lib/librte_cryptodev/rte_cryptodev.h > > @@ -530,6 +530,32 @@ struct rte_cryptodev_qp_conf { }; > > > > /** > > + * Function type used for pre processing crypto ops when enqueue > > +burst is > > + * called. > > + * > > + * The callback function is called on enqueue burst immediately > > + * before the crypto ops are put onto the hardware queue for processin= g. > > + * > > + * @param dev_id The identifier of the device. > > + * @param qp_id The index of the queue pair in which ops are > > + * to be enqueued for processing. The value > > + * must be in the range [0, nb_queue_pairs - 1] > > + * previously supplied to > > + * *rte_cryptodev_configure*. > > + * @param ops The address of an array of *nb_ops* pointers > > + * to *rte_crypto_op* structures which contain > > + * the crypto operations to be processed. > > + * @param nb_ops The number of operations to process. > > + * @param user_param The arbitrary user parameter passed in by the > > + * application when the callback was originally > > + * registered. > > + * @return The number of ops to be enqueued to the > > + * crypto device. > > + */ > > +typedef uint16_t (*rte_cryptodev_enq_cb_fn)(uint16_t dev_id, uint16_t > qp_id, > > + struct rte_crypto_op **ops, uint16_t nb_ops, void > *user_param); > > + > > +/** > > * Typedef for application callback function to be registered by appli= cation > > * software for notification of device events > > * > > @@ -853,7 +879,6 @@ struct rte_cryptodev_config { > > enum rte_cryptodev_event_type event, > > rte_cryptodev_cb_fn cb_fn, void *cb_arg); > > > > - > > typedef uint16_t (*dequeue_pkt_burst_t)(void *qp, > > struct rte_crypto_op **ops, uint16_t nb_ops); > > /**< Dequeue processed packets from queue pair of a device. */ @@ > > -870,6 +895,17 @@ typedef uint16_t (*enqueue_pkt_burst_t)(void *qp, > > /** Structure to keep track of registered callbacks */ > > TAILQ_HEAD(rte_cryptodev_cb_list, rte_cryptodev_callback); > > > > +/** > > + * @internal > > + * Structure used to hold information about the callbacks to be > > +called for a > > + * queue pair on enqueue. > > + */ > > +struct rte_cryptodev_enq_callback { > > + struct rte_cryptodev_enq_callback *next; > > + rte_cryptodev_enq_cb_fn fn; > > + void *arg; > > +}; > > + > > /** The data structure associated with each crypto device. */ struct > > rte_cryptodev { > > dequeue_pkt_burst_t dequeue_burst; > > @@ -898,6 +934,14 @@ struct rte_cryptodev { > > __extension__ > > uint8_t attached : 1; > > /**< Flag indicating the device is attached */ > > + > > +#ifdef RTE_CRYPTODEV_CALLBACKS > > + struct rte_cryptodev_enq_callback **enq_cbs; > > + /**< User application callback for pre enqueue processing */ > > + > > + struct rte_rcu_qsbr *qsbr; > > + /** < RCU QSBR variable for rte_cryptodev_enq_callback */ >=20 > Probably better to have both these fields per queue. > Space for them can be allocated at dev_configure() or so. enq_cbs is allocated during callback add. Unlike ethdev, each cryptodev have their own max queue pair. There is no ma= cro for that. I think, single RCU should be good enough, as it has mechanism to track all= its reporting threads. > BTW, wouldn't it make sense to have ability to add callback for dequeue t= oo? As mentioned in the commit message, this patch was driven by a requirement. If required, callback for the dequeue can be added in a separate patch.=20 >=20 > > +#endif > > } __rte_cache_aligned; > > > > void * > > @@ -1019,6 +1063,18 @@ struct rte_cryptodev_data { > > struct rte_crypto_op **ops, uint16_t nb_ops) { > > struct rte_cryptodev *dev =3D &rte_cryptodevs[dev_id]; > > +#ifdef RTE_CRYPTODEV_CALLBACKS > > + if (unlikely(dev->enq_cbs !=3D NULL && dev->enq_cbs[qp_id] !=3D > NULL)) { > > + struct rte_cryptodev_enq_callback *cb =3D > > + dev->enq_cbs[qp_id]; > > + > > + do { > > + nb_ops =3D cb->fn(dev_id, qp_id, ops, nb_ops, > > + cb->arg); > > + cb =3D cb->next; > > + } while (cb !=3D NULL); > > + } > > +#endif > > > > rte_cryptodev_trace_enqueue_burst(dev_id, qp_id, (void **)ops, > nb_ops); > > return (*dev->enqueue_burst)( > > @@ -1351,6 +1407,102 @@ struct rte_cryptodev_asym_session * > > struct rte_cryptodev_sym_session *sess, union rte_crypto_sym_ofs > ofs, > > struct rte_crypto_sym_vec *vec); > > > > +#ifdef RTE_CRYPTODEV_CALLBACKS > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice > > + * > > + * Add a user callback for a given crypto device and queue pair which > > +will be > > + * called on crypto ops enqueue. > > + * > > + * This API configures a function to be called for each burst of > > +crypto ops > > + * received on a given crypto device queue pair. The return value is > > +a pointer > > + * that can be used later to remove the callback using > > + * rte_cryptodev_remove_enq_callback(). > > + * > > + * Multiple functions are called in the order that they are added. > > + * > > + * @param dev_id The identifier of the device. > > + * @param qp_id The index of the queue pair in which ops are > > + * to be enqueued for processing. The value > > + * must be in the range [0, nb_queue_pairs - 1] > > + * previously supplied to > > + * *rte_cryptodev_configure*. > > + * @param cb_fn The callback function > > + * @param cb_arg A generic pointer parameter which will be > passed > > + * to each invocation of the callback function on > > + * this crypto device and queue pair. > > + * > > + * @return > > + * NULL on error. > > + * On success, a pointer value which can later be used to remove the > callback. > > + */ > > + > > +__rte_experimental > > +struct rte_cryptodev_enq_callback * > > +rte_cryptodev_add_enq_callback(uint8_t dev_id, > > + uint16_t qp_id, > > + rte_cryptodev_enq_cb_fn cb_fn, > > + void *cb_arg); > > + > > + > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice > > + * > > + * Remove a user callback function for given crypto device and queue p= air. > > + * > > + * This function is used to removed callbacks that were added to a > > +crypto > > + * device queue pair using rte_cryptodev_add_enq_callback(). > > + * > > + * Note: The callback expects a RCU QSBR to be configured to > > +synchronize > > + * to free the memory. Application is expected to configure RCU QSBR > > +after > > + * adding an enqueue callback. > > + * > > + * > > + * @param dev_id The identifier of the device. > > + * @param qp_id The index of the queue pair in which ops are > > + * to be enqueued for processing. The value > > + * must be in the range [0, nb_queue_pairs - 1] > > + * previously supplied to > > + * *rte_cryptodev_configure*. > > + * @param cb Pointer to user supplied callback created via > > + * rte_cryptodev_add_enq_callback(). > > + * > > + * @return > > + * - 0: Success. Callback was removed. > > + * - -EINVAL: The dev_id or the qp_id is out of range, or the callb= ack > > + * is NULL or not found for the crypto device queue pair= . > > + */ > > + > > +__rte_experimental > > +int rte_cryptodev_remove_enq_callback(uint8_t dev_id, > > + uint16_t qp_id, > > + struct rte_cryptodev_enq_callback *cb); > > + > > + > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice > > + * > > + * Associate RCU QSBR variable with a cryptodev. > > + * > > + * This function is used to add RCU QSBR to a crypto device. > > + * The purpose of RCU is to help multiple threads to synchronize > > + * with each other before initiating adding/removing callback > > + * while dataplane threads are running enqueue callbacks. > > + * > > + * @param dev_id The identifier of the device. > > + * @param qsr RCU QSBR configuration > > + * @return > > + * On success - 0 > > + * On error - EINVAL. > > + */ > > + > > +__rte_experimental > > +int rte_cryptodev_rcu_qsbr_add(uint8_t dev_id, struct rte_rcu_qsbr > > +*qsbr); #endif > > + > > #ifdef __cplusplus > > } > > #endif > > diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map > > b/lib/librte_cryptodev/rte_cryptodev_version.map > > index 02f6dcf..46de3ca 100644 > > --- a/lib/librte_cryptodev/rte_cryptodev_version.map > > +++ b/lib/librte_cryptodev/rte_cryptodev_version.map > > @@ -64,6 +64,7 @@ DPDK_20.0 { > > rte_cryptodev_sym_capability_get; > > }; > > > > + > > EXPERIMENTAL { > > global: > > > > @@ -105,4 +106,9 @@ EXPERIMENTAL { > > > > # added in 20.08 > > rte_cryptodev_get_qp_status; > > + > > + # added in 20.11 > > + rte_cryptodev_add_enq_callback; > > + rte_cryptodev_remove_enq_callback; > > + rte_cryptodev_rcu_qsbr_add; > > }; > > -- > > 1.9.1