From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 151ACA0521; Tue, 3 Nov 2020 17:37:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B5F7DAC8F; Tue, 3 Nov 2020 17:37:47 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 06C65AA1F for ; Tue, 3 Nov 2020 17:37:43 +0100 (CET) IronPort-SDR: Dht8hP8djVKliq7WbijFVjccq3QoERCu9Fm7yQKiPyiqHtasURcXTt9u2BNgB7z0+rgm94EfUm xn5+y6Ec9diQ== X-IronPort-AV: E=McAfee;i="6000,8403,9794"; a="230713166" X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="230713166" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 08:37:41 -0800 IronPort-SDR: iRBbT5e6LeeUWmlW/S3CbG972yIjtoE26PnpdSgn5yCPHbBsYbwqesFG0YxR+2cCs1n2/TPUvZ LjKc0qd18z4w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="357738365" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga002.fm.intel.com with ESMTP; 03 Nov 2020 08:37:41 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 3 Nov 2020 08:37:41 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 3 Nov 2020 08:37:40 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 3 Nov 2020 08:37:40 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 3 Nov 2020 08:37:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C/8IxauiK5i70vEelbfsHAtWUld2xOeX97rHBDQBUqPl4zRrqPdID8nd2hk3awDac9/5SrOyBzHxdEawNteKefOgQFfDiOwKCI4PTvDO4E9FVbnao+JCkNv9MS/Umc7vJ6q7AMYqGuob94++U3RJuxWTN7nmXDwNPSd0BuS1m1darLrBN8jP9upURGOcrDvTrTKwsN8/w7JIIA+0Uj8QhPnHpfizA38ulqyLXnZHOQQU1+7iBGkrIqUTs1818vcXsgit2p9eQVD7VbNFxKv5cA0Tuu7QqUCakzx/HnOgUS3yT4cvTE0NLPt87JX8hJuzdNvtiDS+1O6vcl+fHO11GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OSQ1adg3qXFJGHWmd9mex9+m98DAkRyk5+QmDy++8sA=; b=nSNnN5Ew3sNYmy0vtjbxar6/sKC+miaFIKEe6Z6+8OA9bqVeL4tVxSaR6LkWfO4h6aed+nGJn+Wi9yqgAigJ9OLtFwHkTpmYb229UfSzTNAln6S305XzcEBjqxfjfHkSkmFRgo3An5iow//Gxt9AStG0s0sWNl+HWEKwXzOsPRC/oqIs9nNrW5ybLobrL4a9xdLoHcx/Ul7tJdyKJFJh4l7FEUtqWv/hTYMABKvW2R3FniobfnOwBZHLJh2Inr1aq3+gzMm8bl/M6tzIlt8eJSeK5tflGyq86YejLgNvojwXbQzl9nqMaBUQ3V/Mw5KUNDFGGCSmHNFZECyJbks9PQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OSQ1adg3qXFJGHWmd9mex9+m98DAkRyk5+QmDy++8sA=; b=lDWUwJnrihU2WTAbOEFHoVrgUUTcRezcyV/jCGmj0jWTkOT6T6wLI2IcbjP8Z7zWexg61vXcd+Y6hTdQzgDzmL3vv5PiVlrLDdW74cBcgGUYFhrRtnUZADHA/jmDrAK6J0wb35ta3WreeZJ5fcKvlxtJ1DbrCwO7LdHS5YAJEaY= Received: from MWHPR11MB1838.namprd11.prod.outlook.com (2603:10b6:300:10c::11) by CO1PR11MB5044.namprd11.prod.outlook.com (2603:10b6:303:92::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Tue, 3 Nov 2020 16:37:37 +0000 Received: from MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea]) by MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea%7]) with mapi id 15.20.3499.029; Tue, 3 Nov 2020 16:37:37 +0000 From: "Gujjar, Abhinandan S" To: Thomas Monjalon CC: Akhil Goyal , "dev@dpdk.org" , "Doherty, Declan" , "Honnappa.Nagarahalli@arm.com" , "Ananyev, Konstantin" , Hemant Agrawal , "Vangati, Narender" , "jerinj@marvell.com" , "Mcnamara, John" , "david.marchand@redhat.com" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue callback functions Thread-Index: AQHWrpUcu4l0aZzUeUWHkBKE9uoPCKmwd9qAgAABNjCABCEKsIAAnOCAgAC0hfCAAAxYAIAAElNwgACOj4CAAAeOUA== Date: Tue, 3 Nov 2020 16:37:36 +0000 Message-ID: References: <1603926611-19086-1-git-send-email-abhinandan.gujjar@intel.com> <1882047.WhnCstt3cK@thomas> In-Reply-To: <1882047.WhnCstt3cK@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [103.5.135.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 76188931-b95e-4f82-0686-08d88016c5de x-ms-traffictypediagnostic: CO1PR11MB5044: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pUOzTX8LBlK5xfHOEfOa7B40D6L856i1/3NiCdawKKWfKwrhr5cMO2V4iARUnOZ5fxiTGyYUsZAhKV7VB8Q8bANeK4ZBlWmEBaKsq9OwmuGdZn9+WLtIV/R60JLZasfz3U5jKO3BXqjChbn8zPwdw0XD6SzOOBfU+cao8T//HAjj5faNhe18qrK5DCuFkk5un7lp5QCHijmlwsDvzo31n6vELeVw30Jo/jb9fax5sM742mI4KRhIywSZWklKwGDtzO/DlDiMVRsmXK6Iz39tpWxHpwV9W1Z3VBDIjRgerpmYEQzl6OBVAhZoQ1WxhsHw5FGF/ZOSASBWfOPopxVn3Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1838.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(346002)(396003)(136003)(376002)(366004)(8936002)(2906002)(66446008)(66556008)(64756008)(71200400001)(66946007)(55016002)(83380400001)(186003)(76116006)(66476007)(33656002)(9686003)(4326008)(8676002)(5660300002)(107886003)(7696005)(316002)(55236004)(478600001)(86362001)(26005)(6506007)(53546011)(52536014)(6916009)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 3oYE5mVs+Sb/qF1jax0yi4ToPbOFt/inom6NKQrKHrknjVPNtUBeah3WD+Fn9Sck4wxex49uo2JPjU7ZxO99kAykpyI0z/VqVOOQPuCvVY8cfhxGWDAzTp+lwd2VS/5AFiizeRyITkKFf+Gt4kYtNIvYoLxGzg/aLjXfRLdqszlzR2Ue1IVsGXRK2pRIUgEp/yZ7EZ/0NOKdD7ebZUmDB4J5sVCuwtxa03hHbMhsT0D7UHdtMHNxHGUOPbCO9XFn8CUKN5TAsN3RGgOnjDcPt+ga1SwJPcz5u85zxBD+rQHBDwIiz6XTgh6ofHqAh0s8q46Co7gs3hdt2ggaHhNztk+OY9bnPXmISethBrJwPHHzfu3KFqStRXeKy5ord/psH2jx3g5PeF5za33fF345MOSTjHt9tUGWvu1/6Ev0/yR6jrbVvCWQj5JIHxcfonZX1nj3oz7BoyGAs82K9F2uoOxevgTFKHqEBREjti9b55WMsB6leiGX3jvw2uB8gaKY2I6aSKVJnx48h8Gh+iZsr0Rbd4bg7CQeZOZqtmVkTH6C+XAIzYRwBh7SdRZsHSpCXjIxEz3ROc/qskWOg+dUChSaaamWx5XS57eT2bVrlBNMp1YZRln5hIKkLIpBF8kUI1vrseKwYV9OwMr0OkyxsA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1838.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76188931-b95e-4f82-0686-08d88016c5de X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2020 16:37:36.7954 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pIy+2cAqbsqIYWOo3HcU0PLgIM+WpXRr+8emORmBLxaNco46zFkEIoJchSPkBZV4BZdPjhdbnhx8xkhEoFdWz92d9SdMUg32gbabb0HX4x4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5044 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, November 3, 2020 9:34 PM > To: Gujjar, Abhinandan S > Cc: Akhil Goyal ; dev@dpdk.org; Doherty, Declan > ; Honnappa.Nagarahalli@arm.com; Ananyev, > Konstantin ; Hemant Agrawal > ; Vangati, Narender > ; jerinj@marvell.com; Mcnamara, John > ; david.marchand@redhat.com; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue > callback functions >=20 > 03/11/2020 08:44, Gujjar, Abhinandan S: > > From: Akhil Goyal > > > As I suggested 2 times that there are documentation issues. Haven't > > > seen a version To fix that. Please check it at your end and try > > > fixing the timing of your system so that CI Can pick it for compilati= on. > > > > As far as I remember, I have pulled in all the comments from you for th= e > previous patch. > > > > > > > I understand that we work in same time zone, getting feedback from > > > > you in the mid night will not help me/you to pull this patch in. > > > > A quick response will enable me to prepare patch set quickly and > > > > send it > > > across. > > > > > > I am not dedicatedly working on your patchset. I will work as per my > priorities. > > > > It is same for me. End of the day, we have mutually agreed to get this = feature > in. > > > > > Had it been a CI pass for compilation for both documentation and > > > code, it would have been applied last night. I could remove those > > > extra spaces, but there are other issues also as the newly added > > > APIs are not visible in html files generated. Please ensure that > > > there are no issues in doxygen build issues and should be able to see= the > newly added APIs in html guides. > > > > This is the kind of information I was looking for, which was not > > available in your previous patch. If this info had been available quick= ly, I > would have prepared next patchset. >=20 > It seems you didn't do all the checks you are required to do. > Please be kind with Akhil who is working hard for the community. > If you want to accelerate the process, help by reviewing other patches. >=20 I have done enough follow ups with Akhil and we both agreed to get this int= o RC2. I did not realize that CI did not pick up the patches because of mismatch w= ith my system time. All I am saying is giving this information would have helped me. > > Anyway, I will post the next patch set. >=20 > This is too late. > We are not supposed to add new API in -rc2, and for sure not after -rc2 > deadline. >=20 > > > > > > And please note, do not top post your comments. It becomes difficult > > > to read it in Archives. > > > > Ok >=20 > Yes please do not top post, use --in-reply-to to gather all versions in t= he same > thread, and fix the clock of your machine. Ok >=20 >=20