From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6BA70A04BB; Tue, 6 Oct 2020 12:30:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4BF351023; Tue, 6 Oct 2020 12:29:59 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id D3D12F64 for ; Tue, 6 Oct 2020 12:29:56 +0200 (CEST) IronPort-SDR: n552pvA3bQPuaEv5Jup5+IkPPyg+jgKomxOipcquFAWIIg1p3uuV6Ptw0zF7l2pFLkIGMN+t+X sbx1tgts/r5w== X-IronPort-AV: E=McAfee;i="6000,8403,9765"; a="152204193" X-IronPort-AV: E=Sophos;i="5.77,342,1596524400"; d="scan'208";a="152204193" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 03:29:54 -0700 IronPort-SDR: YsUQEMhEnU8pMf9yOILxN8GH0arcZf6JG24rJMbZQV/jd4WJU1JxoyTk2Fc8p/wc6+UkKAStQL McCtgXbWbKnA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,342,1596524400"; d="scan'208";a="296904935" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga007.fm.intel.com with ESMTP; 06 Oct 2020 03:29:54 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 6 Oct 2020 03:29:54 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 6 Oct 2020 03:29:54 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 6 Oct 2020 03:29:51 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 6 Oct 2020 03:29:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DVrV0ndTfpID2+YgwI01yEkH7xNSE1qoSYSMykKGR4G4QG+qE7XQOc7BsEg7mgRyopt0v3ld5xdmGNNk6HdZAqTRSYSiKpubWYVPPjKSHK35coQ/dBFhslKiPkFmYa+i98njdK60bC5cO8Wfj/eAkhjSCd4ozU+Ls8F9FKTpjl3FT+SH7wphjynO4dJOU9sh6Ib5JAlGK5JxVbeIgkAmIqH9e2cq7uJDCpNDvIiU58JFbEe5D+iGcl07DE78hI+9QuMTQflqgwikgISUbaJjQ+jdU/Vy+np2MS7VU7QBt1ERgwhOkWI/rYEnTIUtgZbMhY8FMZz/vFacVuaKHMEGEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mi/MmkREhlFiyGJicbyqRYQn7taXIXtT5ncfxVIVzOI=; b=n2bIr1Ii3aDCoritjAJ+Ys7Eq9i4hKTaTILACGWrk+a1jEB4prKttnkcYRlp8wi3gRnIV5FIwhw7kZY9renG3r+EqQIP15PZKYTtgAtnv+P52pIpBnA5GxFUKfFM83fV/0R4M0hWhU41iGstcER7e1ashw3hzF2fyJw2L6Z2+96ds1S4Sutm9rxFiKltDlQc7egQ+fJfRj7fF/M44ypHw+8GkchEZs7Lro1rWvTtpCjD4Qrp22ukHeBRPm+6FJN2vm2RkxwlP/L+HodPFy5SoxwejZfr4uUp6PGaMdMx5zYzVD2acdPWht/G4TcqBVZb4gHLpArczd0hl/pi5h3Ptg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mi/MmkREhlFiyGJicbyqRYQn7taXIXtT5ncfxVIVzOI=; b=Kb5EVZWXXk++3MQbptUwDJRq3FZQTZoZlPSz5IdsH8etSNINtJJTaP0A3IX/xFl2aTvRV8Si6K92maRVNzj5O19XZy/SBzDteidoBXTMkg3fS3/4FF9WQbhiZU46ZPd1oYrTusXRyt/eXx/abBruu0Ynm75y49CLTwgzGjR17PY= Received: from MWHPR11MB1838.namprd11.prod.outlook.com (2603:10b6:300:10c::11) by MW3PR11MB4715.namprd11.prod.outlook.com (2603:10b6:303:57::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.34; Tue, 6 Oct 2020 10:29:49 +0000 Received: from MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea]) by MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea%7]) with mapi id 15.20.3433.045; Tue, 6 Oct 2020 10:29:49 +0000 From: "Gujjar, Abhinandan S" To: Ankur Dwivedi , "dev@dpdk.org" CC: "jerinj@marvell.com" , "anoobj@marvell.com" Thread-Topic: [PATCH v2 3/3] test/event_crypto_adapter: free resources during exit Thread-Index: AQHWkw2fvO6333wDU0SoFqDOYux9lqmKbbBAgAACr3A= Date: Tue, 6 Oct 2020 10:29:49 +0000 Message-ID: References: <20200908091534.24305-1-adwivedi@marvell.com> <20200925072841.17578-1-adwivedi@marvell.com> <20200925072841.17578-4-adwivedi@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [103.5.135.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 311358c5-193e-4c90-ebca-08d869e2c0f5 x-ms-traffictypediagnostic: MW3PR11MB4715: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SiuE/xrYxMdtoV7N2iBCcHV2q2FLwySDhXF+Kz/TI5MHaomv7i2yHPsqlFpEgk+tESMJGeZcw98K1jv7iwGDkZ/3V+uSzH3WeqWgXK7CXFrFd+hWt1lrio+OZ3iSf28b24mRl8UnHTNseeOpUnQiNp3Yg/9q2eEsQavkT8G7+84nzoYvHtqLS8QK7+kwVcWRpev8bvWQitJkO/4QOFygU6kKVXseo/SspIkJvbxiMw/43Ac81H3nfMpL8cDKSxP68Y46u7pyJ/w9RtaHiawLQCE6Jsew/DxiF5tk3cgle9Aw/x5TJTCy6NVfkFCoxY6/e72ymVjv9FYn5c6rU25ZTA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1838.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(396003)(39860400002)(346002)(376002)(86362001)(4326008)(2940100002)(478600001)(2906002)(33656002)(55016002)(8936002)(9686003)(8676002)(110136005)(53546011)(316002)(66946007)(52536014)(66446008)(66556008)(64756008)(71200400001)(66476007)(76116006)(54906003)(5660300002)(7696005)(83380400001)(6506007)(26005)(55236004)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: COcm6wgbN7hLsa6Ki/vnadiSKDmie4gqGX6RMkku4OOfW/DLvkaslxdhN2EYYdUoKQ+wPSrK+nPlnihjRtuAolHRJP4EzrYL4yt8dq086kG2go3Qw5m/HArp5LLnw7gBMvkYzRRv8R003cQIhtLjljdbbclurFuBaHrsktB6/CgH/56Y2ZpcBZGncbSQUHw+nAMLIZX25ErPamgTUVKNmihrQayXspE7PDefcG8a8yCB9msoMCZXy/udem+wJVsIUIEtc2R2IJid4nI12bOaHC+ZgKbdDmkzuYy1Mgu9SXcYxZqOCSzCrr572FWN5IGc/f+ecQXjcOJ7IJyuP4uOPI4viFlHT/OLh63j4q+lgf34iHHtT1KQxGo6S1QfRSLXskll4HDnfZ9PcW2/YV45fkQCwPPZmhj6fkI+XjPznmQNOHEFMJvh8vEed/k3zbeCc0tYG5xOjo+BQwnktqbbNdDeBg+PT+vSUIk+8EZuRXWENSVo5ivtH/rREIqF9ShMJRcqufneg+QW/jCW1PcOZWpOoJmCkNFHn3h3mdOBngJW5sQ3wqmJ3AbxMMWykRvxC4dkoZf7PItRRCvD6SXiT+jm4D9wl5IeIOPtDrMNB+GbrXe3FawkCisfQBiAZrX/d+eQRhXNLFfa3QMVcKkbhA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1838.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 311358c5-193e-4c90-ebca-08d869e2c0f5 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2020 10:29:49.2693 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Mx0CecNs+jo9eRHOLfBuFMfe9DYRu0q6URhWySofPJ/dyOBXMJdgECUDHwuXcO9iQ8kzz6uRBLHHRat0TbaovzPYrNUqerk9qIucp8lxYTY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4715 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 3/3] test/event_crypto_adapter: free resources during exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Gujjar, Abhinandan S > Sent: Tuesday, October 6, 2020 3:52 PM > To: 'Ankur Dwivedi' ; dev@dpdk.org > Cc: jerinj@marvell.com; anoobj@marvell.com > Subject: RE: [PATCH v2 3/3] test/event_crypto_adapter: free resources > during exit >=20 > Hi Ankur, >=20 > Please see comment below. >=20 > > -----Original Message----- > > From: Ankur Dwivedi > > Sent: Friday, September 25, 2020 12:59 PM > > To: dev@dpdk.org > > Cc: Gujjar, Abhinandan S ; > > jerinj@marvell.com; anoobj@marvell.com; Ankur Dwivedi > > > > Subject: [PATCH v2 3/3] test/event_crypto_adapter: free resources > > during exit > > > > The resources held by crypto adapter should be freed when the test > > suite exits. > > > > Signed-off-by: Ankur Dwivedi > > --- > > app/test/test_event_crypto_adapter.c | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/app/test/test_event_crypto_adapter.c > > b/app/test/test_event_crypto_adapter.c > > index 572ef9c27..4b09ab3b7 100644 > > --- a/app/test/test_event_crypto_adapter.c > > +++ b/app/test/test_event_crypto_adapter.c > > @@ -899,6 +899,20 @@ testsuite_setup(void) > > return TEST_SUCCESS; > > } > > > > +static void > > +crypto_adapter_teardown(void) > > +{ > > + int ret; > > + Below APIs could return error. So, set this flag at the end? > > + crypto_adapter_setup_done =3D 0;=20 > Call rte_event_crypto_adapter_stop() here? > > + ret =3D > > rte_event_crypto_adapter_queue_pair_del(TEST_ADAPTER_ID, > > + TEST_CDEV_ID, TEST_CDEV_QP_ID); > > + if (ret < 0) > > + RTE_LOG(ERR, USER1, "Failed to delete queue pair!"); > > + > > + rte_event_crypto_adapter_free(TEST_ADAPTER_ID); > > +} > > + > > static void > > crypto_teardown(void) > > { > > @@ -941,6 +955,7 @@ eventdev_teardown(void) static void > > testsuite_teardown(void) > > { > > + crypto_adapter_teardown(); > > crypto_teardown(); > > eventdev_teardown(); > > } > > -- > > 2.28.0