From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B947A0521; Tue, 3 Nov 2020 06:51:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6231EBE43; Tue, 3 Nov 2020 06:51:00 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id CA19ABC62 for ; Tue, 3 Nov 2020 06:50:57 +0100 (CET) IronPort-SDR: i+NgPrERUHx+NnLoxW0lX4i2v4CPHn98Rk2Tyo4WLMgNLhmNhZe17fJuINurzez+aTojAKDE97 tNvL0EstxrUg== X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="253711959" X-IronPort-AV: E=Sophos;i="5.77,447,1596524400"; d="scan'208";a="253711959" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 21:50:55 -0800 IronPort-SDR: aW/heLRRyMEEeYB2VAZok1EZj3eh8yIe9psPQDBNETgnBpqtFtnkZOXcwOxRYy1m8bDzbdym0x qZJBVfD2jvMg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,447,1596524400"; d="scan'208";a="320312078" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga003.jf.intel.com with ESMTP; 02 Nov 2020 21:50:55 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 2 Nov 2020 21:50:55 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 2 Nov 2020 21:50:55 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 2 Nov 2020 21:50:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ezOa4jrWBVEyBmntDUUc/hxAdNd5JSW/mh3rV8WEJLazV2GqkN4K74XfvNgU442w+m2YXKRT6FXlaVIvj399T22OB0OWoswsmDGxT6LX4zVTa/8/g8RsNqoPacT8VOD/5JY8Yz8NDR+YavJm2oWaLEBOB115BmyexnOWxnxcIz84QWoytdz/10NgRINroKR/4c+D9Br/OwKxyqQ1pseX9NSbPUgm6nO3V7mfy5fxZaCNHc/XqVBcAxHbOGfDOWvEZHtxmCidGdgDm5QCsiPGKJrPEMm1fZ/qqEsGVe0zvNb+ZvfuDFzTNFvqzFjjxBPExjZ4tMfBUuAvNYk4+VLXhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LEpyGveg3J2ivOvWyoeaUjvyYinXiv1lJfY3XHEV+8s=; b=abu03Ut98ybrk+QjTnfHJU7vxTeYiGsjrImvKodMmRLHt6XEEu8CuEUMtMpX3Kmizfa7zw6D0TEDyDyb4uBu09bm9uHDywpZcBFKLjy9YZPXNicqlIVKcEc+/k5aePl59GqyaC1RGIDTUQXLzgPtK2WMOFL3f0i2aZhJd35Uh2gThE7Ohrr2Xv1/Y9n9l6UjIrtbX0PJLf2Z74dG83nD/M9ZBGdZj08BGlZqWtBRv10aVVZnYuaodHwqzU2aBKjRqdCP2CfStSNYLZ4s249MxPXvN9UiAjPUOCjaCOhRwd/T1hL8IgS5Zq1daciR2ViUxRqzkMWZAnysMmA1V3z6oA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LEpyGveg3J2ivOvWyoeaUjvyYinXiv1lJfY3XHEV+8s=; b=tkwskIH3HH9qsUkI8N+6oxUHnjI7kRKyvv1EAOEGC4FTWCcJ0cuixwfRTblBA2zkuYG85zqzrds0RSXyKWG3VJAZJHb81EkiSpoFPLOSozlLsmKoPMduZeegY4vNL0dJrKsAmy1akoyjpXjtnO3Bxs3s5ZhizUaNxvDGuXbgRoI= Received: from MWHPR11MB1838.namprd11.prod.outlook.com (2603:10b6:300:10c::11) by MW3PR11MB4636.namprd11.prod.outlook.com (2603:10b6:303:5a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.27; Tue, 3 Nov 2020 05:50:51 +0000 Received: from MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea]) by MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea%7]) with mapi id 15.20.3499.029; Tue, 3 Nov 2020 05:50:50 +0000 From: "Gujjar, Abhinandan S" To: Akhil Goyal , "dev@dpdk.org" , "Doherty, Declan" , "Honnappa.Nagarahalli@arm.com" , "Ananyev, Konstantin" , Hemant Agrawal CC: "Vangati, Narender" , "jerinj@marvell.com" Thread-Topic: [v6 1/2] cryptodev: support enqueue & dequeue callback functions Thread-Index: AQHWrpUcu4l0aZzUeUWHkBKE9uoPCKmwd9qAgAABNjCABCEKsIAAnOCAgAC0hfA= Date: Tue, 3 Nov 2020 05:50:49 +0000 Message-ID: References: <1603926611-19086-1-git-send-email-abhinandan.gujjar@intel.com> <1603926611-19086-2-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [103.5.135.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 697266a8-377e-4d92-4318-08d87fbc6b1e x-ms-traffictypediagnostic: MW3PR11MB4636: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eJwpSLHe42BYHalB+DuR2XxujC4gw9zNuApAzoHVZrkl6HrIeYcnKn68oPeo86yGQMmtpaI3QEjT5Bt2K1xAQBUoZ8D/1N56br9rIvhV/GeoNGEcSZM6TDgpKiKr5B2OpvPUPha7oQWZmqxJvI2lz4B/Zv5uAh+C9PrOSFRY3HZI1c50mb4362bLqLK4x8goh5QvXRxTxXF1xAZG4hgQopnOIaQbpNuRYCFqrp01EPqgPkTTe6qeeovVRpQveAUPHq8geGXr/rIjH+geXMo5Ptxp+622KmFYSYvc3Vr2jCq6r6abINrT4Hv9L8XUDOVYxt1StILrdbj4LLYr3N/GXg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1838.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(376002)(366004)(396003)(346002)(33656002)(54906003)(478600001)(52536014)(6506007)(5660300002)(55236004)(86362001)(186003)(66446008)(64756008)(66556008)(66476007)(66946007)(83380400001)(316002)(7696005)(9686003)(26005)(2906002)(76116006)(55016002)(53546011)(4326008)(110136005)(8676002)(71200400001)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: F0Q0sR+urPgm4/15sHlWo1T+0ByHybQFd2y+2o730CLIr+B9x2mZOV7mvek62EIf5FWD4P3XGNQj/RHbNQ5a/vdu7+tPL9UrywnL9MVVhfvBEtAGgAlKCuDOSFm8YnkuV91SIGjCd1C1Y5FkPnpY1toTAKyw9Xj5nhZRd2kgIy7Hu+NVfq10oMzIUxyfsDb3fjwGhz537Fi8jy5YKZ2N6mdwHMbyY5/aqS+/bgQehX9XPxKDHnCm2sHDsPB95tvH+7edQSIosBZ6nUTqBgn+dy2zZiFGRwNVLQK8KpKCTeAE0cOPSdWk1BP/CCL6eYQ5BvKVjvkNWe3nZFFtQUMbU0sb9qC3Or7TwoRLkXcwL/MOvIiiGOHES2sXPzOzDOF6u/QHp1tCPM0RXgO+DHH8ndy7sEtHDOWmqZzRsvqtVQi2bxH/A5xK956PEUtVw+LeVzszIs9w3A5lx9YS+1MUljrWZtoX+wLTspk9wXCGepMhGzhtiMGijwzrDel01bO8mK6BAeWsuRHqBOjX0qerY755q4yCAEvT7MGWtFhVzF6M/7I9YLib6KZFdNuD/PalliaRWZssb4OUgsXcf60TTV+x2JI/vIi6cZgZbSJkuqqJHVJSf0fO3WJIACHnu+nDJMZb8vSWDT68xJsmZpRfXQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1838.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 697266a8-377e-4d92-4318-08d87fbc6b1e X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2020 05:50:49.9420 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pBbvjxmTel7HsuUJZRo3QfvyRHY1NIN1ak/lZ3DeyuSbA1Te6lSlAmAlrAjwdZEe0nFNvlYfU7pH024Ac9+HTAiapsiG2i9mo04AFzGlBJw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4636 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, Can you please go through the patch again and check if any more comments? I understand that we work in same time zone, getting feedback from you in t= he mid night will not help me/you to pull this patch in. A quick response will enable me to prepare patch set quickly and send it ac= ross. This time, I will prepare the patch along with dequeue test case. Hope you understand the concern. Thanks.. Regards Abhinandan =20 > -----Original Message----- > From: Akhil Goyal > Sent: Tuesday, November 3, 2020 12:28 AM > To: Gujjar, Abhinandan S ; dev@dpdk.org; > Doherty, Declan ; > Honnappa.Nagarahalli@arm.com; Ananyev, Konstantin > ; Hemant Agrawal > > Cc: Vangati, Narender ; jerinj@marvell.com > Subject: RE: [v6 1/2] cryptodev: support enqueue & dequeue callback funct= ions >=20 > Hi Abhinandan, >=20 > > Hi Akhil, > > > > What is the status of this patch? Is it pulled into RC2? > > > > > As I suggested below, please fix your date and let the CI pick your patch= es for > build. > In my local build for documentation, the newly added APIs are not added i= n the > Documentation. Please fix doxygen issues as soon as possible. > Did you try building documentation at your end? >=20 > Regards, > Akhil >=20 > > > > > > Regarding the date, I am not sure how it can be fixed now. > > > May be the space is missed out as well. Could be please help? > > > > > > > > > > > > +struct rte_cryptodev_cb { > > > > > + struct rte_cryptodev_cb *next; > > > > > + /** < Pointer to next callback */ > > > > > + rte_cryptodev_callback_fn fn; > > > > > + /** < Pointer to callback function */ > > > > > + void *arg; > > > > > + /** < Pointer to argument */ > > > > > +}; > > > > > + > > > > > +/** > > > > > + * @internal > > > > > + * Structure used to hold information about the RCU for a queue = pair. > > > > > + */ > > > > > +struct rte_cryptodev_cb_rcu { > > > > > + struct rte_cryptodev_cb *next; > > > > > + /** < Pointer to next callback */ > > > > > + struct rte_rcu_qsbr *qsbr; > > > > > + /** < RCU QSBR variable per queue pair */ }; #endif > > > > There is an extra space in each of the comments above between * and= <. > > > > Check other doxygen errors if any. > > > > > > > > I believe the timestamp in your system is not correct, as the > > > > patchwork show Date of 2 days back while the patches are sent today= . > > > > Could you please check? I believe CI server is not picking your > > > > patches for auto build. > > > > Please correct it so that auto build can happen. None of your > > > > version was picked by CI.