From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FB32A04BB; Tue, 6 Oct 2020 12:21:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A953F64; Tue, 6 Oct 2020 12:21:53 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 7957EF3E for ; Tue, 6 Oct 2020 12:21:51 +0200 (CEST) IronPort-SDR: ymzns5cKednbOLBTi+jGOHz4rx8YTQuGu48rlX7eFVZpQLpdKHZGFlmQni7azW767fsR01Epnt BUnS+lh04vtg== X-IronPort-AV: E=McAfee;i="6000,8403,9765"; a="143828086" X-IronPort-AV: E=Sophos;i="5.77,342,1596524400"; d="scan'208";a="143828086" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 03:21:47 -0700 IronPort-SDR: 7Cohdpx83bb0ZhJYlvz9CKee3RGDNoHG1H9rFuxuQXI7PeAmLClQR0PitlX02r88jkaY4uXvwG LBVLAe/Yqkrg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,342,1596524400"; d="scan'208";a="353416280" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by FMSMGA003.fm.intel.com with ESMTP; 06 Oct 2020 03:21:47 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 6 Oct 2020 03:21:47 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 6 Oct 2020 03:21:47 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 6 Oct 2020 03:21:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Orq0XiOKPO6KcGxFcW8WKF/cY5bXuk8na2APeMLFu0IWWyficatwSRsOV7MEq62lMyglHLuufZ9Kd34SeN4/7ouem/q0TpML2AtrLbdp2hX5b8reC3vLO9Z8n7Mr6Licd3xnzAj43NRoKXK/LRXJiNQsJ1Y0Cz9nHvJ1LBHdM80XvJyyDKr0H+yjfEPnio+SsmGXrPROyFOLCzmitvPJwx/1apPxuw3nz2VlP/zMrztDHmTBUTxjDtEgRbILVSbYVTPOsS2/MwNKAooejH4sGKN3UmwzpIoG0su6jrLpO4DjeMwFH+hQCvlILwJJbJV4l1cmc0yzhi3P0xNgMVUf6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SCN74k37ch1rFJIhMqX9VGQkbt2AaiSSTnLY5KcTYVY=; b=glwShwSlONEVLak9IfQKj9VJe1oELpGJoZfu7WR7bJERwOUGi0UMi5VgXucaSD/OF2tVgqicu4TYGpbR6LqoOKdOkLcnAoGa+f/BFtC/FPUSD5xpmYirTrqgRKNAMxyGLop/lGpdctBzirAYQ12kn++2NzmJZ62JycHjoXVlsA28i1SU6mz0IMLnNLgpA9WsHWA8GlgjQ8hdnYzeysVO91uJQCu/1hqF3zbiRsDmpM2oNXMs407CfC4Xtbeb6bYN9CiRgj5uJ/uNmbCwqwxd6Pw7jaMRzYt8A2sDJNU5DWrzF5/ULyaOTZlbNEuYb+3hlLDkQHSitM4wKoATGaTDhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SCN74k37ch1rFJIhMqX9VGQkbt2AaiSSTnLY5KcTYVY=; b=fq0op4jl6ovpAxu+gLsNGlWNSeQGubjqpAnwMO136VRTTiCj3CmpZAgUPsSHntExplhoEdyX013qvzl1VioZGNI4x9S9QFQCZ8dclWTrgHJUckpkt6qEBLpEYl1v42Db/PpG1WLwsxVK7CiDB2quN+Jhc7/8s4fcBAwzbAH6LbI= Received: from MWHPR11MB1838.namprd11.prod.outlook.com (2603:10b6:300:10c::11) by MWHPR11MB0031.namprd11.prod.outlook.com (2603:10b6:301:69::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.28; Tue, 6 Oct 2020 10:21:46 +0000 Received: from MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea]) by MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea%7]) with mapi id 15.20.3433.045; Tue, 6 Oct 2020 10:21:46 +0000 From: "Gujjar, Abhinandan S" To: Ankur Dwivedi , "dev@dpdk.org" CC: "jerinj@marvell.com" , "anoobj@marvell.com" Thread-Topic: [PATCH v2 2/3] test/event_crypto_adapter: fix function arguments Thread-Index: AQHWkw2aZHwd5XwjFU61L2d4CL4fm6mKbg3g Date: Tue, 6 Oct 2020 10:21:45 +0000 Message-ID: References: <20200908091534.24305-1-adwivedi@marvell.com> <20200925072841.17578-1-adwivedi@marvell.com> <20200925072841.17578-3-adwivedi@marvell.com> In-Reply-To: <20200925072841.17578-3-adwivedi@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [103.5.135.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2f964ff4-fc6e-4a7a-c3f9-08d869e1a11c x-ms-traffictypediagnostic: MWHPR11MB0031: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: M/rJb7hY5zwwdh0N9nsSqsu8aRoFTTLvgHMD6OCSLiTZZsu6gMgIx4zHKGRN4zitA2Kca4hkIMwYMGpY8ksZUBQU+1mq3D7GM3BD/JimHTyLPwXbWGHSIBZBms4anUL8x5UayJqikrBM0ynNERvXwxPzMF+vm8whymW6Q3c6CaZOvz6VVwjvbXjIqYOKVyB/5J8I4VkkAMlIrWSlonYkBZ1gJm/DmwHN670C+WiaaQ7BPAS/S2ZMYVGd1Ic+YaZpcBO9q0lubCCv1+bNhvaEpttCtJIrDnya9oQOb755T9etlJDlp3fCOmg7LibaIn8B x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1838.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(396003)(376002)(366004)(136003)(39860400002)(52536014)(2906002)(83380400001)(4326008)(478600001)(5660300002)(8936002)(8676002)(66446008)(64756008)(66556008)(66476007)(86362001)(33656002)(316002)(7696005)(71200400001)(66946007)(76116006)(6506007)(55236004)(53546011)(9686003)(55016002)(26005)(186003)(110136005)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 3xhKvLueqWYJ5s/eNp7YYaM2vk9Hkbl3rv7kdaEOUl4r4iC8fQZs9Eg8/NF+TpN2ClB3/u445fXJNW0dkJ2M7ZxBPoyxW/OxfGiT7X/WA4SUiZTmS0fsL6MiZVCEXufbG5eOQZwJ3Z/Y9DxtsLpVDnwdqTbUJ2eKvZJbn62HTj8HntK/MITFq+d1si5eVQcWjkcW/BrB0A0b8YZnwGa0b3Lw6Q8/N5iqXGw7g52+PP+CH+OjBhfmqH+GQOB83Vofa3wPJy3m4IFAlW9doMUUl9acXtghxrO61UURSg3SQSEjdrzQUFHzKlGoqeBrNHtMmHoWn+kQ/1i5uPb6gDaPFaLgas4aECEycEO1XUJYvgM9zc4PswlTXsgzMU0b7wKYBEHhcIRCCemEFUHWWuAkPraZf9wd1w3/zzO+oaxS2BASWfvzSi+iQAmenRUP2thCkrKG3xc6/qDO4hxvK+MPVdUKu3ZxA1Vzx/2Eq7k9jl3s0BTgt+5KddVWmBQkrPUTseuBjow9byrYJ6iuOUvFTFucqXPiDxhTUt8c2dINAXBJ9QTdzYfoACUjAyLtAxppNdccvl89YevcbKOco0wQjfbzEw12MOhJiMMge1uMgga9Si6psYL0W/QuMztbCoantTwjvsL0QSzxzcK93hwcEg== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1838.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f964ff4-fc6e-4a7a-c3f9-08d869e1a11c X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2020 10:21:46.0911 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TXaALRyC6+mv6nyTi9JHXPjczU/LJXeEonklhQqFHrDHPjNMp9SkkDArVRIrWOOuuKcuciIXYWEnM/Upw45lv1EQHW6uPcPAShJGpLrNDys= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0031 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 2/3] test/event_crypto_adapter: fix function arguments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ankur, Overall, it looks good.=20 You have missed out fixing caps args in one place line #299 of test_session= less_with_op_forward_mode(). > -----Original Message----- > From: Ankur Dwivedi > Sent: Friday, September 25, 2020 12:59 PM > To: dev@dpdk.org > Cc: Gujjar, Abhinandan S ; > jerinj@marvell.com; anoobj@marvell.com; Ankur Dwivedi > > Subject: [PATCH v2 2/3] test/event_crypto_adapter: fix function arguments >=20 > The arguments passed to rte_event_crypto_adapter_caps_get() and > rte_event_crypto_adapter_create() are incorrect. >=20 > In the rte_event_crypto_adapter_caps_get(), event device id should be the > first argument and cryptodev id should be the second argument. > In the rte_event_crypto_adapter_create(), the event device id should be > the second argument. >=20 > Signed-off-by: Ankur Dwivedi > --- > app/test/test_event_crypto_adapter.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) >=20 > diff --git a/app/test/test_event_crypto_adapter.c > b/app/test/test_event_crypto_adapter.c > index 3c64742b3..572ef9c27 100644 > --- a/app/test/test_event_crypto_adapter.c > +++ b/app/test/test_event_crypto_adapter.c > @@ -209,8 +209,8 @@ test_op_forward_mode(uint8_t session_less) > &cipher_xform, > params.session_priv_mpool); > TEST_ASSERT_SUCCESS(ret, "Failed to init session\n"); >=20 > - ret =3D > rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, > - evdev, &cap); > + ret =3D rte_event_crypto_adapter_caps_get(evdev, > TEST_CDEV_ID, > + &cap); > TEST_ASSERT_SUCCESS(ret, "Failed to get adapter > capabilities\n"); >=20 > if (cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_SESSION_PRIVATE_DATA) { @@ -321,7 > +321,7 @@ test_session_with_op_forward_mode(void) > uint32_t cap; > int ret; >=20 > - ret =3D rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, > evdev, &cap); > + ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, > &cap); > TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); >=20 > if (!(cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && @@ - > 410,8 +410,8 @@ test_op_new_mode(uint8_t session_less) > params.session_mpool); > TEST_ASSERT_NOT_NULL(sess, "Session creation failed\n"); >=20 > - ret =3D > rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, > - evdev, &cap); > + ret =3D rte_event_crypto_adapter_caps_get(evdev, > TEST_CDEV_ID, > + &cap); > TEST_ASSERT_SUCCESS(ret, "Failed to get adapter > capabilities\n"); >=20 > if (cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_SESSION_PRIVATE_DATA) { @@ -460,7 > +460,7 @@ test_sessionless_with_op_new_mode(void) > uint32_t cap; > int ret; >=20 > - ret =3D rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, > evdev, &cap); > + ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, > &cap); > TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); >=20 > if (!(cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && @@ - > 486,7 +486,7 @@ test_session_with_op_new_mode(void) > uint32_t cap; > int ret; >=20 > - ret =3D rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, > evdev, &cap); > + ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, > &cap); > TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); >=20 > if (!(cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && @@ - > 706,7 +706,7 @@ test_crypto_adapter_create(void) >=20 > /* Create adapter with default port creation callback */ > ret =3D rte_event_crypto_adapter_create(TEST_ADAPTER_ID, > - TEST_CDEV_ID, > + evdev, > &conf, 0); > TEST_ASSERT_SUCCESS(ret, "Failed to create event crypto > adapter\n"); >=20 > @@ -719,7 +719,7 @@ test_crypto_adapter_qp_add_del(void) > uint32_t cap; > int ret; >=20 > - ret =3D rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, > evdev, &cap); > + ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, > &cap); > TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); >=20 > if (cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) { > -- > 2.28.0