From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7797CA0521; Tue, 3 Nov 2020 18:03:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D5FCB5947; Tue, 3 Nov 2020 18:03:49 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id BA390592C for ; Tue, 3 Nov 2020 18:03:46 +0100 (CET) IronPort-SDR: iNEgfEIkXKXbV6pdh5TZbM7hVX9WM+ryqSm3kchmoLyNP1VWAhAooHKHdn4p01YDjqGPWrPPzY nNquI80kUTXg== X-IronPort-AV: E=McAfee;i="6000,8403,9794"; a="165585540" X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="165585540" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 09:03:44 -0800 IronPort-SDR: gygB25CMWsFPDlFKGg57prO8TLLvZUJUsOYtju0FQHwdQEIMMnoTG7+Se+TvvP8Epqm0xSoKuU KmTa6YT+WTLg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="470869591" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP; 03 Nov 2020 09:03:43 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 3 Nov 2020 09:03:43 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 3 Nov 2020 09:03:43 -0800 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.57) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 3 Nov 2020 09:03:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AgHM01Va/D6w7gnn0xI5cHUuuEY3NdQX+jmqKvm1VBh0LfIOHT/Jb0meXV6I+Nb5Tdlr+iI7PpKroci5qd9+dYOoir12SYiGvGnE25KGftxrILM5Pu+c66gDXb5kp6LHm9BG3KyO9DMw8xlPZUdVxpwM8OCgRaVXC9YBY0I5J6Zjk7N0CrDjtwDBtYxPIl4bBOOwQksAhcrnp0ivQGNcx29hGpOdTuPf5BLmsSBGPJhpg0wJU77ilVIYS0VicAqmIt2rstql6vM7rYCpr0AGiiGpHxCzDe8bKi+3bEC8BXTSBE8tOpRmQEi3gG7k7MI6DLiJ7szWXHW4LTuP3v3zpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MfKDVv6OEsVyaveHWLVsDYGDAW01U7M2R0Snnjw96ww=; b=NK+H9nPqIhnlvNkErNf/hUwXO5Oe23F6Ysyr23y5ReRshJcjTR+oPs35WHk8bEzyCaEdmZr4LQ2XQeuE2DYo0p4p+IiREqS+/EYaflpa0EbWHdCBmzsO1f7H29VOU6e2PmL/ztfSdX7gm/imSBQRg+OJE9wWzBs/ldZOMzJ2098jeDuSjO48VNGdyI+Hk+eR2DQ22dHcKemGsUBumdtHJqI73guRcXC2CAyG2KvyJJnhwUT56UlJQvd91NuWAI0cgEWp/SSypQkNBLLTWX1c34BP0yiEtg+YOObOTnSMG25MHj6Xp7HVIhIEw6DuvgCdP5XABuZb79kS3kjBMPC6rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MfKDVv6OEsVyaveHWLVsDYGDAW01U7M2R0Snnjw96ww=; b=AJ0gqvpGhiYhFlWNwTZWpJSpzWGGbOlgpHNyv6hqAk1YQQ3FEPeP69A/5rlqq/pRk9EF/Umz+6DuL9EO6aRtqsnT0Ycv1MNxQIvA/YcB18dp6/IesfhyDO3ZifAKV7qjV9G4m52CqgnCjOJQ1IPQofNxPuE3MVtol7lFb6Z807g= Received: from MWHPR11MB1838.namprd11.prod.outlook.com (2603:10b6:300:10c::11) by MWHPR11MB1661.namprd11.prod.outlook.com (2603:10b6:301:b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.28; Tue, 3 Nov 2020 17:03:11 +0000 Received: from MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea]) by MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea%7]) with mapi id 15.20.3499.029; Tue, 3 Nov 2020 17:03:11 +0000 From: "Gujjar, Abhinandan S" To: Akhil Goyal , Thomas Monjalon CC: "dev@dpdk.org" , "Doherty, Declan" , "Honnappa.Nagarahalli@arm.com" , "Ananyev, Konstantin" , Hemant Agrawal , "Vangati, Narender" , "jerinj@marvell.com" , "Mcnamara, John" , "david.marchand@redhat.com" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue callback functions Thread-Index: AQHWrpUcu4l0aZzUeUWHkBKE9uoPCKmwd9qAgAABNjCABCEKsIAAnOCAgAC0hfCAAAxYAIAAElNwgACOj4CAAAeOUIAABikAgAACjMA= Date: Tue, 3 Nov 2020 17:03:10 +0000 Message-ID: References: <1603926611-19086-1-git-send-email-abhinandan.gujjar@intel.com> <1882047.WhnCstt3cK@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [103.5.135.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 83c08549-8733-469b-90b4-08d8801a584c x-ms-traffictypediagnostic: MWHPR11MB1661: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pyU/DdR1uvKzqRv6AqkEevRvATmMAa3MN28oYAZxoVJC0x4G4z5t306vY1NqD5t4UOx2cgsUgDDXDE/VYqckoLt8XvIIPPQkJQqh/gxAkfa04eakeVtQIJSsbLDfB4sKvxOtboDbJW+1RZ1u7URSgHzYxtAqZam+pvb1GYAa6qLyVLG/fLSIdHELVcRT8JRftxY2FQFSMgbiZhq8cSlojeisC2JdQroNaVl6hKCTNRVOy+Gm07fKiSm6sNqMpTlE+MXFl7nkuCzYfInUD+sRO0oo4y1V8/0fRBQQ8mhNI9ia5yuA9p6AfzQ37sqeBaLFqG2mRqoI8VxZy83xyp9RiQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1838.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(346002)(376002)(396003)(366004)(316002)(107886003)(86362001)(8676002)(4326008)(2906002)(8936002)(478600001)(110136005)(54906003)(9686003)(76116006)(5660300002)(26005)(55016002)(53546011)(66556008)(71200400001)(64756008)(66946007)(66476007)(83380400001)(55236004)(186003)(52536014)(33656002)(7696005)(6506007)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 5aRNZhCbaqG2Xw1qWbwFDYVKrGhPiG+RwTmMlm63QjVvFyik/ZkBot4ykP8Nobxab147qAuJCs1A0hJta8xoyTgqfaP5yKidY9L7xL3IDvbzZxHQ4Xabl3DDAkJYeVbvM71lrV5OXeuAzAI0fokMh/+N2duJn5PoaoheEAoJmPDB3Lj62gnIEoMW3ko1AXOt+OClNeOSeEOMSm+1E9RtHWGn62WS1uTrUQk1xfdg/NxMHCz3885iOJ3CfGHrf1IhFyopIh5gilbAqMomwGCgNOj84/QC7CzSEZ6CQXO3mOI9YNUexI5nK5HBa5qoJBF4Rp+tsX+20I/1W/hTXyhMhkvx87GnNCCZblTYRa+LR/x3juBhrYr7oGNdgbL9rfIo1Sh3COqfFwPNjzxEDrmEqeC4HP1GbBIyhIk0ydE/1aiotiJ4ZYyiqVHXnwVGlCREy7Wf0utLK/M5BAol56wYc0XLEZsFIBeoO/35bSC0v3jdw9Rv4SuYdJG9UZSqcQEgLaPWRyZgda2sfOmfffcmOD8szde38fM8DdVkP+Ey7y0rmIM4BYQIWjOCcTUCX610+mFNwKjqtos+3nJS4vZfnNPhadI1+Gibt7Dv2QOFOiE85e+Y8/DEz0YmvfiXe+UzlTQip8Ji7/slKJ4rphaBHQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1838.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 83c08549-8733-469b-90b4-08d8801a584c X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2020 17:03:11.0003 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xsfcmvknV4Vq0ADUtGr2s8mNAWHi4wpAFuCsDJhwHImslTn1jKcyb7rl91hTXon2BqBy4I+m+lOh+blGPSxay7FRS8c0HWNRqkoWX07lk6I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1661 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, > -----Original Message----- > From: Akhil Goyal > Sent: Tuesday, November 3, 2020 10:23 PM > To: Gujjar, Abhinandan S ; Thomas Monjalon > > Cc: dev@dpdk.org; Doherty, Declan ; > Honnappa.Nagarahalli@arm.com; Ananyev, Konstantin > ; Hemant Agrawal > ; Vangati, Narender > ; jerinj@marvell.com; Mcnamara, John > ; david.marchand@redhat.com; Yigit, Ferruh > > Subject: RE: [dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue > callback functions >=20 > Hi Abhinandan, > > > > Hi Thomas, > > > > > > > > 03/11/2020 08:44, Gujjar, Abhinandan S: > > > > From: Akhil Goyal > > > > > As I suggested 2 times that there are documentation issues. > > > > > Haven't seen a version To fix that. Please check it at your end > > > > > and try fixing the timing of your system so that CI Can pick it f= or > compilation. > > > > > > > > As far as I remember, I have pulled in all the comments from you > > > > for the > > > previous patch. > > > > > > > > > > > I understand that we work in same time zone, getting feedback > > > > > > from you in the mid night will not help me/you to pull this pat= ch in. > > > > > > A quick response will enable me to prepare patch set quickly > > > > > > and send it > > > > > across. > > > > > > > > > > I am not dedicatedly working on your patchset. I will work as > > > > > per my > > > priorities. > > > > > > > > It is same for me. End of the day, we have mutually agreed to get > > > > this > > feature > > > in. > > > > > > > > > Had it been a CI pass for compilation for both documentation and > > > > > code, it would have been applied last night. I could remove > > > > > those extra spaces, but there are other issues also as the newly > > > > > added APIs are not visible in html files generated. Please > > > > > ensure that there are no issues in doxygen build issues and > > > > > should be able to see the > > > newly added APIs in html guides. > > > > > > > > This is the kind of information I was looking for, which was not > > > > available in your previous patch. If this info had been available > > > > quickly, I > > > would have prepared next patchset. > > > > > > It seems you didn't do all the checks you are required to do. > > > Please be kind with Akhil who is working hard for the community. > > > If you want to accelerate the process, help by reviewing other patche= s. > > > > > I have done enough follow ups with Akhil and we both agreed to get > > this into RC2. > > I did not realize that CI did not pick up the patches because of > > mismatch with my system time. > > All I am saying is giving this information would have helped me. >=20 > I highlighted the documentation issue and the system timing on Friday its= elf. > When the fix was not there on Monday, I tried to fix on my side which too= k me > late To comment back. Had it been done by CI, it would have been faster. What is the next step? >=20 > > > > > > Anyway, I will post the next patch set. > > > > > > This is too late. > > > We are not supposed to add new API in -rc2, and for sure not after > > > -rc2 deadline. > > > > > > > > > > > > > And please note, do not top post your comments. It becomes > > > > > difficult to read it in Archives. > > > > > > > > Ok > > > > > > Yes please do not top post, use --in-reply-to to gather all versions > > > in the same thread, and fix the clock of your machine. > > Ok > > > > > >