From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67F1CA0540; Thu, 7 Jul 2022 08:54:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 14D2640A7B; Thu, 7 Jul 2022 08:54:59 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id AEF57406B4 for ; Thu, 7 Jul 2022 08:54:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657176897; x=1688712897; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2QBnR3mIOSwSBiFm7YciV/MtfxIJ1xz0as0Tne1FKCI=; b=YZSHDLDN20uhiBnzMagPjaTaC5Jd1TeIdM9unJBmegIQA9/v9UUJgN/8 HrNgSWYNBhWIXgXVckrjJVKBEryS5KJdPgRI+U9wzUAmQZHNttQR7v7Ti kUimKk+W0p4YPFB+fkWTPUZ6Ycz8WaE/J5/aLhgKaB/ve+TRwOJ9c6dyV HBnZl/z1m0hlwXpXlBr9Mldu1/2E3RlSQcV2Qph3yNQabWfCqdnxi2Iev VF66ORzRopz/db9msfxCwCZTIJYeBR8XDnIF5AkmnzokhbXCOhG7b0und yuRQWv/HtC1bKK2vPSsTGULqueRMmkhQz3D7QO37FXUEMT7yJQdzEqLfh g==; X-IronPort-AV: E=McAfee;i="6400,9594,10400"; a="282700285" X-IronPort-AV: E=Sophos;i="5.92,252,1650956400"; d="scan'208";a="282700285" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2022 23:54:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,252,1650956400"; d="scan'208";a="920478446" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga005.fm.intel.com with ESMTP; 06 Jul 2022 23:54:56 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 6 Jul 2022 23:54:56 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 6 Jul 2022 23:54:55 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 6 Jul 2022 23:54:55 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 6 Jul 2022 23:54:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jZay5yMANXVS5obs4pWcJwSotM/BvNamGAOsLIv7t2WGkl4I1Aun/L9+EcXWeArIMTxfwRzWYcUMiZyqHAnwzqS/FlAHhIsJ26l2ntSWx+q5JPx+UxWcNghZFIsq65Sl0lyEJMX1MQj7EvkmR57buvV6HLMqQ5WD97pZMmArS4hkwj+VGfmLgAeFhT4I8EAIkFHjlttnUk9GAwAsZyQKlQLt63zBYoA86mm8fyYszAbvP3lm8wef04alr0Gnman0seDEhn5M4N469ymu5PsumqUhDU2vOecDMeSCrc4pEOp62bOoE4cdUTErmVSDWJNcn3a/dSoTZLRPS1NYxXzKJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=srzjXsv+wES8i3oG6J6Bo9w8yFLCAZvgVUk3LRZlcYs=; b=Im3JpVQLyaF8aPcHZJaCJGSYhavQQHKH0n3SYB32e9UNB20pgX/PElnakl0muzDId8M4f/uhCehF8PJ4idMvl8XazzBCoPteDsNL+nGxL5wAqP05qQQUL7xDKixtqUy6tArpIS3HA8lVF+wlOBlMTW9B8s/MSCfT6pYh6d4k4gcT6MfaJnD4ClXRttx5/SheyW/n5KNMqjFg4/m7JPk98vkmHb9tlkoPZOgOtbFTFjgi2UuLgJc5/Mxao5a8l1gHSC/UDjcNHpSr55O1I1Cb/7li1ZXzqPKFYJm7mlwp2yiimyYoC+AaLcXeLVGrQ3sNiyiGqWatMKtDHzAuJ8rHuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1886.namprd11.prod.outlook.com (2603:10b6:300:110::9) by CY4PR11MB1640.namprd11.prod.outlook.com (2603:10b6:910:8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Thu, 7 Jul 2022 06:54:53 +0000 Received: from MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::14e0:4dae:c8f5:3146]) by MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::14e0:4dae:c8f5:3146%9]) with mapi id 15.20.5395.022; Thu, 7 Jul 2022 06:54:53 +0000 From: "Yang, Qiming" To: "Liu, KevinX" , "dev@dpdk.org" CC: "Xing, Beilei" , "Zhang, Yuying" , "Yang, SteveX" , "Liu, KevinX" Subject: RE: [PATCH] net/i40e: restore disable double VLAN by default Thread-Topic: [PATCH] net/i40e: restore disable double VLAN by default Thread-Index: AQHYkaxFeGX27Y0oTEaOACA3EMQMOq1yd7dg Date: Thu, 7 Jul 2022 06:54:53 +0000 Message-ID: References: <20220707104732.1816933-1-kevinx.liu@intel.com> In-Reply-To: <20220707104732.1816933-1-kevinx.liu@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ee067d3b-0f37-4564-6bd6-08da5fe5982d x-ms-traffictypediagnostic: CY4PR11MB1640:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UQK0yyJz6lLmN/mtWxi9mV/0QVSdqFE/A2ZvEj0xb22AWBaalm1h1rjKZ78pzJvoT66N+/Edmemy8lLXK9bN05rh1J62D++yMsHAR4jDUe6sedNLRNYDf3ZDEyoDOWerdIP3xzcNFQKTy7iF0Fl2odLCOt4heulj0+Cy3doGH3apxQDZMIdPS3kFnVSiDOT0k6nDgIfZx4qTsvuJiiOpwrASSqF/bVgNqFXDoQAryMi5vBOwnC+fv/D+n+qr4+KTEUYkEK+TrjpWYUCdTjdhaHkPyShM3LHfklrUijTkp9Ed+aK4V2z8amgi5WFyTtglpu0OyA0G9mRN4pzAMI9KSeUSN0x4ZvWdmbJ1NZFgo3OjcH9wNLvH9KAykseb3v6uJVe15HrU8wuH0x30UfqNPUw4RLWdwj/QQsbCXDjNxdXw5Zes/JOquQdDanaVyjwtBwP8dfhMxcGFTAZnztfre1fl08gm0tCuhJpHCfmlL82xYML5Ib1T3zMM6mZfsYabJoFa0MgkqmYjPQLACdfSCtZC9UHokuIS9tccDHDnJtK+HqGEKhcmwflW5sU4GsE61Tr8dbPRvoeyDq4ubZr1kELAIt6+27ns1xcoRYEOV8HUVR8SJporEtb/r0L/fPJen2i4sMYoPHmZXQJ3JSsP699jYgX9SMrDVOp/vZssrJEUev+o31lZ8PfJQ4VDKKoiR4nGAiDZYOsZyuycZxZ/kLz2UOoU1PpsxsyhwkkslBeF13rwvjc4eqkhKLUE6PLKArZW5JhGDPW+pugtC+sbxB9V3wIY8J39G3PMKjIjJx3v6y2jTRU2i52ZcoSyB9CZ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1886.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(366004)(376002)(136003)(39860400002)(346002)(186003)(7696005)(55016003)(110136005)(54906003)(66446008)(66946007)(76116006)(64756008)(66556008)(66476007)(4326008)(8676002)(9686003)(107886003)(26005)(71200400001)(83380400001)(53546011)(6506007)(33656002)(86362001)(38070700005)(38100700002)(122000001)(41300700001)(2906002)(316002)(478600001)(82960400001)(52536014)(8936002)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KKoggXCrqWV2DX47dobDpe6H7ZqUoRhVAxiIECSgXsD7H7yn9qLsKTdxRrnS?= =?us-ascii?Q?DG5TwiCseFmpqAqbC0caT52IGmojKRXcZJkI0yAf9qpHNP2UBI3Ov1cueZN9?= =?us-ascii?Q?pVFrs3k1aOjw2H6kmyqMDRIeACcMp17aLXJ+9vqHlTO3lE7AWvRScYOOMUVV?= =?us-ascii?Q?nw/5hLtNsPwuqfsoV0vQPK162Izg+gQgGx1Ob7qaYHBpvJxx5/MObovI15NE?= =?us-ascii?Q?vCUJfZ6QGznMnadr6FQmiNHILGSlm5CVAMqCHDqM5FwhO6ZYg8bC179ue5wv?= =?us-ascii?Q?rQEoyF6xkqT0cyLtKicTGdIFoTI/aKCQMb4ihiKiYY7BPLSySxkynd+itnV6?= =?us-ascii?Q?epusv131eV+qfwCysPEyDmDtIPq+5QdByjQu/1Vs3e0TSAwuvaem+9rbt1vY?= =?us-ascii?Q?NLC69/WDTico4WsFoSYmXMac50Lc+CpmV97SU0ZtM/Zx5QgfWJtbEO/nti8L?= =?us-ascii?Q?P2oI0uAwa6dzt+/Oe4dEdNUnyqeQvngDQlCEmsIfy5F3S1rpdQ/AOmZ5HhW7?= =?us-ascii?Q?o4zHJbtDPKa9YsJF9819fJqNKkM+L80/TZ533LD97+LJ9uGz6Iu83a2YwcWl?= =?us-ascii?Q?QjR2fQjHxmkxFWARk1pGLMcevDxZ3pRGUlAmbpcC8nWHmX1Bh7/+KjMuXGKI?= =?us-ascii?Q?QczKkLM2MyHJbRhW53278snytCL3i0FjREdtoflPZdPEgjaNQEoTJ1uO/qwL?= =?us-ascii?Q?QrEMq9rU2DazTBRybCJIcjGb/04RaT5g9Jv+GfdvqTTqn+joVKkPUWv2+uVR?= =?us-ascii?Q?yJ1/DciVaE7TN1u7jLVz7fH517DgJNLYkzc9Rpfwo91lVs86j/J2Si38Vpfi?= =?us-ascii?Q?4l2uMRJ3te62WfHViTI+wbwzUvKNDUJ5QJPZOPp1BDl2Ngt3x/RluFMQRI3k?= =?us-ascii?Q?TVG70y2E5EmqtGBbps2la+QAC+Qh4G/jvahMqsoleEXx2N+/3RUUKCDPCvpU?= =?us-ascii?Q?09PwfXHy+6Uj1eMNgqUFZKBYrzuAZOIro02uzbs5NgYPulMqgbsdggC8N8Pd?= =?us-ascii?Q?WfZCuvVvkL+FUf2yoN+BvB+sMIsIQTyxdQL6TIG5UdhyThK5zEE7cMsJfPpo?= =?us-ascii?Q?ClVGFYhj+oHkKIgLREM1fFV+7pHBhWvx1hLicOZgJdgAQcIMeRZyBJuX4J/y?= =?us-ascii?Q?UFKqEMd6MpN8ULxsb6YcQo4bEnSn5qLwopA2+8PES8h8cURNQJ6Ro/iiO3jX?= =?us-ascii?Q?KxnMvrVXRYFFjl9rA0NnVfLzKLuGf0uhn6iMzA0ZGD4cnsDGFH6lMfFEZvPr?= =?us-ascii?Q?wZ8R2IncEBaxg+agzwOkZCoFeT17l0ApcsxNEM/K+vNmLE6rFgLHZeTRZ5ao?= =?us-ascii?Q?crEs1zNYG61ALZqFqGARwYJwnHi3yucjRbgR4SldI1i5jc+MKGYCO+zsiXSb?= =?us-ascii?Q?jTXDzo0RQpwDjGJxqEY7OWS/oWviDE2Dcval5TNmiZAdy8ug0lzQHhbgY+h3?= =?us-ascii?Q?9vU2fLVyyozwb3ywUzWGsjLZ9vDRD9RhZJZmhSLQA8YaexMy+jxTGuaWhP6r?= =?us-ascii?Q?cTs98QbHBtwU6rNXftM+a3h8DFMphT74snAhO3pAaLnJTV58+gs6TbIsQw0w?= =?us-ascii?Q?c/GltEszHYdWDeghhfY0u/Onr7UmDG2TVQecoqhO?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1886.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee067d3b-0f37-4564-6bd6-08da5fe5982d X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 06:54:53.1453 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qntJh+EHS2tO23rjhDjJT0UBVrq6W/x0bGSQ3TTj9M0dh+ODcbQ71PoViorSQ8WVLE4gCZOfcS55dkKrbd5J9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1640 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Kevin Liu > Sent: Thursday, July 7, 2022 18:48 > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Yuying > ; Yang, SteveX ; Liu, Kevi= nX > > Subject: [PATCH] net/i40e: restore disable double VLAN by default >=20 > Restore disable double VLAN by default. Please add detail reason, like will caused performance drop issue. >=20 > Fixes: ae97b8b89826 ("net/i40e: fix error disable double VLAN") > Signed-off-by: Kevin Liu > --- > doc/guides/nics/i40e.rst | 6 +++--- > drivers/net/i40e/i40e_ethdev.c | 12 ------------ > 2 files changed, 3 insertions(+), 15 deletions(-) >=20 > diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index > 85fdc4944d..f61c327726 100644 > --- a/doc/guides/nics/i40e.rst > +++ b/doc/guides/nics/i40e.rst > @@ -969,10 +969,10 @@ it will fail and return the info "Conflict with the= first > rule's input set", which means the current rule's input set conflicts wi= th the first > rule's. > Remove the first rule if want to change the input set of the PCTYPE. >=20 > -Disable QinQ is not supported when FW >=3D 8.4 - > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > +To use VLAN functions, need to enable QinQ when FW >=3D 8.4 Not only this issue, you should cover all the issue we know. Vlan related feature miss when FW>=3D8.4 ~~~~~~~~~~~~~ If upgrade FW to version 8.4 and higher, some vlan related issue exist: 1.vlan tci input set not work 2.tpid set fail 3.need enable qinq before use vlan filter 4.outer vlan strip fail > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >=20 > -If upgrade FW to version 8.4 and higher, enable QinQ by default and disa= ble > QinQ is not supported. > +If upgrade FW to version 8.4 and higher, when using VLAN functions, need= to > enable QinQ. >=20 >=20 > Example of getting best performance with l3fwd example diff --git > a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index > 684e095026..117dd85c11 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -4027,12 +4027,6 @@ i40e_vlan_offload_set(struct rte_eth_dev *dev, int > mask) > } >=20 > if (mask & RTE_ETH_VLAN_EXTEND_MASK) { > - /* Double VLAN not allowed to be disabled.*/ > - if (pf->fw8_3gt && !(rxmode->offloads & > RTE_ETH_RX_OFFLOAD_VLAN_EXTEND)) { > - PMD_DRV_LOG(WARNING, > - "Disable double VLAN is not allowed after > firmwarev8.3!"); > - return 0; > - } > i =3D 0; > num =3D vsi->mac_num; > mac_filter =3D rte_zmalloc("mac_filter_info_data", > @@ -6296,7 +6290,6 @@ int i40e_vsi_cfg_inner_vlan_stripping(struct i40e_v= si > *vsi, bool on) static int i40e_dev_init_vlan(struct rte_eth_dev *dev) = { > - struct i40e_pf *pf =3D I40E_DEV_PRIVATE_TO_PF(dev->data- > >dev_private); > struct rte_eth_dev_data *data =3D dev->data; > int ret; > int mask =3D 0; > @@ -6307,11 +6300,6 @@ i40e_dev_init_vlan(struct rte_eth_dev *dev) > RTE_ETH_VLAN_FILTER_MASK | > RTE_ETH_VLAN_EXTEND_MASK; >=20 > - /* Double VLAN be enabled by default.*/ > - if (pf->fw8_3gt) { > - struct rte_eth_rxmode *rxmode =3D &dev->data- > >dev_conf.rxmode; > - rxmode->offloads |=3D RTE_ETH_RX_OFFLOAD_VLAN_EXTEND; > - } > ret =3D i40e_vlan_offload_set(dev, mask); > if (ret) { > PMD_DRV_LOG(INFO, "Failed to update vlan offload"); > -- > 2.34.1