RE: [DPDK v3] net/ixgbe: promote MDIO API

["Yang, Qiming" <qiming.yang@intel.com>]

> -----Original Message-----
> From: Ray Kinsella <mdr@ashroe.eu>
> Sent: 2022年4月15日 22:36
> To: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Cc: dev@dpdk.org; Wang, Haiyue <haiyue.wang@intel.com>; David
> Marchand <david.marchand@redhat.com>
> Subject: Re: [DPDK v3] net/ixgbe: promote MDIO API
> 
> 
> zhichaox.zeng@intel.com writes:
> 
> > From: zhichao zeng <zhichaox.zeng@intel.com>
> >
> > Promote the MDIO APIs to be stable.
> >
> > Signed-off-by: zhichao zeng <zhichaox.zeng@intel.com>

Your sign off should be Zhichao Zeng, upper case.

> > ---
> >  drivers/net/ixgbe/rte_pmd_ixgbe.h |  5 -----
> >  drivers/net/ixgbe/version.map     | 10 +++++-----
> >  2 files changed, 5 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h
> > b/drivers/net/ixgbe/rte_pmd_ixgbe.h
> > index eef6f6661c..426fe5845b 100644
> > --- a/drivers/net/ixgbe/rte_pmd_ixgbe.h
> > +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h
> > @@ -586,7 +586,6 @@ int rte_pmd_ixgbe_bypass_wd_reset(uint16_t
> port);
> >   *   - (-ENODEV) if *port* invalid.
> >   *   - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed
> >   */
> > -__rte_experimental
> >  int
> >  rte_pmd_ixgbe_mdio_lock(uint16_t port);
> >
> > @@ -600,7 +599,6 @@ rte_pmd_ixgbe_mdio_lock(uint16_t port);
> >   *   - (-ENOTSUP) if hardware doesn't support.
> >   *   - (-ENODEV) if *port* invalid.
> >   */
> > -__rte_experimental
> >  int
> >  rte_pmd_ixgbe_mdio_unlock(uint16_t port);
> >
> > @@ -622,7 +620,6 @@ rte_pmd_ixgbe_mdio_unlock(uint16_t port);
> >   *   - (-ENODEV) if *port* invalid.
> >   *   - (IXGBE_ERR_PHY) If PHY read command failed
> >   */
> > -__rte_experimental
> >  int
> >  rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
> >  				 uint32_t dev_type, uint16_t *phy_data);
> @@ -646,7 +643,6 @@
> > rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
> >   *   - (-ENODEV) if *port* invalid.
> >   *   - (IXGBE_ERR_PHY) If PHY read command failed
> >   */
> > -__rte_experimental
> >  int
> >  rte_pmd_ixgbe_mdio_unlocked_write(uint16_t port, uint32_t reg_addr,
> >  				  uint32_t dev_type, uint16_t phy_data);
> @@ -725,7 +721,6 @@ enum
> > {
> >   *   - (-ENODEV) if *port* invalid.
> >   *   - (-ENOTSUP) if hardware doesn't support this feature.
> >   */
> > -__rte_experimental
> >  int
> >  rte_pmd_ixgbe_upd_fctrl_sbp(uint16_t port, int enable);
> >
> > diff --git a/drivers/net/ixgbe/version.map
> > b/drivers/net/ixgbe/version.map index bca5cc5826..f0f29d8749 100644
> > --- a/drivers/net/ixgbe/version.map
> > +++ b/drivers/net/ixgbe/version.map
> > @@ -16,6 +16,10 @@ DPDK_22 {
> >  	rte_pmd_ixgbe_macsec_enable;
> >  	rte_pmd_ixgbe_macsec_select_rxsa;
> >  	rte_pmd_ixgbe_macsec_select_txsa;
> 
> Promoted APIs should be part of the DPDK_23 ABI, not DPDK_22.
> 
> David - I just did some checking and noted that we have been promoting
> directly from experimental to DPDK 22, and that we did the same for DPDK
> 21. However in the DPDK_20 we (rightly) promoted to DPDK_21, new APIs
> are promoted to being stable in the next ABI release.
> 
> Was that I conscious decision? I don't thinking there is impact by the error /
> change, beyond house keeping.
> 
> 
> > +	rte_pmd_ixgbe_mdio_lock;
> > +	rte_pmd_ixgbe_mdio_unlock;
> > +	rte_pmd_ixgbe_mdio_unlocked_read;
> > +	rte_pmd_ixgbe_mdio_unlocked_write;
> >  	rte_pmd_ixgbe_ping_vf;
> >  	rte_pmd_ixgbe_set_all_queues_drop_en;
> >  	rte_pmd_ixgbe_set_tc_bw_alloc;
> > @@ -31,6 +35,7 @@ DPDK_22 {
> >  	rte_pmd_ixgbe_set_vf_vlan_filter;
> >  	rte_pmd_ixgbe_set_vf_vlan_insert;
> >  	rte_pmd_ixgbe_set_vf_vlan_stripq;
> > +	rte_pmd_ixgbe_upd_fctrl_sbp;
> >
> >  	local: *;
> >  };
> > @@ -40,9 +45,4 @@ EXPERIMENTAL {
> >
> >  	rte_pmd_ixgbe_get_fdir_info;
> >  	rte_pmd_ixgbe_get_fdir_stats;
> > -	rte_pmd_ixgbe_mdio_lock;
> > -	rte_pmd_ixgbe_mdio_unlock;
> > -	rte_pmd_ixgbe_mdio_unlocked_read;
> > -	rte_pmd_ixgbe_mdio_unlocked_write;
> > -	rte_pmd_ixgbe_upd_fctrl_sbp;
> >  };
> 
> 
> --
> Regards, Ray K