From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2C86A04BB; Tue, 6 Oct 2020 12:22:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9899C2E81; Tue, 6 Oct 2020 12:22:37 +0200 (CEST) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by dpdk.org (Postfix) with ESMTP id 26DD62952 for ; Tue, 6 Oct 2020 12:22:35 +0200 (CEST) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 06 Oct 2020 03:22:20 -0700 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 6 Oct 2020 10:22:22 +0000 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.56) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 6 Oct 2020 10:22:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ReMzZmdOeWgyXXSeko4Eqm27k0IjuwixHVGSBeU5raVM8WM7ooV0jrZjJej5Q0xEbsmjThfAXParEHPKQhqdbOE3iu3D+YM5UhTAf+ZrAlJDDFikuxXLeO2yycM96qK47Q/zBOvJ5VEv9B3dQFseZ2UqLrvj6naD9Lr4kk1x/Rl8uJFBpF5tWMzMJQx5dQKM5e8xsyLMQ2B3qrE3iLfZsHXFpxIcGEyaEvEySl6jWNq3vErGOXxjn7xQY+7wtAk/+ppyatzeVNkGqXvvzmy/9gtAq9DaE54kSKI6qXqS4sTN/6cg5CegNOOg5LGKUYNjmfbXZ1Ji49QmQ9e/6uFzyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b5pVRqhIOdwR9eOqhpecYA8EsybtdOhAgaWLQlQYeBc=; b=M0FKish3PKOKcFarmZ/y4S1Fj3rzChW+ikhoTXivj/r6jvHpdTsyFpIuYKEfXmqPXB+tIBj+NFT/9NxtfvKevPlfroNqGngF5wSZnyN5rJpBd0nOAXwmjt1JQlaF7QgT9QbC6nVix59SUA81WujheseMPDLkOcD6dZatnHWtth8Ea10ydxD5a4++/LdhUhG0UnECMNJo4X1Qyerm4P1FzJ4QipaUkn6Y2L5fffb1VgK+59USjWy3LcR5IjKZA2Jb0cwhlIiu/rNxm4SeuV1RBgV4MJ1PKoeoRUPc+qXjcey/PJ4iARw7EfS2baUBF3EVSDXgWl7LKCAUH9ne1VUhaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MWHPR1201MB2525.namprd12.prod.outlook.com (2603:10b6:300:e0::19) by MWHPR12MB1230.namprd12.prod.outlook.com (2603:10b6:300:f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.38; Tue, 6 Oct 2020 10:22:19 +0000 Received: from MWHPR1201MB2525.namprd12.prod.outlook.com ([fe80::3ccb:ec09:9346:54b1]) by MWHPR1201MB2525.namprd12.prod.outlook.com ([fe80::3ccb:ec09:9346:54b1%7]) with mapi id 15.20.3433.045; Tue, 6 Oct 2020 10:22:19 +0000 From: Andrey Vesnovaty To: Ori Kam , "dev@dpdk.org" CC: "jer@marvell.com" , "jerinjacobk@gmail.com" , NBU-Contact-Thomas Monjalon , "ferruh.yigit@intel.com" , "stephen@networkplumber.org" , "bruce.richardson@intel.com" , Slava Ovsiienko , "andrey.vesnovaty@gmail.com" , "mdr@ashroe.eu" , "nhorman@tuxdriver.com" , "ajit.khaparde@broadcom.com" , "samik.gupta@broadcom.com" , Andrey Vesnovaty , "Andrew Rybchenko" , Ori Kam Thread-Topic: [PATCH v3 01/10] ethdev: add flow shared action API Thread-Index: AQHWmdGPF7NYD2XwZke988qTjZnIAKmHSiwAgAMTHGA= Date: Tue, 6 Oct 2020 10:22:19 +0000 Message-ID: References: <20201003220619.19231-1-andreyv@nvidia.com> <20201003220619.19231-2-andreyv@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [87.71.166.102] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 583e9d02-7e7d-49a2-8bbd-08d869e1b4dd x-ms-traffictypediagnostic: MWHPR12MB1230: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7muGrLYzouNY9LQcj7B7CRsJbVYvgXxkFsVKKJpOrm3BGQJcCsYb06DmBoncFQXB+0HgOF8HdiBCjKHdxfu7o9B2p+IihWfDDj45skemG+xquOyDWXDhFFXQ04aYlTRHStYiOB+HoY1H1gk8fEgUzHpqZWhy9pTb8v7QWurehtF2u0ML8JObUysQfpg6EQp+8jgevwVsy+l6DQZDGNvoplazOVo5fp5lLzA4PqwS6Fq3rROGQi49fUIv4H+ILezsdmqtO5fWPH8V8fA+2GdNcwYgxwvedkA1q7Qw6ZbHuYNb/v/DwKzocSU6ItfCf2I1+VQqnEZ/HnoCaA4f/WpDXg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1201MB2525.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(376002)(39860400002)(346002)(366004)(71200400001)(66946007)(5660300002)(83380400001)(66446008)(64756008)(66476007)(86362001)(52536014)(30864003)(9686003)(66556008)(26005)(76116006)(186003)(55016002)(2906002)(7416002)(53546011)(7696005)(6506007)(478600001)(54906003)(33656002)(110136005)(316002)(8936002)(4326008)(107886003)(8676002)(579004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: qPJdLeXgWW59QEsCvlE/a9gj7w0yVKHBTcvAH+BVSYRstTWWoGqP2qj4Rx3vtSY/b85c5nT0Rwd/pUtuJBw1CXhVk58UT3ibn+KIGsZnQ8tye6oE9UccNxAvqAdNjYRrmvRaWvK8ZyXZ4Yo2j2AYKyLgSHXK72KHrxrCI4RUENMYPQ56LM1PLtZTVeg08Yr4sWWCRFm9IMm8kp9qDgdlBh/ATxRt3rFJXNSEkWtalu8Chx5jZYZ2PqIrMUDFa2iWZNi4mFwd8nRDzTieyTsHDj1RvZFu/26r79z4OUiWbR5mFJFNahLbovpAqQ7Ph6W8Xi/I5ZiQ8befzjTmDWVGSMLK9MZ6Xoewcymh/fdzQ9LG030dt4yoGaYpaASnLnNuiJM+6gU84EdOW+zJ0NMcvDjL1eNeGRfejt9kcBB6jr19oRnKHtq+5lFYHAO3uTmLBE8TrWKfU6c/ik+f2lPd4GVc1o+8FcEt1a69ZTsIe/w71nizyTpYfJMBtGCFMEA56BUIqJNIs9/e9hRUmVpKUQYGr+rZs2/yDIfZp28r+tg65wU2j9en89ZBM8BU1KHIM0QbK9iwbG+zs/gUgvDYUNMaMYAb+yiHA4XOtGV0ulEVTDk2sTUhTRopmn+ZgU3QhMcAl1ZVcRwgkVjXEzgzEQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1201MB2525.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 583e9d02-7e7d-49a2-8bbd-08d869e1b4dd X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2020 10:22:19.3832 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aPILWN2RF8cp+3H71z6Mc6IdLOy3CznGueFxI5Hc2iDxYnkW+/17B4aLJ5T96EbGH/2xmgSaQqJUHHHFeILoqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1230 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1601979740; bh=b5pVRqhIOdwR9eOqhpecYA8EsybtdOhAgaWLQlQYeBc=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=b2x1GrT06UGr6xhS035NXp5Y6BPqJady/eEsSK/5M23iOkCDYJlVVMb7vK1eDRC6R s+dVwpCnMcabDuEy6q2cUTiMjh8pP25o1g3j8Rd029oxOOjniYeZgXMgUyAR6cEpuS mszfd07/0/H28Y+NhAK5Oqj/rhx55g4UnrKuW6rhf/v5wY7WeLfjkemaThwUaCuwyA c2fwrycEAsM/DCajrmKRCmmIr4Xxut8mK+kxpOjU7rQjN+/V9YqUKHH/8xcgXaocAF MQvEvog23or3D977SUW9n4PeWtjmGXMo6MVk7lFyG6QPUJYtWwQxjQXN/Crwjqzoyh bIH+Zu4dor64A== Subject: Re: [dpdk-dev] [PATCH v3 01/10] ethdev: add flow shared action API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ori, PSB Thanks, Andrey > -----Original Message----- > From: Ori Kam > Sent: Sunday, October 4, 2020 2:10 PM > To: Andrey Vesnovaty ; dev@dpdk.org > Cc: jer@marvell.com; jerinjacobk@gmail.com; NBU-Contact-Thomas Monjalon > ; ferruh.yigit@intel.com; > stephen@networkplumber.org; bruce.richardson@intel.com; Slava Ovsiienko > ; andrey.vesnovaty@gmail.com; mdr@ashroe.eu; > nhorman@tuxdriver.com; ajit.khaparde@broadcom.com; > samik.gupta@broadcom.com; Andrey Vesnovaty ; > Andrew Rybchenko ; Ori Kam > > Subject: RE: [PATCH v3 01/10] ethdev: add flow shared action API >=20 > Hi Andrey, >=20 > You are missing the doc update (rte_flow) Got it. Will update in release_notes_20.11.rst & testpmd. > PSB for more comments. >=20 > Best, > Ori >=20 > > -----Original Message----- > > From: Andrey Vesnovaty > > Sent: Sunday, October 4, 2020 1:06 AM > > Subject: [PATCH v3 01/10] ethdev: add flow shared action API > > > > This commit introduces extension of DPDK flow action API enabling > > sharing of single rte_flow_action in multiple flows. The API intended f= or > > PMDs where multiple HW offloaded flows can reuse the same HW > > essence/object representing flow action and modification of such an > > essence/object effects all the rules using it. > > > > Motivation and example > > =3D=3D=3D > > Adding or removing one or more queues to RSS used by multiple flow rule= s > > imposes per rule toll for current DPDK flow API; the scenario requires > > for each flow sharing cloned RSS action: > > - call `rte_flow_destroy()` > > - call `rte_flow_create()` with modified RSS action > > > > API for sharing action and its in-place update benefits: > > - reduce the overhead of multiple RSS flow rules reconfiguration > > - optimize resource utilization by sharing action across of multiple > > flows > > > > Change description > > =3D=3D=3D > > > > Shared action > > =3D=3D=3D > > In order to represent flow action shared by multiple flows new action > > type RTE_FLOW_ACTION_TYPE_SHARED is introduced (see `enum > > rte_flow_action_type`). > > Actually the introduced API decouples action from any specific flow and > > enables sharing of single action by its handle across multiple flows. > > > > Shared action create/use/destroy > > =3D=3D=3D > > Shared action may be reused by some or none flow rules at any given > > moment, i.e. shared action reside outside of the context of any flow. > > Shared action represent HW resources/objects used for action offloading > > implementation. > > API for shared action create (see `rte_flow_shared_action_create()`): > > - should allocate HW resources and make related initializations require= d > > for shared action implementation. > > - make necessary preparations to maintain shared access to > > the action resources, configuration and state. > > API for shared action destroy (see `rte_flow_shared_action_destroy()`) > > should release HW resources and make related cleanups required for shar= ed > > action implementation. > > > > In order to share some flow action reuse the handle of type > > `struct rte_flow_shared_action` returned by > > rte_flow_shared_action_create() as a `conf` field of > > `struct rte_flow_action` (see "example" section). > > > > If some shared action not used by any flow rule all resources allocated > > by the shared action can be released by rte_flow_shared_action_destroy(= ) > > (see "example" section). The shared action handle passed as argument to > > destroy API should not be used any further i.e. result of the usage is > > undefined. > > > > Shared action re-configuration > > =3D=3D=3D > > Shared action behavior defined by its configuration can be updated via > > rte_flow_shared_action_update() (see "example" section). The shared > > action update operation modifies HW related resources/objects allocated > > on the action creation. The number of operations performed by the updat= e > > operation should not be dependent on number of flows sharing the relate= d > > action. On return of shared action update API action behavior should be > > according to updated configuration for all flows sharing the action. > > > > Shared action query > > =3D=3D=3D > > Provide separate API to query shared action sate (see >=20 > I think sate --> state, also it is not clear if we are sharing both confi= guration and > state > or only configuration. For example what will happen if we create counter = and > attached it > to number of flow? Does it count for all flow so counter =3D flow1 + flow= 2? > Or it is only for configuration which means that one each flow gets diffe= rent > counter? > For counter there is a shared bit in the action so this can be used to de= terment if > the state > should be shared, but counter doesn't have configuration to share. > What happens with aging where we have state and configuration? >=20 > I'm O.K with starting just with configuration, but it should be clear. > Shared action state considered shared till it's defined differently. So when shared action queried it's considered query for state. Configuration of shred action controlled by rte_flow_sahred_action_create() and rte_flow_shared_action_update() APIs and no supposed to change by other means. Do you think there is a need to query shared action configurat= ion? =20 > > rte_flow_shared_action_update()). Taking a counter as an example: query > > returns value aggregating all counter increments across all flow rules > > sharing the counter. > > > > PMD support > > =3D=3D=3D > > The support of introduced API is pure PMD specific design and > > responsibility for each action type (see struct rte_flow_ops). > > > > testpmd > > =3D=3D=3D > > In order to utilize introduced API testpmd cli may implement following > > extension > > create/update/destroy/query shared action accordingly > > > > flow shared_action (port) create {action_id (id)} (action) / end > > flow shared_action (port) update (id) (action) / end > > flow shared_action (port) destroy action_id (id) {action_id (id) [...]} > > flow shared_action (port) query (id) > > > > testpmd example > > =3D=3D=3D > > > > configure rss to queues 1 & 2 > > > > > flow shared_action 0 create action_id 100 rss queues 1 2 end / end > > > > create flow rule utilizing shared action > > > > > flow create 0 ingress \ > > pattern eth dst is 0c:42:a1:15:fd:ac / ipv6 / tcp / end \ > > actions shared 100 / end > > > > add 2 more queues > > > > > flow shared_action 0 modify 100 rss queues 1 2 3 4 end / end > > > > example > > =3D=3D=3D > > > > struct rte_flow_action actions[2]; > > struct rte_flow_action action; > > /* skipped: initialize action */ > > struct rte_flow_shared_action *handle =3D rte_flow_shared_action_create= ( > > port_id, &action, &error); > > actions[0].type =3D RTE_FLOW_ACTION_TYPE_SHARED; > > actions[0].conf =3D handle; > > actions[1].type =3D RTE_FLOW_ACTION_TYPE_END; > > /* skipped: init attr0 & pattern0 args */ > > struct rte_flow *flow0 =3D rte_flow_create(port_id, &attr0, pattern0, > > actions, error); > > /* create more rules reusing shared action */ > > struct rte_flow *flow1 =3D rte_flow_create(port_id, &attr1, pattern1, > > actions, error); > > /* skipped: for flows 2 till N */ > > struct rte_flow *flowN =3D rte_flow_create(port_id, &attrN, patternN, > > actions, error); > > /* update shared action */ > > struct rte_flow_action updated_action; > > /* > > * skipped: initialize updated_action according to desired action > > * configuration change > > */ > > rte_flow_shared_action_update(port_id, handle, &updated_action, error); > > /* > > * from now on all flows 1 till N will act according to configuration o= f > > * updated_action > > */ > > /* skipped: destroy all flows 1 till N */ > > rte_flow_shared_action_destroy(port_id, handle, error); > > > > Signed-off-by: Andrey Vesnovaty > > Signed-off-by: Andrey Vesnovaty > > --- > > lib/librte_ethdev/rte_ethdev_version.map | 4 + > > lib/librte_ethdev/rte_flow.c | 82 +++++++++++++ > > lib/librte_ethdev/rte_flow.h | 148 ++++++++++++++++++++++- > > lib/librte_ethdev/rte_flow_driver.h | 22 ++++ > > 4 files changed, 255 insertions(+), 1 deletion(-) > > > > diff --git a/lib/librte_ethdev/rte_ethdev_version.map > > b/lib/librte_ethdev/rte_ethdev_version.map > > index fc47f6472e..168bf7fc12 100644 > > --- a/lib/librte_ethdev/rte_ethdev_version.map > > +++ b/lib/librte_ethdev/rte_ethdev_version.map > > @@ -225,6 +225,10 @@ EXPERIMENTAL { > > rte_tm_shared_wred_context_delete; > > rte_tm_wred_profile_add; > > rte_tm_wred_profile_delete; > > + rte_flow_shared_action_create; > > + rte_flow_shared_action_destroy; > > + rte_flow_shared_action_update; > > + rte_flow_shared_action_query; > > }; > > > > INTERNAL { > > diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.= c > > index f8fdd68fe9..ba3f01f7c7 100644 > > --- a/lib/librte_ethdev/rte_flow.c > > +++ b/lib/librte_ethdev/rte_flow.c > > @@ -174,6 +174,7 @@ static const struct rte_flow_desc_data > > rte_flow_desc_action[] =3D { > > MK_FLOW_ACTION(SET_IPV4_DSCP, sizeof(struct > > rte_flow_action_set_dscp)), > > MK_FLOW_ACTION(SET_IPV6_DSCP, sizeof(struct > > rte_flow_action_set_dscp)), > > MK_FLOW_ACTION(AGE, sizeof(struct rte_flow_action_age)), > > + MK_FLOW_ACTION(SHARED, 0), > > }; > > > > int > > @@ -1251,3 +1252,84 @@ rte_flow_get_aged_flows(uint16_t port_id, void > > **contexts, > > RTE_FLOW_ERROR_TYPE_UNSPECIFIED, > > NULL, rte_strerror(ENOTSUP)); > > } > > + > > +struct rte_flow_shared_action * > > +rte_flow_shared_action_create(uint16_t port_id, > > + const struct rte_flow_action *action, > > + struct rte_flow_error *error) >=20 > You are missing the property for direction that we agreed in previous ver= sion. >=20 > > +{ > > + struct rte_eth_dev *dev =3D &rte_eth_devices[port_id]; > > + struct rte_flow_shared_action *shared_action; > > + const struct rte_flow_ops *ops =3D rte_flow_ops_get(port_id, error); > > + > > + if (unlikely(!ops)) > > + return NULL; > > + if (likely(!!ops->shared_action_create)) { > > + shared_action =3D ops->shared_action_create(dev, action, error); > > + if (shared_action =3D=3D NULL) > > + flow_err(port_id, -rte_errno, error); > > + return shared_action; > > + } > > + rte_flow_error_set(error, ENOSYS, > > RTE_FLOW_ERROR_TYPE_UNSPECIFIED, > > + NULL, rte_strerror(ENOSYS)); > > + return NULL; > > +} > > + > > +int > > +rte_flow_shared_action_destroy(uint16_t port_id, > > + struct rte_flow_shared_action *action, > > + struct rte_flow_error *error) > > +{ > > + struct rte_eth_dev *dev =3D &rte_eth_devices[port_id]; > > + const struct rte_flow_ops *ops =3D rte_flow_ops_get(port_id, error); > > + > > + if (unlikely(!ops)) > > + return -rte_errno; > > + if (likely(!!ops->shared_action_destroy)) > > + return flow_err(port_id, > > + ops->shared_action_destroy(dev, action, > > error), > > + error); > > + return rte_flow_error_set(error, ENOSYS, > > + RTE_FLOW_ERROR_TYPE_UNSPECIFIED, > > + NULL, rte_strerror(ENOSYS)); > > +} > > + > > +int > > +rte_flow_shared_action_update(uint16_t port_id, > > + struct rte_flow_shared_action *action, > > + const struct rte_flow_action *update, > > + struct rte_flow_error *error) > > +{ > > + struct rte_eth_dev *dev =3D &rte_eth_devices[port_id]; > > + const struct rte_flow_ops *ops =3D rte_flow_ops_get(port_id, error); > > + > > + if (unlikely(!ops)) > > + return -rte_errno; > > + if (likely(!!ops->shared_action_update)) > > + return flow_err(port_id, ops->shared_action_update(dev, > > action, > > + update, error), > > + error); > > + return rte_flow_error_set(error, ENOSYS, > > + RTE_FLOW_ERROR_TYPE_UNSPECIFIED, > > + NULL, rte_strerror(ENOSYS)); > > +} > > + > > +int > > +rte_flow_shared_action_query(uint16_t port_id, > > + const struct rte_flow_shared_action *action, > > + void *data, > > + struct rte_flow_error *error) > > +{ > > + struct rte_eth_dev *dev =3D &rte_eth_devices[port_id]; > > + const struct rte_flow_ops *ops =3D rte_flow_ops_get(port_id, error); > > + > > + if (unlikely(!ops)) > > + return -rte_errno; > > + if (likely(!!ops->shared_action_query)) > > + return flow_err(port_id, ops->shared_action_query(dev, action, > > + data, error), > > + error); > > + return rte_flow_error_set(error, ENOSYS, > > + RTE_FLOW_ERROR_TYPE_UNSPECIFIED, > > + NULL, rte_strerror(ENOSYS)); > > +} > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.= h > > index da8bfa5489..02391316cb 100644 > > --- a/lib/librte_ethdev/rte_flow.h > > +++ b/lib/librte_ethdev/rte_flow.h > > @@ -1714,7 +1714,8 @@ enum rte_flow_action_type { > > /** > > * Enables counters for this flow rule. > > * > > - * These counters can be retrieved and reset through rte_flow_query()= , > > + * These counters can be retrieved and reset through rte_flow_query() > > or > > + * rte_flow_shared_action_query() if the action provided via handle, > > * see struct rte_flow_query_count. > > * > > * See struct rte_flow_action_count. > > @@ -2132,6 +2133,14 @@ enum rte_flow_action_type { > > * see enum RTE_ETH_EVENT_FLOW_AGED > > */ > > RTE_FLOW_ACTION_TYPE_AGE, > > + > > + /** > > + * Describes action shared a cross multiple flow rules. > > + * > > + * Enables multiple rules reference the same action by handle (see > > + * struct rte_flow_shared_action). > > + */ > > + RTE_FLOW_ACTION_TYPE_SHARED, > > }; > > > > /** > > @@ -2693,6 +2702,20 @@ struct rte_flow_action_set_dscp { > > uint8_t dscp; > > }; > > > > + > > +/** > > + * RTE_FLOW_ACTION_TYPE_SHARED > > + * > > + * Opaque type returned after successfully creating a shared action. > > + * > > + * This handle can be used to manage and query the related action: > > + * - share it a cross multiple flow rules > > + * - update action configuration > > + * - query action data > > + * - destroy action > > + */ > > +struct rte_flow_shared_action; > > + > > /* Mbuf dynamic field offset for metadata. */ > > extern int32_t rte_flow_dynf_metadata_offs; > > > > @@ -3357,6 +3380,129 @@ int > > rte_flow_get_aged_flows(uint16_t port_id, void **contexts, > > uint32_t nb_contexts, struct rte_flow_error *error); > > > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice. > > + * > > + * Create shared action for reuse in multiple flow rules. > > + * > > + * @param[in] port_id > > + * The port identifier of the Ethernet device. > > + * @param[in] action > > + * Action configuration for shared action creation. > > + * @param[out] error > > + * Perform verbose error reporting if not NULL. PMDs initialize this > > + * structure in case of error only. > > + * @return > > + * A valid handle in case of success, NULL otherwise and rte_errno i= s set > > + * to one of the error codes defined: > > + * - (ENOSYS) if underlying device does not support this functionali= ty. > > + * - (EIO) if underlying device is removed. > > + * - (EINVAL) if *action* invalid. > > + * - (ENOTSUP) if *action* valid but unsupported. > > + */ > > +__rte_experimental > > +struct rte_flow_shared_action * > > +rte_flow_shared_action_create(uint16_t port_id, > > + const struct rte_flow_action *action, > > + struct rte_flow_error *error); > > + > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice. > > + * > > + * Destroys the shared action by handle. > > + * > > + * @param[in] port_id > > + * The port identifier of the Ethernet device. > > + * @param[in] action > > + * Handle for the shared action to be destroyed. > > + * @param[out] error > > + * Perform verbose error reporting if not NULL. PMDs initialize this > > + * structure in case of error only. > > + * @return > > + * - (0) if success. > > + * - (-ENOSYS) if underlying device does not support this functional= ity. > > + * - (-EIO) if underlying device is removed. > > + * - (-ENOENT) if action pointed by *action* handle was not found. > > + * - (-ETOOMANYREFS) if action pointed by *action* handle still used= by one > > or > > + * more rules > > + * rte_errno is also set. > > + */ > > +__rte_experimental > > +int > > +rte_flow_shared_action_destroy(uint16_t port_id, > > + struct rte_flow_shared_action *action, > > + struct rte_flow_error *error); > > + > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice. > > + * > > + * Updates inplace the shared action configuration pointed by *action* > handle > > + * with the configuration provided as *update* argument. > > + * The update of the shared action configuration effects all flow rule= s reusing > > + * the action via handle. > > + * > > + * @param[in] port_id > > + * The port identifier of the Ethernet device. > > + * @param[in] action > > + * Handle for the shared action to be updated. > > + * @param[in] update > > + * Action specification used to modify the action pointed by handle. > > + * *update* should be of same type with the action pointed by the *a= ction* > > + * handle argument, otherwise considered as invalid. > > + * @param[out] error > > + * Perform verbose error reporting if not NULL. PMDs initialize this > > + * structure in case of error only. > > + * @return > > + * - (0) if success. > > + * - (-ENOSYS) if underlying device does not support this functional= ity. > > + * - (-EIO) if underlying device is removed. > > + * - (-EINVAL) if *update* invalid. > > + * - (-ENOTSUP) if *update* valid but unsupported. > > + * - (-ENOENT) if action pointed by *ctx* was not found. > > + * rte_errno is also set. > > + */ > > +__rte_experimental > > +int > > +rte_flow_shared_action_update(uint16_t port_id, > > + struct rte_flow_shared_action *action, > > + const struct rte_flow_action *update, > > + struct rte_flow_error *error); > > + > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice. > > + * > > + * Query the shared action by handle. > > + * > > + * This function allows retrieving action-specific data such as counte= rs. > > + * Data is gathered by special action which may be present/referenced = in > > + * more than one flow rule definition. > > + * > > + * \see RTE_FLOW_ACTION_TYPE_COUNT > > + * > > + * @param port_id > > + * Port identifier of Ethernet device. > > + * @param[in] action > > + * Handle for the shared action to query. > > + * @param[in, out] data > > + * Pointer to storage for the associated query data type. > > + * @param[out] error > > + * Perform verbose error reporting if not NULL. PMDs initialize this > > + * structure in case of error only. > > + * > > + * @return > > + * 0 on success, a negative errno value otherwise and rte_errno is s= et. > > + */ > > +__rte_experimental > > +int > > +rte_flow_shared_action_query(uint16_t port_id, > > + const struct rte_flow_shared_action *action, > > + void *data, > > + struct rte_flow_error *error); > > + > > #ifdef __cplusplus > > } > > #endif > > diff --git a/lib/librte_ethdev/rte_flow_driver.h > > b/lib/librte_ethdev/rte_flow_driver.h > > index 3ee871d3eb..72bfc3b7a7 100644 > > --- a/lib/librte_ethdev/rte_flow_driver.h > > +++ b/lib/librte_ethdev/rte_flow_driver.h > > @@ -108,6 +108,28 @@ struct rte_flow_ops { > > void **context, > > uint32_t nb_contexts, > > struct rte_flow_error *err); > > + /** See rte_flow_shared_action_create() */ > > + struct rte_flow_shared_action *(*shared_action_create) > > + (struct rte_eth_dev *dev, > > + const struct rte_flow_action *action, > > + struct rte_flow_error *error); > > + /** See rte_flow_shared_action_destroy() */ > > + int (*shared_action_destroy) > > + (struct rte_eth_dev *dev, > > + struct rte_flow_shared_action *shared_action, > > + struct rte_flow_error *error); > > + /** See rte_flow_shared_action_update() */ > > + int (*shared_action_update) > > + (struct rte_eth_dev *dev, > > + struct rte_flow_shared_action *shared_action, > > + const struct rte_flow_action *update, > > + struct rte_flow_error *error); > > + /** See rte_flow_shared_action_query() */ > > + int (*shared_action_query) > > + (struct rte_eth_dev *dev, > > + const struct rte_flow_shared_action *shared_action, > > + void *data, > > + struct rte_flow_error *error); > > }; > > > > /** > > -- > > 2.26.2