From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C954A04DB; Fri, 16 Oct 2020 11:38:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E04A01DBBC; Fri, 16 Oct 2020 11:38:47 +0200 (CEST) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by dpdk.org (Postfix) with ESMTP id D560A1D5B7 for ; Fri, 16 Oct 2020 11:38:45 +0200 (CEST) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 16 Oct 2020 02:38:31 -0700 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 16 Oct 2020 09:38:43 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.44) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 16 Oct 2020 09:38:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EAiyK8nKH2zPanhlQsgp830ICbCnuB9kTmoApEbo94NNsTOYSG9f0woOKA/dtAv2ZIofBNklLY4yIFcZKe0J4O2Thf0jPFIXnXtOf2q/PGmwAI0q+la3QE9d9ZKrRNXmqeKN9rWAGMzFSHtq2htPkmIbZF1SzyJ6c3M8EUfWWchLCc6TH9luPAJDTvR7sdZQBXalnDbXTyhQD052Kc4H3P6sRVGqp4fgqMbLJCTEHCkvg+vfWEvRB3ga7bVPLGADcxlJVDd/WCid3Uib8Ebk1Pn9yDe4voSdn/3yf6/6AT6w4ityFxTmH0rrR396vvEG5dS83jIeAGy4Bzg4sfoWsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uBuFo3CG2DiBUivH0VviMqXNugiRHVYLPaoI8OXwBWM=; b=VOVmJpFf5ZT6PNUJozTgdAD4ivgwJz9Hcsz8azbdh7svp7grKYRtH9B3plUP5ksOsmrl8MM0wImne726DjO9EFhR+WEyuzrcdA2FZ0RmlBYqovGTXS6zIPh5EF3xhObtB2H1fZAJ/bmhim25tTt8kidz2wx7y30LSDEKehQyq1L0QAE3VZZ6J468hPxRZpU0Iq4AdOy6n8MSDxArTtO0zi+eOWOYC7JmToVdZDb8AnW9Mw+CYfdBXRuCDWTMqNvRpHU47AvCG7m+pmdMbTxyL1DWMwe2OkN2GYUXQsn8oyBVCckYj91Fi4OXccZkTLjo1+GoZukZCM1ghi4atkHVWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MWHPR12MB1360.namprd12.prod.outlook.com (2603:10b6:300:12::7) by MWHPR12MB1421.namprd12.prod.outlook.com (2603:10b6:300:12::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.20; Fri, 16 Oct 2020 09:38:41 +0000 Received: from MWHPR12MB1360.namprd12.prod.outlook.com ([fe80::191b:81c4:8297:c6ce]) by MWHPR12MB1360.namprd12.prod.outlook.com ([fe80::191b:81c4:8297:c6ce%5]) with mapi id 15.20.3477.020; Fri, 16 Oct 2020 09:38:41 +0000 From: Slava Ovsiienko To: NBU-Contact-Thomas Monjalon , Andrew Rybchenko CC: "dev@dpdk.org" , "stephen@networkplumber.org" , "ferruh.yigit@intel.com" , "olivier.matz@6wind.com" , "jerinjacobk@gmail.com" , "maxime.coquelin@redhat.com" , "david.marchand@redhat.com" Thread-Topic: [PATCH v8 1/6] ethdev: introduce Rx buffer split Thread-Index: AQHWo5mcV++RY4lX5UuYNgJ7mv5YfqmZ8N3AgAAHxgCAAAA/8A== Date: Fri, 16 Oct 2020 09:38:41 +0000 Message-ID: References: <2107416.BS4W9YiMui@thomas> In-Reply-To: <2107416.BS4W9YiMui@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f9f8378a-c1e3-48ce-9fe9-08d871b744ae x-ms-traffictypediagnostic: MWHPR12MB1421: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: y1+OT9hh2DOxcHH0uX4eE8wNdCz++y6hr1LrbyL1urygGYmzkjPPqgDcsfMMxMfrXXIt74taXkB5+omXEPBXvlf3VY87JklVBqaCb6q8IC0c5gKCnRUSgUBoV4K5MNIKNvy3q5MrojwACcTgZpM16Gr3caT3X9yjw5upLnn8DVTFW2oD59Nc24l5zNQ+IWTmuY5LrZJrA2mNVGeE57g6i7MyaY8cN/np0GPm4GBw+DUjNCIMdrm2pVUsDms22gvrTnMtrqk/lcMmb1+pVhx79z2NBRoLX9hjZUHXXwBXoj6xnoeem/VFyhf24BW0jKfhrOdqGemj4/STVjFyMOJXxQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR12MB1360.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(376002)(39860400002)(366004)(396003)(86362001)(9686003)(33656002)(55016002)(8936002)(316002)(110136005)(54906003)(5660300002)(4326008)(7696005)(76116006)(66946007)(66476007)(66556008)(64756008)(66446008)(52536014)(71200400001)(83380400001)(186003)(26005)(2906002)(478600001)(53546011)(6506007)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: w+a7dwoKefRWqGUm/2wveL6aAMyqG1J+88mHvFnx7DAZEjpYImpkdFs2t6qFdZ0LO4eV+aF1rt1fDb4u7jB8MMakk5SeKBonhoRTU0mVtzGu5GDGbiwUqeH3mY0Ck+x7FybmmQqWyZcHYQegfm1yv06qv/2Xj0J0bUTWxy392MWo3mWz/Yca58yy0OoVhnTBiT2AtoQBi9Jii+TcYi2gdJyzc1/XMviVnErYoBsi72mnPoeCnQ65Ej+X4GZYmVCOCBJEOgTNiFTA/mOmyWdfO2qfCHXsz4F/iGm9ta0fuKBMLeXwd6mDIBBNUs8+VnJVr8o16DjSoNY2pJm6rw9bIaB9MyWLDCZrTnjQuGIE8StgCGuUO4NcJmQmBqnX/oFppm2Q1q7VyoIw6fYZCjU33+LUtKG5pszHYhR4VLb9tZjT6YD9FlaKP08z26lnVVR1lyK9U0fsPapuWyspgqPnTU8tuM2B1+MuBXWVL13pEpRSP+Qb3Z2wEALilTn9Irl1DAQc65W/ZiAw/b7Rld2wIq/skaGNqPSuQjfSZUmb9KHeGONQYbanpdziOh6HBTIIim3H/7ugjxOEQsmaUUO3Bmkn0Bu9PpMmmzuGD/EplgAW9Q2cLaUelAie/Y+x95h6U/+AbkUqT3mazNMvYrUing== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR12MB1360.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f9f8378a-c1e3-48ce-9fe9-08d871b744ae X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2020 09:38:41.6804 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HZqm0w4LW/WCa5v5uxoiGGY+W4lCZ35LRY3UBdGhMXoscnJ6AViLOXTz0C9cc+qM1dH+i4LNHDJw2HyQ4INxZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1421 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1602841111; bh=uBuFo3CG2DiBUivH0VviMqXNugiRHVYLPaoI8OXwBWM=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:x-ms-exchange-transport-forked: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=mCyfkylj2iUbLf1GeZxXFwUWdz/kOMfb4kY3RJ2rOJsJdRI0hOJaOefYSJX9g2YBd jdS28/jV3kUG5Tj/anPzACQ76Ug9imb8PoLpU14f2cePxhEe9pa7T51GDxrKmfaMmf yWcQrtGGmaZo4hS4JOk3iohaaLW2ELwQZWuMpZbO9L4s1I2l+ovDkhOTl3oLbDFSoA JV6js6e5wwuBnQIRlxTeSd4SctFnW3Ut77UlVAWTobIerXjeU5H1JGzEHATjzKrXdK 3QTeqF7nG6zauMW2bpYiKEOUB1pRUY+J79JOu5PO7bxyISLkjlXZCP3T+LKD3MKHvo Ea+58Ajfedylg== Subject: Re: [dpdk-dev] [PATCH v8 1/6] ethdev: introduce Rx buffer split X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Friday, October 16, 2020 12:37 > To: Andrew Rybchenko ; Slava Ovsiienko > > Cc: dev@dpdk.org; stephen@networkplumber.org; ferruh.yigit@intel.com; > olivier.matz@6wind.com; jerinjacobk@gmail.com; > maxime.coquelin@redhat.com; david.marchand@redhat.com > Subject: Re: [PATCH v8 1/6] ethdev: introduce Rx buffer split >=20 > 16/10/2020 11:15, Slava Ovsiienko: > > From: Andrew Rybchenko > > > On 10/16/20 10:48 AM, Viacheslav Ovsiienko wrote: > > > > /** > > > > + * Ethernet device Rx buffer segmentation capabilities. > > > > + */ > > > > +__extension__ > > > > +struct rte_eth_rxseg_capa { > > > > + uint16_t max_seg; /**< Maximum amount of segments to split. */ > > > > > > May be 'max_segs' to avoid confusing vs maximum segment length. > > > > > OK, max_nseg would be more appropriate. > > > > > > + uint16_t multi_pools:1; /**< Supports receiving to multiple pools= .*/ > > > > + uint16_t offset_allowed:1; /**< Supports buffer offsets. */ > > > > + uint16_t offset_align_log2:4; /**< Required offset alignment. */ > > > > > > 4 bits are even insufficient to specify cache-line alignment. > > > IMHO at least 8 bits are required. > > > > 4 bits seems to be quite sufficient. It is a log2, tells how many lsbs = in offset > should be zeroes. > > 2^15 is 32K, it covers all reasonable alignments for uint16_t type. >=20 > bitfields with uint16_t is not standard I think, we could experience buil= d issues. > If I remember well uint32_t is safer. >=20 Agree, it is being replaced with uint32_t and embraces max_nseg as well.